observers 0.5.2 → 0.5.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 43b98e363f71c1af49c171092474b32876ed8960b95c5ec02a9583d8c86ed7f6
-  data.tar.gz: 885c88e2e012bb1a57570a80e06838cab02c5ddd4f3efeddde73ababa6de2ebe
+  metadata.gz: 3ab0c93bff9df65a8fcf5bf39a6196ac9f4be51bf823dfc7eeabebe0d2ec21e8
+  data.tar.gz: ec0de69288f9ea75794b5027d4eb1df90810c399310fcc43dfac873ae6accee0
 SHA512:
-  metadata.gz: 2d5d49d769a470b89d5f07aa85bafd1a3f913666f5999de99d84d7649fc5c9fc829fcf555b2d487b47d2870139cc93ef7b0dad040d4a6b4cd987305f0c322ff0
-  data.tar.gz: 72bc50b694eb42de5c8c48bc9775b5ae4386daf0dd74c0bbd2cc7be2540809505d6ef9c8c82ea3ef244fc0442acf5039c646606daf717a701827aeaf9084b98e
+  metadata.gz: d09f8cd88c509452aa3d9627f3326a7fb2ba3120a938fa8b32b397f64908bb668f52d5750527f96d70ee140071c220693e7f916908dfac09a2e0b1521e624aa1
+  data.tar.gz: 4ac4a3bddaf49ae0e000fd44402e3c9cca88e3078dab7a7e9b02046d6cf4246c8a9ece9c8dcc8b5d5795c5fe531991478383d6db2739cbe3dc7ef3aa03069149

data/lib/models/observer.rb

@@ -12,13 +12,15 @@ module Observers
     def trigger(action:, event:)
       action = @action if @action
       event ? @object.send(action, **{ event: }) : @object.send(action)
-    rescue ArgumentError
+    rescue ArgumentError => e
       type = @object.instance_of?(Class) ? @object : @object.class
+      method_type = @object.instance_of?(Class) ? '.' : '#'
 
-      raise ArgumentError, "#{type}##{action} has an 'event:' keyword argument but no event was sent" if event.nil?
+      raise ArgumentError, "#{type}##{action} has an 'event:' keyword argument but no event arg was sent" if event.nil?
 
-      # TODO: An error here will bubble up to the observer that triggered this observer, overwriting this error with its error.
-      raise ArgumentError, "#{event.class} sent to #{type}##{action} but it has no 'event:' keyword argument"
+      # Events trigger events, so the error bubbles up to becomes the error message for the next rescue's error message:
+      # "RequestEvent sent to Rain::Router#handle -> StatusEvent sent to Error404Node.render -> unknown keyword: :props"
+      raise ArgumentError, "#{event.class} sent to #{type}#{method_type}#{action} -> #{e.message}"
     end
   end
 end

data/lib/observables.rb

@@ -13,6 +13,7 @@ module Observers
       end
 
       def fetch(key)
+        # TODO: Log instead per configuration, much better to fail silently sometimes!
         observables[key] || raise(MissingKeyError, "Observable key '#{key}' not found")
       end
 

data/lib/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Observers
-  VERSION = '0.5.2'
+  VERSION = '0.5.3'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: observers
 version: !ruby/object:Gem::Version
-  version: 0.5.2
+  version: 0.5.3
 platform: ruby
 authors:
 - maedi