observers 0.5.1 → 0.5.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 217a2e6bfbef18a53be6cf3ab314277ef2faf7b19cf60a11c2d3443d338d23a6
-  data.tar.gz: 0abdc4e8f77f4b7968befcb1c07869f4a33407376a9ee7aded42df20e7ba98f9
+  metadata.gz: 3ab0c93bff9df65a8fcf5bf39a6196ac9f4be51bf823dfc7eeabebe0d2ec21e8
+  data.tar.gz: ec0de69288f9ea75794b5027d4eb1df90810c399310fcc43dfac873ae6accee0
 SHA512:
-  metadata.gz: a2a1bb5e9c3c10a50241c161fb661f818d317c3f5aceda89a0114e1dc997f86ae9f338066ca4fb686a0be24e37b2e6f2b4c29b9348d3584cbcfde35242a4d80a
-  data.tar.gz: 24bec70d31c23ba3368c7d14d7897ded905c25d7ecca9a9cc8e22b9b099ee93f395457679fe64200fbbb7da7ac5b55933d8b8dca8a0939b790da2c8bb78f9a52
+  metadata.gz: d09f8cd88c509452aa3d9627f3326a7fb2ba3120a938fa8b32b397f64908bb668f52d5750527f96d70ee140071c220693e7f916908dfac09a2e0b1521e624aa1
+  data.tar.gz: 4ac4a3bddaf49ae0e000fd44402e3c9cca88e3078dab7a7e9b02046d6cf4246c8a9ece9c8dcc8b5d5795c5fe531991478383d6db2739cbe3dc7ef3aa03069149

data/lib/models/observable.rb

@@ -4,8 +4,7 @@ module Observers
   class Observable
     attr_reader :observers
 
-    def initialize(key:)
-      @key = key
+    def initialize
       @observers = []
     end
 

data/lib/models/observer.rb

@@ -12,13 +12,15 @@ module Observers
     def trigger(action:, event:)
       action = @action if @action
       event ? @object.send(action, **{ event: }) : @object.send(action)
-    rescue ArgumentError
+    rescue ArgumentError => e
       type = @object.instance_of?(Class) ? @object : @object.class
+      method_type = @object.instance_of?(Class) ? '.' : '#'
 
-      raise ArgumentError, "#{type}##{action} has an 'event:' keyword argument but no event was sent" if event.nil?
+      raise ArgumentError, "#{type}##{action} has an 'event:' keyword argument but no event arg was sent" if event.nil?
 
-      # TODO: An error here will bubble up to the observer that triggered this observer, overwriting this error with its error.
-      raise ArgumentError, "#{event.class} sent to #{type}##{action} but it has no 'event:' keyword argument"
+      # Events trigger events, so the error bubbles up to becomes the error message for the next rescue's error message:
+      # "RequestEvent sent to Rain::Router#handle -> StatusEvent sent to Error404Node.render -> unknown keyword: :props"
+      raise ArgumentError, "#{event.class} sent to #{type}#{method_type}#{action} -> #{e.message}"
     end
   end
 end

data/lib/observables.rb

@@ -4,7 +4,7 @@ require_relative 'models/observable'
 
 module Observers
   class Observables
-    class MissingObservableError < StandardError; end
+    class MissingKeyError < StandardError; end
 
     class << self
       def observables
@@ -13,7 +13,8 @@ module Observers
       end
 
       def fetch(key)
-        observables[key] || raise(MissingObservableError, "Observable key '#{key}' not found")
+        # TODO: Log instead per configuration, much better to fail silently sometimes!
+        observables[key] || raise(MissingKeyError, "Observable key '#{key}' not found")
       end
 
       def [](key)
@@ -21,7 +22,7 @@ module Observers
       end
 
       def upsert(key:)
-        observables[key] = Observable.new(key:) if observables[key].nil?
+        observables[key] = Observable.new if observables[key].nil?
         observables[key]
       end
 

data/lib/observers.rb

@@ -11,12 +11,16 @@ module Observers
   end
 
   # Add an observer on the observable side.
-  def observers(key: self)
+  def observers(key = self)
     Struct.new(:key) do
       def push(object, action: nil)
         Observables[key].observe(object:, action:)
       end
       alias :<< :push
+
+      def count
+        Observables[key].observers.count
+      end
     end.new(key)
   end
 
@@ -37,4 +41,4 @@ module Observers
 end
 
 # For quick debugging, not official API.
-OOO = Observers::Observables.observables
+OOO = Observers::Observables.observables unless defined?(OOO)

data/lib/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Observers
-  VERSION = '0.5.1'
+  VERSION = '0.5.3'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: observers
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.5.3
 platform: ruby
 authors:
 - maedi