observers 0.0.2 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e16b25754307c5e5ae72dfbe6e2774637306a381c0fb4acb81495732aa21f9ac
-  data.tar.gz: 9b376d1470e2c9b30b7888dd1409fd7ef3e5340fdb97ea53d93ed037d68c67b8
+  metadata.gz: b1c16092762a682c96f1cc007988ec2406d3b2dd6ce91c1b793b2fbf4f95d628
+  data.tar.gz: 18045745a7cc775e61dd9afc1f46a80074565be6986a37ead5b30d49105a6e77
 SHA512:
-  metadata.gz: eab730189e35a58279c2069fbd41b9763c6a3c8862777982a3e4d4bccd5cf704a7e5371277ac50415d70ecc18a8bda674224073f0f3dc27406d972496f46c405
-  data.tar.gz: d498b6b4590c74e6695fee0922f017bf0af086ac85db299933f4e90a2b3c53c13bba00fcca861e6dbb8d67229980f1f66925b01b05ff558eb0fd052892ae3c5c
+  metadata.gz: 8c3eb3b00120bfcd498345c0f1ef44322212eacaa6856d794fb9e74044b7a26fa4a6502067cec87aaeff241b4835f5f5e0c048a80d59fe61e3dda277b84c03af
+  data.tar.gz: 843137754e96d5187b23f36fa72e2aa423cba6b9e0af82a99d3b84ef046bc7c2feb76fd3acfe0b3607ea55a6ef250d23ee0f90a211266bd551d5b2045211156f

data/lib/models/observer.rb

@@ -4,13 +4,18 @@ module Observers
   class Observer
     attr_reader :order
 
-    def initialize(observer:, order:)
+    def initialize(observer:, action:, order:)
       @observer = observer
+      @action = action
       @order = order
     end
 
     def trigger(action:, event:)
-      event ? @observer.send(action, event) : @observer.send(action)
+      action = @action if @action
+      event ? @observer.send(action, **{ event: event }) : @observer.send(action)
+    rescue ArgumentError
+      type = @observer.instance_of?(Class) ? @observer : @observer.class
+      raise ArgumentError, "#{event.class} sent to #{type}##{action} but it has no 'event:' keyword argument"
     end
   end
 end

data/lib/observables.rb

@@ -24,10 +24,39 @@ module Observers
         observable.add_observer(observer:)
       end
 
-      def trigger(key:, action:, event:)
+      def trigger(actionable:, key:)
+        action, event = parse_actionable(actionable:)
+
         observables[key].observers.each do |observer|
           observer.trigger(action:, event:)
         end
+
+        nil # The trigger method is boring and uneventful, it fires events and if it doesn't complain then all is okay.
+      end
+
+      def take(actionable:, key:)
+        action, event = parse_actionable(actionable:)
+
+        observables[key].observers.each do |observer|
+          result = observer.trigger(action:, event:)
+          return result unless result.nil?
+        end
+
+        nil # This is a bad day for the take method, one of the worst.
+      end
+
+      private
+
+      def parse_actionable(actionable:)
+        action = actionable
+        event = nil
+
+        if actionable.class.ancestors.any? { |ancestor| ancestor.to_s == 'Low::Event' }
+          event = actionable
+          action = event.action
+        end
+
+        [action, event]
       end
     end
   end

data/lib/observers.rb

@@ -8,27 +8,19 @@ module Observers
     Observables.upsert(key:)
   end
 
-  def observe(key, order: 0)
-    observer = Observer.new(observer: self, order:)
+  # TODO: Unit test order.
+  def observe(key, action = nil, order: Observables.observables.count)
+    observer = Observer.new(observer: self, action:, order:)
     Observables.observe(key:, observer:)
   end
 
-  def trigger(*args)
-    key = self
-    action = nil
-
-    case args.count
-    when 1
-      action = args.first
-    when 2
-      key, action = args
-    end
-
-    if action.respond_to?(:action)
-      event = action
-      action = event.action
-    end
+  def trigger(actionable, key = nil)
+    Observables.trigger(actionable:, key: key || self)
+  end
 
-    Observables.trigger(key:, action:, event: nil)
+  # Returns the first observer with a non-nil return value.
+  # One day it may use ractors and be concurrent, if we can freeze the args.
+  def take(actionable, key = nil)
+    Observables.take(actionable:, key: key || self)
   end
 end

data/lib/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Observers
-  VERSION = '0.0.2'
+  VERSION = '0.2.0'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: observers
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.2.0
 platform: ruby
 authors:
 - maedi