oboe 2.7.7.1-java → 2.7.8.1-java

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 44247dad53ec61599ece5203a8fccc1063797e33
-  data.tar.gz: 1ae26684562b3282b90506580c0c203b4e9ce86f
+  metadata.gz: 62cd3db82e213327668a85173155c2a26f7283ec
+  data.tar.gz: e5c55906ad783742b8af7d35aa0e008eea6c4f38
 SHA512:
-  metadata.gz: 7cada019bdb599b445c970ebc5c66bdcdb74447c91b24c064b4821611db33fd47c930167ab4db96ab4f318cd2c2d7776b4ed763aa4f5e6ba6d62f1500c7bc023
-  data.tar.gz: abed2fc5e5fb5c34b661369f0c750b627143c2536c6e4d211998a03fc086a770807f05fd01a18bb6738037bf3dc0dfc5f89869ba3a15f514fc3c8bb427928e41
+  metadata.gz: 4a54753774a6c4ca87119e5dba44a7bb0f71c78358477fe084e0b40327e297074039e471cf85e6678c787c54d608af24f5278350d5de68394d3960db59ff6b96
+  data.tar.gz: bf1813f9ff669b8744bc3633df3d5457c5d72660b44b3215d1c3a7262c01903bb809c7bb668b95d2ac450594cd5824f5a4661b14833d4110fa17f2f9345e0578

data/CHANGELOG.md

@@ -4,6 +4,41 @@ https://github.com/appneta/oboe-ruby/releases
 
 Dates in this file are in the format MM/DD/YYYY.
 
+# oboe 2.7.8.1
+
+This patch release includes:
+
+* Improved sampling management and reporting
+
+Pushed to Rubygems:
+
+https://rubygems.org/gems/oboe/versions/2.7.8.1
+https://rubygems.org/gems/oboe/versions/2.7.8.1-java
+
+
+# oboe 2.7.7.1
+
+This patch release includes:
+
+* Add support and instrumentation for Sequel: #91
+
+Pushed to Rubygems:
+
+https://rubygems.org/gems/oboe/versions/2.7.7.1
+https://rubygems.org/gems/oboe/versions/2.7.7.1-java
+
+# oboe 2.7.6.2
+
+This patch release includes:
+
+* Fixed metrics when hosting a JRuby application under a Java webserver such as Tomcat: #94
+* Fix for moped aggregate calls: #95
+
+Pushed to Rubygems:
+
+https://rubygems.org/gems/oboe/versions/2.7.6.2
+https://rubygems.org/gems/oboe/versions/2.7.6.2-java
+
 # oboe 2.7.5.1 (11/20/2014)
 
 This patch release includes:

data/Gemfile

@@ -39,7 +39,11 @@ if defined?(JRUBY_VERSION)
 else
   gem 'mysql'
   gem 'mysql2'
-  gem 'pg'
+  if RUBY_VERSION < '1.9.3'
+    gem 'pg', '0.17.1'
+  else
+    gem 'pg'
+  end
 end
 
 if RUBY_VERSION >= '1.9'

data/lib/joboe_metal.rb

@@ -153,14 +153,17 @@ module Oboe
         # Store the returned SampleRateConfig into Oboe::Config
         if sr_cfg
           begin
-            Oboe.sample_rate = sr_cfg.sampleRate
-            Oboe.sample_source = sr_cfg.sampleRateSource.a
+            Oboe::Config.sample_rate = cfg.sampleRate
+            Oboe::Config.sample_source = cfg.sampleRateSourceValue
             # If we fail here, we do so quietly.  This was we don't spam logs
             # on every request
           end
+        else
+          Oboe.sample_rate = -1
+          Oboe.sample_source = -1
         end
 
-        sr_cfg
+        sr_cfg ? true : false
       rescue => e
         Oboe.logger.debug "[oboe/debug] #{e.message}"
         false

data/lib/oboe/api/logging.rb

@@ -69,9 +69,33 @@ module Oboe
         Oboe::Context.fromString(xtrace) if Oboe.pickup_context?(xtrace)
 
         if Oboe.tracing?
+          # Pre-existing context.  Either we inherited context from an
+          # incoming X-Trace request header or under JRuby, Joboe started
+          # tracing before the JRuby code was called (e.g. Tomcat)
           Oboe.is_continued_trace = true
+
+          if Oboe.has_xtrace_header
+            opts[:TraceOrigin] = :continued_header
+          elsif Oboe.has_incoming_context
+            opts[:TraceOrigin] = :continued_context
+          else
+            opts[:TraceOrigin] = :continued
+          end
+
           log_entry(layer, opts)
-        elsif opts.key?('Force') || Oboe.sample?(opts.merge(:layer => layer, :xtrace => xtrace))
+
+        elsif opts.key?('Force')
+          # Forced tracing: used by __Init reporting
+          opts[:TraceOrigin] = :forced
+          log_event(layer, 'entry', Oboe::Context.startTrace, opts)
+
+        elsif Oboe.sample?(opts.merge(:layer => layer, :xtrace => xtrace))
+          # Probablistic tracing of a subset of requests based off of
+          # sample rate and sample source
+          opts[:SampleRate]        = Oboe.sample_rate
+          opts[:SampleSource]      = Oboe.sample_source
+          opts[:TraceOrigin] = :always_sampled
+
           log_event(layer, 'entry', Oboe::Context.startTrace, opts)
         end
       end

data/lib/oboe/base.rb

@@ -31,8 +31,8 @@ module OboeBase
 
   attr_accessor :reporter
   attr_accessor :loaded
-  attr_accessor :sample_source
-  attr_accessor :sample_rate
+  thread_local :sample_source
+  thread_local :sample_rate
   thread_local :layer
   thread_local :layer_op
 

data/lib/oboe/inst/rack.rb

@@ -37,6 +37,8 @@ module Oboe
         report_kvs['Forwarded-Port']    = env['HTTP_X_FORWARDED_PORT']   if env.key?('HTTP_X_FORWARDED_PORT')
 
         report_kvs['Ruby.Oboe.Version'] = ::Oboe::Version::STRING
+        report_kvs['ProcessID']         = Process.pid
+        report_kvs['ThreadID']          = Thread.current.to_s[/0x\w*/]
       rescue StandardError => e
         # Discard any potential exceptions. Debug log and report whatever we can.
         Oboe.logger.debug "[oboe/debug] Rack KV collection error: #{e.inspect}"
@@ -50,13 +52,6 @@ module Oboe
       report_kvs = {}
       report_kvs[:URL] = URI.unescape(req.path)
 
-      if Oboe.always?
-        # Only report these KVs under tracing_mode 'always' (never for 'through')
-        # These KVs need to be in the entry event for server side.
-        report_kvs[:SampleRate]        = Oboe.sample_rate
-        report_kvs[:SampleSource]      = Oboe.sample_source
-      end
-
       # Under JRuby, JOboe may have already started a trace.  Make note of this
       # if so and don't clear context on log_end (see oboe/api/logging.rb)
       Oboe.has_incoming_context = Oboe.tracing?

data/lib/oboe/version.rb

@@ -8,7 +8,7 @@ module Oboe
   module Version
     MAJOR = 2
     MINOR = 7
-    PATCH = 7
+    PATCH = 8
     BUILD = 1
 
     STRING = [MAJOR, MINOR, PATCH, BUILD].compact.join('.')

data/lib/oboe_metal.rb

@@ -85,7 +85,7 @@ module Oboe
   class << self
     def sample?(opts = {})
       begin
-        return false unless Oboe.always?
+        return false unless Oboe.always? && Oboe.loaded
 
         # Assure defaults since SWIG enforces Strings
         layer   = opts[:layer]      ? opts[:layer].strip      : ''
@@ -94,13 +94,23 @@ module Oboe
 
         rv = Oboe::Context.sampleRequest(layer, xtrace, tv_meta)
 
-        # For older liboboe that returns true/false, just return that.
-        return rv if [TrueClass, FalseClass].include?(rv.class) || (rv == 0)
-
-        # liboboe version > 1.3.1 returning a bit masked integer with SampleRate and
-        # source embedded
-        Oboe.sample_rate = (rv & SAMPLE_RATE_MASK)
-        Oboe.sample_source = (rv & SAMPLE_SOURCE_MASK) >> 24
+        if rv == 0
+          if ENV.key?('OBOE_GEM_TEST')
+            # When in test, always trace and don't clear
+            # the stored sample rate/source
+            true
+          else
+            Oboe.sample_rate = -1
+            Oboe.sample_source = -1
+            false
+          end
+        else
+          # liboboe version > 1.3.1 returning a bit masked integer with SampleRate and
+          # source embedded
+          Oboe.sample_rate = (rv & SAMPLE_RATE_MASK)
+          Oboe.sample_source = (rv & SAMPLE_SOURCE_MASK) >> 24
+          true
+        end
       rescue StandardError => e
         Oboe.logger.debug "[oboe/error] sample? error: #{e.inspect}"
         false

data/test/frameworks/apps/grape_simple.rb

@@ -1,7 +1,6 @@
 require 'grape'
 
 class GrapeSimple < Grape::API
-  set :reload, true
 
   get '/json_endpoint' do
     present({ :test => true })

data/test/instrumentation/rack_test.rb

@@ -45,6 +45,8 @@ class RackTestApp < Minitest::Test
 
     assert traces[0].has_key?('SampleRate')
     assert traces[0].has_key?('SampleSource')
+    assert traces[1].has_key?('ProcessID')
+    assert traces[1].has_key?('ThreadID')
 
     assert last_response.ok?
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: oboe
 version: !ruby/object:Gem::Version
-  version: 2.7.7.1
+  version: 2.7.8.1
 platform: java
 authors:
 - Peter Giacomo Lombardo
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2014-12-14 00:00:00.000000000 Z
+date: 2015-01-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -186,35 +186,35 @@ specification_version: 4
 summary: AppNeta TraceView performance instrumentation gem for Ruby
 test_files:
 - test/minitest_helper.rb
-- test/support/config_test.rb
-- test/support/xtrace_test.rb
-- test/support/liboboe_settings_test.rb
-- test/profiling/method_test.rb
-- test/frameworks/sinatra_test.rb
 - test/frameworks/grape_test.rb
 - test/frameworks/padrino_test.rb
+- test/frameworks/sinatra_test.rb
 - test/frameworks/apps/sinatra_simple.rb
-- test/frameworks/apps/grape_simple.rb
 - test/frameworks/apps/padrino_simple.rb
-- test/instrumentation/memcache_test.rb
-- test/instrumentation/moped_test.rb
-- test/instrumentation/rack_test.rb
-- test/instrumentation/http_test.rb
+- test/frameworks/apps/grape_simple.rb
+- test/instrumentation/mongo_test.rb
 - test/instrumentation/redis_hashes_test.rb
-- test/instrumentation/em_http_request_test.rb
+- test/instrumentation/sequel_pg_test.rb
 - test/instrumentation/redis_misc_test.rb
-- test/instrumentation/redis_sets_test.rb
-- test/instrumentation/memcached_test.rb
+- test/instrumentation/dalli_test.rb
 - test/instrumentation/redis_keys_test.rb
+- test/instrumentation/redis_sortedsets_test.rb
+- test/instrumentation/redis_strings_test.rb
+- test/instrumentation/sequel_mysql_test.rb
+- test/instrumentation/redis_sets_test.rb
+- test/instrumentation/http_test.rb
 - test/instrumentation/typhoeus_test.rb
 - test/instrumentation/resque_test.rb
+- test/instrumentation/em_http_request_test.rb
+- test/instrumentation/moped_test.rb
+- test/instrumentation/rack_test.rb
+- test/instrumentation/memcache_test.rb
 - test/instrumentation/faraday_test.rb
-- test/instrumentation/redis_sortedsets_test.rb
-- test/instrumentation/dalli_test.rb
-- test/instrumentation/sequel_mysql_test.rb
 - test/instrumentation/redis_lists_test.rb
-- test/instrumentation/cassandra_test.rb
-- test/instrumentation/redis_strings_test.rb
-- test/instrumentation/sequel_pg_test.rb
-- test/instrumentation/mongo_test.rb
 - test/instrumentation/sequel_mysql2_test.rb
+- test/instrumentation/cassandra_test.rb
+- test/instrumentation/memcached_test.rb
+- test/profiling/method_test.rb
+- test/support/liboboe_settings_test.rb
+- test/support/config_test.rb
+- test/support/xtrace_test.rb