objectid_columns 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 --- 
-SHA512: 
-  metadata.gz: 216e3a0b18aa9ff589f728a7ba6d95fa56ada067b51a99cff26dac0b19cb3f49cb4fa9deb2b2ae227498123bb5d8aa286aa76760eed1fbf96cfc6599dd7e423f
-  data.tar.gz: c9a48a9b4e065da3a3b45555cf7c2acd0c3a5687c6e5cf752318934553110fed9906d7d72b4e87cef431a4df7386e5fab1001c0ffbcf4cef655b8e59f8d1a169
 SHA1: 
-  metadata.gz: 522783d13b6a7e03735ae0c8d793a545ef4926aa
-  data.tar.gz: c69aed130528349b56f2c60effed8ca0e73213eb
+  data.tar.gz: a7f678bd14b88d042886baff1b5414b11deb4707
+  metadata.gz: e7b852e2a9fd9f1d1ca584b2cfd7e3af2cd9f03f
+SHA512: 
+  data.tar.gz: 9dd1a74b4e4923f9502f46ddded57492019f7cea242cf57ca7289174c4e37babadd0eb2ceb32a32df464cc83d7932462ead3d8ed8079e1d105524e2f6e7f10b2
+  metadata.gz: bf0a9bcf3f653674d3a04ddc84bd25a2127cf05465be7582baa3e62445a95993b92c52c0b83cae4822b70c2b84d74f436a81ac876a59e192310863afea6ce0ad

data/.travis.yml

@@ -11,12 +11,15 @@ env:
     - OBJECTID_COLUMNS_AR_TEST_VERSION=3.1.12 OBJECTID_COLUMNS_TRAVIS_CI_DATABASE_TYPE=mysql
     - OBJECTID_COLUMNS_AR_TEST_VERSION=3.1.12 OBJECTID_COLUMNS_TRAVIS_CI_DATABASE_TYPE=postgres
     - OBJECTID_COLUMNS_AR_TEST_VERSION=3.1.12 OBJECTID_COLUMNS_TRAVIS_CI_DATABASE_TYPE=sqlite
-    - OBJECTID_COLUMNS_AR_TEST_VERSION=3.2.16 OBJECTID_COLUMNS_TRAVIS_CI_DATABASE_TYPE=mysql
-    - OBJECTID_COLUMNS_AR_TEST_VERSION=3.2.16 OBJECTID_COLUMNS_TRAVIS_CI_DATABASE_TYPE=postgres
-    - OBJECTID_COLUMNS_AR_TEST_VERSION=3.2.16 OBJECTID_COLUMNS_TRAVIS_CI_DATABASE_TYPE=sqlite
-    - OBJECTID_COLUMNS_AR_TEST_VERSION=4.0.2 OBJECTID_COLUMNS_TRAVIS_CI_DATABASE_TYPE=mysql
-    - OBJECTID_COLUMNS_AR_TEST_VERSION=4.0.2 OBJECTID_COLUMNS_TRAVIS_CI_DATABASE_TYPE=postgres
-    - OBJECTID_COLUMNS_AR_TEST_VERSION=4.0.2 OBJECTID_COLUMNS_TRAVIS_CI_DATABASE_TYPE=sqlite
+    - OBJECTID_COLUMNS_AR_TEST_VERSION=3.2.17 OBJECTID_COLUMNS_TRAVIS_CI_DATABASE_TYPE=mysql
+    - OBJECTID_COLUMNS_AR_TEST_VERSION=3.2.17 OBJECTID_COLUMNS_TRAVIS_CI_DATABASE_TYPE=postgres
+    - OBJECTID_COLUMNS_AR_TEST_VERSION=3.2.17 OBJECTID_COLUMNS_TRAVIS_CI_DATABASE_TYPE=sqlite
+    - OBJECTID_COLUMNS_AR_TEST_VERSION=4.0.4 OBJECTID_COLUMNS_TRAVIS_CI_DATABASE_TYPE=mysql
+    - OBJECTID_COLUMNS_AR_TEST_VERSION=4.0.4 OBJECTID_COLUMNS_TRAVIS_CI_DATABASE_TYPE=postgres
+    - OBJECTID_COLUMNS_AR_TEST_VERSION=4.0.4 OBJECTID_COLUMNS_TRAVIS_CI_DATABASE_TYPE=sqlite
+    - OBJECTID_COLUMNS_AR_TEST_VERSION=4.1.0 OBJECTID_COLUMNS_TRAVIS_CI_DATABASE_TYPE=mysql
+    - OBJECTID_COLUMNS_AR_TEST_VERSION=4.1.0 OBJECTID_COLUMNS_TRAVIS_CI_DATABASE_TYPE=postgres
+    - OBJECTID_COLUMNS_AR_TEST_VERSION=4.1.0 OBJECTID_COLUMNS_TRAVIS_CI_DATABASE_TYPE=sqlite
 before_script:
     - mysql -e 'create database myapp_test;'
     - psql -c 'create database myapp_test;' -U postgres
@@ -24,12 +27,18 @@ matrix:
     exclude:
         # ActiveRecord 4.x doesn't support Ruby 1.8.7
         -   rvm: 1.8.7
-            env: OBJECTID_COLUMNS_AR_TEST_VERSION=4.0.2 OBJECTID_COLUMNS_TRAVIS_CI_DATABASE_TYPE=mysql
+            env: OBJECTID_COLUMNS_AR_TEST_VERSION=4.0.4 OBJECTID_COLUMNS_TRAVIS_CI_DATABASE_TYPE=mysql
         -   rvm: 1.8.7
-            env: OBJECTID_COLUMNS_AR_TEST_VERSION=4.0.2 OBJECTID_COLUMNS_TRAVIS_CI_DATABASE_TYPE=postgres
+            env: OBJECTID_COLUMNS_AR_TEST_VERSION=4.0.4 OBJECTID_COLUMNS_TRAVIS_CI_DATABASE_TYPE=postgres
         -   rvm: 1.8.7
-            env: OBJECTID_COLUMNS_AR_TEST_VERSION=4.0.2 OBJECTID_COLUMNS_TRAVIS_CI_DATABASE_TYPE=sqlite
+            env: OBJECTID_COLUMNS_AR_TEST_VERSION=4.0.4 OBJECTID_COLUMNS_TRAVIS_CI_DATABASE_TYPE=sqlite
+        -   rvm: 1.8.7
+            env: OBJECTID_COLUMNS_AR_TEST_VERSION=4.1.0 OBJECTID_COLUMNS_TRAVIS_CI_DATABASE_TYPE=mysql
+        -   rvm: 1.8.7
+            env: OBJECTID_COLUMNS_AR_TEST_VERSION=4.1.0 OBJECTID_COLUMNS_TRAVIS_CI_DATABASE_TYPE=postgres
+        -   rvm: 1.8.7
+            env: OBJECTID_COLUMNS_AR_TEST_VERSION=4.1.0 OBJECTID_COLUMNS_TRAVIS_CI_DATABASE_TYPE=sqlite
     allow_failures:
         -   env: OBJECTID_COLUMNS_AR_TEST_VERSION=3.1.12 OBJECTID_COLUMNS_TRAVIS_CI_DATABASE_TYPE=sqlite
         -   rvm: 1.8.7
-            env: OBJECTID_COLUMNS_AR_TEST_VERSION=3.2.16 OBJECTID_COLUMNS_TRAVIS_CI_DATABASE_TYPE=sqlite
+            env: OBJECTID_COLUMNS_AR_TEST_VERSION=3.2.17 OBJECTID_COLUMNS_TRAVIS_CI_DATABASE_TYPE=sqlite

data/CHANGES.md

@@ -1,5 +1,11 @@
 # Change History for ObjectidColumns
 
+### Version 1.0.2: April 14, 2014
+
+* Fixed an issue where, if you tried to pass an ObjectID instance in a `where` clause for a column that didn't exist or wasn't on a table that declared any ObjectID columns, you could get an error from deep down in `ObjectidColumns`. (Now, you'll still get an error, but it will be the ActiveRecord error you expect, instead.)
+* Rails 4.1 support.
+* Bumped Travis version matrix to the latest point-releases of Rails 3.2 and 4.0.
+
 ### Version 1.0.1: March 7, 2014
 
 * Compatibility with the [`composite_primary_keys`](https://github.com/composite-primary-keys/composite_primary_keys)

data/README.md

@@ -26,9 +26,10 @@ want to allow you to use either one. It will accept either one when assigning Ob
 whichever one you have loaded, (currently) preferring `BSON::ObjectId` if you have both.
 
 ObjectidColumns supports Ruby 1.8.7, 1.9.3, 2.0.0, and 2.1.0, plus JRuby 1.7.9; it supports ActiveRecord 3.0.20,
-3.1.12, 3.2.16, and 4.0.2. It supports SQLite 3.x, MySQL 5.x, and PostgreSQL 8.x. (These are just the versions it's
-tested against; while it will not work with ActiveRecord 2.x, it is otherwise highly unlikely to be sensitive to
-exact ActiveRecord or Ruby versions, or type of RDBMS, and generally should work with most combinations.)
+3.1.12, 3.2.17, 4.0.4, and 4.1.0. It supports SQLite 3.x, MySQL 5.x, and PostgreSQL 8.x. (These are just the
+versions it's tested against; while it will not work with ActiveRecord 2.x, it is otherwise highly unlikely to
+be sensitive to exact ActiveRecord or Ruby versions, or type of RDBMS, and generally should work with most
+combinations.)
 
 *Note*: If you use SQLite3 with ActiveRecord 3.1.x on MRI (_i.e._, not JRuby), or SQLite3 with ActiveRecord 3.2.x on
 MRI 1.8.7, there is a bug in the SQLite3-ActiveRecord integration that causes ObjectId primary keys to not work. (They

data/lib/objectid_columns/arel/visitors/to_sql.rb

@@ -45,8 +45,7 @@ module ObjectidColumns
           column = if a then column_for(a) else last_column end
           relation = if a then a.relation else last_relation end
 
-          raise "no column?!?" unless column
-          raise "no relation?!?" unless relation
+          return quote(o.to_s) unless column && relation
 
           quote(bson_objectid_value_from_parameter(o, column, relation), column)
         end
@@ -77,7 +76,7 @@ that contains a BSON ObjectId value -- you're trying to use the value '#{o}'
 
 While we can find a record of some ObjectId columns being declared for
 that table, they don't appear to include #{column_name.inspect}. As such,
-we don't knwo whether this column should be treated as a binary or a hexadecimal
+we don't know whether this column should be treated as a binary or a hexadecimal
 ObjectId, and hence don't know how to transform this value properly.}
           end
 

data/lib/objectid_columns/version.rb

@@ -1,4 +1,4 @@
 # What's the current version of this gem?
 module ObjectidColumns
-  VERSION = "1.0.1"
+  VERSION = "1.0.2"
 end

data/spec/objectid_columns/system/basic_system_spec.rb

@@ -461,6 +461,23 @@ describe "ObjectidColumns basic operations" do
           expect(::Spectable.where(:perfect_s_oid => @oid2.to_binary).to_a.map(&:id)).to eq([ r2.id ])
           expect(::Spectable.where(:perfect_s_oid => [ @oid1, @oid2 ].map(&:to_binary)).to_a.map(&:id).sort).to eq([ r1.id, r2.id ].sort)
         end
+
+        it "should give a good exception if you try to pass an ObjectID for a column that isn't an official ObjectID column" do
+          oid = new_oid
+          expect { ::Spectable.where(:perfect_b_oid => oid).to_a }.to raise_error(/ObjectidColumns:.*perfect_b_oid/mi)
+        end
+
+        it "should not blow up (and instead let ActiveRecord blow up) if you try to pass an ObjectID for a column that isn't a column at all" do
+          oid = new_oid
+          expect { ::Spectable.where(:something => oid).to_a }.to raise_error(/something/mi)
+        end
+
+        it "should not blow up (and instead let ActiveRecord just find no records, or blow up) if you try to pass an ObjectID for a column on a table that isn't using this gem at all" do
+          define_model_class(:SpectableNondeclared, 'objectidcols_spec_table') { }
+          expect(::SpectableNondeclared.where(:perfect_s_oid => new_oid).to_a).to eq([ ])
+
+          expect { ::SpectableNondeclared.where(:something => new_oid).to_a }.to raise_error(/something/i)
+        end
       end
 
       it "should allow using any column that's long enough, including binary or string columns" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: objectid_columns
 version: !ruby/object:Gem::Version 
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors: 
 - Andrew Geweke
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2014-03-08 00:00:00 Z
+date: 2014-04-14 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: activerecord