objectbouncer 0.0.1 → 0.0.2

data/README.mdown

@@ -61,11 +61,11 @@ the President through SecretService first:
     @joe_biden   = VicePresident.new
     @tommy_chong = Hippie.new
 
-    SecretService.as(@gaddafi).on(@president).shake_hands # Raises PermissionDenied
-    SecretService.as(@joe_biden).on(@president).shake_hands # Allowed
-    SecretService.as(@tommy_chong).on(@president).shake_hands # Allowed
-    SecretService.as(@joe_biden).on(@president).high_five # Allowed
-    SecretService.as(@tommy_chong).on(@president).high_five # Raises PermissionDenied
+    SecretService.new(@gaddafi, @president).shake_hands # Raises PermissionDenied
+    SecretService.new(@joe_biden, @president).shake_hands # Allowed
+    SecretService.new(@tommy_chong, @president).shake_hands # Allowed
+    SecretService.new(@joe_biden, @president).high_five # Allowed
+    SecretService.new(@tommy_chong, @president).high_five # Raises PermissionDenied
 
 ## Why would I want to use this?
 
@@ -84,7 +84,11 @@ Test suite has currently only been confirmed on the following platforms:
 ## Contributions
 
 Patches gladly accepted. Please fork this repo, add a relevant test, and send
-me a pull request.
+me a pull request. Kudos to the following for design, advice, input, etc.:
+
+ * Pedro Belo
+ * Ryan Smith
+ * Graham Ashton
 
 ## Status
 

data/lib/objectbouncer/base.rb

@@ -46,18 +46,6 @@ module ObjectBouncer
         @policies
       end
 
-      def as(person)
-        doorman = new
-        doorman.send(:person=, person)
-        doorman
-      end
-
-      def on(object)
-        doorman = new
-        doorman.send(:object=, object)
-        doorman
-      end
-
       def blank_policy_template
         { :allow => { :if => [], :unless => [] },
           :deny  => { :if => [], :unless => [] }
@@ -66,19 +54,15 @@ module ObjectBouncer
 
     end
 
-    def on(object)
+    def initialize(accessee, object)
+      @accessee = accessee
       @object = object
-      self
-    end
-
-    def as(person)
-      @person = person
-      self
+      super
     end
 
     def method_missing(meth, *args, &block)
       if respond_to?(meth)
-        raise "adada!!!" if self.class.policies.nil? or self.class.policies.empty?
+        raise "TODO!!!" if self.class.policies.nil? or self.class.policies.empty?
         if call_allowed?(meth)
           @object.send(meth, *args, &block)
         elsif call_denied?(meth)
@@ -96,23 +80,23 @@ module ObjectBouncer
     private
       def call_allowed?(meth)
         if policies = self.class.policies[meth]
-          return true if !policies[:allow][:unless].empty? && !policies[:allow][:unless].detect{|policy| policy.call(@person, @object) rescue nil}
-          return true if policies[:allow][:if].detect{|policy| policy.call(@person, @object) rescue nil}
-          return true if policies[:deny][:unless].detect{|policy| policy.call(@person, @object) rescue nil}
+          return true if !policies[:allow][:unless].empty? && !policies[:allow][:unless].detect{|policy| policy.call(@accessee, @object) rescue nil}
+          return true if policies[:allow][:if].detect{|policy| policy.call(@accessee, @object) rescue nil}
+          return true if policies[:deny][:unless].detect{|policy| policy.call(@accessee, @object) rescue nil}
         end
       end
 
       def call_denied?(meth)
         return true if self.class.lockdown?
         if policies = self.class.policies[meth]
-          return true if policies[:allow][:unless].detect{|policy| policy.call(@person, @object) rescue nil}
-          return true if policies[:deny][:if].detect{|policy| policy.call(@person, @object) rescue nil}
+          return true if policies[:allow][:unless].detect{|policy| policy.call(@accessee, @object) rescue nil}
+          return true if policies[:deny][:if].detect{|policy| policy.call(@accessee, @object) rescue nil}
           return true if !policies[:deny][:unless].empty? && !call_allowed?(meth)
         end
       end
 
-      def person=(val)
-        @person = val
+      def accessee=(val)
+        @accessee = val
       end
 
       def object=(val)

data/test/objectbouncer/base_test.rb

@@ -53,25 +53,29 @@ class ObjectBouncerTest < Test::Unit::TestCase
 
     should "not let the public shake hands" do
       joe_public = JoePublic.new
+      secret_service = SecretService.new(joe_public, @president)
       assert_raise ObjectBouncer::PermissionDenied do
-        SecretService.as(joe_public).on(@president).shake_hands
+        secret_service.shake_hands
       end
     end
 
     should "let the first lady get in close" do
       first_lady = MichelleObama.new
-      assert_equal "shaking hands", SecretService.as(first_lady).on(@president).shake_hands
+      secret_service = SecretService.new(first_lady, @president)
+      assert_equal "shaking hands", secret_service.shake_hands
     end
 
     should "high five Biden" do
       vice_pres = JoeBiden.new
-      assert_equal "high five!", SecretService.as(vice_pres).on(@president).high_five
+      secret_service = SecretService.new(vice_pres, @president)
+      assert_equal "high five!", secret_service.high_five
     end
 
     should "not let the public high five" do
       joe_public = JoePublic.new
+      secret_service = SecretService.new(joe_public, @president)
       assert_raise ObjectBouncer::PermissionDenied do
-        SecretService.as(joe_public).on(@president).high_five
+        secret_service.high_five
       end
     end
 
@@ -85,30 +89,20 @@ class ObjectBouncerTest < Test::Unit::TestCase
 
     should "deny everything by default" do
       joe_public = JoePublic.new
+      coast_guard = CoastGuard.new(joe_public, @president)
       assert_raise ObjectBouncer::PermissionDenied do
-        CoastGuard.as(joe_public).on(@president).high_five
+        coast_guard.high_five
       end
       assert_raise ObjectBouncer::PermissionDenied do
-        CoastGuard.as(joe_public).on(@president).shake_hands
+        coast_guard.shake_hands
       end
     end
 
     should "allow if explictly said it's ok" do
       joe_public = JoePublic.new
-      assert_equal "I'm on your TV!", CoastGuard.as(joe_public).on(@president).watch_tv_appearance
+      coast_guard = CoastGuard.new(joe_public, @president)
+      assert_equal "I'm on your TV!", coast_guard.watch_tv_appearance
     end
   end
 
-  context "having a forgiving API" do
-
-    setup do
-      @president = President.new
-    end
-
-    should "let people chain methods either order" do
-      joe_public = JoePublic.new
-      assert_equal "I'm on your TV!", CoastGuard.as(joe_public).on(@president).watch_tv_appearance
-      assert_equal "I'm on your TV!", CoastGuard.on(@president).as(joe_public).watch_tv_appearance
-    end
-  end
 end

metadata

@@ -2,7 +2,7 @@
 name: objectbouncer
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors: 
 - Glenn Gillen
@@ -12,19 +12,9 @@ cert_chain: []
 
 date: 2011-03-07 00:00:00 +00:00
 default_executable: 
-dependencies: 
-- !ruby/object:Gem::Dependency 
-  name: httparty
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - "="
-      - !ruby/object:Gem::Version 
-        version: 0.6.1
-  type: :runtime
-  version_requirements: *id001
-description: ""
+dependencies: []
+
+description: A simple DSL and object proxy to restrict access to instances of your classes based on any conditional you provide
 email: glenn@rubypond.com
 executables: []
 
@@ -68,7 +58,7 @@ rubyforge_project:
 rubygems_version: 1.6.0
 signing_key: 
 specification_version: 2
-summary: ""
+summary: A simple object proxy to restrict access to methods and attributes
 test_files: 
 - test/objectbouncer/base_test.rb
 - test/test_helper.rb