obj_parser 0.0.5 → 0.0.6

data/lib/obj_parser/obj.rb

@@ -35,6 +35,7 @@ module ObjParser
     end
     
     def compute_tangents
+      return if textures.count == 0 || normals.count == 0
       self.resolve_faces
     	self.tangents = []
     	self.tangents_indexes = []

data/lib/obj_parser/version.rb

@@ -1,3 +1,3 @@
 module ObjParser
-  VERSION = "0.0.5"
+  VERSION = "0.0.6"
 end

data/test/obj_parser_spec.rb

@@ -11,7 +11,7 @@ describe ObjParser::ObjParser do
     obj.textures.count.must_equal(4)
     obj.vertice_indexes.count.must_equal(36)
     obj.normals_indexes.count.must_equal(36)
-    obj.textures_indexes.count.must_equal(36)    
+    obj.textures_indexes.count.must_equal(36)
   end
 
   private

data/test/obj_spec.rb

@@ -22,7 +22,6 @@ describe ObjParser::Obj do
   
   it 'compute tangents' do
     @obj.compute_tangents
-    puts @obj.tangents.map(&:data)
     result = @obj.faces.each_with_index.map do |face, index| 
   		face.vertice.map do |vertex|
   		  ("%.2f" % ObjParser::MathUtils::dot(vertex.tangent.data[0..2], vertex.normal.data)).to_f
@@ -31,4 +30,16 @@ describe ObjParser::Obj do
     result.must_equal(0)
   end
   
+  it 'compute tangents does nothing when normals and textures are defined' do
+    t = @obj.textures
+    @obj.textures = []
+    @obj.compute_tangents
+    @obj.tangents.must_equal([])
+    
+    @obj.textures = t
+    @obj.normals = []
+    @obj.compute_tangents
+    @obj.tangents.must_equal([])
+  end
+  
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: obj_parser
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
   prerelease: 
 platform: ruby
 authors: