obj_parser 0.0.4 → 0.0.5

data/lib/obj_parser/obj.rb

@@ -41,35 +41,35 @@ module ObjParser
     	pindex = 0
     	self.faces.each do |face|
       	pindex += 1
-    		tangent_for_face = ObjParser::MathUtils::tangent_for_vertices_and_texures(face.vertice.map(&:data), face.textures.map(&:data))
-    		tangent_for_face = ObjParser::MathUtils::normalized_vector(tangent_for_face)
+    		tangent_for_face = MathUtils::tangent_for_vertices_and_texures(face.vertice.map(&:data), face.textures.map(&:data))
+    		tangent_for_face = MathUtils::normalized_vector(tangent_for_face)
     		#set the same tangent for the 3 vertex of current face
     		#re-compute tangents for duplicates vertices to get tangent per face
     		face.vertice.each_with_index do |vertex, index|
-    			vertex.tangent.data = ObjParser::MathUtils::sum_vectors(vertex.tangent.data, tangent_for_face)
+    			vertex.tangent.data = MathUtils::sum_vectors(vertex.tangent.data, tangent_for_face)
     		end
       end
 	
     	#orthonormalize
     	self.faces.each_with_index do |face,pindex|
     	  face.vertice.each_with_index do |vertex, index|
-    		vertex.tangent.data = ObjParser::MathUtils::orthogonalized_vector_with_vector(vertex.tangent.data, self.normals[self.normals_indexes[pindex * 3 + index]].data)
-    		vertex.tangent.data = ObjParser::MathUtils::normalized_vector(vertex.tangent.data)
+    		vertex.tangent.data = MathUtils::orthogonalized_vector_with_vector(vertex.tangent.data, self.normals[self.normals_indexes[pindex * 3 + index]].data)
+    		vertex.tangent.data = MathUtils::normalized_vector(vertex.tangent.data)
        	 end
     	end
 	
     	#binormal should be computed with per vertex tangent and summed for each vertex
     	self.faces.each_with_index do |face,pindex|
     		face.vertice.each_with_index do |vertex, index|
-    			binormal = ObjParser::MathUtils::cross_product(self.normals[self.normals_indexes[pindex * 3 + index]].data, vertex.tangent.data)
-    			vertex.binormal.data = ObjParser::MathUtils::sum_vectors(vertex.binormal.data, binormal)
+    			binormal = MathUtils::cross_product(self.normals[self.normals_indexes[pindex * 3 + index]].data, vertex.tangent.data)
+    			vertex.binormal.data = MathUtils::sum_vectors(vertex.binormal.data, binormal)
     		end
     	end
 	
     	self.faces.each_with_index do |face,pindex|
     	  face.vertice.each_with_index do |vertex, index|
-      		vertex.binormal.data = ObjParser::MathUtils::normalized_vector(vertex.binormal.data)
-      		if(ObjParser::MathUtils::dot(ObjParser::MathUtils::cross_product(self.normals[self.normals_indexes[pindex * 3 + index]].data, vertex.tangent.data), vertex.binormal.data) < 0.0)
+      		vertex.binormal.data = MathUtils::normalized_vector(vertex.binormal.data)
+      		if(MathUtils::dot(MathUtils::cross_product(self.normals[self.normals_indexes[pindex * 3 + index]].data, vertex.tangent.data), vertex.binormal.data) < 0.0)
       			vertex.tangent.data[3] = -1.0 
       		else
       			vertex.tangent.data[3] = 1.0 
@@ -88,7 +88,7 @@ module ObjParser
       self.resolve_faces
       result = self.faces.each_with_index.map do |face, index| 
     		face.vertice.map do |vertex|
-    		  ("%.2f" % ObjParser::MathUtils::dot(vertex.tangent.data[0..2], vertex.normal.data)).to_f
+    		  ("%.2f" % MathUtils::dot(vertex.tangent.data[0..2], vertex.normal.data)).to_f
     		end.reduce(&:+)
       end.reduce(&:+)
       puts "RESULT: tangents and normals are orthogonal -> [#{result == 0 ? "VALID" : "NOT VALID"}]"

data/lib/obj_parser/version.rb

@@ -1,3 +1,3 @@
 module ObjParser
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/test/obj_spec.rb

@@ -22,6 +22,7 @@ describe ObjParser::Obj do
   
   it 'compute tangents' do
     @obj.compute_tangents
+    puts @obj.tangents.map(&:data)
     result = @obj.faces.each_with_index.map do |face, index| 
   		face.vertice.map do |vertex|
   		  ("%.2f" % ObjParser::MathUtils::dot(vertex.tangent.data[0..2], vertex.normal.data)).to_f

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: obj_parser
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
   prerelease: 
 platform: ruby
 authors: