oauth2_api_client 3.1.0 → 3.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f658a875027e6f1dcfd8ca75235d581aa5ee577e6cf1cf01e30c5e0c902c987b
-  data.tar.gz: e11832285855ef59f5475fad329ebe3e286983a21e8a21ad2dad41853f508ecb
+  metadata.gz: 538d67c5360a1a6a2e2f9ff40c1b87acdaf6fdfe64ba292fbee47bc52c48047f
+  data.tar.gz: b50a7904af84f243bc73d0aebf89a8b00d50dd6ef5e579805b959b9de8161319
 SHA512:
-  metadata.gz: 292ee89d31d2eed1da05f7b5aec3abd25bef1048c03be27200810d94ed0d71e60b4300a9a28c21a6568a50e2c6c912f9acb85a6b4f7bc0ac5fbe97ec19a82f9c
-  data.tar.gz: 78425acfe627c77d4f4ebba6b78e791a743ae192ae8b39367e3e82e5ea6376d90c11a8272b705a62704b355b32908ee268ec989868be1f66e25c93612224a658
+  metadata.gz: b801d4daec062a26567ba686b923a1051a3d024e5a9ed0ddb954edb093d5c26891b4f071657df2c34284be7d3f8cb38f60ceb277d145e3c7628cd45daa58c227
+  data.tar.gz: 4dd5218f1d770194836800702190dba87b943c80c92f65c0a518bc4ca2c9783f24f7d2bc23968705ec52ec067f6d4127439aa9d367f14a80f95cbe828861f722

data/.github/workflows/test.yml

@@ -0,0 +1,21 @@
+on: push
+name: test
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby:
+        - 2.6
+        - 2.7
+        - 3.0
+    steps:
+    - uses: actions/checkout@v1
+    - uses: actions/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+    - run: gem install bundler
+    - run: bundle
+    - run: bundle exec rspec
+    - run: bundle exec rubocop

data/.rubocop.yml

@@ -1,6 +1,12 @@
 AllCops:
   NewCops: enable
 
+Gemspec/RequiredRubyVersion:
+  Enabled: false
+
+Gemspec/RequireMFA:
+  Enabled: false
+
 Metrics/ParameterLists:
   Enabled: false
 

data/CHANGELOG.md

@@ -1,6 +1,18 @@
 
 # CHANGELOG
 
+# v3.2.1
+
+* Fix thread safety issue of http-rb
+
+# v3.2.0
+
+* Allow passing `nil` as token for unprotected APIs
+
+# v3.1.1
+
+* Added oauth2 version constraint
+
 # v3.1.0
 
 * Added uri to `Oauth2ApiClient::ReponseError` exception message

data/README.md

@@ -1,6 +1,6 @@
 # oauth2_api_client
 
-[![Build Status](https://secure.travis-ci.org/mrkamel/oauth2_api_client.svg?branch=master)](http://travis-ci.org/mrkamel/oauth2_api_client)
+[![Build](https://github.com/mrkamel/oauth2_api_client/workflows/test/badge.svg)](https://github.com/mrkamel/oauth2_api_client/actions?query=workflow%3Atest+branch%3Amaster)
 [![Gem Version](https://badge.fury.io/rb/oauth2_api_client.svg)](http://badge.fury.io/rb/oauth2_api_client)
 
 Oauth2ApiClient is a small, but powerful client around
@@ -12,10 +12,17 @@ oauth2 for authentication.
 client = Oauth2ApiClient.new(base_url: "https://api.example.com", token "oauth2 token")
 
 client.post("/orders", json: { address: "..." }).status.success?
-client.headers("User-Agent" => "API Client").timeout(read: 5, write: 5).get("/orders").parse
+client.headers("User-Agent" => "API Client").timeout(read: 5, write: 5).get("/orders").parse(:json)
 # ...
 ```
 
+In case an API is unprotected and you still want to use Oauth2ApiClient, you
+can simply not pass any token:
+
+```ruby
+client = Oauth2ApiClient.new(base_url: "...")
+```
+
 Oauth2ApiClient is capable of generating oauth2 tokens, when a client id,
 client secret and oauth token url is given with automatic token caching and
 renewal on expiry, including retry of the current request.

data/lib/oauth2_api_client/response_error.rb

@@ -65,6 +65,8 @@ class Oauth2ApiClient
     attr_reader :response
 
     def initialize(response)
+      super()
+
       @response = response
     end
 

data/lib/oauth2_api_client/version.rb

@@ -1,3 +1,3 @@
 class Oauth2ApiClient
-  VERSION = "3.1.0"
+  VERSION = "3.2.1"
 end

data/lib/oauth2_api_client.rb

@@ -1,7 +1,6 @@
 require "ruby2_keywords"
 require "oauth2"
 require "http"
-require "ruby2_keywords"
 require "active_support"
 
 require "oauth2_api_client/version"
@@ -28,7 +27,7 @@ class Oauth2ApiClient
   #   )
   #
   #   client.post("/orders", json: { address: "..." }).status.success?
-  #   client.headers("User-Agent" => "API Client").timeout(read: 5, write: 5).get("/orders").parse
+  #   client.headers("User-Agent" => "API Client").timeout(read: 5, write: 5).get("/orders").parse(:json)
   #
   # @example
   #   client = Oauth2ApiClient.new(
@@ -41,7 +40,7 @@ class Oauth2ApiClient
   #     )
   #   )
 
-  def initialize(base_url:, base_request: HTTP, token:)
+  def initialize(base_url:, token: nil, base_request: HTTP)
     @base_url = base_url
     @token = token
     @request = base_request
@@ -52,6 +51,8 @@ class Oauth2ApiClient
   # @return [String] The token
 
   def token
+    return if @token.nil?
+
     @token.respond_to?(:to_str) ? @token.to_str : @token.token
   end
 
@@ -75,7 +76,11 @@ class Oauth2ApiClient
 
   def execute(verb, path, options = {})
     with_retry do
-      response = @request.auth("Bearer #{token}").send(verb, "#{@base_url}#{path}", options)
+      request = @request
+      request = request.headers({}) # Prevent thread-safety issue of http-rb: https://github.com/httprb/http/issues/558
+      request = request.auth("Bearer #{token}") if token
+
+      response = request.send(verb, "#{@base_url}#{path}", options)
 
       return response if response.status.success?
 

data/oauth2_api_client.gemspec

@@ -15,7 +15,6 @@ Gem::Specification.new do |spec|
 
   spec.files         = `git ls-files`.split($INPUT_RECORD_SEPARATOR)
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
   spec.add_development_dependency "bundler"
@@ -26,6 +25,6 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency "activesupport"
   spec.add_dependency "http"
-  spec.add_dependency "oauth2"
+  spec.add_dependency "oauth2", ">= 1.4.2"
   spec.add_dependency "ruby2_keywords"
 end

data/spec/oauth2_api_client_spec.rb

@@ -84,7 +84,7 @@ RSpec.describe Oauth2ApiClient do
       expect(client.get("/path", params: { key: "value" }).to_s).to eq("ok")
     end
 
-    it "passes the token in the authentication header" do
+    it "passes the token in the authorization header" do
       stub_request(:get, "http://localhost/api/path")
         .with(headers: { "Authorization" => "Bearer access_token" })
         .to_return(status: 200, body: "ok", headers: {})
@@ -94,6 +94,16 @@ RSpec.describe Oauth2ApiClient do
       expect(client.get("/path").to_s).to eq("ok")
     end
 
+    it "does not pass any authorization header when no token is provided" do
+      stub_request(:get, "http://localhost/api/path")
+        .with { |request| !request.headers.keys.map(&:to_s).map(&:downcase).include?("authorization") }
+        .to_return(status: 200, body: "ok", headers: {})
+
+      client = described_class.new(base_url: "http://localhost/api")
+
+      expect(client.get("/path").to_s).to eq("ok")
+    end
+
     it "retries the request when an http unauthorized status is returned" do
       stub_request(:get, "http://localhost/api/path")
         .to_return({ status: 401, body: "unauthorized" }, { status: 200, body: "ok" })

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: oauth2_api_client
 version: !ruby/object:Gem::Version
-  version: 3.1.0
+  version: 3.2.1
 platform: ruby
 authors:
 - Benjamin Vetter
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-07-23 00:00:00.000000000 Z
+date: 2022-08-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -114,14 +114,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.4.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.4.2
 - !ruby/object:Gem::Dependency
   name: ruby2_keywords
   requirement: !ruby/object:Gem::Requirement
@@ -144,9 +144,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/test.yml"
 - ".gitignore"
 - ".rubocop.yml"
-- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
@@ -165,7 +165,7 @@ homepage: https://github.com/mrkamel/oauth2_api_client
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -180,12 +180,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.3.3
+signing_key:
 specification_version: 4
 summary: Small but powerful client around oauth2 and http-rb to interact with APIs
-test_files:
-- spec/oauth2_api_client/response_error_spec.rb
-- spec/oauth2_api_client/token_provider_spec.rb
-- spec/oauth2_api_client_spec.rb
-- spec/spec_helper.rb
+test_files: []

data/.travis.yml

@@ -1,10 +0,0 @@
-sudo: false
-language: ruby
-rvm:
-  - ruby-2.6.2
-  - ruby-2.7.1
-install:
-  - travis_retry bundle install
-script:
- - bundle exec rspec
- - bundle exec rubocop