oass 0.0.1 → 0.1.0

data/spec/oass/client_spec.rb

@@ -17,7 +17,7 @@ describe Oass::Client do
   end
 
   describe "#request" do
-    use_vcr_cassette :record => :new_episodes, :match_requests_on => [:uri, :method, :body]
+    use_vcr_cassette
 
     let(:client) { Oass::Client.new }
 
@@ -49,7 +49,7 @@ describe Oass::Client do
   end
 
   describe "#read_campaign" do
-    use_vcr_cassette :record => :new_episodes, :match_requests_on => [:uri, :method, :body]
+    use_vcr_cassette
 
     let(:client) { Oass::Client.new }
 
@@ -69,7 +69,7 @@ describe Oass::Client do
   end
 
   describe "#read_creative" do
-    use_vcr_cassette :record => :new_episodes, :match_requests_on => [:uri, :method, :body]
+    use_vcr_cassette
 
     let(:client) { Oass::Client.new }
 
@@ -95,31 +95,61 @@ describe Oass::Client do
   end
 
   describe "#create_campaign" do
-    use_vcr_cassette :record => :new_episodes, :match_requests_on => [:uri, :method, :body]
+    use_vcr_cassette
 
     let(:client) { Oass::Client.new }
 
     context "with the required attributes" do
       let(:attributes) do
         {
-          :id => "random_id_lolwut_wtf",
+          :id => "random_id_lolwut_wtf_shit",
           :name => "LOLWUT",
           :advertiser_id => "bobo",
           :agency_id => "unknown_agency",
           :name => "LOLWUT",
           :campaign_manager => "lol",
           :product_id => "default-product",
+          :schedule => {
+            :impressions => 999,
+            :clicks => 0,
+            :uniques => 0,
+            :weight => 10,
+            :priority_level => 1,
+            :completion => "E",
+            :start_date => "2005-12-01",
+            :end_date => "2040-12-01",
+            :reach => "O",
+            :daily_impressions => 99,
+            :daily_clicks => 9,
+            :daily_uniq => 1,
+            :smooth_or_asap => "S",
+            :impression_overrun => 2,
+            :companion_positions => %w(B/T BL/TL),
+            :strict_companions => "Y",
+            :hours_of_day => %w(00 01 23),
+            :days_of_week => %w(2 3 4 5),
+            :user_time_zone => "Y",
+            :sections => %w(SectionABC SectionDEF)
+          }
         }
       end
 
       subject { client.create_campaign attributes }
 
-      its(:content) { "Successfully added." }
+      its(:content) { should == "Successfully added." }
+    end
+
+    context "with invalid attributes" do
+      use_vcr_cassette "Invalid campaign movie"
+
+      it "raises an OasError" do
+        expect { client.create_campaign :invalid => true }.to raise_error(Oass::OASError)
+      end
     end
   end
 
-  describe "#create_criative" do
-    use_vcr_cassette :record => :new_episodes, :match_requests_on => [:uri, :method, :body]
+  describe "#create_creative" do
+    use_vcr_cassette
 
     let(:client) { Oass::Client.new }
 
@@ -127,7 +157,7 @@ describe Oass::Client do
       let(:attributes) do
         {
           :campaign_id => "random_id_lolwut",
-          :id => "I_am_so_creative_lol",
+          :id => "I_am_so_creative_lolwut",
           :name => "A nice name indeed",
           :description => "Blabla",
           :click_url => "http://lolwut.com",
@@ -150,12 +180,60 @@ describe Oass::Client do
           :browser_versions => %w(explorer6 netscape7),
           :sequence_number => "4"
         }
+      end
+
+      subject { client.create_creative attributes }
+
+      its(:content) { should == "Successfully added." }
+    end
+
+    context "with a creative file" do
+      use_vcr_cassette :record => :once
 
+      let(:attributes) do
+        {
+          :campaign_id => "random_id_lolwut",
+          :id => "creative_with_a_creative_lol",
+          :name => "A nice name indeed",
+          :description => "Blabla",
+          :click_url => "http://lolwut.com",
+          :positions => %w(TopLeft BottomLeft),
+          :creative_types_id => "unknow_type",
+          :redirect_url => "http://lolwut.com",
+          :display => "Y",
+          :height => "30",
+          :width => "30",
+          :target_window => "targetwindow",
+          :alt_text => "Oh hai!",
+          :discount_impressions => "N",
+          :start_date => "1986-03-31",
+          :end_date => "2040-03-31",
+          :weight => "79",
+          :expire_immediately => "N",
+          :no_cache => "N",
+          :extra_html => "<b></b>",
+          :extra_text => "kthxbai",
+          :browser_versions => %w(explorer6 netscape7),
+          :sequence_number => "4",
+          :creative_file => {
+            :name => "image.png",
+            :content_type => "image/png",
+            :file => File.join(File.dirname(__FILE__), "../fixtures/creative_file.png")
+          }
+        }
       end
 
       subject { client.create_creative attributes }
 
-      its(:content) { "Successfully added." }
+      its(:content) { should == "Successfully added." }
+    end
+
+    context "with invalid attributes" do
+      use_vcr_cassette "Invalid creative movie"
+
+      it "raises an OasError" do
+        expect { client.create_creative :invalid => true }.to raise_error(Oass::OASError)
+      end
     end
   end
 end

data/spec/oass/configuration_spec.rb

@@ -6,6 +6,14 @@ describe Oass do
       it "allows configuration for #{setting}" do
         expect { Oass.send("#{setting}=", "LOL") }.to change { Oass.send(setting) }.to("LOL")
       end
+
+      it "provides #{setting} in the configuration block" do
+        expect {
+          Oass.configure { |config|
+            config.send("#{setting}=", "WUT")
+          }
+        }.to change { Oass.send(setting) }.to("WUT")
+      end
     end
   end
 end

data/spec/spec_helper.rb

@@ -1,9 +1,16 @@
 require 'oass'
 require 'vcr'
 
+Dir[File.join("spec/support/**/*.rb")].each { |f| require f }
+
 VCR.config do |config|
   config.cassette_library_dir = File.join("spec/fixtures/vcr_cassettes")
   config.stub_with :webmock
+  config.default_cassette_options = {
+    :record => :new_episodes,
+    :match_requests_on => [:uri, :method, :body],
+    :erb => { :username => ENV["OAS_USERNAME"], :password => ENV["OAS_PASSWORD"], :account => ENV["OAS_ACCOUNT"] }
+  }
 end
 
 RSpec.configure do |config|

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: oass
 version: !ruby/object:Gem::Version 
-  hash: 29
+  hash: 27
   prerelease: 
   segments: 
   - 0
-  - 0
   - 1
-  version: 0.0.1
+  - 0
+  version: 0.1.0
 platform: ruby
 authors: 
 - Rodrigo Navarro
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-05-25 00:00:00 -03:00
+date: 2011-05-26 00:00:00 -03:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -81,12 +81,18 @@ files:
 - README.md
 - Rakefile
 - lib/oass.rb
-- lib/oass/campaign.rb
 - lib/oass/client.rb
-- lib/oass/creative.rb
+- lib/oass/client/campaign.rb
+- lib/oass/client/creative.rb
 - lib/oass/errors.rb
 - lib/oass/version.rb
 - oass.gemspec
+- spec/fixtures/creative_file.png
+- spec/fixtures/vcr_cassettes/Invalid_campaign_movie.yml
+- spec/fixtures/vcr_cassettes/Invalid_creative_movie.yml
+- spec/fixtures/vcr_cassettes/Oass_Client/_create_campaign.yml
+- spec/fixtures/vcr_cassettes/Oass_Client/_create_creative.yml
+- spec/fixtures/vcr_cassettes/Oass_Client/_create_creative/with_a_creative_file.yml
 - spec/fixtures/vcr_cassettes/Oass_Client/_read_campaign.yml
 - spec/fixtures/vcr_cassettes/Oass_Client/_read_creative.yml
 - spec/fixtures/vcr_cassettes/Oass_Client/_request.yml
@@ -128,6 +134,12 @@ signing_key:
 specification_version: 3
 summary: Funny API to access OAS hellish soap interface
 test_files: 
+- spec/fixtures/creative_file.png
+- spec/fixtures/vcr_cassettes/Invalid_campaign_movie.yml
+- spec/fixtures/vcr_cassettes/Invalid_creative_movie.yml
+- spec/fixtures/vcr_cassettes/Oass_Client/_create_campaign.yml
+- spec/fixtures/vcr_cassettes/Oass_Client/_create_creative.yml
+- spec/fixtures/vcr_cassettes/Oass_Client/_create_creative/with_a_creative_file.yml
 - spec/fixtures/vcr_cassettes/Oass_Client/_read_campaign.yml
 - spec/fixtures/vcr_cassettes/Oass_Client/_read_creative.yml
 - spec/fixtures/vcr_cassettes/Oass_Client/_request.yml

data/lib/oass/campaign.rb

@@ -1,35 +0,0 @@
-module Oass
-  module Campaign
-    def read_campaign(id)
-      request "Campaign" do |xml|
-        xml.Campaign(:action => "read") do
-          xml.Overview { xml.Id id }
-        end
-      end
-    end
-
-    def create_campaign(attributes)
-      request "Campaign" do |xml|
-        xml.Campaign(:action => "add") do
-          xml.Overview do
-            # Yeah... the attributes must be in the right order =/
-            xml.Id attributes[:id]
-            xml.AdvertiserId attributes[:advertiser_id]
-            xml.Name attributes[:name]
-            xml.AgencyId attributes[:agency_id]
-            xml.Description attributes[:description]
-            xml.CampaignManager attributes[:campaign_manager]
-            xml.ProductId attributes[:product_id]
-            xml.ExternalUsers do
-              attributes[:external_users].each do |user_id|
-                xml.UserId user_id
-              end
-            end if attributes[:external_users]
-            xml.InternalQuickReport attributes[:internal_quick_report]
-            xml.ExternalQuickReport attributes[:external_quick_report]
-          end
-        end
-      end
-    end
-  end
-end

data/lib/oass/creative.rb

@@ -1,50 +0,0 @@
-module Oass
-  module Creative
-    def read_creative(campaign_id, id)
-      request "Creative" do |xml|
-        xml.Creative(:action => "read") do
-          xml.CampaignId campaign_id
-          xml.Id id
-        end
-      end
-    end
-
-    def create_creative(attributes)
-      request "Creative" do |xml|
-        xml.Creative(:action => "add") do
-          xml.CampaignId attributes[:campaign_id]
-          xml.Id attributes[:id]
-          xml.Name attributes[:name]
-          xml.Description attributes[:description]
-          xml.ClickUrl attributes[:click_url]
-          xml.Positions do
-            attributes[:positions].each do |position|
-              xml.Position position
-            end
-          end
-          xml.CreativeTypesId attributes[:creative_types_id]
-          xml.RedirectUrl attributes[:redirect_url]
-          xml.Display attributes[:display]
-          xml.Height attributes[:height]
-          xml.Width attributes[:width]
-          xml.TargetWindow attributes[:target_window]
-          xml.AltText attributes[:alt_text]
-          xml.DiscountImpressions attributes[:discount_impressions]
-          xml.StartDate attributes[:start_date]
-          xml.EndDate attributes[:end_date]
-          xml.Weight attributes[:weight]
-          xml.ExpireImmediately attributes[:expire_immediately]
-          xml.NoCache attributes[:no_cache]
-          xml.ExtraHTML attributes[:extra_html]
-          xml.ExtraText attributes[:extra_text]
-          xml.BrowserV do
-            attributes[:browser_versions].each do |version|
-              xml.Code version
-            end
-          end
-          xml.SequenceNo attributes[:sequence_number]
-        end
-      end
-    end
-  end
-end