oa-globocom 0.4.6 → 0.4.7

data/lib/oa-globocom/version.rb

@@ -2,7 +2,7 @@ module OAGloboCom
   module VERSION
     MAJOR = 0
     MINOR = 4
-    PATCH = 6
+    PATCH = 7
     
     STRING = [MAJOR, MINOR, PATCH] * '.'
   end

data/lib/omni_auth/strategies/globocom.rb

@@ -8,9 +8,12 @@ module OmniAuth
     class GloboCom
       include OmniAuth::Strategy
       
+      attr_reader :logger
+      
       def initialize(app, opts = {})
         Cadun::Config.load_file(opts[:config])
         
+        @logger = opts[:logger]
         super(app, :cadun, opts)
       end
       
@@ -22,6 +25,8 @@ module OmniAuth
         begin
           super
         rescue => e
+          logger.error(log_exception(e)) if logger
+          
           fail!(e.message, e.message)
         end
       end
@@ -57,6 +62,14 @@ module OmniAuth
           env['REMOTE_ADDR']
         end
       end
+      
+      def log_env
+        "SERVER_NAME: #{request.env['SERVER_NAME']} | PATH_INFO: #{request.env['PATH_INFO']} | QUERY_STRING: #{request.env['QUERY_STRING']}"
+      end
+      
+      def log_exception(exception)
+        "#{log_env} | EXCEPTION: #{exception}"
+      end
     end
   end
 end

data/spec/omni_auth/strategies/globocom_spec.rb

@@ -131,4 +131,50 @@ describe OmniAuth::Strategies::GloboCom do
     end
   end
 
+  describe "#log_env" do
+    it 'should render the log' do
+      stub_fail_requests
+      strategy.call! Rack::MockRequest.env_for("http://localhost/auth/cadun/callback?GLBID=GLBID", "rack.session" => {}, "REMOTE_ADDR" => "127.0.0.1")
+      strategy.log_env.should == "SERVER_NAME: localhost | PATH_INFO: /auth/cadun/callback | QUERY_STRING: GLBID=GLBID"
+    end
+  end
+  
+  describe "#log_exception" do
+    it "should render the log" do
+      stub_fail_requests
+      strategy.call! Rack::MockRequest.env_for("http://localhost/auth/cadun/callback?GLBID=GLBID", "rack.session" => {}, "REMOTE_ADDR" => "127.0.0.1")
+      
+      exception = Exception.new('Error')
+      strategy.log_exception(exception).should == "SERVER_NAME: localhost | PATH_INFO: /auth/cadun/callback | QUERY_STRING: GLBID=GLBID | EXCEPTION: Error"
+    end
+  end
+  
+  describe "logging failures" do
+    before do
+      pending("RR doesn't implement superclass stubs. I don't know how to figure it out yet.")
+    end
+    
+    it "should log the failure" do
+      strategy = OmniAuth::Strategies::GloboCom.new app, :service_id => 1, :config => "#{File.dirname(__FILE__)}/../../support/fixtures/config.yml", :logger => Logger.new($stdout)
+      stub_fail_requests
+      
+      logger = mock('logger')
+      mock(logger).error('SERVER_NAME: localhost | PATH_INFO: /auth/cadun/callback | QUERY_STRING: GLBID=GLBID | EXCEPTION: Exception')
+      stub(strategy).call_app! { raise Exception }
+      stub(strategy).logger { logger }
+      
+      strategy.call! Rack::MockRequest.env_for("http://localhost/auth/cadun/callback?GLBID=GLBID", "rack.session" => {}, "REMOTE_ADDR" => "127.0.0.1")
+    end
+    
+    it "should not log the failure" do
+      stub_fail_requests
+      
+      logger = mock('logger')
+      dont_allow(logger).error
+      stub(strategy).call_app! { raise Exception }
+      stub(strategy).logger { nil }
+      
+      strategy.call! Rack::MockRequest.env_for("http://localhost/auth/cadun/callback?GLBID=GLBID", "rack.session" => {}, "REMOTE_ADDR" => "127.0.0.1")
+    end
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: oa-globocom
 version: !ruby/object:Gem::Version
-  version: 0.4.6
+  version: 0.4.7
   prerelease: 
 platform: ruby
 authors:
@@ -11,11 +11,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2011-07-28 00:00:00.000000000Z
+date: 2011-08-05 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: oa-core
-  requirement: &2156660480 !ruby/object:Gem::Requirement
+  requirement: &2152430320 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -23,10 +23,10 @@ dependencies:
         version: 0.2.6
   type: :runtime
   prerelease: false
-  version_requirements: *2156660480
+  version_requirements: *2152430320
 - !ruby/object:Gem::Dependency
   name: cadun
-  requirement: &2156659980 !ruby/object:Gem::Requirement
+  requirement: &2152429820 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -34,10 +34,10 @@ dependencies:
         version: 0.5.5
   type: :runtime
   prerelease: false
-  version_requirements: *2156659980
+  version_requirements: *2152429820
 - !ruby/object:Gem::Dependency
   name: rack
-  requirement: &2156689280 !ruby/object:Gem::Requirement
+  requirement: &2152429440 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -45,10 +45,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2156689280
+  version_requirements: *2152429440
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &2156688820 !ruby/object:Gem::Requirement
+  requirement: &2152428980 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -56,10 +56,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2156688820
+  version_requirements: *2152428980
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &2156688400 !ruby/object:Gem::Requirement
+  requirement: &2152428560 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -67,10 +67,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2156688400
+  version_requirements: *2152428560
 - !ruby/object:Gem::Dependency
   name: rr
-  requirement: &2156687980 !ruby/object:Gem::Requirement
+  requirement: &2152428140 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -78,10 +78,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2156687980
+  version_requirements: *2152428140
 - !ruby/object:Gem::Dependency
   name: fakeweb
-  requirement: &2156687560 !ruby/object:Gem::Requirement
+  requirement: &2152427720 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -89,7 +89,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2156687560
+  version_requirements: *2152427720
 description: The goal of this gem is to allow the developer to use ContaGlobo.com
   (a login webservice made by Globo.com) in any web app using OmniAuth
 email: