nylas 4.6.0 → 4.6.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 46e28cb5adc245b84ca2b193137308a2d0d95b45ec76938b8ce8bc50ad43e39e
-  data.tar.gz: 7b518a3084cacc0416ccfe7124d5580f092e63d9589c62d693a4c889618155ec
+  metadata.gz: cc59654b2a73962455afa89f51aa5bd9b5dcfe7867c6a10add1da68725982db6
+  data.tar.gz: 6df2f0c708e16d688666429edb793f736f9df1ae65fc310f3c1ffdf8fa197672
 SHA512:
-  metadata.gz: 77debca7d2c13b8da3f64266843d834a1e49b2cbb982a5176e6fd084eb472c5b7a6ba9e865266092c1e4240eedcc7f9db3eb959f114b7f33c1bef0d4f888cf09
-  data.tar.gz: be398a3b5ca813fc91f9bd44abba42d1a6c36f20397646529b97829e1b752f1b4b45f56c223ce1a72fedeed1b0c566b92b3148db517332344d93bd08bd9bf43c
+  metadata.gz: c2bb1f816dbd759685097c76d7d03ee9a24870fd341a4cd2909cc33be5078f6a1bee9b72871d126a48f09e6e0edd047e2f1dd2b3b9b0205003f7cf8d2af6ac25
+  data.tar.gz: dd34aa4b46d5de885dc3c0acca19fe4f0adfedec97b2790e2bff402c3240aa5c26c78f4b413c8cf817e5914eb8cd6788770a652ff21af4484c80b832ba44909f

data/lib/nylas.rb

@@ -3,6 +3,21 @@
 require "json"
 require "rest-client"
 
+# BUGFIX
+#   See https://github.com/sparklemotion/http-cookie/issues/27
+#   and https://github.com/sparklemotion/http-cookie/issues/6
+#
+# CookieJar uses unsafe class caching for dynamically loading cookie jars
+# If 2 rest-client instances are instantiated at the same time, (in threads)
+# non-deterministic behaviour can occur whereby the Hash cookie jar isn't
+# properly loaded and cached.
+# Forcing an instantiation of the jar onload will force the CookieJar to load
+# before the system has a chance to spawn any threads.
+# Note this should technically be fixed in rest-client itself however that
+# library appears to be stagnant so we're forced to fix it here
+# This object should get GC'd as it's not referenced by anything
+HTTP::CookieJar.new
+
 require "ostruct"
 require "forwardable"
 

data/lib/nylas/api.rb

@@ -36,6 +36,18 @@ module Nylas
       )
     end
 
+    def exchange_code_for_token(code)
+      data = {
+        "client_id" => app_id,
+        "client_secret" => client.app_secret,
+        "grant_type" => "authorization_code",
+        "code" => code
+      }
+
+      response_json = execute(method: :post, path: "/oauth/token", payload: data)
+      response_json[:access_token]
+    end
+
     # @return [Collection<Contact>] A queryable collection of Contacts
     def contacts
       @contacts ||= Collection.new(model: Contact, api: self)

data/lib/nylas/calendar.rb

@@ -15,6 +15,9 @@ module Nylas
 
     attribute :name, :string
     attribute :description, :string
+    attribute :is_primary, :boolean
+    attribute :location, :string
+    attribute :timezone, :string
 
     attribute :read_only, :boolean
 
@@ -22,6 +25,10 @@ module Nylas
       read_only == true
     end
 
+    def primary?
+      is_primary
+    end
+
     def events
       api.events.where(calendar_id: id)
     end

data/lib/nylas/contact.rb

@@ -29,7 +29,6 @@ module Nylas
     attribute :manager_name, :string
     attribute :office_location, :string
     attribute :notes, :string
-    attribute :web_page, :web_page
     attribute :source, :string
 
     has_n_of_attribute :groups, :contact_group

data/lib/nylas/draft.rb

@@ -33,9 +33,13 @@ module Nylas
     attribute :folder, :folder
     has_n_of_attribute :labels, :label
 
+    attribute :tracking, :message_tracking
+
     transfer :api, to: %i[events files folder labels]
 
     def send!
+      return execute(method: :post, path: "/send", payload: to_json) if tracking
+
       save
       execute(method: :post, path: "/send", payload: JSON.dump(draft_id: id, version: version))
     end

data/lib/nylas/errors.rb

@@ -14,6 +14,8 @@ module Nylas
   class ModelNotUpdatableError < ModelActionError; end
   class ModelNotDestroyableError < ModelActionError; end
 
+  class JsonParseError < Error; end
+
   # Raised when attempting to set a field that is not on a model with mass assignment
   class ModelMissingFieldError < ModelActionError
     def initialize(field, model)
@@ -48,6 +50,10 @@ module Nylas
   ResourceNotFound = Class.new(APIError)
   MethodNotAllowed = Class.new(APIError)
   InvalidRequest = Class.new(APIError)
+  UnauthorizedRequest = Class.new(APIError)
+  ResourceRemoved = Class.new(APIError)
+  TeapotError = Class.new(APIError)
+  RequestTimedOut = Class.new(APIError)
   MessageRejected = Class.new(APIError)
   SendingQuotaExceeded = Class.new(APIError)
   ServiceUnavailable = Class.new(APIError)

data/lib/nylas/event.rb

@@ -15,6 +15,7 @@ module Nylas
     attribute :calendar_id, :string
     attribute :master_event_id, :string
     attribute :message_id, :string
+    attribute :ical_uid, :string
 
     attribute :busy, :boolean
     attribute :description, :string

data/lib/nylas/file.rb

@@ -18,6 +18,7 @@ module Nylas
     attribute :content_type, :string
     attribute :filename, :string
     attribute :size, :integer
+    attribute :content_disposition, :string
 
     attr_accessor :file
     # Downloads and caches a local copy of the file.
@@ -56,7 +57,9 @@ module Nylas
     def retrieve_file
       response = api.get(path: "#{resource_path}/download")
       filename = response.headers.fetch(:content_disposition, "").gsub("attachment; filename=", "")
-      temp_file = Tempfile.new(filename, encoding: "ascii-8bit")
+      # The returned filename can be longer than 256 chars which isn't supported by rb_sysopen.
+      # 128 chars here is more than enough given that TempFile ensure the filename will be unique.
+      temp_file = Tempfile.new(filename[0..127], encoding: "ascii-8bit")
       temp_file.write(response.body)
       temp_file.seek(0)
       temp_file

data/lib/nylas/http_client.rb

@@ -1,20 +1,26 @@
 # frozen_string_literal: true
 
 module Nylas
+  require "yajl"
+
   # Plain HTTP client that can be used to interact with the Nylas API sans any type casting.
   class HttpClient # rubocop:disable Metrics/ClassLength
     HTTP_CODE_TO_EXCEPTIONS = {
       400 => InvalidRequest,
+      401 => UnauthorizedRequest,
       402 => MessageRejected,
       403 => AccessDenied,
       404 => ResourceNotFound,
       405 => MethodNotAllowed,
+      410 => ResourceRemoved,
+      418 => TeapotError,
       422 => MailProviderError,
       429 => SendingQuotaExceeded,
       500 => InternalError,
       501 => EndpointNotYetImplemented,
       502 => BadGateway,
-      503 => ServiceUnavailable
+      503 => ServiceUnavailable,
+      504 => RequestTimedOut
     }.freeze
 
     ENDPOINT_TIMEOUTS = {
@@ -80,7 +86,14 @@ module Nylas
         timeout: timeout
       )
       rest_client_execute(**request) do |response, _request, result|
-        response = parse_response(response)
+        content_type = nil
+
+        if response.headers && response.headers[:content_type]
+          content_type = response.headers[:content_type].downcase
+        end
+
+        response = parse_response(response) if content_type == "application/json"
+
         handle_failed_response(result: result, response: response)
         response
       end
@@ -130,9 +143,12 @@ module Nylas
     end
 
     def parse_response(response)
-      response.is_a?(Enumerable) ? response : JSON.parse(response, symbolize_names: true)
-    rescue JSON::ParserError
-      response
+      return response if response.is_a?(Enumerable)
+
+      json = StringIO.new(response)
+      Yajl::Parser.new(symbolize_names: true).parse(json)
+    rescue Yajl::ParseError
+      raise Nylas::JsonParseError
     end
     inform_on :parse_response, level: :debug, also_log: { result: true }
 

data/lib/nylas/message.rb

@@ -59,11 +59,33 @@ module Nylas
       super(payload)
     end
 
+    def update_folder(folder_id)
+      update(folder_id: folder_id)
+    end
+
     def expanded
       return self unless headers.nil?
 
       assign(api.execute(method: :get, path: resource_path, query: { view: "expanded" }))
       self
     end
+
+    def save_call
+      handle_folder
+
+      execute(
+        method: :put,
+        payload: attributes.serialize(keys: allowed_keys_for_save),
+        path: resource_path
+      )
+    end
+
+    def handle_folder
+      return if folder.nil?
+
+      self.folder_id = folder.id if folder_id.nil? && !self.to_h.dig(:folder, :id).nil?
+
+      self.folder = nil
+    end
   end
 end

data/lib/nylas/model/attributable.rb

@@ -2,7 +2,7 @@
 
 module Nylas
   module Model
-    # Allows defining of tyypecastable attributes on a model
+    # Allows defining of typecastable attributes on a model
     module Attributable
       def self.included(model)
         model.extend(ClassMethods)
@@ -27,8 +27,6 @@ module Nylas
         data.each do |attribute_name, value|
           if respond_to?(:"#{attribute_name}=")
             send(:"#{attribute_name}=", value)
-          else
-            Logging.logger.warn("#{attribute_name} is not defined as an attribute on #{self.class.name}")
           end
         end
       end

data/lib/nylas/model/attributes.rb

@@ -17,6 +17,8 @@ module Nylas
 
       def []=(key, value)
         data[key] = cast(key, value)
+      rescue Nylas::Registry::MissingKeyError
+        # Don't crash when a new attribute is added
       end
 
       # Merges data into the registry while casting input types correctly

data/lib/nylas/new_message.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Nylas
-  # Data structure for seending a message via the Nylas API
+  # Data structure for sending a message via the Nylas API
   class NewMessage
     include Model
     self.creatable = false
@@ -15,6 +15,7 @@ module Nylas
     has_n_of_attribute :from, :email_address
     has_n_of_attribute :cc, :email_address
     has_n_of_attribute :bcc, :email_address
+    has_n_of_attribute :reply_to, :email_address
 
     attribute :subject, :string
     attribute :body, :string

data/lib/nylas/physical_address.rb

@@ -12,5 +12,6 @@ module Nylas
     attribute :state, :string
     attribute :city, :string
     attribute :country, :string
+    attribute :secondary_address, :string
   end
 end

data/lib/nylas/thread.rb

@@ -45,6 +45,10 @@ module Nylas
       super(data)
     end
 
+    def update_folder(folder_id)
+      update(folder_id: folder_id)
+    end
+
     def starred?
       starred
     end

data/lib/nylas/types.rb

@@ -86,6 +86,7 @@ module Nylas
       end
 
       def serialize(object)
+        return nil if object.nil?
         object.to_i
       end
     end

data/lib/nylas/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Nylas
-  VERSION = "4.6.0"
+  VERSION = "4.6.5"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: nylas
 version: !ruby/object:Gem::Version
-  version: 4.6.0
+  version: 4.6.5
 platform: ruby
 authors:
 - Nylas, Inc.
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-09-27 00:00:00.000000000 Z
+date: 2021-02-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -240,7 +240,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '2.0'
     - - "<"
       - !ruby/object:Gem::Version
         version: '3.0'
@@ -250,10 +250,30 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: '2.0'
     - - "<"
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: yajl-ruby
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.2'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.2.1
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.2'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.2.1
 description: Gem for interacting with the Nylas API.
 email: support@nylas.com
 executables: []
@@ -311,7 +331,7 @@ files:
 - lib/nylas/web_page.rb
 - lib/nylas/webhook.rb
 - lib/nylas/when.rb
-homepage: 
+homepage:
 licenses:
 - MIT
 metadata:
@@ -321,7 +341,7 @@ metadata:
   homepage_uri: https://www.nylas.com
   source_code_uri: https://github.com/nylas/nylas-ruby
   wiki_uri: https://github.com/nylas/nylas-ruby/wiki
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -336,8 +356,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.1.2
+signing_key:
 specification_version: 4
 summary: Gem for interacting with the Nylas API
 test_files: []