nxt_http_client 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 24cb9d0503259603ad4a511e5f015503995a8a888fce15c87dcd6d66c6115ea2
-  data.tar.gz: 2158e2a01d44bad00194de299ecaedeeb29fb76d7c172cbb7b862c92c3f40b81
+  metadata.gz: ffedb69d52754004e36852106cc642f45c631a976c965d1f461a9ba7932ec836
+  data.tar.gz: dd9e0401a4002238ae521bba964552f0b9b68d2fd565deaa967932fe2f943258
 SHA512:
-  metadata.gz: 7b1928da8bacd8f94dab46a279c537fc4195c63940f9424b0366cafe94fd8689cfbea3e718d16ba376653d5ac919a23b967f46449137332bc9578b7ed7fcb465
-  data.tar.gz: 9bd2e240a1cb683fec23bd67392ecda8b96b6e17161b1297350fc00f4b85ea3633bcf151049d01c5bd2906e3495c6b45616afbec5c528b57becd27f2a6e79da9
+  metadata.gz: c087b60ab57dfb40ac9ae537ae4df7659fcc2c647177a4374ee7ab6df8e2de21223b29d8f757b39db1fd9231258008275b65c13c70afc9e28aba3bf6466e4069
+  data.tar.gz: 434b45a64a01692dbdd9a261d6cf33fdd1a8960e4c30a2dd207a128b9751fba2b041c35e6dd5fdce125fb601f2b217d381b4004e3d17ac1503f0b0c7cced3d63

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    nxt_http_client (0.2.1)
+    nxt_http_client (0.2.2)
       activesupport (~> 5.2)
       typhoeus
 

data/README.md

@@ -60,7 +60,11 @@ class MyClient < NxtHttpClient
    
     # In case one of the response handler callbacks raises an error
     # after fire will has access to it and you may want to reraise the error in that case.
-    raise result if result.is_a?(StandardError)  
+    if error
+      raise error
+    else  
+      result
+    end
   end
   
   def fetch_details
@@ -79,6 +83,13 @@ class MyClient < NxtHttpClient
       end
     end
   end
+  
+  def update
+    # there are also convenience methods for all http verbs (get post patch put delete head)
+    post(params: { my: 'payload' }) do |handler|
+      # would post to the base_url
+    end
+  end
 end
 ```
 

data/lib/nxt_http_client/client_dsl.rb

@@ -1,9 +1,11 @@
 module NxtHttpClient
   module ClientDsl
     def configure(opts = {}, &block)
-      @default_config ||= DefaultConfig.new(**opts)
-      @default_config.tap { |d| block.call(d) }
-      @default_config
+      opts.each do |k,v|
+        default_config.send(k, v)
+      end
+      default_config.tap { |d| block.call(d) }
+      default_config
     end
 
     def before_fire(&block)
@@ -11,7 +13,7 @@ module NxtHttpClient
     end
 
     def before_fire_callback
-      @before_fire_callback
+      @before_fire ||= dup_instance_variable_from_ancestor_chain(:@before_fire_callback)
     end
 
     def after_fire(&block)
@@ -19,34 +21,44 @@ module NxtHttpClient
     end
 
     def after_fire_callback
-      @after_fire_callback
+      @after_fire_callback ||= dup_instance_variable_from_ancestor_chain(:@after_fire_callback)
     end
 
     def default_config
-      @default_config ||= DefaultConfig.new
+      @default_config ||= dup_instance_variable_from_ancestor_chain(:@default_config) { DefaultConfig.new }
     end
 
     def register_response_handler(handler = nil, &block)
       @response_handler = handler
-      @response_handler ||= dup_handler_from_ancestor_or_new
+      @response_handler ||= dup_instance_variable_from_ancestor_chain(:@response_handler) { NxtHttpClient::ResponseHandler.new }
       @response_handler.configure(&block) if block_given?
       @response_handler
     end
 
     def response_handler
-      @response_handler
+      @response_handler ||= dup_instance_variable_from_ancestor_chain(:@response_handler) { NxtHttpClient::ResponseHandler.new }
     end
 
-    def dup_handler_from_ancestor_or_new
-      handler_from_ancestor = ancestors[1].instance_variable_get(:@response_handler)
-      handler_from_ancestor && handler_from_ancestor.dup || NxtHttpClient::ResponseHandler.new
+    def client_ancestors
+      ancestors.select { |ancestor| ancestor <= NxtHttpClient::Client }
     end
 
-    def inherited(child)
-      child.instance_variable_set(:@response_handler, @response_handler.dup)
-      child.instance_variable_set(:@before_fire_callback, @before_fire_callback.dup)
-      child.instance_variable_set(:@after_fire_callback, @after_fire_callback.dup)
-      child.instance_variable_set(:@default_config, DefaultConfig.new(**default_config.to_h.deep_dup))
+    def instance_variable_from_ancestor_chain(instance_variable_name)
+      client = client_ancestors.find do |client|
+        client.instance_variable_get(instance_variable_name)
+      end
+
+      client.instance_variable_get(instance_variable_name)
+    end
+
+    def dup_instance_variable_from_ancestor_chain(instance_variable_name)
+      result = instance_variable_from_ancestor_chain(instance_variable_name).dup
+
+      if block_given?
+        result || yield
+      else
+        result
+      end
     end
   end
 end

data/lib/nxt_http_client/version.rb

@@ -1,3 +1,3 @@
 module NxtHttpClient
-  VERSION = "0.2.1"
+  VERSION = "0.2.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nxt_http_client
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Andreas Robecke