nxt_http_client 0.1.9 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fe54eb2ecb7b7c7025699424d538ab43c730dd93728557b427551317e6c60363
-  data.tar.gz: 703d8d45fe804609d39ded9806ecc6c0771a3dba9cb3414df890ffed6589bcca
+  metadata.gz: 63b2822eb210af59ee6f1c93d4eb3f7e7cae8d2e8f3d0d7af736a6b4ab16409e
+  data.tar.gz: 8508f16697f48fbb517c64b9c6663103b8a18f35fcb2bee2fc038e9d4e2613df
 SHA512:
-  metadata.gz: 68dbda40d531999f1f9fde9bfa17726ec6801f6f6d50db4a365dfc4586a1bdae3006d98c792a7f3fa58bc20144484a4044cd0e854b9a30ea4b98059bfb59bc82
-  data.tar.gz: a66fbc5a9aba10fbb4fbcf90d384e6bfd6bb5ca591bb7e8e8507670453167c84bee06390e69223bf6948b4c1251ecc5285db2ef298f121b41d90f5fc7504f40f
+  metadata.gz: a22e52e7f2dc4f8444d514c615f8f7972684dde4225720080290360c2cbb2f2df0f59e492f27ba588f0187619d88d9c6c392425dcebdd0e02c1786eaf026a4c7
+  data.tar.gz: 67cb746af5f0844b548bcaaa40aca1cdcb298080de1e4e5b1e049c1b4ad0f7ffcccbc364439dcbb3deb3f90236806cecb9a14a9b33c7535bfa11b3eddb4c6ba0

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    nxt_http_client (0.1.9)
+    nxt_http_client (0.2.0)
       activesupport (~> 5.2)
       typhoeus
 

data/README.md

@@ -28,12 +28,17 @@ class MyClient < NxtHttpClient
   
   configure do |config|
     config.base_url = 'www.example.com'
-    config.request_options = {
+    # In your subclasses you probably want to deep_merge options in order to not overwrite options inherited 
+    # from the parent class. Of course this will not influence the parent class and you can also reset them 
+    # to a new hash here.  
+    config.request_options.deep_merge!(
       headers: { API_KEY: '1993' },
       method: :get,
       followlocation: true
-    }
-    config.x_request_id_proc = -> { ('a'..'z').to_a.shuffle.take(10).join } # config to -> { SecureRandom.uuid } 
+    )
+    # Be aware that the result of x_request_id_proc will be hashed into the cache key and thus might cause 
+    # your request not to be cached if not used properly 
+    config.x_request_id_proc = -> { ('a'..'z').to_a.shuffle.take(10).join } 
   end
   
   register_response_handler do |handler|
@@ -50,7 +55,12 @@ class MyClient < NxtHttpClient
   end
   
   after_fire do |request, result, response|
-    # Will be called after fire 
+    # Will be called after fire. You probably want to return the result here in order for your code 
+    # to be able to access the result from the response handler from before. 
+   
+    # In case one of the response handler callbacks raises an error
+    # after fire will receive the error as the result and you may want to reraise the error in that case
+    raise result if result.is_a?(StandardError)  
   end
   
   def fetch_details

data/lib/nxt_http_client/client.rb

@@ -10,6 +10,10 @@ module NxtHttpClient
       opts = default_config.request_options.with_indifferent_access.deep_merge(opts.with_indifferent_access)
       opts[:headers] ||= {}
 
+      if default_config.x_request_id_proc
+        opts[:headers]['X-Request-ID'] ||= default_config.x_request_id_proc.call
+      end
+
       if opts[:cache] ||= false
         strategy = opts.delete(:cache)
 
@@ -52,15 +56,21 @@ module NxtHttpClient
       end
 
       result = nil
+      error = nil
 
       request.on_complete do |response|
         callback = response_handler.callback_for_response(response)
         result = callback && instance_exec(response, &callback) || response
-
+      rescue StandardError => e
+        error = e
+      ensure
         after_fire_callback = self.class.after_fire_callback
-        after_fire_callback && instance_exec(request, response, result, &after_fire_callback)
 
-        result
+        if after_fire_callback
+          result = instance_exec(request, response, (result || error), &after_fire_callback)
+        else
+          result || (raise error)
+        end
       end
 
       request.run

data/lib/nxt_http_client/default_config.rb

@@ -2,7 +2,7 @@ module NxtHttpClient
   CONFIGURABLE_OPTIONS = %i[request_options base_url x_request_id_proc]
 
   DefaultConfig = Struct.new('DefaultConfig', *CONFIGURABLE_OPTIONS) do
-    def initialize(request_options: ActiveSupport::HashWithIndifferentAccess.new, base_url: '', x_request_id_proc: -> { SecureRandom.uuid })
+    def initialize(request_options: ActiveSupport::HashWithIndifferentAccess.new, base_url: '', x_request_id_proc: nil)
       self.request_options = request_options
       self.base_url = base_url
       self.x_request_id_proc = x_request_id_proc

data/lib/nxt_http_client/version.rb

@@ -1,3 +1,3 @@
 module NxtHttpClient
-  VERSION = "0.1.9"
+  VERSION = "0.2.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nxt_http_client
 version: !ruby/object:Gem::Version
-  version: 0.1.9
+  version: 0.2.0
 platform: ruby
 authors:
 - Andreas Robecke
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-08-02 00:00:00.000000000 Z
+date: 2019-08-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: typhoeus