nxt_cop 2.5.0 → 2.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d36d052009c7de1ca3318d89019cd42f7db459c9ee4b2c0dd88f2e63adc37a83
-  data.tar.gz: 5c8b68f2cf5db256d431f1e7a37702417401b82eb017af97a71f73c0f515fc2b
+  metadata.gz: 7f45584695121519ec6dbc0f1d565c2463dbe829e55e7cf00df78e8f728042ee
+  data.tar.gz: b5a2d9c22beb2f592fc8cb1d50f04abaad093c53b8b69d3bec04a18a931068b2
 SHA512:
-  metadata.gz: 83bf1c4ce35ca15ea3211674015ca930797974855394b65fb3fbdd059399aae5542cf34be808d587df99a981ee2bc28fecfac7c2645bb244662bad3e35428fba
-  data.tar.gz: cf81b2893d0dfd9d8df6b4d9ff624fe16bfe70a546849fa5a0bb8a84b73f555ced914022ed452dc0e9f9ada71fcf4a9069c717a9dc3169b7d5b4241097472400
+  metadata.gz: 6e14374bcaa444f215a6a4b62d713666ba48553e4cc4d9660c5ecd8a3d6f957184a619a7446caad5840a2d1e9f3603f9a4533c5d2a89db165efa6275718d8cf5
+  data.tar.gz: 9ed42c24ab1cca574a987649c7aafe5f15931297d25fdbb4e05d628df14aa9fc299f1e1466a65eed5decfdf0c5dbb37b153ad623e65b913cf135af6b75e9cfc7

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+# v2.6.0 2025-02-26
+
+## What's Changed
+
+- Moves customs cops to namespace `Rubocop::Cop::NxtCop` so they can be required directly from the application without it being part of nxt_cop's `default.yml`.
+
+# v2.5.1 2024-06-12
+## What's Changed
+- Adds rubocop-rspec_rails to `.default.yml` to restore previous functionality
+
 # v2.5.0 2024-06-11
 ## What's Changed
 - Relaxes the rubocop version to not pin the patch

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    nxt_cop (2.5.0)
+    nxt_cop (2.6.0)
       rubocop (~> 1.60)
       rubocop-capybara (~> 2.21)
       rubocop-factory_bot (~> 2.26)

data/default.yml

@@ -1,15 +1,16 @@
 require:
-- rubocop-factory_bot
-- rubocop-rails
-- rubocop-rspec
-- ./custom_cops/nxt_core/rails/use_of_rails_logger.rb
+  - rubocop-factory_bot
+  - rubocop-rails
+  - rubocop-rspec
+  - rubocop-rspec_rails
+  - rubocop/cop/nxt_cop/use_of_rails_logger.rb
 
 inherit_mode:
   merge:
     - Exclude
     - Include
 
-Rails/UseOfRailsLogger:
+NxtCop/UseOfRailsLogger:
   Description: "Custom Getsafe cop to ensure the correct logger is used"
 
 AllCops:
@@ -26,7 +27,6 @@ AllCops:
   DisabledByDefault: false
   NewCops: disable # to avoid warnings. TODO: remove this setting and add new cops from the warning.
 
-
 Layout/ArgumentAlignment:
   EnforcedStyle: with_fixed_indentation
 Layout/ArrayAlignment:
@@ -64,35 +64,44 @@ Layout/FirstArrayElementLineBreak:
 Layout/MultilineMethodParameterLineBreaks:
   Enabled: true
 
+# Lint
 Lint:
   Enabled: true
 Lint/AmbiguousBlockAssociation:
   Exclude:
     - spec/**/*
+Lint/AssignmentInCondition:
+  Enabled: true
+Lint/DuplicateHashKey:
+  Enabled: true
+Lint/DuplicateRegexpCharacterClassElement:
+  Enabled: true
+Lint/EmptyInPattern:
+  Enabled: true
+Lint/IncompatibleIoSelectWithFiberScheduler:
+  Enabled: true
+Lint/LambdaWithoutLiteralBlock:
+  Enabled: true
 Lint/Loop:
-  Enabled: false
+  Enabled: true
 Lint/MissingSuper:
-  Enabled: false
-Lint/SymbolConversion:
-  EnforcedStyle: consistent
-Style/TrailingCommaInHashLiteral:
-  Enabled: false
-Style/HashSyntax:
   Enabled: true
-  EnforcedShorthandSyntax: either
-Security:
-  EnabledByDefault: true
-Style/Semicolon:
-  Exclude:
-    - spec/**/*
-Rails/TimeZone:
+Lint/NoReturnInBeginEndBlocks:
   Enabled: true
-Rails/Date:
+Lint/NumberedParameterAssignment:
   Enabled: true
-RSpec:
-  Enabled: false
-RSpec/Focus:
+Lint/RefinementImportMethods:
   Enabled: true
+Lint/RequireRelativeSelfPath:
+  Enabled: true
+Lint/ToEnumArguments:
+  Enabled: true
+Lint/UnexpectedBlockArity:
+  Enabled: true
+Lint/UselessRuby2Keywords:
+  Enabled: true
+Lint/SymbolConversion:
+  EnforcedStyle: consistent
 Lint/AmbiguousAssignment:
   Enabled: true
 Lint/DeprecatedConstants:
@@ -116,39 +125,15 @@ Lint/RedundantDirGlobSort:
 Lint/RequireRangeParentheses:
   Enabled: true
 
-# These checks are valid, but better left to programmer's discretion, as the effects of such code are harmless.
+# Lint - These checks are valid, but better left to programmer's discretion, as the effects of such code are harmless.
 Lint/DuplicateBranch:
   Enabled: false
-Lint/DuplicateRegexpCharacterClassElement:
-  Enabled: false
 Lint/EmptyBlock:
   Enabled: false
 Lint/EmptyClass:
   Enabled: false
-Lint/EmptyInPattern:
-  Enabled: false
-Lint/UnexpectedBlockArity:
-  Enabled: false
 
-# These code patterns are rare/nonexistent in our code, so checking for them is a waste of time
-Lint/IncompatibleIoSelectWithFiberScheduler:
-  Enabled: false
-Lint/LambdaWithoutLiteralBlock:
-  Enabled: false
-Lint/NoReturnInBeginEndBlocks:  # ❌ ENABLE THIS!
-  Enabled: false
-Lint/NumberedParameterAssignment:
-  Enabled: false
-Lint/RefinementImportMethods:
-  Enabled: false
-Lint/RequireRelativeSelfPath:
-  Enabled: false
-Lint/ToEnumArguments:
-  Enabled: false
-Lint/UselessRuby2Keywords:
-  Enabled: false
-
-# Since we don't have all cops enabled by default we have to add every new cop explicitly
+# Lint - Since we don't have all cops enabled by default we have to add every new cop explicitly
 Lint/DuplicateMagicComment:
   Enabled: true
 Lint/UselessRescue:
@@ -160,6 +145,25 @@ Lint/MixedCaseRange:
 Lint/RedundantRegexpQuantifiers:
   Enabled: true
 
+Style/TrailingCommaInHashLiteral:
+  Enabled: false
+Style/HashSyntax:
+  Enabled: true
+  EnforcedShorthandSyntax: either
+Security:
+  EnabledByDefault: true
+Style/Semicolon:
+  Exclude:
+    - spec/**/*
+Rails/TimeZone:
+  Enabled: true
+Rails/Date:
+  Enabled: true
+RSpec:
+  Enabled: false
+RSpec/Focus:
+  Enabled: true
+
 # This is default cops we want to keep disabled:
 Style/FrozenStringLiteralComment:
   Enabled: false
@@ -307,7 +311,7 @@ Rails/IndexBy:
   Enabled: false
 Rails/Pick:
   Enabled: false
-Style/CombinableLoops:  # hard to autocorrect properly
+Style/CombinableLoops: # hard to autocorrect properly
   Enabled: false
 FactoryBot/CreateList:
   Enabled: false
@@ -319,7 +323,7 @@ Style/GuardClause:
   Enabled: false
 Style/PercentLiteralDelimiters:
   Enabled: false
-Style/StringConcatenation:  # heavily used in insurance service
+Style/StringConcatenation: # heavily used in insurance service
   Enabled: false
 Style/InverseMethods:
   Enabled: false
@@ -392,7 +396,7 @@ Rails/UniqueValidationWithoutIndex: # definitely enable!!!
   Enabled: false
 Rails/Validation: # discuss with the team
   Enabled: false
-Rails/LexicallyScopedActionFilter:  # enable and manually disable offences
+Rails/LexicallyScopedActionFilter: # enable and manually disable offences
   Enabled: false
 Security/Open:
   Enabled: false

data/lib/nxt_cop/version.rb

@@ -1,3 +1,3 @@
 module NxtCop
-  VERSION = '2.5.0'.freeze
+  VERSION = '2.6.0'.freeze
 end

data/{custom_cops/nxt_core/rails → lib/rubocop/cop/nxt_cop}/use_of_rails_logger.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
 
-module CustomCops
-  module NxtCore
-    module Rails
+module Rubocop
+  module Cop
+    module NxtCop
       # Ensures that the NxtCore logger is used instead of `Rails.logger`.
       class UseOfRailsLogger < RuboCop::Cop::Base
         extend RuboCop::Cop::AutoCorrector

data/lib/rubocop/cop/nxt_cop.rb

@@ -0,0 +1,3 @@
+# frozen_string_literal: true
+
+require 'rubocop/cop/nxt_cop/use_of_rails_logger'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: nxt_cop
 version: !ruby/object:Gem::Version
-  version: 2.5.0
+  version: 2.6.0
 platform: ruby
 authors:
 - Scott Livingstone
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-06-12 00:00:00.000000000 Z
+date: 2025-02-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -172,9 +172,10 @@ files:
 - bin/guard
 - bin/rspec
 - bin/setup
-- custom_cops/nxt_core/rails/use_of_rails_logger.rb
 - default.yml
 - lib/nxt_cop/version.rb
+- lib/rubocop/cop/nxt_cop.rb
+- lib/rubocop/cop/nxt_cop/use_of_rails_logger.rb
 - nxt_cop.gemspec
 homepage: https://github.com/nxt-insurance/nxt_cop
 licenses: