nxt_cop 2.1.0 → 2.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 31120e5b23ae4a12f07a900c4331cf782390dd6e33d1e1f85ec700bfb6b40bc4
-  data.tar.gz: b6177b79c00d01220d57ded64b554e84106db6d87a0173b106bdc8e4d5f70aa0
+  metadata.gz: 36425e542055540a840b751553cd953353fafe70dc6201101dfb5c72432cba54
+  data.tar.gz: 14770d51c1893f141891cf0df314b5b0af32bbd5539a862ab0868b9bc7061729
 SHA512:
-  metadata.gz: c78924a1a8ad16e71c65989580e6b22b17e9fca132829fcd8d0b179284ba37c0aea827633acd1fb0ddfb30b29e8b1c904bf4e4398f3d814dce8ea2a1762775a3
-  data.tar.gz: a4526ac0f36242d8114a3d681453585dda82f9a0c5cb5420f3d2d7afe3b128a5ad277660c6fba0c75cd0dab85993b0af495a41c2ca5d783ed2c65da4e42d2ca7
+  metadata.gz: 0e1325eb79a605393bf2c985bade464459b6e035d57e8c5b3e02d638e28ff6f6f973f899ae5d006189d95216ce2908f2e2abf7db244617b33bf52bc6ed4538a0
+  data.tar.gz: '008136f537dd440edb75742c3c1219180dd33cd745644fa1fc489b4fa2234b1d846e7668bf83c880152f8ee5bca671945dd8a6a39796d0986cfd0ca111e16e43'

data/.tool-versions

@@ -0,0 +1 @@
+ruby 3.3.0

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+# v2.3.0 2024-02-09
+## What's Changed
+- Tree shake the config (no rules change)
+
+# v2.2.0 2024-01-30
+## What's Changed
+- Add rubocop-factory_bot
+
 # v2.1.0 2024-01-26
 ## What's Changed
 - Add cops for Rails + NxtCore logger functionality

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    nxt_cop (2.1.0)
+    nxt_cop (2.3.0)
       rubocop (~> 1.60.0)
       rubocop-rails (~> 2.8)
       rubocop-rspec (~> 2.12)
@@ -30,14 +30,14 @@ GEM
       concurrent-ruby (~> 1.0)
     json (2.7.1)
     language_server-protocol (3.17.0.3)
-    minitest (5.21.2)
+    minitest (5.22.2)
     mutex_m (0.2.0)
     parallel (1.24.0)
     parser (3.3.0.5)
       ast (~> 2.4.1)
       racc
     racc (1.7.3)
-    rack (3.0.8)
+    rack (3.0.9)
     rainbow (3.1.1)
     rake (13.1.0)
     regexp_parser (2.9.0)

data/default.yml

@@ -1,4 +1,5 @@
 require:
+- rubocop-factory_bot
 - rubocop-rails
 - rubocop-rspec
 - ./custom_cops/nxt_core/rails/use_of_rails_logger.rb
@@ -29,26 +30,17 @@ AllCops:
   DisabledByDefault: false
   NewCops: disable # to avoid warnings. TODO: remove this setting and add new cops from the warning.
 
-# A bunch of these layout cops are enabled by default,
-# but for some reason 'DisableByDefault' is set to 'true' above.
-# Removing this configuration leads to a lot of violations triggered
-# by other cops that are not auto-correctable.
+
 Layout/ArgumentAlignment:
   EnforcedStyle: with_fixed_indentation
 Layout/ArrayAlignment:
   EnforcedStyle: with_fixed_indentation
-Layout/HashAlignment:
-  EnforcedHashRocketStyle: key
 Layout/ParameterAlignment:
   EnforcedStyle: with_fixed_indentation
 Layout/MultilineArrayLineBreaks:
   Enabled: true
-Layout/MultilineBlockLayout:
-  Enabled: true
 Layout/MultilineHashKeyLineBreaks:
   Enabled: true
-Layout/MultilineHashBraceLayout:
-  Enabled: true
 Layout/FirstMethodArgumentLineBreak:
   Enabled: true
 Layout/MultilineMethodCallBraceLayout:
@@ -73,120 +65,22 @@ Layout/FirstArrayElementIndentation:
   EnforcedStyle: consistent
 Layout/FirstArrayElementLineBreak:
   Enabled: true
-Layout/IndentationWidth:
-  Enabled: true
-Layout/ClosingParenthesisIndentation:
-  Enabled: true
-Layout/FirstArgumentIndentation:
-  Enabled: true
-Layout/ElseAlignment:
-  Enabled: true
-Layout/FirstHashElementIndentation:
-  Enabled: true
-Layout/AssignmentIndentation:
-  Enabled: true
-Layout/CaseIndentation:
-  Enabled: true
-Layout/MultilineArrayBraceLayout:
-  Enabled: true
-Layout/BeginEndAlignment:
-  Enabled: true
-Layout/CommentIndentation:
-  Enabled: true
-Layout/DotPosition:
-  EnforcedStyle: leading
-Layout/EmptyLineAfterGuardClause:
-  Enabled: true
-Layout/IndentationConsistency:
-  Enabled: true
 Layout/MultilineMethodParameterLineBreaks:
   Enabled: true
-Layout/SpaceBeforeBlockBraces:
-  Enabled: true
-Layout/SpaceInsideBlockBraces:
-  Enabled: true
-Layout/SpaceInsideHashLiteralBraces:
-  Enabled: true
-Layout/TrailingEmptyLines:
-  Enabled: true
-Layout/EmptyLinesAroundClassBody:
-  EnforcedStyle: no_empty_lines
-Layout/EmptyLinesAroundBlockBody:
-  EnforcedStyle: no_empty_lines
-Layout/TrailingWhitespace:
-  AllowInHeredoc: false
-Layout/SpaceBeforeComma:
-  Enabled: true
-Layout/SpaceAfterComma:
-  Enabled: true
-Layout/EmptyLines:
-  Enabled: true
-Layout/EmptyLineAfterMagicComment:
-  Enabled: true
 
 Lint:
   Enabled: true
 Lint/AmbiguousBlockAssociation:
   Exclude:
     - spec/**/*
-Lint/BinaryOperatorWithIdenticalOperands:
-  Enabled: true
-Lint/ConstantDefinitionInBlock:
-  Enabled: true
-Lint/DeprecatedOpenSSLConstant:
-  Enabled: true
-Lint/DuplicateElsifCondition:
-  Enabled: true
-Lint/DuplicateRequire:
-  Enabled: true
-Lint/DuplicateRescueException:
-  Enabled: true
-Lint/EmptyConditionalBody:
-  Enabled: true
-Lint/EmptyFile:
-  Enabled: true
-Lint/FloatComparison:
-  Enabled: true
-Lint/IdentityComparison:
-  Enabled: true
 Lint/Loop:
   Enabled: false
 Lint/MissingSuper:
   Enabled: false
-Lint/MixedRegexpCaptureTypes:
-  Enabled: true
-Lint/OutOfRangeRegexpRef:
-  Enabled: true
-Lint/RaiseException:
-  Enabled: true
-Lint/SelfAssignment:
-  Enabled: true
-Lint/StructNewOverride:
-  Enabled: true
 Lint/SymbolConversion:
   EnforcedStyle: consistent
-Lint/TopLevelReturnWithArgument:
-  Enabled: true
-Lint/TrailingCommaInAttributeDeclaration:
-  Enabled: true
-Lint/UnreachableLoop:
-  Enabled: true
-Lint/UselessMethodDefinition:
-  Enabled: true
-Lint/UselessTimes:
-  Enabled: true
-Style/MutableConstant:
-  Enabled: true
-Style/StringLiterals:
-  Enabled: true
-Style/SymbolArray:
-  Enabled: true
 Style/TrailingCommaInHashLiteral:
   Enabled: false
-Style/TrailingCommaInArguments:
-  Enabled: true
-Style/WordArray:
-  Enabled: true
 Style/HashSyntax:
   Enabled: true
   EnforcedShorthandSyntax: either
@@ -245,7 +139,7 @@ Lint/IncompatibleIoSelectWithFiberScheduler:
   Enabled: false
 Lint/LambdaWithoutLiteralBlock:
   Enabled: false
-Lint/NoReturnInBeginEndBlocks:
+Lint/NoReturnInBeginEndBlocks:  # ❌ ENABLE THIS!
   Enabled: false
 Lint/NumberedParameterAssignment:
   Enabled: false
@@ -512,155 +406,3 @@ Style/EmptyElse:
   Enabled: false
 Style/MixinUsage: # Enable and then manually disable offenses?
   Enabled: false
-
-
-
-# ✅ Enabled in 2.0 version (activated by "enable all rules by default')
-# Let's keep commented list here for visibility for a while
-#
-#Layout/SpaceInsideParens:
-#  Enabled: false
-#Layout/SpaceBeforeFirstArg:
-#  Enabled: false
-#Layout/ExtraSpacing:
-#  Enabled: false
-#Layout/SpaceAfterColon:
-#  Enabled: false
-#Rails/PluralizationGrammar:
-#  Enabled: false
-#Layout/SpaceAroundMethodCallOperator:
-#  Enabled: false
-#Style/RedundantFreeze:
-#  Enabled: false
-#Layout/SpaceInLambdaLiteral:
-#  Enabled: false
-#Layout/LeadingCommentSpace:
-#  Enabled: false
-#Layout/DefEndAlignment:
-#  Enabled: false
-#Style/RedundantRegexpEscape:
-#  Enabled: false
-#Layout/HeredocIndentation:
-#  Enabled: false
-#Layout/ClosingHeredocIndentation:
-#  Enabled: false
-#Layout/LeadingEmptyLines:
-#  Enabled: false
-#Layout/EmptyLinesAroundAccessModifier:
-#  Enabled: false
-#Style/NegatedIf:
-#  Enabled: false
-#Style/CommentAnnotation:
-#  Enabled: false
-#Layout/MultilineOperationIndentation:
-#  Enabled: false
-#Style/ExpandPathArguments:
-#  Enabled: false
-#Layout/EmptyLinesAroundMethodBody:
-#  Enabled: false
-#Style/RedundantReturn:
-#  Enabled: false
-#Style/GlobalStdStream:
-#  Enabled: false
-#Style/FloatDivision:
-#  Enabled: false
-#Style/RescueStandardError:
-#  Enabled: false
-#Style/NilComparison:
-#  Enabled: false
-#Style/RedundantFetchBlock:
-#  Enabled: false
-#Style/Encoding:
-#  Enabled: false
-#Style/EmptyLiteral:
-#  Enabled: false
-#Layout/SpaceInsideReferenceBrackets:
-#  Enabled: false
-#Style/EmptyLambdaParameter:
-#  Enabled: false
-#Style/TernaryParentheses:
-#  Enabled: false
-#Naming/MethodName:
-#  Enabled: false
-#Style/SlicingWithRange:
-#  Enabled: false
-#Style/EmptyCaseCondition:
-#  Enabled: false
-#Style/SoleNestedConditional:
-#  Enabled: false
-#Rails/FindEach:
-#  Enabled: false
-#Style/RedundantFileExtensionInRequire:
-#  Enabled: false
-#Layout/SpaceInsideArrayLiteralBrackets:
-#  Enabled: false
-#Style/HashAsLastArrayItem:
-#  Enabled: false
-#Lint/RedundantCopDisableDirective:
-#  Enabled: false
-#Layout/SpaceAroundKeyword:
-#  Enabled: false
-#Style/KeywordParametersOrder:
-#  Enabled: false
-#Style/BlockComments:
-#  Enabled: false
-#Style/AndOr:
-#  Enabled: false
-#Style/EachWithObject:
-#  Enabled: false
-#Layout/SpaceAroundBlockParameters:
-#  Enabled: false
-#Style/MultilineTernaryOperator:
-#  Enabled: false
-#Style/RedundantParentheses:
-#  Enabled: false
-#Security/JSONLoad:
-#  Enabled: false
-#Style/MethodCallWithoutArgsParentheses:
-#  Enabled: false
-#Style/CommentedKeyword:
-#  Enabled: false
-#Style/MultilineIfModifier:
-#  Enabled: false
-#Style/IfInsideElse:
-#  Enabled: false
-#Style/AccessorGrouping:
-#  Enabled: false
-#Layout/BlockEndNewline:
-#  Enabled: false
-#Rails/RedundantForeignKey:
-#  Enabled: false
-#Style/UnlessElse:
-#  Enabled: false
-#Layout/EmptyLinesAroundModuleBody:
-#  Enabled: false
-#Rails/RakeEnvironment:
-#  Enabled: false
-#Layout/EmptyLinesAroundArguments:
-#  Enabled: false
-#Style/EachForSimpleLoop:
-#  Enabled: false
-#Style/ClassCheck:
-#  Enabled: false
-#Style/NestedParenthesizedCalls:
-#  Enabled: false
-#Style/LineEndConcatenation:
-#  Enabled: false
-#Style/ParallelAssignment:
-#  Enabled: false
-#Layout/EmptyLinesAroundExceptionHandlingKeywords:
-#  Enabled: false
-#Layout/SpaceAroundEqualsInParameterDefault:
-#  Enabled: false
-#Style/YodaCondition:
-#  Enabled: false
-#Layout/SpaceInsideStringInterpolation:
-#  Enabled: false
-#Style/EmptyMethod:
-#  Enabled: false
-#Layout/EmptyLineBetweenDefs:
-#  Enabled: false
-#Naming/ConstantName:
-#  Enabled: false
-#Rails/RelativeDateConstant:
-#  Enabled: false

data/lib/nxt_cop/version.rb

@@ -1,3 +1,3 @@
 module NxtCop
-  VERSION = '2.1.0'.freeze
+  VERSION = '2.3.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: nxt_cop
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.3.0
 platform: ruby
 authors:
 - Scott Livingstone
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-01-29 00:00:00.000000000 Z
+date: 2024-02-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -89,6 +89,7 @@ files:
 - ".gitignore"
 - ".rubocop.yml"
 - ".ruby-version"
+- ".tool-versions"
 - CHANGELOG.md
 - Gemfile
 - Gemfile.lock