nxt_cop 2.0.1 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 530b577b485dd169ba5ef2bf3820e7a3fa6e8ec4a6604db775c755d5019a3dbc
-  data.tar.gz: cddfba144d854181aecd07f7e3ea98a24d83a281575ec7cece77543f7d9fd448
+  metadata.gz: 31120e5b23ae4a12f07a900c4331cf782390dd6e33d1e1f85ec700bfb6b40bc4
+  data.tar.gz: b6177b79c00d01220d57ded64b554e84106db6d87a0173b106bdc8e4d5f70aa0
 SHA512:
-  metadata.gz: 04b24945b0ca039e944b465e822b9be9882672db7a2d9dca15528ae6be45945a0c2a3ec2ebd90a7ce7c48a6a10703ce183ffedb2c5b2e2f189ea79b7f3f07beb
-  data.tar.gz: 5c535e553548102f708b5c981e255af718bcdde9580cdda845a06ba7ae8f9cdd162139d2b0f7e4cc7873df53094677d0c21aac0f97848e5be69fc6b42cbc83d5
+  metadata.gz: c78924a1a8ad16e71c65989580e6b22b17e9fca132829fcd8d0b179284ba37c0aea827633acd1fb0ddfb30b29e8b1c904bf4e4398f3d814dce8ea2a1762775a3
+  data.tar.gz: a4526ac0f36242d8114a3d681453585dda82f9a0c5cb5420f3d2d7afe3b128a5ad277660c6fba0c75cd0dab85993b0af495a41c2ca5d783ed2c65da4e42d2ca7

data/.rubocop.yml

@@ -1 +1,4 @@
 inherit_from: default.yml
+
+Rails:
+  Enabled: false

data/.ruby-version

@@ -0,0 +1 @@
+3.3.0

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+# v2.1.0 2024-01-26
+## What's Changed
+- Add cops for Rails + NxtCore logger functionality
+
+# v2.0.2 2024-01-10
+## What's Changed
+* Disable more cops depending on the code style in our backend-services
+
+* **Full Changelog**: https://github.com/nxt-insurance/nxt_cop/compare/v2.0.1...v2.0.2
+
 # v2.0.1 2024-01-10
 ## What's Changed
 * Disable more cops depending on the code style in our backend-services

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    nxt_cop (2.0.1)
+    nxt_cop (2.1.0)
       rubocop (~> 1.60.0)
       rubocop-rails (~> 2.8)
       rubocop-rspec (~> 2.12)
@@ -21,7 +21,7 @@ GEM
       tzinfo (~> 2.0)
     ast (2.4.2)
     base64 (0.2.0)
-    bigdecimal (3.1.5)
+    bigdecimal (3.1.6)
     concurrent-ruby (1.2.3)
     connection_pool (2.4.1)
     drb (2.2.0)
@@ -30,10 +30,10 @@ GEM
       concurrent-ruby (~> 1.0)
     json (2.7.1)
     language_server-protocol (3.17.0.3)
-    minitest (5.21.1)
+    minitest (5.21.2)
     mutex_m (0.2.0)
     parallel (1.24.0)
-    parser (3.3.0.4)
+    parser (3.3.0.5)
       ast (~> 2.4.1)
       racc
     racc (1.7.3)
@@ -42,7 +42,7 @@ GEM
     rake (13.1.0)
     regexp_parser (2.9.0)
     rexml (3.2.6)
-    rubocop (1.60.0)
+    rubocop (1.60.2)
       json (~> 2.3)
       language_server-protocol (>= 3.17.0)
       parallel (~> 1.10)

data/custom_cops/nxt_core/rails/missing_logger_include.rb

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+module CustomCops
+  module NxtCore
+    module Rails
+      # The NxtCore logger requires an include in most cases. Ensures it is present.
+      #
+      # @safety
+      #   This cop's autocorrection is unsafe because
+      #   `logger` may refer to an instance variable or other method of the class.
+      class MissingLoggerInclude < RuboCop::Cop::Base
+        extend RuboCop::Cop::AutoCorrector
+
+        RESTRICT_ON_SEND = [:logger].freeze
+
+        MSG = 'Missing `include Nxt::Loggable` for a class which uses the logger.'
+
+        # NodePattern docs: https://github.com/rubocop/rubocop-ast/blob/master/docs/modules/ROOT/pages/node_pattern.adoc
+        def_node_matcher :includes_nxt_loggable?, <<~PATTERN
+          (begin <(send nil? :include (const (const nil? :Nxt) :Loggable)) ...>)
+        PATTERN
+
+        def on_send(node)
+          return unless node.receiver.nil?
+
+          class_node = node.ancestors.find(&:class_type?)
+          return unless class_node
+
+          class_definition_node = class_node.each_child_node(:begin).first
+          return if includes_nxt_loggable?(class_definition_node)
+
+          add_offense(class_node, message: MSG) do |corrector|
+            corrector.insert_before(class_definition_node.child_nodes.first, "include Nxt::Loggable\n")
+          end
+        end
+      end
+    end
+  end
+end

data/custom_cops/nxt_core/rails/use_of_rails_logger.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+module CustomCops
+  module NxtCore
+    module Rails
+      # Ensures that the NxtCore logger is used instead of `Rails.logger`.
+      class UseOfRailsLogger < RuboCop::Cop::Base
+        extend RuboCop::Cop::AutoCorrector
+
+        RESTRICT_ON_SEND = [:logger].freeze
+
+        MSG = 'Use of Rails.logger is not allowed. Use `logger` and include `Nxt::Loggable`'
+
+        def on_send(node)
+          return unless node.receiver&.const_type? && node.receiver.short_name == :Rails
+
+          add_offense(node, message: MSG) do |corrector|
+            corrected = node.source.gsub('Rails.logger', 'logger')
+            corrector.replace(node, corrected)
+          end
+        end
+      end
+    end
+  end
+end

data/default.yml

@@ -1,12 +1,20 @@
 require:
 - rubocop-rails
 - rubocop-rspec
+- ./custom_cops/nxt_core/rails/use_of_rails_logger.rb
+- ./custom_cops/nxt_core/rails/missing_logger_include.rb
 
 inherit_mode:
   merge:
     - Exclude
     - Include
 
+Rails/UseOfRailsLogger:
+  Description: "Custom Getsafe cop to ensure the correct logger is used"
+Rails/MissingLoggerInclude:
+  Description: "Custom Getsafe cop to find missing `include` statements when using our custom logger"
+  SafeAutoCorrect: false
+
 AllCops:
   Exclude:
     - bin/guard
@@ -429,6 +437,12 @@ Style/RedundantInterpolation:
   Enabled: false
 Style/ZeroLengthPredicate:
   Enabled: false
+Style/NegatedIf: # sometimes "if !var" just reads better
+  Enabled: false
+Style/NilComparison: # we don't have a good reason to enforce this
+  Enabled: false
+Style/GlobalStdStream: # autocorrection is unsafe because STDOUT and $stdout may point to different objects
+  Enabled: false
 Style/MultilineTernaryOperator:
   Enabled: false
 Style/RedundantReturn:

data/lib/nxt_cop/version.rb

@@ -1,3 +1,3 @@
 module NxtCop
-  VERSION = '2.0.1'.freeze
+  VERSION = '2.1.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: nxt_cop
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.1.0
 platform: ruby
 authors:
 - Scott Livingstone
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-01-17 00:00:00.000000000 Z
+date: 2024-01-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -88,6 +88,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rubocop.yml"
+- ".ruby-version"
 - CHANGELOG.md
 - Gemfile
 - Gemfile.lock
@@ -98,6 +99,8 @@ files:
 - bin/guard
 - bin/rspec
 - bin/setup
+- custom_cops/nxt_core/rails/missing_logger_include.rb
+- custom_cops/nxt_core/rails/use_of_rails_logger.rb
 - default.yml
 - lib/nxt_cop/version.rb
 - nxt_cop.gemspec
@@ -124,7 +127,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.10
+rubygems_version: 3.5.3
 signing_key:
 specification_version: 4
 summary: Getsafe shared Rubocop.