nutrella 1.3.1 → 1.5.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2321108c798fd3867e8eac2a4d5ef41059bfbe335a2b8e3ee94b93da00edaab0
-  data.tar.gz: 933966bc0eea7d83deae162b5841375ef795ec20d2abd191b16996d4a8e43d75
+  metadata.gz: 388bb6fc6a90e7819009bb33d2a05f8341949b135218618628b8caf6bdda0478
+  data.tar.gz: cb8b8713edc5aa263877b6a9924ad49d6b0725be174926a9119a2d9a168bb28e
 SHA512:
-  metadata.gz: 44d5c1cf2f24967fc7a4f522f71afb7a690536bdee609c8e22d2ff18367757d77c14e69055575d2f8bcf99372575ac4efd0d03ca2e66356c6eaf60df83b89373
-  data.tar.gz: 42f308da3f88a6de0f63d1a636d93c3c007b4d3049367e2fd315cd1bf4f6538d742ff57a8e202662da5450d50cb76aa58f162bf4744efb86d15173a0b37a6935
+  metadata.gz: 065c8d70378e4e202136a857cff0a0e816d6e17b56d8feaacd469d864273f404304b902310d258727b664ec4a25081dfbb4629a8c1e3aa26690c0b9f85879d84
+  data.tar.gz: db0d17e835fe9b3553cfd675018a9b569af6acfb312d2e1a9bd01e9585e8aff8e613d854b51be40d6cb0e4353ed40be9e1e70e219535fc1b28d2ec985f4c13bc

data/.gitignore

@@ -5,3 +5,4 @@
 /pkg
 /tmp
 /.bundle
+/*.log

data/.rubocop.yml

@@ -1,9 +1,10 @@
 require:
-  - rubocop-performance
+  - rubocop-rake
   - rubocop-rspec
 
 AllCops:
-  TargetRubyVersion: 2.4
+  NewCops: enable
+  TargetRubyVersion: 2.6
 
   Exclude:
     - 'bin/**/*'
@@ -15,6 +16,12 @@ Layout/MultilineMethodCallBraceLayout:
 Metrics/BlockLength:
   Enabled: false
 
+Naming/MemoizedInstanceVariableName:
+  EnforcedStyleForLeadingUnderscores: required
+
+Rake/Desc:
+  Enabled: false
+
 RSpec/AnyInstance:
   Enabled: false
 
@@ -45,6 +52,12 @@ RSpec/MultipleExpectations:
 RSpec/SubjectStub:
   Enabled: false
 
+Style/BlockDelimiters:
+  Enabled: true
+  EnforcedStyle: line_count_based
+  BracesRequiredMethods:
+    - 'let'
+
 # We can ignore this small performance improvement.
 Style/FrozenStringLiteralComment:
   Enabled: false

data/.ruby-version

@@ -1 +1 @@
-2.5.3
+2.6.6

data/CHANGELOG.md

@@ -6,13 +6,49 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.5.3] - 2021-02-18
+
+- Update ruby-trello
+- Update development dependencies
+
+#### Breaking Changes
+
+- Drop support for Ruby 2.5
+
+## [1.5.2] - 2020-04-27
+
+#### New Features
+
+- Added a configuration option to enable logging for easier troubleshooting
+
+## [1.5.1] - 2020-04-27
+
+#### Bug Fix
+
+- Honour the specified named Trello board argument over the Trello board derived from the current git branch
+
+## [1.5.0] - 2020-04-26
+
+#### New Features
+
+- Added a configuration option to support opening boards in the desktop Trello app
+
+## [1.4.0] - 2020-03-30
+
+#### Breaking Changes
+
+- Drop support for Ruby 2.4
+
 ## [1.3.1] - 2019-05-20
-### Added
+
+#### New Features
+
 - Added a configuration option to adjust the command that launches your Trello boards
 
 ## [1.3.0] - 2019-05-20
-### Yanked
+
+- Yanked
 
 ## [1.2.2] - 2019-04-27
-### Added
+
 - Added a changelog

data/README.md

@@ -29,7 +29,7 @@ A command line tool for associating a Trello board with the current git branch.
 **Step 3**: Get key and secret (best to do this from your home directory)
 
     $ cd ~
-    $ irb -rubygems
+    $ irb -r rubygems
     irb> require 'nutrella'
     irb> Nutrella.open_public_key_url
 
@@ -47,6 +47,7 @@ If your haven't already done so, insert your `key`, `secret`, and `token` into y
 
 The configuration file should look like the following (don't use the keys below, they won't work):
 
+```yaml
     # Trello Developer API Keys
     key: c2fc703429da08b6e7dcb0a878e35564
     secret: 7fd865f372891afa93aabdb6b836254bcda10c8a320def2b3207e2ffb425bc0a
@@ -55,50 +56,81 @@ The configuration file should look like the following (don't use the keys below,
     # Optional Configuration
     organization: 542d76ac2fad4697c3e80448
     launch_command: open $url$
+    enable_trello_app: false
+```
+
+**Step 6**: Adjust configuration file (Optional)
 
-Finally, you can adjust the launch_command to fit your needs. For example, on macOS to open your
-Trello board in Firefox change the last line to:
+Adjust the `launch_command` configuration to fit your needs.
+For example, to open your Trello board in Firefox change your configuration to:
 
+```yaml
     launch_command: open -a firefox $url$
+```
+
+Adjust the `enable_trello_app` configuration to open boards in the Trello app.
+To open your Trello board in the Trello app change your configuration to:
+
+```yaml
+    enable_trello_app: true
+```
+
+Adjust the `enable_logging` configuration to start logging diagnostics:
+
+```yaml
+    enable_logging: true
+```
 
 
 ## Usage
 
 Create or open a Trello board based on the name of the current git branch:
 
+```sh
     $ nutrella
+```
 
 Create or open a named Trello board:
 
+```sh
     $ nutrella <git-branch-name>
+```
 
 Note: you can invoke `nutrella` from your project directory or from any subdirectory.
 
+
 ## Troubleshooting
 
-#### `method_missing: undefined method 'this'`
+1. If an unexpected Trello board is opening try clearing your cache:
 
-Try updating `RubyGems`
+    ```sh
+    rm ~/.nutrella.cache.yml
+    ```
 
-```sh
-gem update --system
-```
+1. If you see `method_missing: undefined method 'this'`
 
-#### `uninitialized constant Gem::Source (NameError)`
+    Try updating `RubyGems`
 
-Try updating `bundler`
+    ```sh
+    gem update --system
+    ```
 
-```sh
-gem install bundler
-```
+1. If you see `uninitialized constant Gem::Source (NameError)`
 
-#### `cannot load such file -- nutrella`
+    Try updating `bundler`
 
-This error may appear after running `irb -rubygems` and you are unable to `require 'nutrella'`. Try running `irb -rubygems` from your home directory:
+    ```sh
+    gem install bundler
+    ```
 
-```sh
-cd ~
-```
+1. If you see `cannot load such file -- nutrella`
+
+    This error may appear after running `irb -rubygems` and you are unable to `require 'nutrella'`.
+    Try running `irb -rubygems` from your home directory:
+
+    ```sh
+    cd ~
+    ```
 
 
 ## Origin of Name

data/lib/nutrella/cache.rb

@@ -41,7 +41,7 @@ module Nutrella
     end
 
     def cache_contents
-      @cache_contents ||= YAML.load_file(path)
+      @_cache_contents ||= YAML.load_file(path)
     end
   end
 end

data/lib/nutrella/command.rb

@@ -14,23 +14,51 @@ module Nutrella
     end
 
     def run
-      open board_url # rubocop:disable Security/Open
+      launch(board_url)
+    ensure
+      logger.close
     end
 
     private
 
+    def launch(url)
+      launch_command = configuration_values.fetch(:launch_command).gsub("$url$", url)
+
+      logger.info { "Launch command: '#{launch_command}'" }
+
+      system(launch_command)
+    end
+
     def board_url
-      url_cache.fetch(@board_name) { task_board.lookup_or_create(@board_name).url }
+      url = enable_trello_app? ? trello_url(cached_url) : cached_url
+
+      logger.info { "Board URL: '#{url}'" }
+
+      url
+    end
+
+    def cached_url
+      @_cached_url ||= url_cache.fetch(@board_name) { task_board.lookup_or_create(@board_name).url }
     end
 
     def configuration_values
-      @configuration_values ||= Nutrella::Configuration.values(configuration_filename)
+      @_configuration_values ||= Nutrella::Configuration.values(configuration_filename)
     end
 
-    def open(url)
-      launch_command = configuration_values.fetch(:launch_command).gsub("$url$", url)
+    def enable_trello_app?
+      configuration_values.fetch(:enable_trello_app)
+    end
 
-      system(launch_command)
+    def logger
+      @_logger ||= Logger.new(log_filename)
+    end
+
+    def log_filename
+      configuration_values.fetch(:enable_logging) ? "nutrella.log" : "/dev/null"
+    end
+
+    def trello_url(http_url)
+      http_url.gsub(/^http.?:/, "trello:")
     end
 
     def task_board

data/lib/nutrella/configuration.rb

@@ -9,7 +9,7 @@ module Nutrella
   class Configuration
     NULOGY_ORGANIZATION_ID = "542d76ac2fad4697c3e80448"
 
-    INITIAL_CONFIGURATION = <<-YAML.strip_heredoc
+    INITIAL_CONFIGURATION = <<~YAML
       # Trello Developer API Keys
       key: <your developer key>
       secret: <your developer secret>
@@ -18,6 +18,8 @@ module Nutrella
       # Optional Configuration
       organization: #{NULOGY_ORGANIZATION_ID}
       launch_command: open $url$
+      enable_trello_app: false
+      enable_logging: false
     YAML
 
     attr_reader :path, :values
@@ -34,20 +36,24 @@ module Nutrella
 
     private
 
-    def load_configuration
-      configuration = YAML.load_file(path)
-
+    def load_configuration # rubocop:disable Metrics/MethodLength
       @values = {
         key: configuration.fetch("key"),
         secret: configuration.fetch("secret"),
         token: configuration.fetch("token"),
         organization: configuration.fetch("organization", NULOGY_ORGANIZATION_ID),
-        launch_command: configuration.fetch("launch_command", "open $url$")
+        launch_command: configuration.fetch("launch_command", "open $url$"),
+        enable_trello_app: configuration.fetch("enable_trello_app", "false"),
+        enable_logging: configuration.fetch("enable_logging", "false")
       }
     rescue => e
       abort "#{path} #{e}"
     end
 
+    def configuration
+      @_configuration ||= YAML.load_file(path)
+    end
+
     def configuration_missing?
       return false if File.exist?(path)
 
@@ -60,7 +66,7 @@ module Nutrella
     end
 
     def configuration_missing_message
-      <<-TEXT.strip_heredoc
+      <<~TEXT
         I see that you don't have a config file '#{path}'.
         So, I created one for you.
 

data/lib/nutrella/string_ext.rb

@@ -1,13 +1,9 @@
 # frozen_string_literal: true
 
-# Simpler versions of extensions from ActiveSupport.
+# Simpler versions of an extension from ActiveSupport.
 #
 class String
-  def strip_heredoc
-    gsub(/^ +/, "")
-  end
-
   def titleize
-    tr("_-", " ").split(" ").map(&:capitalize).join(" ")
+    tr("_-", " ").split.map(&:capitalize).join(" ")
   end
 end

data/lib/nutrella/task_board_name.rb

@@ -10,12 +10,12 @@ module Nutrella
   #
   class TaskBoardName
     def self.board_name(args)
-      git_branch_name, status = Open3.capture2("git rev-parse --abbrev-ref HEAD")
-      return git_branch_name.chomp if status.success?
-
       git_branch_name = args[0]
       return git_branch_name if git_branch_name.present?
 
+      git_branch_name, status = Open3.capture2("git rev-parse --abbrev-ref HEAD")
+      return git_branch_name.chomp if status.success?
+
       abort "Sorry. Can't figure out a name for the board."
     end
   end

data/lib/nutrella/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Nutrella
-  VERSION = "1.3.1"
+  VERSION = "1.5.3"
 end

data/nutrella.gemspec

@@ -24,14 +24,14 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.required_ruby_version = ">= 2.4"
+  spec.required_ruby_version = ">= 2.6"
 
-  spec.add_runtime_dependency "ruby-trello", "~> 2.1"
+  spec.add_runtime_dependency "ruby-trello", "~> 3.0"
 
-  spec.add_development_dependency "rake", "~> 12.1"
-  spec.add_development_dependency "rspec", "~> 3.8"
-  spec.add_development_dependency "rubocop", "~> 0.69"
-  spec.add_development_dependency "rubocop-performance", "~> 1.3"
-  spec.add_development_dependency "rubocop-rspec", "~> 1.33"
-  spec.add_development_dependency "simplecov", "~> 0.16"
+  spec.add_development_dependency "rake", "~> 13.0"
+  spec.add_development_dependency "rspec", "~> 3.10"
+  spec.add_development_dependency "rubocop", "~> 1.10"
+  spec.add_development_dependency "rubocop-rake", "~> 0.5"
+  spec.add_development_dependency "rubocop-rspec", "~> 2.2"
+  spec.add_development_dependency "simplecov", "~> 0.21"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: nutrella
 version: !ruby/object:Gem::Version
-  version: 1.3.1
+  version: 1.5.3
 platform: ruby
 authors:
 - Alistair McKinnell
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-05-20 00:00:00.000000000 Z
+date: 2021-02-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ruby-trello
@@ -16,98 +16,98 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.1'
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.1'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.1'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.1'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.8'
+        version: '3.10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.8'
+        version: '3.10'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.69'
+        version: '1.10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.69'
+        version: '1.10'
 - !ruby/object:Gem::Dependency
-  name: rubocop-performance
+  name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '0.5'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.33'
+        version: '2.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.33'
+        version: '2.2'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.16'
+        version: '0.21'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.16'
+        version: '0.21'
 description: 
 email:
 - alistair.mckinnell@gmail.com
@@ -163,14 +163,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.4'
+      version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.2.11
 signing_key: 
 specification_version: 4
 summary: A command line tool for creating a Trello Board based on the current git