numbers_in_words 0.2.0 → 0.5.1

data/spec/numerical_strings_spec.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+require './spec/spec_helper'
+
+describe NumbersInWords do
+  it 'recognizes numerical strings' do
+    arr = %w[8 56 100 5789 3435356]
+    arr.each { |s| expect(s.in_numbers).to eql(s.to_f) }
+  end
+
+  MIXED = {
+    '19 hundred' => 1_900,
+    '20 thousand' => 20_000,
+    '100 million' => 100_000_000,
+    '7 billion' => 7_000_000_000,
+    '42 trillion' => 42_000_000_000_000,
+    '20 thousand and 4' => 20_004
+  }.freeze
+
+  MIXED.each do |k, v|
+    it do
+      expect(k.in_numbers).to eql(v)
+    end
+  end
+
+  PENDING_MIXED = {
+    '19 zero five' => 1_905
+  }.freeze
+
+  PENDING_MIXED.each do |k, v|
+    pending do
+      expect(k.in_numbers).to eql(v)
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,2 +1,26 @@
+# frozen_string_literal: true
+
+if ENV['CC_TEST_REPORTER_ID']
+  require 'simplecov'
+  SimpleCov.start
+end
+
+unless Kernel.method_defined?(:silence_warnings)
+  module Kernel
+    def silence_warnings
+      with_warnings(nil) { yield }
+    end
+
+    def with_warnings(flag)
+      old_verbose = $VERBOSE
+      $VERBOSE = flag
+      yield
+    ensure
+      $VERBOSE = old_verbose
+    end
+  end
+end
+
 require 'numbers_in_words'
 require 'numbers_in_words/duck_punch'
+require 'byebug'

data/spec/to_word_spec.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+RSpec.describe NumbersInWords::ToWord do
+  let(:number) { 2_111 }
+  let(:writer) { described_class.new(number) }
+
+  describe '#in_words' do
+    let(:number) { 99 }
+
+    subject do
+      writer.in_words
+    end
+
+    it do
+      expect(subject).to eq 'ninety-nine'
+    end
+  end
+end

data/spec/words_in_numbers_spec.rb

@@ -1,134 +1,152 @@
+# frozen_string_literal: true
+
 require './spec/spec_helper'
 
-describe WordsInNumbers do
-  it "should do the digits 0-10" do
-    "zero"  .in_numbers.should == 0
-    "one"   .in_numbers.should == 1
-    "two"   .in_numbers.should == 2
-    "three" .in_numbers.should == 3
-    "four"  .in_numbers.should == 4
-    "five"  .in_numbers.should == 5
-    "six"   .in_numbers.should == 6
-    "seven" .in_numbers.should == 7
-    "eight" .in_numbers.should == 8
-    "nine"  .in_numbers.should == 9
+describe NumbersInWords::StringExtension do # rubocop: disable Metrics/BlockLength
+  it 'should do the digits 0-10' do
+    expect('zero'.in_numbers).to eq(0)
+    expect('one'.in_numbers).to eq(1)
+    expect('two'.in_numbers).to eq(2)
+    expect('three'.in_numbers).to eq(3)
+    expect('four'.in_numbers).to eq(4)
+    expect('five'.in_numbers).to eq(5)
+    expect('six'.in_numbers).to eq(6)
+    expect('seven'.in_numbers).to eq(7)
+    expect('eight'.in_numbers).to eq(8)
+    expect('nine'.in_numbers).to eq(9)
+  end
+
+  it 'should handle numbers for which there is one word' do
+    expect('ten'.in_numbers).to eq(10)
+    expect('eleven'.in_numbers).to eq(11)
+    expect('twelve'.in_numbers).to eq(12)
+    expect('thirteen'.in_numbers).to eq(13)
+    expect('fourteen'.in_numbers).to eq(14)
+    expect('fifteen'.in_numbers).to eq(15)
+    expect('sixteen'.in_numbers).to eq(16)
+    expect('seventeen'.in_numbers).to eq(17)
+    expect('eighteen'.in_numbers).to eq(18)
+    expect('nineteen'.in_numbers).to eq(19)
+    expect('twenty'.in_numbers).to eq(20)
+  end
+
+  it 'should handle two word numbers up to 100' do
+    expect('twenty-one'.in_numbers).to eq(21)
+    expect('twenty-two'.in_numbers).to eq(22)
+    expect('twenty-three'.in_numbers).to eq(23)
+    expect('twenty-four'.in_numbers).to eq(24)
+    expect('twenty-five'.in_numbers).to eq(25)
+    expect('twenty-six'.in_numbers).to eq(26)
+    expect('twenty-seven'.in_numbers).to eq(27)
+    expect('twenty-eight'.in_numbers).to eq(28)
+    expect('seventy-six'.in_numbers).to eq(76)
+    expect('ninety-nine'.in_numbers).to eq(99)
   end
 
-  it "should handle numbers for which there is one word" do
-    "ten"       .in_numbers.should == 10
-    "eleven"    .in_numbers.should == 11
-    "twelve"    .in_numbers.should == 12
-    "thirteen"  .in_numbers.should == 13
-    "fourteen"  .in_numbers.should == 14
-    "fifteen"   .in_numbers.should == 15
-    "sixteen"   .in_numbers.should == 16
-    "seventeen" .in_numbers.should == 17
-    "eighteen"  .in_numbers.should == 18
-    "nineteen"  .in_numbers.should == 19
-    "twenty"    .in_numbers.should == 20
+  it 'should handle hundreds' do
+    expect('one hundred'.in_numbers).to eq(100)
+    expect('two hundred'.in_numbers).to eq(200)
+    expect('three hundred'.in_numbers).to eq(300)
+    expect('nine hundred'.in_numbers).to eq(900)
+    expect('one hundred and seventy six'.in_numbers).to eq(176)
+    expect('one hundred and seventy nine'.in_numbers).to eq(179)
+    expect('nine hundred and ninety nine'.in_numbers).to eq(999)
   end
 
-  it "should handle two word numbers up to 100" do
-    "twenty one"   .in_numbers.should == 21
-    "twenty two"   .in_numbers.should == 22
-    "twenty three" .in_numbers.should == 23
-    "twenty four"  .in_numbers.should == 24
-    "twenty five"  .in_numbers.should == 25
-    "twenty six"   .in_numbers.should == 26
-    "twenty seven" .in_numbers.should == 27
-    "twenty eight" .in_numbers.should == 28
-    "seventy six"  .in_numbers.should == 76
-    "ninety nine"  .in_numbers.should == 99
+  it 'should handle unusual hundreds' do
+    expect('eleven hundred'.in_numbers).to eq(1100)
+    expect('twelve hundred'.in_numbers).to eq(1200)
+    expect('thirteen hundred'.in_numbers).to eq(1300)
+    expect('fifteen hundred'.in_numbers).to eq(1500)
+    expect('nineteen hundred'.in_numbers).to eq(1900)
+  end
+  it 'should handle thousands' do
+    expect('two thousand and one'.in_numbers).to eq(2001)
+    expect('one thousand'.in_numbers).to eq(1000)
+    expect('two thousand'.in_numbers).to eq(2000)
+    expect('three thousand'.in_numbers).to eq(3000)
+    expect('nine thousand'.in_numbers).to eq(9000)
+    expect('nine thousand two hundred'.in_numbers).to eq(9200)
+    expect('nine thousand two hundred and seven'.in_numbers).to eq(9207)
+    expect('nine thousand two hundred and ninety seven'.in_numbers).to eq(9297)
   end
 
-  it "should handle hundreds" do
-    "one hundred"                  .in_numbers.should == 100
-    "two hundred"                  .in_numbers.should == 200
-    "three hundred"                .in_numbers.should == 300
-    "nine hundred"                 .in_numbers.should == 900
-    "one hundred and seventy six"  .in_numbers.should == 176
-    "one hundred and seventy nine" .in_numbers.should == 179
-    "nine hundred and ninety nine" .in_numbers.should == 999
+  it 'handles numbers that begin with a instead of one', :aggregate_failures do
+    expect('a thousand six hundred'.in_numbers).to eq(1600)
+    expect('a thousand six hundred and fifty-five'.in_numbers).to eq(1655)
   end
 
-  it "should handle unusual hundreds" do
-    "eleven hundred"   .in_numbers.should == 1100
-    "twelve hundred"   .in_numbers.should == 1200
-    "thirteen hundred" .in_numbers.should == 1300
-    "fifteen hundred"  .in_numbers.should == 1500
-    "nineteen hundred" .in_numbers.should == 1900
+  it 'should handle larger numbers' do
+    expect('one million'.in_numbers).to eq(1_000_000)
+    expect('two googol five billion and seventy six'.in_numbers).to eq(2 * 10**100 + 5 * 10**9 + 76)
+    expect('thirty seven million'.in_numbers).to eq(37 * 10**6)
+    expect('twenty six googol'.in_numbers).to eq(26 * 10**100)
+  end
 
+  it 'should handle numbers in hundreds of thousands etc' do
+    expect('nine hundred thousand'.in_numbers).to eq(900_000)
+    expect('three hundred and fifty seven thousand'.in_numbers).to eq(357_000)
+    expect('five million three hundred and fifty seven thousand'.in_numbers).to eq(5_357_000)
+    expect('nine hundred and ninety nine trillion'.in_numbers).to eq(999 * 10**12)
+  end
+  it 'should handle negative numbers' do
+    expect('minus one'.in_numbers).to eq(-1)
+    expect('minus two googol'.in_numbers).to eq(-2 * 10**100)
+    expect('minus nine hundred and ninety nine trillion'.in_numbers).to eq(-999 * 10**12)
   end
-  it "should handle thousands" do
-    "two thousand and one"                       .in_numbers .should ==  2001
-    "one thousand"                               .in_numbers .should ==  1000
-    "two thousand"                               .in_numbers .should ==  2000
-    "three thousand"                             .in_numbers .should ==  3000
-    "nine thousand"                              .in_numbers .should ==  9000
-    "nine thousand two hundred"                  .in_numbers .should ==  9200
-    "nine thousand two hundred and seven"        .in_numbers .should ==  9207
-    "nine thousand two hundred and ninety seven" .in_numbers .should ==  9297
-    end
-
-    it "should handle larger numbers" do
-    "one million"                                .in_numbers .should ==  1000000
-    "two googol five billion and seventy six"    .in_numbers .should ==  (2*10**100 + 5*10**9 + 76)
-    "thirty seven million"                       .in_numbers .should == 37 * 10**6
-    "twenty six googol"                          .in_numbers .should == 26 * 10**100
-    end
-
-  it "should handle numbers in hundreds of thousands etc" do
-    "nine hundred thousand"                                            .in_numbers .should == 900000
-    "three hundred and fifty seven thousand"                           .in_numbers .should == 357000
-    "five million three hundred and fifty seven thousand"              .in_numbers .should == 5357000
-    "nine hundred and ninety nine trillion"                            .in_numbers .should == 999 * 10**12
-    end
-    it "should handle negative numbers" do
-    "minus one"                                                        .in_numbers .should == -1
-    "minus two googol"                                                 .in_numbers .should == -2 * 10**100
-    "minus nine hundred and ninety nine trillion"                      .in_numbers .should == -999 * 10**12
-    end
-
-    it "should ignore punctuation and capitalisation" do
-    "Minus one"                                                        .in_numbers .should == -1
-    "FIVE Million, three hundred and fifty-seVen Thousand"             .in_numbers .should == 5357000
-    "FIVE,,./';';';[] Million, three hundred and fifty-seVen Thousand" .in_numbers .should == 5357000
-
-    end
-
-  it "should handle decimal points" do
-    "one point one"                        .in_numbers .should == 1.1
-
-    "zero point seven six five three four" .in_numbers .should == 0.76534
-    "one trillion point six"               .in_numbers .should == 10**12 + 0.6
-
-    long_number = <<-NUMBER
-    nine duotrigintillion seven hundred and seventy seven untrigintillion
-    fifty nine trigintillion one hundred and sixty novemvigintillion
-    eight hundred and six octovigintillion seven hundred and thirty six
-    septenvigintillion four hundred and seventy one sexvigintillion
-    nine hundred and seventy quinvigintillion six hundred and thirty two
-    quattuorvigintillion eight hundred and twenty seven trevigintillion
-    eight hundred and thirty six duovigintillion nine hundred and fifty
-    two unvigintillion seven hundred and ten vigintillion eight hundred and one
-    novemdecillion nine hundred and forty eight octodecillion seven hundred
-    and five septendecillion six hundred and eighty three sexdecillion
-    one hundred and six quindecillion seven hundred and seven quattuordecillion
-    seven hundred and fifty seven tredecillion four hundred and twenty six
-    duodecillion seven hundred and ninety five undecillion seven hundred
-    and forty six decillion eight hundred and thirteen nonillion one hundred
-    and twenty seven octillion four hundred and sixty five septillion two
-    hundred and thirty seven sextillion one hundred and thirty nine
-    quintillion one hundred and fifty three quadrillion forty six
-    trillion seven hundred and fifty two billion eight hundred and three
-    million ninety three thousand seven hundred and ninety one point
-    eight nine five six four three two one eight nine five six seven eight
+
+  it 'should ignore punctuation and capitalisation' do
+    expect('Minus one'.in_numbers).to eq(-1)
+    expect('FIVE Million, three hundred and fifty-seVen Thousand'.in_numbers).to eq(5_357_000)
+    expect("FIVE,,./';';';[] Million, three hundred and fifty-seVen Thousand".in_numbers).to eq(5_357_000)
+  end
+
+  it 'should handle decimal points' do # rubocop: disable Metrics/BlockLength
+    expect('one point one'.in_numbers).to eq(1.1)
+
+    expect('zero point seven six five three four'.in_numbers).to eq(0.76534)
+    expect('one trillion point six'.in_numbers).to eq(10**12 + 0.6)
+
+    long_number = <<~NUMBER
+      nine duotrigintillion seven hundred and seventy seven untrigintillion
+      fifty nine trigintillion one hundred and sixty novemvigintillion
+      eight hundred and six octovigintillion seven hundred and thirty six
+      septenvigintillion four hundred and seventy one sexvigintillion
+      nine hundred and seventy quinvigintillion six hundred and thirty two
+      quattuorvigintillion eight hundred and twenty seven trevigintillion
+      eight hundred and thirty six duovigintillion nine hundred and fifty
+      two unvigintillion seven hundred and ten vigintillion eight hundred and one
+      novemdecillion nine hundred and forty eight octodecillion seven hundred
+      and five septendecillion six hundred and eighty three sexdecillion
+      one hundred and six quindecillion seven hundred and seven quattuordecillion
+      seven hundred and fifty seven tredecillion four hundred and twenty six
+      duodecillion seven hundred and ninety five undecillion seven hundred
+      and forty six decillion eight hundred and thirteen nonillion one hundred
+      and twenty seven octillion four hundred and sixty five septillion two
+      hundred and thirty seven sextillion one hundred and thirty nine
+      quintillion one hundred and fifty three quadrillion forty six
+      trillion seven hundred and fifty two billion eight hundred and three
+      million ninety three thousand seven hundred and ninety one point
+      eight nine five six four three two one eight nine five six seven eight
     NUMBER
-    long_number.in_numbers.should ==
-      9777059160806736471970632827836952710801948705683106707757426795746813127465237139153046752803093791.89564321895678
 
-    "seventy five point eight four three two seven six nine four five one eight".
-      in_numbers.should == 75.84327694518
+    # rubocop: disable Metrics/LineLength
+    expect(long_number.in_numbers).to eq(
+      9_777_059_160_806_736_471_970_632_827_836_952_710_801_948_705_683_106_707_757_426_795_746_813_127_465_237_139_153_046_752_803_093_791.89564321895678
+    )
+    # rubocop: enable Metrics/LineLength
+
+    expect('seventy five point eight four three two seven six nine four five one eight'
+           .in_numbers).to eq(75.84327694518)
   end
 
+  it 'should handle years notation' do
+    expect('fifteen sixteen'.in_numbers).to eq(1516)
+    expect('eighty five sixteen'.in_numbers).to eq(8516)
+    expect('nineteen ninety six'.in_numbers).to eq(1996)
+    expect('forty nine ninety eight forty seven seventy nine'.in_numbers).to eq(49_984_779)
+    expect('fifteen sixteen'.in_numbers).to eq(1516)
+    expect('fifteen sixteen seven'.in_numbers).to eq(15_167)
+    expect('fifteen sixteen seventeen'.in_numbers).to eq(151_617)
+  end
 end

data/spec/writer_spec.rb

@@ -0,0 +1,26 @@
+# frozen_string_literal: true
+
+RSpec.describe NumbersInWords::Writer do
+  let(:number) { 2_111 }
+  let(:writer) { described_class.new(number) }
+
+  it 'should display numbers grouped' do
+    count = 0
+
+    writer.group_words(3) do |power, name, digits|
+      case count
+      when 0
+        expect(power).to eq(3)
+        expect(name).to eq('thousand')
+        expect(digits).to eq(2)
+      when 1
+        expect(power).to eq(0)
+        expect(name).to eq('one')
+        expect(digits).to eq(111)
+      end
+      count += 1
+    end
+
+    expect(count).to eq 2
+  end
+end

data/spec/years_spec.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+require './spec/spec_helper'
+
+describe NumbersInWords::NumericExtension do
+  YEARS = {
+    'thirteen hundred' => 13_00,
+    'twenty-two hundred' => 22_00,
+    'twenty-two hundred and five' => 22_05,
+    'fifteen sixteen seventeen' => 151_617,
+    'forty-nine ninety-eight forty-seven seventy-nine' => 49_984_779,
+    'one fifty' => 150,
+    'two fifty' => 250,
+    'three fifty' => 350,
+    'one point fifty-six fifty-seven' => 1.5657,
+    'one three forty-seven' => 1347,
+    'one three five-point forty-seven' => 135.47,
+    'one ten sixty-three' => 11_063,
+    'one nineteen ten oh five' => 1_191_005
+  }.freeze
+
+  YEARS.each do |k, v|
+    it do
+      expect(k.in_numbers).to eql(v)
+    end
+  end
+end

metadata

@@ -1,127 +1,129 @@
 --- !ruby/object:Gem::Specification
 name: numbers_in_words
 version: !ruby/object:Gem::Version
-  prerelease: 
-  version: 0.2.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Mark Burns
+- Dimid Duchovny
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-01-17 00:00:00.000000000 Z
+date: 2020-08-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  type: :runtime
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  name: activesupport
-  prerelease: false
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
+        version: 3.4.0
   type: :development
+  prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
-  name: rspec
-  prerelease: false
+        version: 3.4.0
+- !ruby/object:Gem::Dependency
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
   type: :development
-  version_requirements: !ruby/object:Gem::Requirement
-    none: false
-    requirements:
-    - - ! '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  name: debugger
   prerelease: false
-  requirement: !ruby/object:Gem::Requirement
-    none: false
+  version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: ! '#in_words method for integers and #in_numbers for strings'
+description: convert written numbers into Integers and vice-versa
 email:
 - markthedeveloper@gmail.com
-executables: []
+- dimidd@gmail.com
+executables:
+- spec
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".codeclimate.yml"
+- ".gitignore"
+- ".rspec"
+- ".rubocop.yml"
+- ".travis.yml"
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt
 - README.md
 - Rakefile
+- bin/spec
 - lib/numbers_in_words.rb
 - lib/numbers_in_words/duck_punch.rb
-- lib/numbers_in_words/english/constants.rb
-- lib/numbers_in_words/english/language_writer_english.rb
-- lib/numbers_in_words/language_writer.rb
+- lib/numbers_in_words/exceptional_numbers.rb
+- lib/numbers_in_words/fraction.rb
 - lib/numbers_in_words/number_group.rb
-- lib/numbers_in_words/number_parser.rb
-- lib/numbers_in_words/to_number.rb
+- lib/numbers_in_words/parsing/fraction_parsing.rb
+- lib/numbers_in_words/parsing/number_parser.rb
+- lib/numbers_in_words/parsing/pair_parsing.rb
+- lib/numbers_in_words/parsing/parse_fractions.rb
+- lib/numbers_in_words/parsing/parse_individual_number.rb
+- lib/numbers_in_words/parsing/parse_status.rb
+- lib/numbers_in_words/parsing/special.rb
+- lib/numbers_in_words/parsing/to_number.rb
+- lib/numbers_in_words/powers_of_ten.rb
 - lib/numbers_in_words/to_word.rb
 - lib/numbers_in_words/version.rb
+- lib/numbers_in_words/writer.rb
 - numbers_in_words.gemspec
-- spec/language_writer_spec.rb
+- spec/exceptional_numbers_spec.rb
+- spec/fraction_spec.rb
+- spec/fractions_spec.rb
+- spec/non_monkey_patch_spec.rb
 - spec/number_group_spec.rb
+- spec/number_parser_spec.rb
 - spec/numbers_in_words_spec.rb
+- spec/numerical_strings_spec.rb
 - spec/spec_helper.rb
+- spec/to_word_spec.rb
 - spec/words_in_numbers_spec.rb
+- spec/writer_spec.rb
+- spec/years_spec.rb
 homepage: http://github.com/markburns/numbers_in_words
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
-      segments:
-      - 0
-      hash: -1513551754306869579
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
-      segments:
-      - 0
-      hash: -1513551754306869579
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 3.0.3
 signing_key: 
-specification_version: 3
-summary: ! 'Example: 123.in_words # => "one hundred and twenty three", "seventy-five
-  point eight".in_numbers # = > 75.8'
+specification_version: 4
+summary: 'Example: NumbersInWords.in_words(123) # => "one hundred and twenty three",
+  NumbersInWords.in_numbers("seventy-five point eight") # = > 75.8'
 test_files:
-- spec/language_writer_spec.rb
+- spec/exceptional_numbers_spec.rb
+- spec/fraction_spec.rb
+- spec/fractions_spec.rb
+- spec/non_monkey_patch_spec.rb
 - spec/number_group_spec.rb
+- spec/number_parser_spec.rb
 - spec/numbers_in_words_spec.rb
+- spec/numerical_strings_spec.rb
 - spec/spec_helper.rb
+- spec/to_word_spec.rb
 - spec/words_in_numbers_spec.rb
+- spec/writer_spec.rb
+- spec/years_spec.rb