nulogy_sso 2.1.1 → 2.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f8ec688ae7f8588c5b11398daa287a0923843eb934cdb420ba79492d42784dd5
-  data.tar.gz: 6f25f0a9d8c049713c2e6fddb85fde3c4682f4d00ffdbc70925345f0ecdb7bef
+  metadata.gz: ca97de81b4866da1365262d4a579dd6d20728f7ffdeabadc20fa4102f13d5376
+  data.tar.gz: 95955ce74b932dc92485a6aa0fe2fa97f6b72db9b6059f18696b03a556ee70ed
 SHA512:
-  metadata.gz: 13c8c7a3a9a4d7320df033fc11e88c0e82be6fe1bb8f45e25dbf2d8b7151987786375c524da08a7b1bc2aed01b9847335c370b9a369e2d8f505a7a0b044dba5c
-  data.tar.gz: 32b427f0dcd83078a4f1d07a339b90858afee2ece0853e0c1ba033c567688af560e29f06c40b37bf225b284f21a0ca84e8056b9323114e37bc836a01f3c8fa67
+  metadata.gz: 5e995c890341267f0d7e8948043085d8a8b2f2de1933865f4da5641dfa0cfc6f2959b9a925c0be27fa64acc0de6998e0c3f453f98672091a8d118c43bedfcaf1
+  data.tar.gz: b753276ec79bf51315d353516d4a7e308161d34a934f446cbc0676b1e4e15cd91722ca49c269f3a703495d79e5bb1604b228ac2d9496fc0123555f7c6d65bdcc

data/README.md

@@ -65,7 +65,7 @@ With that available, you can configure the engine with an initializer file. This
 NulogySSO.sso_config = Rails::Application.config_for(:sso)
 
 # Return the user matching the provided email, or nil if not found.
-NulogySSO.find_user_by_email = ->(email) { nil } 
+NulogySSO.find_user_by_email = ->(email) { nil }
 
 # Handle errors from the SSO authentication flow, according to the app's design.
 # This includes internal errors from the Auth0 gem (ie, token signature mismatch) and no user from the app DB matching the email from the JWT.
@@ -74,8 +74,8 @@ NulogySSO.handle_sso_error = ->(controller: , error:) { }
 
 # Handle how unauthenticated requests should be responded to. The default is to redirect to the defined login page.
 # For API based applications this should be overriden to provide a meaningful error as per your API's contract (i.e. an HTTP 401 error code)
-# Additionally, this could be overriden if an application should bypass SSO when running tests. 
-NulogySSO.handle_unauthenticated_request = ->(controller) { controller.redirect_to sso_engine.login_path } 
+# Additionally, this could be overriden if an application should bypass SSO when running tests.
+NulogySSO.handle_unauthenticated_request = ->(controller) { controller.redirect_to sso_engine.login_path }
 ```
 
 The app is now ready to authenticate a user with Auth0! With NulogySSO and Auth0, the user's identity is maintained across requests (and apps!) via a [JWT](https://auth0.com/docs/jwt) stored as a browser cookie. Add this code to the `ApplicationController`:
@@ -109,20 +109,14 @@ docker-compose up -d
 
 ### Testing
 
+Tests must be run manually before submitting a PR. This can be done using `rspec spec`.
+
 There are multiple helpers made available via the `NulogySSO::TestUtilities` module. These are helpful for doing things such as grabbing test JWT values and interacting with a [Mockserver](https://github.com/jamesdbloom/mockserver) mock of the Auth0 API.
 
-It is a common use case for a Rails app to switch from Devise-powered authentication to Auth0. Here's a pattern that could be applied around a feature flag (e.g. environment variable) to switch between Devise user authentication test helpers and NulogySSO test helpers: _(TODO: insert link to CPI `ControllerIntegrationSpecMacros`)_
+It is a common use case for a Rails app to switch from Devise-powered authentication to Auth0. This would also require updates to test helper code, similar to [functionality that Devise provides out of the box](https://github.com/heartcombo/devise/wiki/How-To:-Test-controllers-with-Rails-(and-RSpec)). [See this example](https://github.com/nulogy/Common-Platform-Interface/blob/f9444ded80d6012b9659942481fa2e6b880b54ee/spec/support/controller_integration_spec_macros.rb) of how a test helper could be written for an app using a feature flag (e.g. environment variable) to switch between Devise and NulogySSO authentication.
 
 ### Contributing
 
 Feel free to create a PR if you wish to add new functionality to this Engine or detect a bug. A developer on CN1 will review and merge.
 
 This project follows [Semver Versioning](https://semver.org/). Please add an entry into [CHANGELOG.md](./CHANGELOG.md) in your PR. Deployments are done manually on an as-needed basis.
-
-## Roadmap
-
-* Parameterize app name for error page
-* Buildkite pipeline
-* Rubocop
-* Rake install task (ie, generate required files automatically, instead of requiring a heavy amount of manual work to integrate nulogy_sso into a Rails app)
-* Add additional hooks, as necessitated by unique use cases for new apps using this engine

data/app/controllers/nulogy_sso/authentication_controller.rb

@@ -88,7 +88,7 @@ module NulogySSO
         client_id: sso_config.client_id,
         response_type: "code",
         scope: "openid email",
-        redirect_uri: "#{sso_config.login_uri}?origin=#{session[:previous_request_url]}"
+        redirect_uri: "#{sso_config.login_uri}?origin=#{CGI::escape(session[:previous_request_url])}"
       }
 
       "#{sso_config.base_uri}/authorize?#{query_params.to_query}"

data/lib/nulogy_sso/version.rb

@@ -1,3 +1,3 @@
 module NulogySSO
-  VERSION = "2.1.1"
+  VERSION = "2.1.2"
 end

data/spec/dummy/log/development.log

@@ -1,21 +0,0 @@
-   (1.5ms)  SELECT sqlite_version(*)
-   (0.1ms)  SELECT sqlite_version(*)
-   (0.1ms)  SELECT sqlite_version(*)
-   (0.2ms)  DROP TABLE IF EXISTS "users"
-   (1.4ms)  CREATE TABLE "users" ("id" integer PRIMARY KEY AUTOINCREMENT NOT NULL, "email" varchar, "active" boolean DEFAULT 0 NOT NULL, "created_at" datetime NOT NULL, "updated_at" datetime NOT NULL)
-   (1.2ms)  CREATE TABLE "schema_migrations" ("version" varchar NOT NULL PRIMARY KEY)
-   (0.1ms)  SELECT "schema_migrations"."version" FROM "schema_migrations" ORDER BY "schema_migrations"."version" ASC
-   (1.3ms)  INSERT INTO "schema_migrations" (version) VALUES (20190912211120)
-   (1.3ms)  CREATE TABLE "ar_internal_metadata" ("key" varchar NOT NULL PRIMARY KEY, "value" varchar, "created_at" datetime(6) NOT NULL, "updated_at" datetime(6) NOT NULL)
-  ActiveRecord::InternalMetadata Load (0.1ms)  SELECT "ar_internal_metadata".* FROM "ar_internal_metadata" WHERE "ar_internal_metadata"."key" = ? LIMIT ?  [["key", "environment"], ["LIMIT", 1]]
-   (0.0ms)  begin transaction
-  ActiveRecord::InternalMetadata Create (0.2ms)  INSERT INTO "ar_internal_metadata" ("key", "value", "created_at", "updated_at") VALUES (?, ?, ?, ?)  [["key", "environment"], ["value", "development"], ["created_at", "2019-12-30 21:43:55.035685"], ["updated_at", "2019-12-30 21:43:55.035685"]]
-   (1.1ms)  commit transaction
-  ActiveRecord::InternalMetadata Load (0.1ms)  SELECT "ar_internal_metadata".* FROM "ar_internal_metadata" WHERE "ar_internal_metadata"."key" = ? LIMIT ?  [["key", "environment"], ["LIMIT", 1]]
-   (0.0ms)  begin transaction
-  ActiveRecord::InternalMetadata Update (0.2ms)  UPDATE "ar_internal_metadata" SET "value" = ?, "updated_at" = ? WHERE "ar_internal_metadata"."key" = ?  [["value", "test"], ["updated_at", "2019-12-30 21:43:55.040182"], ["key", "environment"]]
-   (0.7ms)  commit transaction
-  ActiveRecord::InternalMetadata Load (0.1ms)  SELECT "ar_internal_metadata".* FROM "ar_internal_metadata" WHERE "ar_internal_metadata"."key" = ? LIMIT ?  [["key", "schema_sha1"], ["LIMIT", 1]]
-   (0.0ms)  begin transaction
-  ActiveRecord::InternalMetadata Create (0.2ms)  INSERT INTO "ar_internal_metadata" ("key", "value", "created_at", "updated_at") VALUES (?, ?, ?, ?)  [["key", "schema_sha1"], ["value", "2b01fa59c4c74162736a2cb624389712cfa71fdb"], ["created_at", "2019-12-30 21:43:55.043650"], ["updated_at", "2019-12-30 21:43:55.043650"]]
-   (0.6ms)  commit transaction