nulogy_message_bus_producer 3.4.0 → 3.7.0

data/spec/dummy/config/initializers/backtrace_silencers.rb

@@ -1,7 +1,8 @@
 # Be sure to restart your server when you modify this file.
 
 # You can add backtrace silencers for libraries that you're using but don't wish to see in your backtraces.
-# Rails.backtrace_cleaner.add_silencer { |line| line =~ /my_noisy_library/ }
+# Rails.backtrace_cleaner.add_silencer { |line| /my_noisy_library/.match?(line) }
 
-# You can also remove all the silencers if you're trying to debug a problem that might stem from framework code.
-# Rails.backtrace_cleaner.remove_silencers!
+# You can also remove all the silencers if you're trying to debug a problem that might stem from framework code
+# by setting BACKTRACE=1 before calling your invocation, like "BACKTRACE=1 ./bin/rails runner 'MyClass.perform'".
+Rails.backtrace_cleaner.remove_silencers! if ENV["BACKTRACE"]

data/spec/dummy/config/initializers/content_security_policy.rb

@@ -0,0 +1,30 @@
+# Be sure to restart your server when you modify this file.
+
+# Define an application-wide content security policy
+# For further information see the following documentation
+# https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy
+
+# Rails.application.config.content_security_policy do |policy|
+#   policy.default_src :self, :https
+#   policy.font_src    :self, :https, :data
+#   policy.img_src     :self, :https, :data
+#   policy.object_src  :none
+#   policy.script_src  :self, :https
+#   policy.style_src   :self, :https
+#   # If you are using webpack-dev-server then specify webpack-dev-server host
+#   policy.connect_src :self, :https, "http://localhost:3035", "ws://localhost:3035" if Rails.env.development?
+
+#   # Specify URI for violation reports
+#   # policy.report_uri "/csp-violation-report-endpoint"
+# end
+
+# If you are using UJS then enable automatic nonce generation
+# Rails.application.config.content_security_policy_nonce_generator = -> request { SecureRandom.base64(16) }
+
+# Set the nonce only to specific directives
+# Rails.application.config.content_security_policy_nonce_directives = %w(script-src)
+
+# Report CSP violations to a specified URI
+# For further information see the following documentation:
+# https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Security-Policy-Report-Only
+# Rails.application.config.content_security_policy_report_only = true

data/spec/dummy/config/initializers/filter_parameter_logging.rb

@@ -1,4 +1,6 @@
 # Be sure to restart your server when you modify this file.
 
 # Configure sensitive parameters which will be filtered from the log file.
-Rails.application.config.filter_parameters += [:password]
+Rails.application.config.filter_parameters += [
+  :password, :passw, :secret, :token, :_key, :crypt, :salt, :certificate, :otp, :ssn
+]

data/spec/dummy/config/initializers/new_framework_defaults_6_1.rb

@@ -0,0 +1,67 @@
+# Be sure to restart your server when you modify this file.
+#
+# This file contains migration options to ease your Rails 6.1 upgrade.
+#
+# Once upgraded flip defaults one by one to migrate to the new default.
+#
+# Read the Guide for Upgrading Ruby on Rails for more info on each option.
+
+# Support for inversing belongs_to -> has_many Active Record associations.
+# Rails.application.config.active_record.has_many_inversing = true
+
+# Track Active Storage variants in the database.
+# Rails.application.config.active_storage.track_variants = true
+
+# Apply random variation to the delay when retrying failed jobs.
+# Rails.application.config.active_job.retry_jitter = 0.15
+
+# Stop executing `after_enqueue`/`after_perform` callbacks if
+# `before_enqueue`/`before_perform` respectively halts with `throw :abort`.
+# Rails.application.config.active_job.skip_after_callbacks_if_terminated = true
+
+# Specify cookies SameSite protection level: either :none, :lax, or :strict.
+#
+# This change is not backwards compatible with earlier Rails versions.
+# It's best enabled when your entire app is migrated and stable on 6.1.
+# Rails.application.config.action_dispatch.cookies_same_site_protection = :lax
+
+# Generate CSRF tokens that are encoded in URL-safe Base64.
+#
+# This change is not backwards compatible with earlier Rails versions.
+# It's best enabled when your entire app is migrated and stable on 6.1.
+# Rails.application.config.action_controller.urlsafe_csrf_tokens = true
+
+# Specify whether `ActiveSupport::TimeZone.utc_to_local` returns a time with an
+# UTC offset or a UTC time.
+# ActiveSupport.utc_to_local_returns_utc_offset_times = true
+
+# Change the default HTTP status code to `308` when redirecting non-GET/HEAD
+# requests to HTTPS in `ActionDispatch::SSL` middleware.
+# Rails.application.config.action_dispatch.ssl_default_redirect_status = 308
+
+# Use new connection handling API. For most applications this won't have any
+# effect. For applications using multiple databases, this new API provides
+# support for granular connection swapping.
+# Rails.application.config.active_record.legacy_connection_handling = false
+
+# Make `form_with` generate non-remote forms by default.
+# Rails.application.config.action_view.form_with_generates_remote_forms = false
+
+# Set the default queue name for the analysis job to the queue adapter default.
+# Rails.application.config.active_storage.queues.analysis = nil
+
+# Set the default queue name for the purge job to the queue adapter default.
+# Rails.application.config.active_storage.queues.purge = nil
+
+# Set the default queue name for the incineration job to the queue adapter default.
+# Rails.application.config.action_mailbox.queues.incineration = nil
+
+# Set the default queue name for the routing job to the queue adapter default.
+# Rails.application.config.action_mailbox.queues.routing = nil
+
+# Set the default queue name for the mail deliver job to the queue adapter default.
+# Rails.application.config.action_mailer.deliver_later_queue_name = nil
+
+# Generate a `Link` header that gives a hint to modern browsers about
+# preloading assets when using `javascript_include_tag` and `stylesheet_link_tag`.
+# Rails.application.config.action_view.preload_links_header = true

data/spec/dummy/config/initializers/permissions_policy.rb

@@ -0,0 +1,11 @@
+# Define an application-wide HTTP permissions policy. For further
+# information see https://developers.google.com/web/updates/2018/06/feature-policy
+#
+# Rails.application.config.permissions_policy do |f|
+#   f.camera      :none
+#   f.gyroscope   :none
+#   f.microphone  :none
+#   f.usb         :none
+#   f.fullscreen  :self
+#   f.payment     :self, "https://secure.example.com"
+# end

data/spec/dummy/config/locales/en.yml

@@ -27,7 +27,7 @@
 #   'true': 'foo'
 #
 # To learn more, please read the Rails Internationalization guide
-# available at http://guides.rubyonrails.org/i18n.html.
+# available at https://guides.rubyonrails.org/i18n.html.
 
 en:
   hello: "Hello world"

data/spec/dummy/config/storage.yml

@@ -0,0 +1,34 @@
+test:
+  service: Disk
+  root: <%= Rails.root.join("tmp/storage") %>
+
+local:
+  service: Disk
+  root: <%= Rails.root.join("storage") %>
+
+# Use rails credentials:edit to set the AWS secrets (as aws:access_key_id|secret_access_key)
+# amazon:
+#   service: S3
+#   access_key_id: <%= Rails.application.credentials.dig(:aws, :access_key_id) %>
+#   secret_access_key: <%= Rails.application.credentials.dig(:aws, :secret_access_key) %>
+#   region: us-east-1
+#   bucket: your_own_bucket
+
+# Remember not to checkin your GCS keyfile to a repository
+# google:
+#   service: GCS
+#   project: your_project
+#   credentials: <%= Rails.root.join("path/to/gcs.keyfile") %>
+#   bucket: your_own_bucket
+
+# Use rails credentials:edit to set the Azure Storage secret (as azure_storage:storage_access_key)
+# microsoft:
+#   service: AzureStorage
+#   storage_account_name: your_account_name
+#   storage_access_key: <%= Rails.application.credentials.dig(:azure_storage, :storage_access_key) %>
+#   container: your_container_name
+
+# mirror:
+#   service: Mirror
+#   primary: local
+#   mirrors: [ amazon, google, microsoft ]

data/spec/dummy/config.ru

@@ -3,3 +3,4 @@
 require_relative "config/environment"
 
 run Rails.application
+Rails.application.load_server

data/spec/integration/lib/nulogy_message_bus_producer/repopulate_replication_slots_spec.rb

@@ -14,7 +14,7 @@ RSpec.describe NulogyMessageBusProducer::RepopulateReplicationSlots do
     cleanup_everything
   end
 
-  it "generates events" do
+  it "generates events", skip: flakey_in_ci do
     Kafka.create_topic(topic_name)
     consumer = Kafka.setup_kafka_consumer(topic_name)
 

data/spec/integration/lib/nulogy_message_bus_producer/subscription_spec.rb

@@ -1,79 +1,7 @@
 require "integration_spec_helper"
 
-RSpec.describe NulogyMessageBusProducer::Subscription do
-  context "when validating" do
-    it "is invalid without an id" do
-      model = build_subscription(id: "")
-
-      model.validate
-
-      expect(model.errors[:id]).to contain_exactly("can't be blank")
-    end
-
-    it "is invalid without a subscription_group_id" do
-      model = build_subscription(subscription_group_id: "")
-
-      model.validate
-
-      expect(model.errors[:subscription_group_id]).to contain_exactly("can't be blank")
-    end
-
-    it "is invalid with a blank query" do
-      model = build_subscription(query: "")
-
-      model.validate
-
-      expect(model.errors[:query]).to contain_exactly("can't be blank")
-    end
-
-    it "is invalid with blank schema_key" do
-      model = build_subscription(schema_key: "")
-
-      model.validate
-
-      expect(model.errors[:schema_key]).to contain_exactly("can't be blank")
-    end
-
-    it "is invalid with an invalid schema_key" do
-      model = build_subscription(schema_key: "invalid")
-
-      model.validate
-
-      expect(model.errors[:query]).to contain_exactly(/Could not find a schema for schema_key 'invalid'/)
-    end
-
-    it "is invalid with an invalid query" do
-      model = build_subscription(
-        query: subscription_query(query: "foo { a_field_that_does_not_exist }")
-      )
-
-      model.validate
-
-      expect(model).not_to be_valid
-      expect(model.errors[:query]).to contain_exactly(
-        match(/Field 'a_field_that_does_not_exist' doesn't exist on type 'testObject'/)
-      )
-    end
-
-    it "valid with a valid query" do
-      model = build_subscription(
-        query: subscription_query(query: "foo { id }")
-      )
-
-      model.validate
-
-      expect(model.errors).not_to include(:query)
-    end
-  end
-
-  def build_subscription(overrides = {})
-    attrs = {
-      id: SecureRandom.uuid,
-      subscription_group_id: SecureRandom.uuid,
-      schema_key: "test",
-      query: subscription_query,
-    }.merge(overrides)
-
-    NulogyMessageBusProducer::Subscription.new(attrs)
+module NulogyMessageBusProducer
+  RSpec.describe SelfServeSubscription do
+    include_examples "subscription validations"
   end
 end

data/spec/integration_spec_helper.rb

@@ -1,6 +1,3 @@
-# Make all rspec configuration changes to this file.
-# Leave automatically generated configuration files untouched to facilitate gem upgrades.
-
 ENV["RAILS_ENV"] ||= "test"
 
 require File.expand_path("dummy/config/environment.rb", __dir__)
@@ -10,8 +7,6 @@ require "rspec/json_expectations"
 require "active_record"
 require "spec_helper"
 
-Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].sort.each { |f| require f }
-
 RSpec.configure do |config|
   # Uncomment this line to see full backtraces for spec failures
   # config.backtrace_exclusion_patterns = []
@@ -37,5 +32,4 @@ RSpec.configure do |config|
 
   config.include(SpecUtils)
   config.include(SqlHelpers)
-  config.include(SubscriptionHelpers)
 end

data/spec/nulogy_message_bus_producer/subscriptions/subscription_spec.rb

@@ -0,0 +1,9 @@
+require "spec_helper"
+
+module NulogyMessageBusProducer
+  module Subscriptions
+    RSpec.describe ConfiguredSubscription do
+      include_examples "subscription validations"
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -1,6 +1,8 @@
 require "rails/all"
 require "nulogy_message_bus_producer"
 
+Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].sort.each { |f| require f }
+
 RSpec.configure do |config|
   config.expect_with(:rspec) do |expectations|
     # This is generally recommended, and will default to `true` in RSpec 4.
@@ -52,4 +54,7 @@ RSpec.configure do |config|
       example.run
     end
   end
+
+  config.include(SubscriptionHelpers)
+  config.extend(Skip)
 end

data/spec/support/shared_examples/subscription_validations.rb

@@ -0,0 +1,77 @@
+RSpec.shared_examples "subscription validations" do
+  context "when validating" do
+    it "is invalid without an id" do
+      model = build_subscription(id: "")
+
+      model.validate
+
+      expect(model.errors[:id]).to contain_exactly("can't be blank")
+    end
+
+    it "is invalid without a subscription_group_id" do
+      model = build_subscription(subscription_group_id: "")
+
+      model.validate
+
+      expect(model.errors[:subscription_group_id]).to contain_exactly("can't be blank")
+    end
+
+    it "is invalid with a blank query" do
+      model = build_subscription(query: "")
+
+      model.validate
+
+      expect(model.errors[:query]).to contain_exactly("can't be blank")
+    end
+
+    it "is invalid with blank schema_key" do
+      model = build_subscription(schema_key: "")
+
+      model.validate
+
+      expect(model.errors[:schema_key]).to contain_exactly("can't be blank")
+    end
+
+    it "is invalid with an invalid schema_key" do
+      model = build_subscription(schema_key: "invalid")
+
+      model.validate
+
+      expect(model.errors[:query]).to contain_exactly(/Could not find a schema for schema_key 'invalid'/)
+    end
+
+    it "is invalid with an invalid query" do
+      model = build_subscription(
+        query: subscription_query(query: "foo { a_field_that_does_not_exist }")
+      )
+
+      model.validate
+
+      expect(model).not_to be_valid
+      expect(model.errors[:query]).to contain_exactly(
+        match(/Field 'a_field_that_does_not_exist' doesn't exist on type 'testObject'/)
+      )
+    end
+
+    it "valid with a valid query" do
+      model = build_subscription(
+        query: subscription_query(query: "foo { id }")
+      )
+
+      model.validate
+
+      expect(model.errors).not_to include(:query)
+    end
+  end
+
+  def build_subscription(overrides = {})
+    attrs = {
+      id: SecureRandom.uuid,
+      subscription_group_id: SecureRandom.uuid,
+      schema_key: "test",
+      query: subscription_query
+    }.merge(overrides)
+
+    described_class.new(attrs)
+  end
+end

data/spec/support/skip.rb

@@ -0,0 +1,9 @@
+module Skip
+  def flakey_in_ci
+    if ENV.fetch("CI", false)
+      "This spec is terribly flakey in CI, so we only run it locally"
+    else
+      false
+    end
+  end
+end

data/spec/support/sql_helpers.rb

@@ -14,7 +14,7 @@ module SqlHelpers
 
     # Just incase these models weren't loaded, do them explicitly
     ActiveRecord::Base.connection.execute("TRUNCATE #{NulogyMessageBusProducer::SubscriptionEvent.table_name}")
-    ActiveRecord::Base.connection.execute("TRUNCATE #{NulogyMessageBusProducer::Subscription.table_name}")
+    ActiveRecord::Base.connection.execute("TRUNCATE #{NulogyMessageBusProducer::SelfServeSubscription.table_name}")
   end
 
   def replication_slots

data/spec/support/subscription_helpers.rb

@@ -9,9 +9,9 @@ module SubscriptionHelpers
     expect {
       gql_response = execute_graphql(gql, schema)
       expect(gql_response).to eq(data: {})
-    }.to change(NulogyMessageBusProducer::Subscription, :count).by(1)
+    }.to change(NulogyMessageBusProducer::SelfServeSubscription, :count).by(1)
 
-    NulogyMessageBusProducer::Subscription.find(subscription_id)
+    NulogyMessageBusProducer::SelfServeSubscription.find(subscription_id)
   end
 
   def configured_subscription(

data/spec/support/test_graphql_schema.rb

@@ -40,8 +40,6 @@ module NulogyMessageBusProducer
     end
 
     class TestSchema < GraphQL::Schema
-      use GraphQL::Execution::Interpreter
-      use GraphQL::Analysis::AST
       use NulogyMessageBusProducer::Subscriptions::PostgresTransport
 
       query TestQuery