nulogy_message_bus_producer 3.3.0 → 3.4.0

data/spec/spec_helper.rb

@@ -1,4 +1,6 @@
-# See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
+require "rails/all"
+require "nulogy_message_bus_producer"
+
 RSpec.configure do |config|
   config.expect_with(:rspec) do |expectations|
     # This is generally recommended, and will default to `true` in RSpec 4.
@@ -32,4 +34,22 @@ RSpec.configure do |config|
   # test failures related to randomization by passing the same `--seed` value
   # as the one that triggered the failure.
   Kernel.srand(config.seed)
+
+  config.around do |example|
+    if example.metadata[:subscriptions]
+      old_config = NulogyMessageBusProducer.config
+
+      NulogyMessageBusProducer.config = NulogyMessageBusProducer::Config.new
+      NulogyMessageBusProducer.config.register_schema(
+        schema: "NulogyMessageBusProducer::Specs::TestSchema",
+        key: "test"
+      )
+
+      example.run
+
+      NulogyMessageBusProducer.config = old_config
+    else
+      example.run
+    end
+  end
 end

data/spec/support/kafka_connect.rb

@@ -28,4 +28,4 @@ class KafkaConnect
     response = @http.request(request)
     JSON.parse(response.body, symbolize_names: true)
   end
-end
+end

data/spec/support/subscription_helpers.rb

@@ -1,19 +1,37 @@
 module SubscriptionHelpers
-  def subscribe_to(
+  def self_serve_subscription(
     schema: NulogyMessageBusProducer::Specs::TestSchema,
     subscription_id: SecureRandom.uuid,
     **query_args
   )
     gql = subscription_query(subscription_id: subscription_id, **query_args)
 
-    expect do
+    expect {
       gql_response = execute_graphql(gql, schema)
       expect(gql_response).to eq(data: {})
-    end.to change(NulogyMessageBusProducer::Subscription, :count).by(1)
+    }.to change(NulogyMessageBusProducer::Subscription, :count).by(1)
 
     NulogyMessageBusProducer::Subscription.find(subscription_id)
   end
 
+  def configured_subscription(
+    schema: NulogyMessageBusProducer::Specs::TestSchema,
+    subscription_id: SecureRandom.uuid,
+    subscription_group_id: SecureRandom.uuid,
+    **query_args
+  )
+    gql = subscription_query(
+      subscription_id: subscription_id,
+      subscription_group_id: subscription_group_id,
+      **query_args
+    )
+
+    NulogyMessageBusProducer.config.add_subscription!(
+      schema: schema.name,
+      query: gql
+    )
+  end
+
   def subscription_query(
     event_type: "testCreated",
     query: "foo { id }",

data/spec/support/test_graphql_schema.rb

@@ -29,8 +29,14 @@ module NulogyMessageBusProducer
       field :foo_list, [TestObject], null: false
     end
 
+    class TestUpdated < NulogyMessageBusProducer::BaseSubscription
+      field :foo, TestObject, null: false
+      field :foo_list, [TestObject], null: false
+    end
+
     class TestSubscription < GraphQL::Schema::Object
       field :test_created, subscription: TestCreated
+      field :test_updated, subscription: TestCreated
     end
 
     class TestSchema < GraphQL::Schema

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: nulogy_message_bus_producer
 version: !ruby/object:Gem::Version
-  version: 3.3.0
+  version: 3.4.0
 platform: ruby
 authors:
 - Nulogy
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-11-19 00:00:00.000000000 Z
+date: 2021-03-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: graphql
@@ -114,14 +114,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.2.1
+        version: 1.3.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.2.1
+        version: 1.3.0
 - !ruby/object:Gem::Dependency
   name: rdkafka
   requirement: !ruby/object:Gem::Requirement
@@ -165,33 +165,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 4.0.1
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: standard
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.85.1
+        version: 0.11.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.85.1
-- !ruby/object:Gem::Dependency
-  name: rubocop-performance
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 1.6.1
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 1.6.1
+        version: 0.11.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
@@ -235,13 +221,15 @@ files:
 - lib/nulogy_message_bus_producer/application_record.rb
 - lib/nulogy_message_bus_producer/base_subscription.rb
 - lib/nulogy_message_bus_producer/config.rb
+- lib/nulogy_message_bus_producer/configuration/query_parser.rb
 - lib/nulogy_message_bus_producer/engine.rb
 - lib/nulogy_message_bus_producer/repopulate_replication_slots.rb
-- lib/nulogy_message_bus_producer/subscriber_graphql_schema_validator.rb
 - lib/nulogy_message_bus_producer/subscription.rb
 - lib/nulogy_message_bus_producer/subscription_event.rb
+- lib/nulogy_message_bus_producer/subscriptions/finder.rb
 - lib/nulogy_message_bus_producer/subscriptions/no_variables.rb
 - lib/nulogy_message_bus_producer/subscriptions/postgres_transport.rb
+- lib/nulogy_message_bus_producer/subscriptions/query_validator.rb
 - lib/nulogy_message_bus_producer/subscriptions/risky_subscription_blocker.rb
 - lib/nulogy_message_bus_producer/version.rb
 - lib/tasks/engine/message_bus_producer.rake
@@ -291,6 +279,8 @@ files:
 - spec/dummy/config/spring.rb
 - spec/dummy/db/migrate/20201005164116_create_active_storage_tables.active_storage.rb
 - spec/dummy/db/schema.rb
+- spec/dummy/log/development.log
+- spec/dummy/log/test.log
 - spec/dummy/package.json
 - spec/dummy/public/404.html
 - spec/dummy/public/422.html
@@ -298,13 +288,16 @@ files:
 - spec/dummy/public/apple-touch-icon-precomposed.png
 - spec/dummy/public/apple-touch-icon.png
 - spec/dummy/public/favicon.ico
+- spec/integration/lib/nulogy_message_bus_producer/config_spec.rb
 - spec/integration/lib/nulogy_message_bus_producer/repopulate_replication_slots_spec.rb
-- spec/integration/lib/nulogy_message_bus_producer/subscriber_graphql_schema_validator_spec.rb
 - spec/integration/lib/nulogy_message_bus_producer/subscription_spec.rb
+- spec/integration/lib/nulogy_message_bus_producer/subscriptions/finder_spec.rb
 - spec/integration/lib/nulogy_message_bus_producer/subscriptions/no_variables_spec.rb
 - spec/integration/lib/nulogy_message_bus_producer/subscriptions/postgres_transport_spec.rb
+- spec/integration/lib/nulogy_message_bus_producer/subscriptions/query_validator_spec.rb
 - spec/integration/lib/nulogy_message_bus_producer/subscriptions/risky_subscription_blocker_spec.rb
 - spec/integration_spec_helper.rb
+- spec/nulogy_message_bus_producer/configuration/query_parser_spec.rb
 - spec/spec_helper.rb
 - spec/support/kafka.rb
 - spec/support/kafka_connect.rb
@@ -330,7 +323,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.8
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Nulogy's code for producing to the Message Bus
@@ -389,16 +382,21 @@ test_files:
 - spec/dummy/package.json
 - spec/dummy/db/schema.rb
 - spec/dummy/db/migrate/20201005164116_create_active_storage_tables.active_storage.rb
+- spec/dummy/log/test.log
+- spec/dummy/log/development.log
 - spec/integration_spec_helper.rb
 - spec/integration/lib/nulogy_message_bus_producer/repopulate_replication_slots_spec.rb
+- spec/integration/lib/nulogy_message_bus_producer/config_spec.rb
 - spec/integration/lib/nulogy_message_bus_producer/subscriptions/risky_subscription_blocker_spec.rb
+- spec/integration/lib/nulogy_message_bus_producer/subscriptions/finder_spec.rb
 - spec/integration/lib/nulogy_message_bus_producer/subscriptions/postgres_transport_spec.rb
+- spec/integration/lib/nulogy_message_bus_producer/subscriptions/query_validator_spec.rb
 - spec/integration/lib/nulogy_message_bus_producer/subscriptions/no_variables_spec.rb
 - spec/integration/lib/nulogy_message_bus_producer/subscription_spec.rb
-- spec/integration/lib/nulogy_message_bus_producer/subscriber_graphql_schema_validator_spec.rb
 - spec/support/kafka_connect.rb
 - spec/support/subscription_helpers.rb
 - spec/support/kafka.rb
 - spec/support/spec_utils.rb
 - spec/support/sql_helpers.rb
 - spec/support/test_graphql_schema.rb
+- spec/nulogy_message_bus_producer/configuration/query_parser_spec.rb

data/lib/nulogy_message_bus_producer/subscriber_graphql_schema_validator.rb

@@ -1,45 +0,0 @@
-module NulogyMessageBusProducer
-  # A custom validator that checks that the provided (or all) subscriptions have a query that is valid for its
-  # configured schema. Schemas must be registered with a `schema_key`, that is persisted in the database.
-  # It ties the subscription to a particular schema.
-  #
-  # This validator is run as part of an initializer as a last ditch effort to verify that the stored queries in the
-  # database are valid against the deployed schema, so that when events are generated in the system, they are always
-  # sucessfully created.
-  class SubscriberGraphqlSchemaValidator
-    attr_reader :errors
-
-    def initialize
-      @errors = []
-    end
-
-    def validate(subscription_or_subscriptions = NulogyMessageBusProducer::Subscription.all)
-      Array(subscription_or_subscriptions).each do |subscription|
-        schema = find_schema(subscription)
-        next unless schema
-
-        gql_errors = schema.validate(subscription.query)
-        errors = gql_errors.map { |e| "#{e.message} #{display_id(subscription.id)}" }
-
-        @errors.concat(errors)
-      end
-
-      @errors.empty?
-    end
-
-    private
-
-    def find_schema(subscription)
-      NulogyMessageBusProducer.resolve_schema(subscription.schema_key) do
-        @errors << "Could not find a schema for schema_key '#{subscription.schema_key}' #{display_id(subscription.id)}"
-        nil
-      end
-    end
-
-    def display_id(id)
-      normalized = id.presence || "<new_record>"
-
-      "(id: #{normalized})"
-    end
-  end
-end