nulogy_message_bus_producer 1.0.4 → 2.0.0

data/spec/integration/lib/graphql_api/postgres_public_subscriptions_spec.rb

@@ -13,4 +13,110 @@ RSpec.describe NulogyMessageBusProducer::PostgresPublicSubscriptions do
       end.to raise_error(KeyError, /The schema registry did not contain an entry/)
     end
   end
+
+  context "when subscription is triggered" do
+    before do
+      NulogyMessageBusProducer.config.register_schema(
+        schema: "NulogyMessageBusProducer::Specs::TestSchema",
+        key: "test"
+      )
+    end
+
+    it "generates events" do
+      create_subscription(event_type: "testCreated")
+      create_subscription(event_type: "testCreated")
+
+      uuid = SecureRandom.uuid
+
+      expect do
+        NulogyMessageBusProducer::Specs::TestSchema.subscriptions.trigger(
+          "testCreated",
+          {},
+          { uuid: uuid, tenant_id: SecureRandom.uuid }
+        )
+      end.to change(NulogyMessageBusProducer::PublicSubscriptionEvent, :count).by(2)
+
+      event_data = NulogyMessageBusProducer::PublicSubscriptionEvent.pluck(:event_json)
+      expect(event_data).to all(include("foo" => { "id" => uuid }))
+    end
+  end
+
+  context "when a subscription error occurs" do
+    context "when failing with raise" do
+      before do
+        NulogyMessageBusProducer.config.producing_events_fails_with(:raise)
+      end
+
+      it "raises an exception" do
+        expect { trigger_erroneous_subscription }.to raise_error(/A subscription event could not be produced/)
+      end
+    end
+
+    context "when failing with a soft fail" do
+      before do
+        NulogyMessageBusProducer.config.producing_events_fails_with(:soft_fail)
+      end
+
+      it "does not raise an error" do
+        trigger_erroneous_subscription
+      end
+
+      it "calls the provided block" do
+        called = false
+
+        NulogyMessageBusProducer.config.producing_events_fails_with(:soft_fail) do |_|
+          called = true
+        end
+
+        trigger_erroneous_subscription
+
+        expect(called).to be(true)
+      end
+    end
+  end
+
+  def trigger_erroneous_subscription
+    NulogyMessageBusProducer.config.register_schema(schema: "NulogyMessageBusProducer::Specs::TestSchema", key: "test")
+
+    event_type = "testCreated"
+
+    subscription = create_subscription(event_type: event_type)
+    simulate_invalid_query(subscription)
+
+    NulogyMessageBusProducer::Specs::TestSchema.subscriptions.trigger(
+      event_type,
+      {},
+      { uuid: SecureRandom.uuid, tenant_id: SecureRandom.uuid }
+    )
+  end
+
+  def create_subscription(**overrides) # rubocop:disable Metrics/MethodLength
+    args = {
+      id: SecureRandom.uuid,
+      subscription_group_id: SecureRandom.uuid,
+      topic_name: "test_topic",
+      schema_key: "test",
+      event_type: "test_event_type",
+      query: <<~QUERY
+        query ($id: UUID!) {
+          foo (id: $id) {
+            id
+          }
+        }
+      QUERY
+    }.merge(overrides)
+
+    NulogyMessageBusProducer::PublicSubscription.create_or_update(args)
+  end
+
+  def simulate_invalid_query(subscription)
+    subscription.query = <<~QUERY
+      query ($id: UUID!) {
+        foo (id: $id) {
+          a_field_that_does_not_exist
+        }
+      }
+    QUERY
+    subscription.save(validate: false)
+  end
 end

data/spec/integration/lib/graphql_api/validators/subscriber_graphql_schema_validator_spec.rb

@@ -4,7 +4,7 @@ RSpec.describe NulogyMessageBusProducer::SubscriberGraphqlSchemaValidator do
   subject(:validator) { NulogyMessageBusProducer::SubscriberGraphqlSchemaValidator.new }
 
   before do
-    NulogyMessageBusProducer.register_schema("test", "NulogyMessageBusProducer::Specs::TestSchema")
+    NulogyMessageBusProducer.config.register_schema(schema: "NulogyMessageBusProducer::Specs::TestSchema", key: "test")
   end
 
   describe "#validate" do

data/spec/integration_spec_helper.rb

@@ -7,6 +7,7 @@ require File.expand_path("dummy/config/environment.rb", __dir__)
 
 require "rspec/rails"
 require "active_record"
+require "spec_helper"
 
 Dir["#{File.dirname(__FILE__)}/support/**/*.rb"].sort.each { |f| require f }
 

data/spec/spec_helper.rb

@@ -13,12 +13,27 @@ module NulogyMessageBusProducer
       field :foo, TestObject, null: false do
         argument :id, type: NulogyGraphqlApi::Types::UUID, required: false
       end
+
+      def foo(id:)
+        OpenStruct.new(id: id)
+      end
+    end
+
+    class TestCreated < NulogyMessageBusProducer::BasePublicSubscription
+      field :description, String, null: false
+    end
+
+    class TestSubscription < GraphQL::Schema::Object
+      extend GraphQL::Subscriptions::SubscriptionRoot
+
+      field :test_created, subscription: TestCreated
     end
 
     class TestSchema < GraphQL::Schema
       use NulogyMessageBusProducer::PostgresPublicSubscriptions
 
       query TestQuery
+      subscription TestSubscription
     end
   end
 end

data/spec/unit/lib/graphql_api/models/public_subscription_spec.rb

@@ -3,7 +3,7 @@ require "unit_spec_helper"
 RSpec.describe NulogyMessageBusProducer::PublicSubscription do
   context "when validating" do
     before do
-      NulogyMessageBusProducer.register_schema("test", "NulogyMessageBusProducer::Specs::TestSchema")
+      NulogyMessageBusProducer.config.register_schema schema: "NulogyMessageBusProducer::Specs::TestSchema", key: "test"
     end
 
     it "is invalid with a blank query" do
@@ -18,6 +18,14 @@ RSpec.describe NulogyMessageBusProducer::PublicSubscription do
       expect(model.errors[:query]).to contain_exactly("can't be blank")
     end
 
+    it "is invalid with blank schema_key" do
+      model = NulogyMessageBusProducer::PublicSubscription.new(schema_key: "")
+
+      model.validate
+
+      expect(model.errors[:schema_key]).to be_present
+    end
+
     it "is invalid with an invalid query" do
       model = NulogyMessageBusProducer::PublicSubscription.new(
         schema_key: "test",
@@ -33,7 +41,9 @@ RSpec.describe NulogyMessageBusProducer::PublicSubscription do
       model.validate
 
       expect(model).to_not be_valid
-      expect(model.errors[:query]).to contain_exactly("Field 'a_field_that_does_not_exist' doesn't exist on type 'testObject' (id: <new_record>)")
+      expect(model.errors[:query]).to contain_exactly(
+        "Field 'a_field_that_does_not_exist' doesn't exist on type 'testObject' (id: <new_record>)"
+      )
     end
 
     it "valid with a valid query" do

metadata

@@ -1,43 +1,43 @@
 --- !ruby/object:Gem::Specification
 name: nulogy_message_bus_producer
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 2.0.0
 platform: ruby
 authors:
 - Nulogy
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-07-13 00:00:00.000000000 Z
+date: 2020-07-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 5.2.4.2
+        version: '5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 5.2.4.2
+        version: '5'
 - !ruby/object:Gem::Dependency
   name: graphql
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.9.12
+        version: '1.9'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.9.12
+        version: '1.9'
 - !ruby/object:Gem::Dependency
   name: strong_migrations
   requirement: !ruby/object:Gem::Requirement
@@ -191,6 +191,7 @@ files:
 - lib/nulogy_message_bus_producer.rb
 - lib/nulogy_message_bus_producer/application_record.rb
 - lib/nulogy_message_bus_producer/base_public_subscription.rb
+- lib/nulogy_message_bus_producer/config.rb
 - lib/nulogy_message_bus_producer/engine.rb
 - lib/nulogy_message_bus_producer/postgres_public_subscriptions.rb
 - lib/nulogy_message_bus_producer/public_subscription.rb
@@ -260,7 +261,7 @@ files:
 homepage: https://github.com/nulogy/message-bus/tree/master/gems/nulogy_message_bus_producer
 licenses: []
 metadata: {}
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -276,7 +277,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.0.3
-signing_key:
+signing_key: 
 specification_version: 4
 summary: Nulogy's code for producing to the Message Bus
 test_files: