nulogy_graphql_api 0.5.3 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6625da7a3a2e9f0f68ded5321a5bc57b81fdf1ca00e1f85385f8551454a3ea70
-  data.tar.gz: 375182960778201a137f3b2dd96667f5eead6c82959e06e1be0f9c8de3e829a0
+  metadata.gz: 4b83dfdf7475f2630a23b11b79d071783253eec60759d0b9011c36334413f298
+  data.tar.gz: aef54c3d57c7b7e666758c041682660521e872ee509942d7c5549274836ea57b
 SHA512:
-  metadata.gz: d83ccfd6856215e4965d9ca64a253447d2593d26c801547c0259a5024765193d1f4ef2e0bbcf865c58a95e11518ab544e0f0486eb95a77ade9f6f041bc3d54cf
-  data.tar.gz: c72a1471eb7dc8f4a63219d0494c7ba159d31009e18e36791455c984f5d01bc5299c639d4eadb42e3150f36db675656135df2001211e4ff4519dbba8134d8d65
+  metadata.gz: 12941fe223139d12da5e571ea7d320d7f55db4cdf53ffe0d0870e60bf1438b01c83c4dc04f91d08ba4aba91dbb617cfa67f873e102d5671a91d8449b0bbe4257
+  data.tar.gz: c339bc9011ce92e493a7e83d4e0a295b10d663b2027933e6530e97be6407fcd2971d75e9b8e849c87671768e30ec07678e892484e0c6ec86f3519039182d8c3f

data/.rubocop.yml

@@ -6,6 +6,9 @@ inherit_from:
 AllCops:
   TargetRubyVersion: 2.6
 
+Gemspec/DateAssignment:
+  Enabled: true
+
 Layout/EmptyLinesAroundAttributeAccessor:
   Enabled: true
 
@@ -38,18 +41,72 @@ Layout/MultilineOperationIndentation:
 Layout/SpaceAroundMethodCallOperator:
   Enabled: false
 
+Layout/SpaceBeforeBrackets:
+  Enabled: true
+
+Lint/AmbiguousAssignment:
+  Enabled: true
+
+Lint/DeprecatedConstants:
+  Enabled: true
+
 Lint/DeprecatedOpenSSLConstant:
   Enabled: true
 
+Lint/DuplicateBranch:
+  Enabled: true
+
+Lint/DuplicateElsifCondition:
+  Enabled: true
+
+Lint/DuplicateRegexpCharacterClassElement:
+  Enabled: true
+
+Lint/EmptyBlock:
+  Enabled: true
+
+Lint/EmptyClass:
+  Enabled: true
+
+Lint/LambdaWithoutLiteralBlock:
+  Enabled: true
+
 Lint/MixedRegexpCaptureTypes:
   Enabled: true
 
+Lint/NoReturnInBeginEndBlocks:
+  Enabled: true
+
+Lint/NumberedParameterAssignment:
+  Enabled: true
+
+Lint/OrAssignmentToConstant:
+  Enabled: true
+
 Lint/RaiseException:
   Enabled: false
 
+Lint/RedundantDirGlobSort:
+  Enabled: true
+
 Lint/StructNewOverride:
   Enabled: false
 
+Lint/SymbolConversion:
+  Enabled: true
+
+Lint/ToEnumArguments:
+  Enabled: true
+
+Lint/TripleQuotes:
+  Enabled: true
+
+Lint/UnexpectedBlockArity:
+  Enabled: true
+
+Lint/UnmodifiedReduceAccumulator:
+  Enabled: true
+
 Metrics:
   Enabled: false
 
@@ -74,18 +131,57 @@ RSpec/MessageSpies:
 RSpec/NotToNot:
   EnforcedStyle: to_not
 
+Style/AccessorGrouping:
+  Enabled: true
+
+Style/ArgumentsForwarding:
+  Enabled: true
+
+Style/ArrayCoercion:
+  Enabled: true
+
+Style/BisectedAttrAccessor:
+  Enabled: true
+
+Style/CaseLikeIf:
+  Enabled: true
+
+Style/CollectionCompact:
+  Enabled: true
+
+Style/DocumentDynamicEvalDefinition:
+  Enabled: true
+
+Style/EndlessMethod:
+  Enabled: true
+
 Style/ExponentialNotation:
   Enabled: false
 
+Style/HashAsLastArrayItem:
+  Enabled: true
+
+Style/HashConversion:
+  Enabled: true
+
 Style/HashEachMethods:
   Enabled: false
 
+Style/HashExcept:
+  Enabled: true
+
+Style/HashLikeCase:
+  Enabled: true
+
 Style/HashTransformKeys:
   Enabled: false
 
 Style/HashTransformValues:
   Enabled: false
 
+Style/IfWithBooleanLiteralBranches:
+  Enabled: true
+
 Style/BlockDelimiters:
   Enabled: false
 
@@ -110,9 +206,24 @@ Style/GuardClause:
 Style/MutableConstant:
   Enabled: false
 
+Style/NegatedIfElseCondition:
+  Enabled: true
+
 Style/RaiseArgs:
   Enabled: false
 
+Style/RedundantArgument:
+  Enabled: true
+
+Style/RedundantAssignment:
+  Enabled: true
+
+Style/RedundantFetchBlock:
+  Enabled: true
+
+Style/RedundantFileExtensionInRequire:
+  Enabled: true
+
 Style/RedundantRegexpCharacterClass:
   Enabled: true
 
@@ -131,6 +242,12 @@ Style/SlicingWithRange:
 Style/StringLiterals:
   EnforcedStyle: double_quotes
 
+Style/SwapValues:
+  Enabled: true
+
+Style/NilLambda:
+  Enabled: true
+
 Style/SymbolArray:
   Enabled: false
 

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## master (unreleased)
 
+**Changes**
+
+* **(Potentially Breaking)** Bump graphql gem version to 1.12.5
+
 ## 0.5.3 (2020-08-11)
 
 * Add `BaseMutation`.
@@ -12,17 +16,17 @@
 
 ## 0.5.0 (2020-08-05)
 
-**Breaking Changes**
+**Changes**
 
-* Add `context` to the Rake task that generates the schema file.  
+* **(Breaking)** Add `context` to the Rake task that generates the schema file.  
 This changes the way the schema is parsed. Please refer to the README file to see an example of how to use `context`.
 
 ## 0.4.0 (2020-07-06)
 
-**Breaking Changes**
+**Changes**
 
-* Remove the GraphqlApiController
-* Add the ErrorHandling controller concern
+* **(Breaking)** Remove the GraphqlApiController
+* **(Breaking)** Add the ErrorHandling controller concern
 
 ## 0.3.1 (2020-07-03)
 
@@ -30,20 +34,20 @@ This changes the way the schema is parsed. Please refer to the README file to se
 
 ## 0.3.0 (2020-06-25)
 
-**Breaking Changes**
+**Changes**
 
-* Remove spec helpers related to subscriptions
+* **(Breaking)** Remove spec helpers related to subscriptions
 
 ## 0.2.0 (2020-06-24)
 
-**Breaking Changes**
+**Changes**
 
-* Rename `GraphqlExecutor.call` to `execute`
-* Change `schema` parameter on `execute_graphql` test helper to positional
+* **(Breaking)** Rename `GraphqlExecutor.call` to `execute`
+* **(Breaking)** Change `schema` parameter on `execute_graphql` test helper to positional
 
 ## 0.1.1 (2020-06-24)
 
-**New Features**
+**Changes**
 
 * RSpec custom matchers
 * RSpec helpers

data/README.md

@@ -1,5 +1,9 @@
 # NulogyGraphqlApi
 
+## Intent
+
+Help Nulogy applications be compliant with the [Standard on Error-handling in GraphQL](https://trello.com/c/N5cHt4Gp/7-error-handling-in-graphql-apis).
+
 ## Installation
 
 Add this line to your application's Gemfile:
@@ -275,7 +279,22 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/nulogy/nulogy_graphql_api/issues. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [code of conduct](https://github.com/nulogy/nulogy_graphql_api/blob/master/CODE_OF_CONDUCT.md).
+We treat this project as an internal "open source" project. Everyone at Nulogy is welcome to submit Pull Requests.
+
+### Submitting Pull Requests
+
+The Directly Responsible Individual (DRI) for this project is Daniel Silva.
+
+When you are happy with your changes:
+
+1. Add description of changes to the top of the [CHANGELOG](./CHANGELOG.md) file, under the `## master (unreleased)` section subdivided into the following categories:
+    - New Features
+    - Bug Fixes
+    - Changes
+        - *prepend these with* **(Breaking)***,* **(Potentially Breaking)** *or just leave it blank in case neither applies*
+    
+1. Create a Pull Request.
+1. Notify #nulogy-graphql-api Slack channel to get the DRI review and merge your changes.
 
 ## License
 

data/lib/nulogy_graphql_api/rspec.rb

@@ -1,4 +1,4 @@
 # relative-require all rspec files
-Dir[File.dirname(__FILE__) + "/rspec/*.rb"].each do |file|
-  require "nulogy_graphql_api/rspec/" + File.basename(file, File.extname(file))
+Dir["#{File.dirname(__FILE__)}/rspec/*.rb"].each do |file|
+  require "nulogy_graphql_api/rspec/#{File.basename(file, File.extname(file))}"
 end

data/lib/nulogy_graphql_api/rspec/graphql_helpers.rb

@@ -16,8 +16,8 @@ module NulogyGraphqlApi
     def request_graphql(url, query, variables: {}, headers: {})
       params = { query: query, variables: variables }.to_json
       default_headers = {
-        "CONTENT_TYPE": "application/json",
-        "HTTP_AUTHORIZATION": basic_auth_token(default_user.login)
+        CONTENT_TYPE: "application/json",
+        HTTP_AUTHORIZATION: basic_auth_token(default_user.login)
       }
 
       post url, params: params, headers: default_headers.merge(headers)

data/lib/nulogy_graphql_api/tasks/schema_changes_checker.rb

@@ -25,7 +25,7 @@ module NulogyGraphqlApi
 
         puts "\n\nDo you want to update the schema anyway? [Y/n]"
 
-        STDIN.gets.chomp.downcase != "n"
+        $stdin.gets.chomp.downcase != "n"
       end
     end
   end

data/lib/nulogy_graphql_api/version.rb

@@ -1,3 +1,3 @@
 module NulogyGraphqlApi
-  VERSION = "0.5.3"
+  VERSION = "0.6.0"
 end

data/nulogy_graphql_api.gemspec

@@ -28,15 +28,15 @@ Gem::Specification.new do |spec|
   spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "graphql", "~> 1.11.2"
+  spec.add_dependency "graphql", "~> 1.12.5"
   spec.add_dependency "graphql-schema_comparator", "~> 1.0.0"
   spec.add_dependency "rails", ">= 5.2.4", "< 6.1.0"
   spec.add_dependency "rainbow", "~> 3.0.0"
 
-  spec.add_development_dependency "appraisal", "~> 2.1.0"
+  spec.add_development_dependency "appraisal", "~> 2.3.0"
   spec.add_development_dependency "rspec-rails", "~> 3.9.0"
-  spec.add_development_dependency "rubocop", "~> 0.83"
+  spec.add_development_dependency "rubocop", "~> 1.10.0"
   spec.add_development_dependency "rubocop-performance", "~> 1.6"
-  spec.add_development_dependency "rubocop-rspec", "~> 1.39"
+  spec.add_development_dependency "rubocop-rspec", "~> 2.2.0"
   spec.add_development_dependency "sqlite3", "~> 1.4.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: nulogy_graphql_api
 version: !ruby/object:Gem::Version
-  version: 0.5.3
+  version: 0.6.0
 platform: ruby
 authors:
 - Daniel Silva
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-08-11 00:00:00.000000000 Z
+date: 2021-02-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: graphql
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.11.2
+        version: 1.12.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.11.2
+        version: 1.12.5
 - !ruby/object:Gem::Dependency
   name: graphql-schema_comparator
   requirement: !ruby/object:Gem::Requirement
@@ -78,14 +78,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.1.0
+        version: 2.3.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.1.0
+        version: 2.3.0
 - !ruby/object:Gem::Dependency
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
@@ -106,14 +106,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.83'
+        version: 1.10.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.83'
+        version: 1.10.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
@@ -134,14 +134,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.39'
+        version: 2.2.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.39'
+        version: 2.2.0
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
@@ -156,7 +156,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 1.4.2
-description: 
+description:
 email:
 - danielsi@nulogy.com
 executables: []
@@ -206,7 +206,7 @@ metadata:
   changelog_uri: https://github.com/nulogy/nulogy_graphql_api/blob/master/CHANGELOG.md
   source_code_uri: https://github.com/nulogy/nulogy_graphql_api
   bug_tracker_uri: https://github.com/nulogy/nulogy_graphql_api/issues
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -221,8 +221,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.8
-signing_key: 
+rubygems_version: 3.2.9
+signing_key:
 specification_version: 4
 summary: Standard tooling for building GraphQL apis
 test_files: []