null-logger 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: bb46a333d77b31236b9b3e071244d02a3eba700e
-  data.tar.gz: 48afc3f414bc22b2c8f86b925caee3132b8a8bcf
+SHA256:
+  metadata.gz: 148dcf1f7a434633cc943ac6ee27a1916692cdcd9ecbf04e89b9e04e3b1068ea
+  data.tar.gz: 45580a1ba4d4e08b90c93fdda96163cf729b9313fb45e12acaa6da83d6003f60
 SHA512:
-  metadata.gz: 3cc144000c3ca3af691c6d9673c01829c869c05e9f28f9a1c7d02ba8091c0637fbe2b8ce06043d10aee1323601e63659e91e9820ed10579c0efdb3dc5379c4f2
-  data.tar.gz: 1fc286f6d4bc649be4f8a069c2f7e3d0abfff8bc369fd0b19ad90fd7e37345be7506cd97026f9ad1cfd17f5c31340862986c5cbf94f70d9a30f37f6392bc86d4
+  metadata.gz: 1dee771ad0351a9183a85ecbf81d5bf1401f97245571ad5b5165219172fabd8f1b8ddb32b65e898c8584a7374ee86525461c270bb64ab82fe68e9185e32c3925
+  data.tar.gz: e952136d3488ff7fe4259c0bc8fa4fb377cf20b59ea6b604e5304f96f7c30f3a08bb2b4fecc8d978e152a315de11ba86323d332e4897cf4254ecba067d849bac

data/.ruby-version

@@ -1 +1 @@
-2.4.1
+2.5.0

data/.travis.yml

@@ -1,11 +1,18 @@
 language: ruby
+sudo: false
 rvm:
-  - 2.2.3
   - 2.3.0
   - 2.3.1
   - 2.3.2
   - 2.3.3
+  - 2.3.4
   - 2.4.0
   - 2.4.1
-script:
-  - bundle exec rake
+  - 2.4.2
+  - 2.5.0
+  - jruby-head
+script: bundle exec rspec spec/
+env:
+  global:
+    - JRUBY_OPTS='--debug'
+install: bundle install --jobs=3 --retry=3

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Null-Logger changelog
 
+## 0.1.5 Unreleased
+- Ruby 2.4.2 support
+- #5 - Could be faster
+- Ruby 2.5.0 support
+
 ## 0.1.4
 - Ruby 2.4.1 as default
 - Gem bump

data/Gemfile

@@ -7,5 +7,4 @@ gemspec
 group :development, :test do
   gem 'rspec'
   gem 'simplecov'
-  gem 'rake'
 end

data/Gemfile.lock

@@ -1,42 +1,40 @@
 PATH
   remote: .
   specs:
-    null-logger (0.1.4)
+    null-logger (0.1.5)
 
 GEM
   remote: https://rubygems.org/
   specs:
     diff-lcs (1.3)
-    docile (1.1.5)
+    docile (1.3.0)
     json (2.1.0)
-    rake (12.0.0)
-    rspec (3.5.0)
-      rspec-core (~> 3.5.0)
-      rspec-expectations (~> 3.5.0)
-      rspec-mocks (~> 3.5.0)
-    rspec-core (3.5.4)
-      rspec-support (~> 3.5.0)
-    rspec-expectations (3.5.0)
+    rspec (3.7.0)
+      rspec-core (~> 3.7.0)
+      rspec-expectations (~> 3.7.0)
+      rspec-mocks (~> 3.7.0)
+    rspec-core (3.7.1)
+      rspec-support (~> 3.7.0)
+    rspec-expectations (3.7.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-mocks (3.5.0)
+      rspec-support (~> 3.7.0)
+    rspec-mocks (3.7.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.5.0)
-    rspec-support (3.5.0)
-    simplecov (0.14.1)
-      docile (~> 1.1.0)
+      rspec-support (~> 3.7.0)
+    rspec-support (3.7.1)
+    simplecov (0.16.1)
+      docile (~> 1.1)
       json (>= 1.8, < 3)
       simplecov-html (~> 0.10.0)
-    simplecov-html (0.10.0)
+    simplecov-html (0.10.2)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
   null-logger!
-  rake
   rspec
   simplecov
 
 BUNDLED WITH
-   1.14.6
+   1.16.1

data/README.md

@@ -1,8 +1,6 @@
 # Null Logger
 
 [![Build Status](https://travis-ci.org/karafka/null-logger.svg?branch=master)](https://travis-ci.org/karafka/null-logger)
-[![Code Climate](https://codeclimate.com/github/karafka/null-logger/badges/gpa.svg)](https://codeclimate.com/github/karafka/null-logger)
-[![Gem Version](https://badge.fury.io/rb/null-logger.svg)](http://badge.fury.io/rb/null-logger)
 [![Join the chat at https://gitter.im/karafka/karafka](https://badges.gitter.im/karafka/karafka.svg)](https://gitter.im/karafka/karafka?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 
 A simple logger that does not log anything. It can be used for defining an interface for other loggers.
@@ -48,27 +46,17 @@ NullLogger define interface for real logger instance, ex:
 ## References
 
 * [Karafka framework](https://github.com/karafka/karafka)
-* [Waterdrop](https://github.com/karafka/waterdrop)
-* [Worker Glass](https://github.com/karafka/worker-glass)
-* [Envlogic](https://github.com/karafka/envlogic)
 * [Null Logger Travis CI](https://travis-ci.org/karafka/null-logger)
-* [Null Logger Code Climate](https://codeclimate.com/github/karafka/null-logger)
+* [Null Logger Coditsu](https://app.coditsu.io/karafka/repositories/null-logger)
 
-## Note on Patches/Pull Requests
+## Note on contributions
 
-Fork the project.
-Make your feature addition or bug fix.
-Add tests for it. This is important so I don't break it in a future version unintentionally.
-Commit, do not mess with Rakefile, version, or history. (if you want to have your own version, that is fine but bump version in a commit by itself I can ignore when I pull). Send me a pull request. Bonus points for topic branches.
+First, thank you for considering contributing to NullLogger! It's people like you that make the open source community such a great community!
 
-[![coditsu](https://coditsu.io/assets/quality_bar.svg)](https://coditsu.io)
+Each pull request must pass all the rspec specs and meet our quality requirements.
 
-Each pull request must pass our quality requirements. To check if everything is as it should be, we use [Coditsu](https://coditsu.io) that combinse multiple linters and code analyzers. Unfortunately, for now it is invite-only based, so just ping us and we will give you access to the quality results.
+To check if everything is as it should be, we use [Coditsu](https://coditsu.io) that combines multiple linters and code analyzers for both code and documentation. Once you're done with your changes, submit a pull request.
 
-Please run:
+Coditsu will automatically check your work against our quality standards. You can find your commit check results on the [builds page](https://app.coditsu.io/karafka/repositories/null-logger/builds/commit_builds) of NullLogger repository.
 
-```bash
-bundle exec rake
-```
-
-to check if everything is in order. After that you can submit a pull request.
+[![coditsu](https://coditsu.io/assets/quality_bar.svg)](https://app.coditsu.io/karafka/repositories/null-logger/builds/commit_builds)

data/lib/null_logger.rb

@@ -1,32 +1,92 @@
 # frozen_string_literal: true
 
-# Null logger class
-# Is used when logger is not defined
+# Null logger class. This is essentially the same as sending data down the
+# `/dev/null` blackhole.
+#
+# @example Basic Usage
+#
+#   logger = NullLogger.new
+#   Rails.logger = logger
+#
+#
+# @example Basic Pattern Usage
+#   class SomeService
+#     def initialize(options = {})
+#       @logger = options[:logger] || NullLogger.new
+#     end
+#
+#     def perform
+#       @logger.debug -> { "do some work here" }
+#       # .. ..
+#       @logger.info -> { "finished working" }
+#     end
+#   end
+#
+#   service = SomeService.new(logger: Logger.new(STDOUT))
+#   service.perform
+#
+#   silent = SomeService.new(logger: NullLogger.new
+#   silent.perform
+#
 class NullLogger
-  # Possible log levels from ruby Logger::Severity class
-  LOG_LEVELS = %w[
-    unknown
-    fatal
-    error
-    warn
-    info
-    debug
-  ].freeze
-
-  # @return [Boolean] true if we can handle this missing method, otherwise false
-  # @param method_name [String, Symbol] method name
-  # @param include_private [Boolean] should we include private methods as well
-  def respond_to_missing?(method_name, include_private = false)
-    LOG_LEVELS.include?(method_name.to_s) || super
-  end
-
-  # Returns nil for any method call from LOG_LEVELS array
-  # Instead raise NoMethodError
-  # @example:
-  #   NullLogger.new.fatal -> return nil
-  #   NullLogger.new.wrong_method -> raise NoMethodError
-  def method_missing(method_name, *args, &block)
-    return nil if LOG_LEVELS.include?(method_name.to_s)
-    super
+  # @param _args Anything that we want to ignore
+  # @return [nil]
+  def unknown(*_args)
+    nil
+  end
+
+  # @param _args Anything that we want to ignore
+  # @return [nil]
+  def fatal(*_args)
+    nil
+  end
+
+  # @return [FALSE]
+  def fatal?
+    false
+  end
+
+  # @param _args Anything that we want to ignore
+  # @return [nil]
+  def error(*_args)
+    nil
+  end
+
+  # @return [FALSE]
+  def error?
+    false
+  end
+
+  # @param _args Anything that we want to ignore
+  # @return [nil]
+  def warn(*_args)
+    nil
+  end
+
+  # @return [FALSE]
+  def warn?
+    false
+  end
+
+  # @param _args Anything that we want to ignore
+  # @return [nil]
+  def info(*_args)
+    nil
+  end
+
+  # @return [FALSE]
+  def info?
+    false
+  end
+
+  # @param _args Anything that we want to ignore
+  # @return [nil]
+  def debug(*_args)
+    nil
+  end
+
+  # @return [FALSE]
+  def debug?
+    false
   end
 end

data/lib/null_logger/version.rb

@@ -2,5 +2,5 @@
 
 class NullLogger
   # null-logger gem Version
-  VERSION = '0.1.4'
+  VERSION = '0.1.5'
 end

data/null-logger.gemspec

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 require 'null_logger/version'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: null-logger
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - Maciej Mensfeld
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-05-02 00:00:00.000000000 Z
+date: 2018-03-23 00:00:00.000000000 Z
 dependencies: []
 description: It can be used for defining an interface for other loggers
 email:
@@ -29,7 +29,6 @@ files:
 - Gemfile.lock
 - MIT-LICENCE
 - README.md
-- Rakefile
 - lib/null_logger.rb
 - lib/null_logger/version.rb
 - null-logger.gemspec
@@ -53,7 +52,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: A simple logger that does not log anything.

data/Rakefile

@@ -1,10 +0,0 @@
-# frozen_string_literal: true
-
-require 'bundler'
-require 'bundler/gem_tasks'
-require 'rspec/core/rake_task'
-require 'rake'
-
-RSpec::Core::RakeTask.new(:spec)
-
-task default: :spec