nucop 0.2.1 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 14bc7f191ad6c8221ad7972a133c06769a07374e7350780f5fb69c060705b8d5
-  data.tar.gz: f1f988c516834dd83e32413732ec0bd37d628e86f96305cd86259867fef83982
+  metadata.gz: fde4a27e2e094af7f2a2de1d873cea9463b75b2353bde9e05fcd4b75063c42a5
+  data.tar.gz: c5a4366a50cd466df74cd7f0acbfd20ff8d6176d1f8860ee2d892c063b219ab3
 SHA512:
-  metadata.gz: 97bbda786921fe144b953367e0d5f50dc0a861f1239dd7723897fc01bc748428fc46ba41c39a7d2e46a849df036e064d19e697276cad97a350f621cc17fd83fd
-  data.tar.gz: 249ff5a852cb65c07de634e9c2c48a00a508ffece0dc5a03425e30b4c965d323a7343a1ff0a8afe21d5d3f10116e3a90ffa6722c81f7e6913a6de4d5be31c54d
+  metadata.gz: 5ec9ddc75385fc1c688b466405b9fabb1ed947e7065f4c18f756a818f9b6fb2b3320f4989d175e06267753a839a7082f078c0767e57cad83482dc21fa60d1984
+  data.tar.gz: d0e634dc581092f4b455ef72dc3520be75e6b152670affb3fb60426bb5e30a5ddcacad74f449df0eed5f2fee821d11e1bebbbce41203c3ffd808d3a81b092366

data/bin/nucop

@@ -5,4 +5,4 @@ $LOAD_PATH.unshift("#{__dir__}/../lib")
 require "nucop"
 require "nucop/cli"
 
-Nucop::CLI.start(ARGV)
+Nucop::Cli.start(ARGV)

data/lib/nucop.rb

@@ -3,9 +3,9 @@ require "nucop/version"
 require "rubocop"
 require "git_diff_parser"
 
-Dir[File.join(__dir__, "nucop/helpers/**/*.rb")].each { |f| require f }
-Dir[File.join(__dir__, "nucop/formatters/**/*.rb")].each { |f| require f }
-Dir[File.join(__dir__, "nucop/cops/**/*.rb")].each { |f| require f }
+Dir[File.join(__dir__, "nucop/helpers/**/*.rb")].sort.each { |f| require f }
+Dir[File.join(__dir__, "nucop/formatters/**/*.rb")].sort.each { |f| require f }
+Dir[File.join(__dir__, "nucop/cops/**/*.rb")].sort.each { |f| require f }
 
 module Nucop
 end

data/lib/nucop/cli.rb

@@ -5,7 +5,7 @@ RUBOCOP_DEFAULT_CONFIG_FILE = ".rubocop.yml"
 CONFIGURATION_FILEPATH = ".nucop.yml"
 
 module Nucop
-  class CLI < Thor
+  class Cli < Thor
     desc "diff_enforced", "run RuboCop on the current diff using only the enforced cops"
     method_option "commit-spec", default: "origin/master", desc: "the commit used to determine the diff."
     method_option "auto-correct", type: :boolean, default: false, desc: "runs RuboCop with auto-correct option"
@@ -250,7 +250,9 @@ module Nucop
     end
 
     def enabled_cops
-      YAML.load(`bundle exec rubocop --parallel --show-cops`).select { |_, config| config["Enabled"] }.map(&:first)
+      YAML.load(`bundle exec rubocop --parallel --show-cops`) # rubocop:disable Security/YAMLLoad
+        .select { |_, config| config["Enabled"] }
+        .map(&:first)
     end
 
     # Override Thor's options method to include Nucop's options

data/lib/nucop/formatters/junit_formatter.rb

@@ -21,16 +21,17 @@ module Nucop
         # One test case per cop per file
         COPS.each do |cop|
           cop_offences = offences.select { |offence| offence.cop_name == cop.cop_name }
-          unless cop_offences.empty?
-            REXML::Element.new("testcase", @testsuite).tap do |f|
-              f.attributes["classname"] = file.gsub(/\.rb\Z/, "").gsub("#{Dir.pwd}/", "").tr("/", ".")
-              f.attributes["name"]      = "Rubocop: #{cop.cop_name}"
-              f.attributes["file"]      = cop.cop_name
-              cop_offences.each do |offence|
-                REXML::Element.new("failure", f).tap do |e|
-                  e.add_text("#{offence.message}\n\n")
-                  e.add_text(offence.location.to_s.sub("/usr/src/app/", ""))
-                end
+
+          next if cop_offences.empty?
+
+          REXML::Element.new("testcase", @testsuite).tap do |f|
+            f.attributes["classname"] = file.gsub(/\.rb\Z/, "").gsub("#{Dir.pwd}/", "").tr("/", ".")
+            f.attributes["name"] = "Rubocop: #{cop.cop_name}"
+            f.attributes["file"] = cop.cop_name
+            cop_offences.each do |offence|
+              REXML::Element.new("failure", f).tap do |e|
+                e.add_text("#{offence.message}\n\n")
+                e.add_text(offence.location.to_s.sub("/usr/src/app/", ""))
               end
             end
           end

data/lib/nucop/helpers/factory_bot_helper.rb

@@ -1,7 +1,7 @@
 module Nucop
   module Helpers
     module FactoryBotHelper
-      extend self
+      module_function
 
       FACTORY_BOT_METHODS = [
         :build,

data/lib/nucop/version.rb

@@ -1,3 +1,3 @@
 module Nucop
-  VERSION = "0.2.1"
+  VERSION = "0.3.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: nucop
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.3.0
 platform: ruby
 authors:
 - Jason Schweier
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-03-24 00:00:00.000000000 Z
+date: 2020-05-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.79.0
+        version: 0.83.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.79.0
+        version: 0.83.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
@@ -86,28 +86,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.4.1
+        version: 2.5.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.4.1
+        version: 2.5.2
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.37.0
+        version: 1.39.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.37.0
+        version: 1.39.0
 - !ruby/object:Gem::Dependency
   name: ruby-progressbar
   requirement: !ruby/object:Gem::Requirement
@@ -171,7 +171,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.3
 signing_key: 
 specification_version: 4
 summary: Nulogy's implementation of RuboCop, including custom cops and additional