nucop-cops 1.0.0 → 1.1.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (5) hide show
  1. checksums.yaml +4 -4
  2. data/lib/nucop/cops/release_toggles_use_symbols.rb +2 -2
  3. data/lib/nucop/version.rb +1 -1
  4. metadata +6 -34
  5. data/lib/nucop/cops/ordered_hash.rb +0 -36
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: 783eebd292d89fd9712f9f247249407e807afc0df09c20b5ed26bee92bab72fb
4
- data.tar.gz: f12a4a355141d167e466415a2e8818fc4ca41aba64c17ec072507ac272d77d85
3
+ metadata.gz: 7926ece63ad08f491378d847cae276f9b2e74eadfaf81f9ce571c2a3947e6f23
4
+ data.tar.gz: f51dc5b7d2593347f0ee4605e1a9263a1bac3aa0ebf9b59f6f88eadba9de2a86
5
5
  SHA512:
6
- metadata.gz: 9427af1245874bc0c1504dff7d004c51db2c39ca03c57806c4de2596597abc5ed4e298022d42de75888407544ab272d4d6bc51dbcc4628c729b7d463a542c99d
7
- data.tar.gz: 64620e5c1e287e7b38cadc2de0f709a777c338e1c369abcdabe07a104b06028cb99ad53c70b9c649df91eac22e74e73cd85f7f251683b1114c81f61a15d2e577
6
+ metadata.gz: ffe9a291cfde91f8a6e484f7e376f6a38a90726e54d5f1428e81a189773a605196ee4c414c16e840dc8ebf394f3a956a7fda3485b835508c81cd111619490e1c
7
+ data.tar.gz: 93267c24b8425b2bf9b64097236f59157bd359affda1eeae1bf4921cf7a40998cd5e10b66ab5a3c1c1bd89bac9633e32306653d0497666436b9022d6ae26850e
data/lib/nucop/cops/release_toggles_use_symbols.rb CHANGED
@@ -30,9 +30,9 @@ module Nucop
30
30
  PATTERN
31
31
 
32
32
  def on_send(node)
33
- test_helper?(node) { add_offense(node, message: MSG, location: node.children[2].loc.expression) }
33
+ test_helper?(node) { add_offense(node.children[2], message: MSG) }
34
34
  release_toggles_public_api_method?(node) do
35
- add_offense(node, message: MSG, location: node.children[2].loc.expression) do |corrector|
35
+ add_offense(node.children[2], message: MSG) do |corrector|
36
36
  toggle_name = node.children[2].value
37
37
 
38
38
  corrector.replace(node.children[2].source_range, ":#{toggle_name}")
data/lib/nucop/version.rb CHANGED
@@ -1,3 +1,3 @@
1
1
  module Nucop
2
- VERSION = "1.0.0"
2
+ VERSION = "1.1.0"
3
3
  end
metadata CHANGED
@@ -1,9 +1,10 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: nucop-cops
3
3
  version: !ruby/object:Gem::Version
4
- version: 1.0.0
4
+ version: 1.1.0
5
5
  platform: ruby
6
6
  authors:
7
+ - Jason Cheong-Kee-You
7
8
  - Jason Schweier
8
9
  bindir: bin
9
10
  cert_chain: []
@@ -15,42 +16,14 @@ dependencies:
15
16
  requirements:
16
17
  - - "~>"
17
18
  - !ruby/object:Gem::Version
18
- version: '1.66'
19
+ version: '1.84'
19
20
  type: :runtime
20
21
  prerelease: false
21
22
  version_requirements: !ruby/object:Gem::Requirement
22
23
  requirements:
23
24
  - - "~>"
24
25
  - !ruby/object:Gem::Version
25
- version: '1.66'
26
- - !ruby/object:Gem::Dependency
27
- name: rake
28
- requirement: !ruby/object:Gem::Requirement
29
- requirements:
30
- - - "~>"
31
- - !ruby/object:Gem::Version
32
- version: '13.2'
33
- type: :development
34
- prerelease: false
35
- version_requirements: !ruby/object:Gem::Requirement
36
- requirements:
37
- - - "~>"
38
- - !ruby/object:Gem::Version
39
- version: '13.2'
40
- - !ruby/object:Gem::Dependency
41
- name: rspec
42
- requirement: !ruby/object:Gem::Requirement
43
- requirements:
44
- - - "~>"
45
- - !ruby/object:Gem::Version
46
- version: '3.13'
47
- type: :development
48
- prerelease: false
49
- version_requirements: !ruby/object:Gem::Requirement
50
- requirements:
51
- - - "~>"
52
- - !ruby/object:Gem::Version
53
- version: '3.13'
26
+ version: '1.84'
54
27
  email:
55
28
  - jasons@nulogy.com
56
29
  executables: []
@@ -61,7 +34,6 @@ files:
61
34
  - lib/nucop/cops/explicit_factory_bot_usage.rb
62
35
  - lib/nucop/cops/no_core_method_overrides.rb
63
36
  - lib/nucop/cops/no_wip_specs.rb
64
- - lib/nucop/cops/ordered_hash.rb
65
37
  - lib/nucop/cops/release_toggles_use_symbols.rb
66
38
  - lib/nucop/cops/shadowing_factory_bot_creation_methods.rb
67
39
  - lib/nucop/helpers/factory_bot_helper.rb
@@ -82,14 +54,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
82
54
  requirements:
83
55
  - - ">="
84
56
  - !ruby/object:Gem::Version
85
- version: '3.2'
57
+ version: '3.4'
86
58
  required_rubygems_version: !ruby/object:Gem::Requirement
87
59
  requirements:
88
60
  - - ">="
89
61
  - !ruby/object:Gem::Version
90
62
  version: '0'
91
63
  requirements: []
92
- rubygems_version: 4.0.4
64
+ rubygems_version: 4.0.5
93
65
  specification_version: 4
94
66
  summary: Custom RuboCop cops for Nulogy's Ruby projects.
95
67
  test_files: []
data/lib/nucop/cops/ordered_hash.rb DELETED
@@ -1,36 +0,0 @@
1
- module Nucop
2
- # This cop looks for usages of `ActiveSupport::OrderedHash`
3
- #
4
- # Hashes in Ruby (since 1.9) enumerate their keys in the order they are
5
- # inserted:
6
- #
7
- # "Hashes enumerate their values in the order that the corresponding keys were inserted."
8
- # http://ruby-doc.org/core-2.1.6/Hash.html
9
- #
10
- # @example
11
- #
12
- # # bad
13
- #
14
- # hash = ActiveSupport::OrderedHash.new
15
- #
16
- # # good
17
- #
18
- # hash = {}
19
- class OrderedHash < ::RuboCop::Cop::Base
20
- extend RuboCop::Cop::AutoCorrector
21
-
22
- MSG = "Ruby hashes after 1.9 enumerate keys in order of insertion"
23
-
24
- def_node_matcher :ordered_hash_usage, <<~PATTERN
25
- (send (const (const nil? :ActiveSupport) :OrderedHash) :new)
26
- PATTERN
27
-
28
- def on_send(node)
29
- ordered_hash_usage(node) do
30
- add_offense(node, message: MSG) do |corrector|
31
- corrector.replace(node.source_range, "{}")
32
- end
33
- end
34
- end
35
- end
36
- end