ns-options 1.0.0.rc3 → 1.0.0.rc4

data/lib/ns-options/namespace_data.rb

@@ -131,11 +131,10 @@ module NsOptions
       elsif is_option_reader?(dslm)
         get_option(dslm.name)
       elsif is_option_writer?(dslm)
-        # TODO: remove same-named opt/ns when adding the other with same name
         add_option(dslm.name) unless has_option?(dslm.name)
         begin
           set_option(dslm.name, dslm.data)
-        rescue NsOptions::Option::CoerceError
+        rescue NsOptions::Option::CoerceError => err
           error! bt, err # reraise this exception with a sane backtrace
         end
       else # namespace writer or unknown

data/lib/ns-options/option.rb

@@ -93,6 +93,8 @@ module NsOptions
         if [ ::Integer, ::Float, ::String ].include?(self.type_class)
           # ruby type conversion, i.e. String(1)
           Object.send(self.type_class.to_s, value)
+        elsif self.type_class == ::Fixnum
+          Object.send('Integer', value)
         elsif self.type_class == ::Symbol
           value.to_sym
         elsif self.type_class == ::Array

data/lib/ns-options/version.rb

@@ -1,3 +1,3 @@
 module NsOptions
-  VERSION = "1.0.0.rc3"
+  VERSION = "1.0.0.rc4"
 end

data/test/unit/namespace_tests.rb

@@ -44,7 +44,7 @@ class NsOptions::Namespace
   class OptionTests < BaseTests
     desc "when adding an option named `something`"
     setup do
-      @added_opt = @namespace.option('something', String, { :default => true })
+      @added_opt = @namespace.option('something', Fixnum, { :default => 1 })
     end
 
     should "have added an option to the namespace" do
@@ -52,8 +52,8 @@ class NsOptions::Namespace
 
       opt = subject.__data__.child_options[:something]
       assert_equal 'something',  opt.name
-      assert_equal String,  opt.type_class
-      assert_equal true, opt.rules[:default]
+      assert_equal Fixnum,  opt.type_class
+      assert_equal 1, opt.rules[:default]
     end
 
     should "return the option it added" do
@@ -86,13 +86,24 @@ class NsOptions::Namespace
     end
 
     should "be writable through the defined writer" do
-      assert_nothing_raised{ subject.something = "abc" }
-      assert_equal "abc", subject.something
+      assert_nothing_raised{ subject.something = 2 }
+      assert_equal 2, subject.something
     end
 
     should "be writable through the reader with args" do
-      assert_nothing_raised{ subject.something "123" }
-      assert_equal "123", subject.something
+      assert_nothing_raised{ subject.something 3 }
+      assert_equal 3, subject.something
+    end
+
+    should "raise CoerceError when writing values not coercable to the type class" do
+      err = begin
+        subject.something = "can't be coerced to a Fixnum!"
+      rescue Exception => err
+        err
+      end
+
+      assert_equal NsOptions::Option::CoerceError,  err.class
+      assert_included 'test/unit/namespace_tests.rb:', err.backtrace.first
     end
 
   end

data/test/unit/option_tests.rb

@@ -190,29 +190,94 @@ class NsOptions::Option
 
   end
 
-  class WithNativeTypeClassTests < BaseTests
-    desc "with a native type class (Float)"
+  class WithIntegerTypeClassTests < BaseTests
+    desc "with an Integer type class"
+    setup do
+      @option = NsOptions::Option.new(:something, Integer)
+    end
+    subject{ @option }
+
+    should "allow setting it's value" do
+      subject.value = 12
+      assert_equal 12, subject.value
+    end
+
+    should "allow setting it's value with a string and convert it" do
+      subject.value = "13"
+      assert_equal "13".to_i, subject.value
+    end
+
+  end
+
+  class WithFixnumTypeClassTests < BaseTests
+    desc "with a Fixnum type class"
+    setup do
+      @option = NsOptions::Option.new(:something, Fixnum)
+    end
+    subject{ @option }
+
+    should "allow setting it's value" do
+      subject.value = 12
+      assert_equal 12, subject.value
+    end
+
+    should "allow setting it's value with a string and convert it" do
+      subject.value = "13"
+      assert_equal "13".to_i, subject.value
+    end
+
+  end
+
+  class WithFloatTypeClassTests < BaseTests
+    desc "with a Float type class"
     setup do
       @option = NsOptions::Option.new(:something, Float)
     end
     subject{ @option }
 
-    should "allow setting it's value with a float" do
-      new_value = 12.5
-      subject.value = new_value
-      assert_equal new_value, subject.value
+    should "allow setting it's value" do
+      subject.value = 12.5
+      assert_equal 12.5, subject.value
     end
 
     should "allow setting it's value with a string and convert it" do
-      new_value = "13.4"
-      subject.value = new_value
-      assert_equal new_value.to_f, subject.value
+      subject.value = "13.4"
+      assert_equal "13.4".to_f, subject.value
     end
 
     should "allow setting it's value with an integer and convert it" do
-      new_value = 1
-      subject.value = new_value
-      assert_equal new_value.to_f, subject.value
+      subject.value = 1
+      assert_equal 1.to_f, subject.value
+    end
+
+  end
+
+  class WithStringTypeClassTests < BaseTests
+    desc "with an String type class"
+    setup do
+      @option = NsOptions::Option.new(:something, String)
+    end
+    subject{ @option }
+
+    should "allow setting it's value" do
+      subject.value = "12"
+      assert_equal "12", subject.value
+    end
+
+    should "allow setting it's value with a numeric and convert it" do
+      subject.value = 13
+      assert_equal 13.to_s, subject.value
+
+      subject.value = 13.5
+      assert_equal 13.5.to_s, subject.value
+    end
+
+    should "allow setting it's value with other things and convert it" do
+      subject.value = true
+      assert_equal true.to_s, subject.value
+
+      subject.value = NsOptions
+      assert_equal NsOptions.to_s, subject.value
     end
 
   end
@@ -300,7 +365,7 @@ class NsOptions::Option
       @option = NsOptions::Option.new(:something, SuperSuperTestTest)
     end
 
-    should "reraise the arg error, with a custom message and backtrace" do
+    should "reraise as a CoerceError with a custom message and backtrace" do
       err = begin
         @option.value = "arg error should be raised"
       rescue Exception => err

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification 
 name: ns-options
 version: !ruby/object:Gem::Version 
-  hash: 1486472869
+  hash: -1768309136
   prerelease: 6
   segments: 
   - 1
   - 0
   - 0
   - rc
-  - 3
-  version: 1.0.0.rc3
+  - 4
+  version: 1.0.0.rc4
 platform: ruby
 authors: 
 - Collin Redding
@@ -18,7 +18,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-11-29 00:00:00 Z
+date: 2012-12-03 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: assert