npm-pipeline-rails 1.3.0 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e04615211140d67774af0ad6d62705b210d7fe0a
-  data.tar.gz: 0857f5f24eeb6012f9f87ba96d8d065614e8127c
+  metadata.gz: 3e7d1f0bbbc5528467366b105a01c0cd3902810d
+  data.tar.gz: 10bb84ce836e8cf1981d6e7db3a2824817076362
 SHA512:
-  metadata.gz: 067dee14278cebeb98f2132df66e65683ecf70473b2c181dc01e6875f1759b4fc3b380223c0ce229d761582c9f9c0383a80c6cc874a5405182ea4591d6bf5380
-  data.tar.gz: 47eb06a1433e22d9e508def1e9d7b44caef4fe2bd5e8c3db2d6289cf158d17c6eee8ff82eb78ecde6c20217bef31cf6e57e9771afabb5bb564ad27b4141cef60
+  metadata.gz: dd7fc64611ecc66733d8fbc682a886ae7d65a0b420849159bf90b98078a01a2b2cd9e6adcec8e9ae59cd2bc0e50f0efa3b456851736af7d8701c341e61e51730
+  data.tar.gz: a0d4c0359e2f916321f9c03e9266f569a0c1850d26332714b68bfd78be4f7510a44b2d610c1e4f0c821559595281ab6ab43d46615cdc017ec723666fc8752045

data/HISTORY.md

@@ -1,3 +1,10 @@
+## [v1.4.0]
+> Apr 20, 2016
+
+- [#3] - Prevent orphaned processes from accumulating. ([#4])
+
+[v1.4.0]: https://github.com/rstacruz/npm-pipeline-rails/compare/v1.3.0...v1.4.0
+
 ## [v1.3.0]
 > Apr 11, 2016
 
@@ -49,3 +56,5 @@
 [v1.0.0]: https://github.com/rstacruz/npm-pipeline-rails/tree/v1.0.0
 [#1]: https://github.com/rstacruz/npm-pipeline-rails/issues/1
 [@victorsolis]: https://github.com/victorsolis
+[#3]: https://github.com/rstacruz/npm-pipeline-rails/issues/3
+[#4]: https://github.com/rstacruz/npm-pipeline-rails/issues/4

data/lib/npm-pipeline-rails/railtie.rb

@@ -3,17 +3,35 @@ require 'rails/railtie'
 
 module NpmPipelineRails
   module Utils
+    module_function
+
+    def log(str)
+      ::Rails.logger.debug "[npm-pipeline-rails] #{str}"
+    end
+
     def do_system(commands)
       [*commands].each do |cmd|
+        Utils.log "starting '#{cmd}'"
         system cmd
+        Utils.log "'#{cmd}' exited with #{$?.exitstatus} status"
         exit $?.exitstatus unless $?.exitstatus == 0
       end
     end
+
+    # Runs a block in the background. When the parent exits, the child
+    # will be asked to exit as well.
+    def background(name, &blk)
+      pid = fork(&blk)
+
+      at_exit do
+        Utils.log "Terminating '#{name}' [#{pid}]"
+        Process.kill 'TERM', pid
+        Process.wait pid
+      end
+    end
   end
 
   class Railtie < ::Rails::Railtie
-    include ::NpmPipelineRails::Utils
-
     config.npm = ActiveSupport::OrderedOptions.new
     config.npm.build = ['npm run build']
     config.npm.watch = ['npm run start']
@@ -23,8 +41,8 @@ module NpmPipelineRails
       namespace :assets do
         desc 'Build asset prerequisites using npm'
         task :npm_build do
-          do_system app.config.npm.install
-          do_system app.config.npm.build
+          Utils.do_system app.config.npm.install
+          Utils.do_system app.config.npm.build
         end
 
         task(:precompile).enhance ['npm_build']
@@ -33,9 +51,9 @@ module NpmPipelineRails
 
     initializer 'npm_pipeline.watch' do |app|
       if ::Rails.env.development? && ::Rails.const_defined?(:Server)
-        do_system app.config.npm.install
+        Utils.do_system app.config.npm.install
         [*app.config.npm.watch].each do |cmd|
-          fork { do_system [cmd] }
+          Utils.background(cmd) { Utils.do_system [cmd] }
         end
       end
     end

data/lib/npm-pipeline-rails/version.rb

@@ -1,3 +1,3 @@
 module NpmPipelineRails
-  VERSION = '1.3.0'
+  VERSION = '1.4.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: npm-pipeline-rails
 version: !ruby/object:Gem::Version
-  version: 1.3.0
+  version: 1.4.0
 platform: ruby
 authors:
 - Rico Sta. Cruz
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-04-11 00:00:00.000000000 Z
+date: 2016-04-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties