noun-project-api 3.1.4 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f43cae5a5e16a45628ad844b61e15211f7902041afc2a1b1369b8cc86c06503b
-  data.tar.gz: 2ff960d4e37127d4866539de095839efad0cd2e8fcebea0121bcb735a68e0d44
+  metadata.gz: a54ae4b1729039cd83078fb3539983ddcaab4a917ec5d0b24a72f83cd4a53e24
+  data.tar.gz: 03f70103a7b43842c63bb75a84f59103c1b13ae429daf2e8e04bf9f2b0d6dd43
 SHA512:
-  metadata.gz: d4fb060b8c726a202549af2f0394f5d4cb781cccf7bcc70ffb13ae635eb68a848096bbe2702ec41a5eac3545e5edc8dce7c2c358d288cc597596799dcfe22a10
-  data.tar.gz: f205f52af9969a615bc4a72683ef461a3db852699c73aa229ed8fed729aa56c0ebd6ece29d33f355015421fc5a4439e768e3c60fe7b7f0d99e6c23e88385b484
+  metadata.gz: 9a466dc9016b91a523ce7828bd3708264c84ade3130f32771a37581cd5686ad6673de50089d92d24977bd07b257c23f189cd5d1b2857155315a8d38ac1a25305
+  data.tar.gz: da1ab9bf4ebfa2fd397e846d7a2d21a3ec70b1399d5b985f0c5f88a6d653b7961c22febff08a4588f508bd107c850428bbac617c23e3e482a7a200ddca9445cd

data/lib/noun_project_api/base_item.rb

@@ -4,6 +4,7 @@ module NounProjectApi
   # A basis to Items returned by the noun project.
   class BaseItem
     attr_accessor :original_hash
+
     ITEM_NAME = nil
 
     def initialize(origin)

data/lib/noun_project_api/collection.rb

@@ -25,10 +25,10 @@ module NounProjectApi
 
     def to_hash
       {
-        id: id,
-        author_id: author_id,
-        author_name: author_name,
-        icon_count: icon_count,
+        id:,
+        author_id:,
+        author_name:,
+        icon_count:,
         published: published?
       }
     end

data/lib/noun_project_api/icon.rb

@@ -31,7 +31,7 @@ module NounProjectApi
 
     def to_hash
       {
-        id: id,
+        id:,
         preview_url_200: preview_url(PREVIEW_SIZE_200),
         preview_url_84: preview_url(PREVIEW_SIZE_84),
         preview_url_42: preview_url(PREVIEW_SIZE_42)

data/lib/noun_project_api/icons_retriever.rb

@@ -19,17 +19,14 @@ module NounProjectApi
       NounProjectApi.configuration.cache.fetch(cache_key, expires_in: cache_ttl) do
         raise ArgumentError, "Missing search term" unless term
 
-        search = OAuth::Helper.escape(term)
-        search += "?limit_to_public_domain=#{NounProjectApi.configuration.public_domain ? 1 : 0}"
-
         args = {
-          "limit" => limit,
-          "offset" => offset,
-          "page" => page
-        }.reject { |_, v| v.nil? }
-        args.each { |k, v| search += "&#{k}=#{v}" } unless args.empty?
+          limit_to_public_domain: NounProjectApi.configuration.public_domain ? 1 : 0,
+          limit:,
+          offset:,
+          page:
+        }.compact
 
-        result = access_token.get("#{API_BASE}#{API_PATH}#{search}")
+        result = access_token.get("#{API_BASE}#{API_PATH}#{OAuth::Helper.escape(term)}?#{args.to_query}")
         raise ServiceError.new(result.code, result.body) unless ["200", "404"].include? result.code
 
         if result.code == "200"
@@ -46,18 +43,12 @@ module NounProjectApi
     # * page - page number
     def recent_uploads(limit = nil, offset = nil, page = nil)
       args = {
-        "limit" => limit,
-        "offset" => offset,
-        "page" => page
-      }.reject { |_, v| v.nil? }
-      if !args.empty?
-        search = "?"
-        args.each { |k, v| search += "#{k}=#{v}&" }
-      else
-        search = ""
-      end
+        limit:,
+        offset:,
+        page:
+      }.compact
 
-      result = access_token.get("#{API_BASE}#{API_PATH}recent_uploads#{search}")
+      result = access_token.get("#{API_BASE}#{API_PATH}recent_uploads?#{args.to_query}")
       raise ServiceError.new(result.code, result.body) unless result.code == "200"
 
       JSON.parse(result.body, symbolize_names: true)[:recent_uploads].map { |icon| Icon.new(icon) }

data/lib/noun_project_api.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require "oauth"
-require "active_support"
+require "active_support/all"
 require "json"
 require "noun_project_api/errors"
 require "noun_project_api/connection"

data/spec/lib/noun_project_api/icons_retriever_spec.rb

@@ -18,7 +18,7 @@ RSpec.describe NounProjectApi::IconsRetriever do
       expect(@icons.access_token).to receive(
         :get
       ).with(
-        "#{NounProjectApi::API_BASE}#{NounProjectApi::IconsRetriever::API_PATH}recent_uploads"
+        "#{NounProjectApi::API_BASE}#{NounProjectApi::IconsRetriever::API_PATH}recent_uploads?"
       ).and_return(
         valid_response
       )
@@ -41,7 +41,7 @@ RSpec.describe NounProjectApi::IconsRetriever do
       expect(@icons.access_token).to receive(
         :get
       ).with(
-        "#{NounProjectApi::API_BASE}#{NounProjectApi::IconsRetriever::API_PATH}recent_uploads?limit=#{limit}&"
+        "#{NounProjectApi::API_BASE}#{NounProjectApi::IconsRetriever::API_PATH}recent_uploads?limit=#{limit}"
       ).and_return(
         valid_response
       )
@@ -141,7 +141,7 @@ RSpec.describe NounProjectApi::IconsRetriever do
       expect(@icons.access_token).to receive(
         :get
       ).with(
-        "#{NounProjectApi::API_BASE}#{NounProjectApi::IconsRetriever::API_PATH}#{OAuth::Helper.escape(term)}?limit_to_public_domain=0&limit=#{limit}"
+        "#{NounProjectApi::API_BASE}#{NounProjectApi::IconsRetriever::API_PATH}#{OAuth::Helper.escape(term)}?limit=#{limit}&limit_to_public_domain=0"
       ).and_return(
         valid_response
       )

data/spec/spec_helper.rb

@@ -2,7 +2,6 @@
 
 require "bundler/setup"
 require "noun_project_api"
-require "pry"
 require "faker"
 require "json"
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: noun-project-api
 version: !ruby/object:Gem::Version
-  version: 3.1.4
+  version: 4.0.0
 platform: ruby
 authors:
 - Tailor Engineering
@@ -30,42 +30,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.5'
+        version: '1.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.5'
+        version: '1.1'
 - !ruby/object:Gem::Dependency
   name: faker
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.13'
+        version: '3.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.13'
-- !ruby/object:Gem::Dependency
-  name: pry
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.13'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.13'
+        version: '3.1'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -86,42 +72,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.9'
+        version: '3.12'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.9'
+        version: '3.12'
 - !ruby/object:Gem::Dependency
-  name: rspec_junit_formatter
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.4'
+        version: '1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.4'
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 0.79.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '='
-      - !ruby/object:Gem::Version
-        version: 0.79.0
+        version: '1'
 description: A Gem to expose a wrapping API for The Noun Project API's
 email: sloths@tailorbrands.com
 executables: []
@@ -163,7 +135,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '3.2'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="