noun-project-api 2.0.1 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bbb311ca73f82163024bcb0df6be86691aa3a330a92633e1a4aa88d6f205f572
-  data.tar.gz: 5ca5acd613a7182f320cf4b70fd5f4d3a4a255ce5f3a8673df71a6cb39cc97c0
+  metadata.gz: dc6c2457656761dd7e1bed16e52f00c5558a4f632a354f3fa7c626b90664b09b
+  data.tar.gz: 184f196a2a7d1da39cc8988d0f7384374220a12a66cb495c06d52a53a3ee74ae
 SHA512:
-  metadata.gz: c6c535dc993850089e01b5fd9e3bfa586d89844abd033f5f09ea29f2bf4626a39405d1506a64ee5e89de71ece597811bfa3e37a5b8ed3c64ca194e9e03298bb8
-  data.tar.gz: c312621d5e9be931e6634af8f9869754b67360bd53abdf4720f395c7ad2b13a54656db7f60414f893ce087dae7bf20ff37e99b26caab8f4dc714446d5bdf7fc4
+  metadata.gz: cf73f5f81a56f940567d2bff8b9dbeb0631d9e7f32f973bf5a29a2f541356420e5651a3c2d48705cd6823890a18d9f71ca2b45c4ad709fe80fad72c8ae41e473
+  data.tar.gz: ae830b9869b6b10dea4b2287d511f7274692b6875776074d9c46eb5a706f0f63e984088eccb07b938087bbe943904ef4cc68762b74eee195db6c883985245bcf

data/lib/noun-project-api.rb

@@ -1,4 +1,5 @@
 require "oauth"
+require "active_support"
 require "json"
 require "noun-project-api/errors"
 require "noun-project-api/connection"
@@ -24,10 +25,11 @@ module NounProjectApi
 
   # Main configuration class.
   class Configuration
-    attr_accessor :public_domain
+    attr_accessor :public_domain, :cache
 
     def initialize
       @public_domain = false
+      @cache = ActiveSupport::Cache::NullStore.new
     end
   end
 end

data/lib/noun-project-api/icons_retriever.rb

@@ -11,25 +11,29 @@ module NounProjectApi
     # * offset - offset the results
     # * page - page number
     def find(term, limit = nil, offset = nil, page = nil)
-      raise ArgumentError.new("Missing search term") unless term
+      cache_key = Digest::MD5.hexdigest("#{term}+#{limit}+#{offset}+#{page}")
 
-      search = OAuth::Helper.escape(term)
-      search += "?limit_to_public_domain=#{NounProjectApi.configuration.public_domain ? 1 : 0}"
+      NounProjectApi.configuration.cache.fetch(cache_key) do
+        raise ArgumentError.new("Missing search term") unless term
 
-      args = {
-        "limit" => limit,
-        "offset" => offset,
-        "page" => page
-      }.reject { |_, v| v.nil? }
-      args.each { |k, v| search += "&#{k}=#{v}" } if args.size > 0
+        search = OAuth::Helper.escape(term)
+        search += "?limit_to_public_domain=#{NounProjectApi.configuration.public_domain ? 1 : 0}"
 
-      result = access_token.get("#{API_BASE}#{API_PATH}#{search}")
-      raise ServiceError.new(result.code, result.body) unless %w(200 404).include? result.code
+        args = {
+          "limit" => limit,
+          "offset" => offset,
+          "page" => page
+        }.reject { |_, v| v.nil? }
+        args.each { |k, v| search += "&#{k}=#{v}" } if args.size > 0
 
-      if result.code == "200"
-        JSON.parse(result.body)["icons"].map { |icon| Icon.new(icon) }
-      else
-        []
+        result = access_token.get("#{API_BASE}#{API_PATH}#{search}")
+        raise ServiceError.new(result.code, result.body) unless %w(200 404).include? result.code
+
+        if result.code == "200"
+          JSON.parse(result.body)["icons"].map { |icon| Icon.new(icon) }
+        else
+          []
+        end
       end
     end
 

data/spec/lib/noun-project-api/collection_retriever_spec.rb

@@ -3,7 +3,7 @@ require "ostruct"
 
 RSpec.describe NounProjectApi::CollectionRetriever do
   before :each do
-    @collection = NounProjectApi::CollectionRetriever.new(Faker::Internet.password(16), Faker::Internet.password(16))
+    @collection = NounProjectApi::CollectionRetriever.new(Faker::Internet.password(min_length: 16), Faker::Internet.password(min_length: 16))
     @valid_hash = JSON.parse(Fakes::Results::COLLECTION_VALID)
     @valid_response = OpenStruct.new(
       body: Fakes::Results::COLLECTION_VALID,

data/spec/lib/noun-project-api/icon_retriever_spec.rb

@@ -3,7 +3,7 @@ require "ostruct"
 
 RSpec.describe NounProjectApi::IconRetriever do
   before :each do
-    @icon = NounProjectApi::IconRetriever.new(Faker::Internet.password(16), Faker::Internet.password(16))
+    @icon = NounProjectApi::IconRetriever.new(Faker::Internet.password(min_length: 16), Faker::Internet.password(min_length: 16))
     @valid_hash = JSON.parse(Fakes::Results::ICON_VALID)
     @valid_response = OpenStruct.new(
       body: Fakes::Results::ICON_VALID,

data/spec/lib/noun-project-api/icons_retriever_spec.rb

@@ -2,7 +2,7 @@ require "spec_helper"
 
 RSpec.describe NounProjectApi::IconsRetriever do
   before :each do
-    @icons = NounProjectApi::IconsRetriever.new(Faker::Internet.password(16), Faker::Internet.password(16))
+    @icons = NounProjectApi::IconsRetriever.new(Faker::Internet.password(min_length: 16), Faker::Internet.password(min_length: 16))
   end
 
   context "recent uploads" do

data/spec/lib/noun-project-api/reporter_spec.rb

@@ -2,16 +2,16 @@ require "spec_helper"
 
 RSpec.describe NounProjectApi::Reporter do
   it "raises an error when initialized without token" do
-    expect { NounProjectApi::Reporter.new(nil, Faker::Internet.password(16)) }.to raise_error(ArgumentError)
+    expect { NounProjectApi::Reporter.new(nil, Faker::Internet.password(min_length: 16)) }.to raise_error(ArgumentError)
   end
 
   it "raises an error when initialized without secret" do
-    expect { NounProjectApi::Reporter.new(Faker::Internet.password(16), nil) }.to raise_error(ArgumentError)
+    expect { NounProjectApi::Reporter.new(Faker::Internet.password(min_length: 16), nil) }.to raise_error(ArgumentError)
   end
 
   it "initializes the values properly" do
-    token = Faker::Internet.password(16)
-    secret = Faker::Internet.password(16)
+    token = Faker::Internet.password(min_length: 16)
+    secret = Faker::Internet.password(min_length: 16)
     reporter = NounProjectApi::Reporter.new(token, secret)
 
     expect(reporter.token).to eq(token)
@@ -20,8 +20,8 @@ RSpec.describe NounProjectApi::Reporter do
 
   context "reports ids usage" do
     before :each do
-      token = Faker::Internet.password(16)
-      secret = Faker::Internet.password(16)
+      token = Faker::Internet.password(min_length: 16)
+      secret = Faker::Internet.password(min_length: 16)
       @reporter = NounProjectApi::Reporter.new(token, secret)
     end
 

data/spec/lib/noun-project-api/retriever_spec.rb

@@ -2,16 +2,16 @@ require "spec_helper"
 
 RSpec.describe NounProjectApi::Retriever do
   it "raises an error when initialized without token" do
-    expect { NounProjectApi::Retriever.new(nil, Faker::Internet.password(16)) }.to raise_error(ArgumentError)
+    expect { NounProjectApi::Retriever.new(nil, Faker::Internet.password(min_length: 16)) }.to raise_error(ArgumentError)
   end
 
   it "raises an error when initialized without secret" do
-    expect { NounProjectApi::Retriever.new(Faker::Internet.password(16), nil) }.to raise_error(ArgumentError)
+    expect { NounProjectApi::Retriever.new(Faker::Internet.password(min_length: 16), nil) }.to raise_error(ArgumentError)
   end
 
   it "initializes the values properly" do
-    token = Faker::Internet.password(16)
-    secret = Faker::Internet.password(16)
+    token = Faker::Internet.password(min_length: 16)
+    secret = Faker::Internet.password(min_length: 16)
     retriever = NounProjectApi::Retriever.new(token, secret)
 
     expect(retriever.token).to eq(token)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: noun-project-api
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 3.0.0
 platform: ruby
 authors:
 - Nadav Shatz
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-09-06 00:00:00.000000000 Z
+date: 2020-07-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: oauth
@@ -24,48 +24,62 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '0.5'
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.3'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '12.3'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.8'
+        version: '3.9'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.8'
+        version: '3.9'
 - !ruby/object:Gem::Dependency
   name: faker
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.9'
+        version: '2.13'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.9'
+        version: '2.13'
 - !ruby/object:Gem::Dependency
   name: semver
   requirement: !ruby/object:Gem::Requirement
@@ -100,14 +114,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.11'
+        version: '0.13'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.11'
+        version: '0.13'
 description: A Gem to expose a wrapping API for The Noun Project API's
 email: nadav@tailorbrands.com
 executables: []
@@ -141,7 +155,7 @@ homepage: https://github.com/TailorBrands/noun-project-api
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -156,9 +170,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
-signing_key: 
+rubygems_version: 3.1.2
+signing_key:
 specification_version: 4
 summary: An API wrapper for The Noun Project API's
 test_files: