notu 2.0.6 → 4.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 17025b3f45128e34a4b3783aaed736bd82db492214095ef237a2df2a7b5d91b4
-  data.tar.gz: fd8df3818f39aa8e9ef55fe574282101b180c978588139d68340bc9cf2b76ee7
+  metadata.gz: efbddd2bb568278da60c542fd1046d39a61d200bf1ca1a20614e7135ac07e66f
+  data.tar.gz: 4c14831c8b1526a402cf47870e64d17fb5e3ffa4b04d0f2ecaefb30d493de4e3
 SHA512:
-  metadata.gz: dd7ce60b42983046ce151511ef094697e329f14bea4000f60f3a54f73b257755102eb93ac7bbb3ae411d69bdbb7f5add631ea7b8e1dcc0cee98d94f3edad2018
-  data.tar.gz: 99e08c70c0dec86e1969ddc6e8a4d144894d0ebf1185e957f870ba2b3b2fdf9712605e787fe05c6021b86ee760037b750f22074a6538764e078e80d9028aa751
+  metadata.gz: 60c8869371be7e6b80a4b8f8b26ebfa2406f63cb576d7788cf6aeacb6d963c3f4d534455a5ae33bca7ea0a33236a0bb6ab529980fc3697ba302062e764f96d0c
+  data.tar.gz: 8343035fb3d9a5ce7e9bba05676f13b0265ace6f514e2e492aa5280eeae0ddc25990eb553adf39f698f66767f4da2d5a5d55523e6b04d2fef428cb47129ece3b

data/VERSION

@@ -1 +1 @@
-2.0.6
+4.0.0

data/lib/notu/api.rb

@@ -0,0 +1,25 @@
+module Notu
+
+  class Api
+
+    DEFAULT_KEY = '91f5d6a201de58e0c0a0d858573dddf0'.freeze
+    FORMAT = 'json'.freeze
+    HOST = 'ws.audioscrobbler.com'.freeze
+    VERSION = '2.0'.freeze
+
+    attr_reader :key
+
+    def initialize(key: DEFAULT_KEY)
+      @key = key.try(:squish).presence || raise(Error.new('API key must be specified'))
+    end
+
+    def url(params = {})
+      params = (params || {}).symbolize_keys
+      params.merge!(api_key: key, format: FORMAT)
+      query_string = params.map { |name, value| "#{CGI.escape(name.to_s)}=#{CGI.escape(value.to_s)}" }.join('&')
+      "https://#{HOST}/#{VERSION}?#{query_string}"
+    end
+
+  end
+
+end

data/lib/notu/http_download.rb

@@ -26,13 +26,13 @@ module Notu
           return response.body
         end
       end
-    rescue Net::ReadTimeout, Timeout::Error, Timeout::Error, Zlib::BufError => exception
-      raise NetworkError.new(exception) if options[:max_retries] < 1
+    rescue Timeout::Error, Zlib::BufError => e
+      raise NetworkError.new(e) if options[:max_retries] < 1
       options[:max_retries] -= 1
       sleep(options[:retry_sleep])
       get(url, options)
-    rescue => exception
-      raise NetworkError.new(exception)
+    rescue => e
+      raise NetworkError.new(e)
     end
 
   end

data/lib/notu/json_document.rb

@@ -0,0 +1,11 @@
+module Notu
+
+  module JsonDocument
+
+    def self.get(url, options = {})
+      JSON.parse(HttpDownload.get(url, options))
+    end
+
+  end
+
+end

data/lib/notu/library.rb

@@ -2,14 +2,11 @@ module Notu
 
   class Library
 
-    HOST = 'www.last.fm'.freeze
+    attr_reader :api, :username
 
-    attr_reader :username
-
-    def initialize(options = {})
-      @semaphore = Mutex.new
-      options = options.symbolize_keys
-      self.username = options[:username]
+    def initialize(username:, api: Api.new)
+      @api = api.presence || raise(Error.new('API must be specified'))
+      @username = username.try(:squish).presence || raise(Error.new('Username must be specified'))
     end
 
     def loved_tracks
@@ -20,38 +17,12 @@ module Notu
       MostPlayedTracks.new(self, options)
     end
 
-    def played_tracks
-      PlayedTracks.new(self)
-    end
-
-    def url(options = {})
-      options = options.symbolize_keys
-      path = options[:path].presence
-      query = options[:query].presence
-      query = options[:query].map { |name, value| "#{CGI.escape(name.to_s)}=#{CGI.escape(value.to_s)}" }.join('&') if options[:query].is_a?(Hash)
-      "https://#{HOST}/user/#{username}".tap do |url|
-        if path.present?
-          url << '/' unless path.starts_with?('/')
-          url << path
-        end
-        if query.present?
-          url << '?' << query
-        end
-      end
+    def recent_tracks
+      RecentTracks.new(self)
     end
 
-    private
-
-    def username=(value)
-      @semaphore.synchronize do
-        @username = value.to_s.strip.downcase
-        raise UnknownUsernameError.new(value) if username !~ /^[a-z0-9_]+$/
-        begin
-          HtmlDocument.get(url)
-        rescue
-          raise UnknownUsernameError.new(value)
-        end
-      end
+    def url(params = {})
+      api.url((params || {}).symbolize_keys.merge(user: username))
     end
 
   end

data/lib/notu/loved_tracks.rb

@@ -2,25 +2,33 @@ module Notu
 
   class LovedTracks
 
-    include Listing
+    include Enumerable
 
-    def each(&block)
+    attr_reader :library
+
+    def initialize(library)
+      raise ArgumentError.new("#{self.class}#library must be a library, #{library.inspect} given") unless library.is_a?(Library)
+      @library = library
+    end
+
+    def each
       return unless block_given?
-      page_urls.each do |url|
-        document = HtmlDocument.get(url)
-        (document/'table.chartlist tbody tr').each do |element|
-          artist = (element/'td.chartlist-artist a').first.try(:text) || next
-          title = (element/'td.chartlist-name a').first.try(:text) || next
-          yield(Track.new(artist: artist, title: title))
+      pages_count = nil
+      page = 1
+      loop do
+        json = JsonDocument.get(library.url(limit: 50, method: 'user.getLovedTracks', page:))
+        pages_count = json['lovedtracks']['@attr']['totalPages'].to_i
+        json['lovedtracks']['track'].each do |track_json|
+          artist = track_json['artist']['name'] || next
+          title = track_json['name'] || next
+          yield(Track.new(artist:, title:))
         end
+        page += 1
+        break if page > pages_count
       end
       nil
     end
 
-    def path
-      'loved'
-    end
-
   end
 
 end

data/lib/notu/most_played_tracks.rb

@@ -2,51 +2,44 @@ module Notu
 
   class MostPlayedTracks
 
-    include Listing
+    include Enumerable
 
-    PERIODS = {
-      '7 days' => 'LAST_7_DAYS',
-      '30 days' => 'LAST_30_DAYS',
-      '90 days' => 'LAST_90_DAYS',
-      '365 days' => 'LAST_365_DAYS',
-      'Overall' => '',
-    }
+    PERIODS = %w(overall 7day 1month 3month 6month 12month).freeze
 
-    attr_reader :period
+    attr_reader :library, :period
 
     def initialize(library, options = {})
-      super(library)
-      options = options.stringify_keys.reverse_merge('period' => PERIODS.keys.first)
-      self.period = options['period']
+      raise ArgumentError.new("#{self.class}#library must be a library, #{library.inspect} given") unless library.is_a?(Library)
+      @library = library
+      options = options.symbolize_keys.reverse_merge(period: PERIODS.first)
+      self.period = options[:period]
     end
 
-    def each(&block)
+    def each
       return unless block_given?
-      page_urls.each do |url|
-        document = HtmlDocument.get(url)
-        (document/'table.chartlist tbody tr').each do |element|
-          artist = (element/'td.chartlist-artist a').first.try(:text) || next
-          title = (element/'td.chartlist-name a').first.try(:text) || next
-          plays_count = (element/'td.chartlist-bar .chartlist-count-bar-value').text.gsub(/[^\d]/, '').presence || next
-          yield(Track.new(artist: artist, plays_count: plays_count, title: title))
+      pages_count = nil
+      page = 1
+      loop do
+        json = JsonDocument.get(library.url(limit: 50, method: 'user.getTopTracks', page:))
+        pages_count = json['toptracks']['@attr']['totalPages'].to_i
+        json['toptracks']['track'].each do |track_json|
+          artist = track_json['artist']['name'] || next
+          title = track_json['name'] || next
+          plays_count = track_json['playcount'] || next
+          yield(Track.new(artist:, plays_count:, title:))
         end
+        page += 1
+        break if page > pages_count
       end
       nil
     end
 
-    def params
-      { 'date_preset' => PERIODS[period] }
-    end
-
-    def path
-      'library/tracks'
-    end
-
     private
 
     def period=(value)
-      raise ArgumentError.new("Notu::MostPlayedTracks#period is invalid: #{value.inspect}") unless PERIODS.key?(value.to_s)
-      @period = value.to_s
+      string_value = value.to_s
+      raise ArgumentError.new("Notu::MostPlayedTracks#period is invalid: #{value.inspect}") unless PERIODS.include?(string_value)
+      @period = string_value
     end
 
   end

data/lib/notu/recent_tracks.rb

@@ -0,0 +1,34 @@
+module Notu
+
+  class RecentTracks
+
+    include Enumerable
+
+    attr_reader :library
+
+    def initialize(library)
+      raise ArgumentError.new("#{self.class}#library must be a library, #{library.inspect} given") unless library.is_a?(Library)
+      @library = library
+    end
+
+    def each
+      return unless block_given?
+      pages_count = nil
+      page = 1
+      loop do
+        json = JsonDocument.get(library.url(limit: 50, method: 'user.getRecentTracks', page:))
+        pages_count = json['recenttracks']['@attr']['totalPages'].to_i
+        json['recenttracks']['track'].each do |track_json|
+          artist = track_json['artist']['#text'] || next
+          title = track_json['name'] || next
+          yield(Track.new(artist:, title:))
+        end
+        page += 1
+        break if page > pages_count
+      end
+      nil
+    end
+
+  end
+
+end

data/lib/notu.rb

@@ -3,7 +3,6 @@ require 'active_support/core_ext'
 require 'byebug' if ENV['DEBUGGER']
 require 'cgi'
 require 'net/https'
-require 'nokogiri'
 
 lib_path = "#{__dir__}/notu"
 
@@ -18,12 +17,11 @@ require "#{lib_path}/error"
 require "#{lib_path}/network_error"
 require "#{lib_path}/parse_error"
 
-require "#{lib_path}/html_document"
+require "#{lib_path}/api"
 require "#{lib_path}/http_download"
+require "#{lib_path}/json_document"
 require "#{lib_path}/library"
-require "#{lib_path}/listing"
 require "#{lib_path}/loved_tracks"
 require "#{lib_path}/most_played_tracks"
-require "#{lib_path}/played_tracks"
+require "#{lib_path}/recent_tracks"
 require "#{lib_path}/track"
-require "#{lib_path}/unknown_username_error"

data/notu.gemspec

@@ -9,18 +9,20 @@ Gem::Specification.new do |s|
   s.description = 'API to get Last.fm tracks (most played, loved, etc.)'
   s.license = 'MIT'
 
-  s.files = `git ls-files | grep -vE '^(spec/|test/|\\.|Gemfile|Rakefile)'`.split("\n")
-  s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
+  s.files = %x(git ls-files | grep -vE '^(spec/|test/|\\.|Gemfile|Rakefile)').split("\n")
+  s.executables = %x(git ls-files -- bin/*).split("\n").map { |f| File.basename(f) }
   s.require_paths = ['lib']
 
-  s.required_ruby_version = '>= 2.0.0'
+  s.required_ruby_version = '>= 3.1.0'
 
-  s.add_dependency 'activesupport', '>= 4.1.0', '< 7.0.0'
-  s.add_dependency 'nokogiri', '>= 1.6.0', '< 1.12.0'
+  s.add_dependency 'activesupport', '>= 7.0.0', '< 8.0.0'
 
   s.add_development_dependency 'byebug', '>= 3.2.0', '< 12.0.0'
   s.add_development_dependency 'rake', '>= 10.3.0', '< 14.0.0'
   s.add_development_dependency 'rspec', '>= 3.1.0', '< 4.0.0'
+  s.add_development_dependency 'rubocop', '>= 1.25.0', '< 2.0.0'
+  s.add_development_dependency 'rubocop-rake', '>= 0.6.0', '< 1.0.0'
+  s.add_development_dependency 'rubocop-rspec', '>= 2.8.0', '< 3.0.0'
   s.add_development_dependency 'vcr', '>= 4.0.0', '< 7.0.0'
   s.add_development_dependency 'webmock', '>= 3.0.0', '< 4.0.0'
 end

metadata

@@ -1,55 +1,35 @@
 --- !ruby/object:Gem::Specification
 name: notu
 version: !ruby/object:Gem::Version
-  version: 2.0.6
+  version: 4.0.0
 platform: ruby
 authors:
 - Alexis Toulotte
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-06-15 00:00:00.000000000 Z
+date: 2023-01-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
-      - !ruby/object:Gem::Version
-        version: 4.1.0
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: 7.0.0
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 4.1.0
-    - - "<"
       - !ruby/object:Gem::Version
         version: 7.0.0
-- !ruby/object:Gem::Dependency
-  name: nokogiri
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 1.6.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 1.12.0
+        version: 8.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.6.0
+        version: 7.0.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: 1.12.0
+        version: 8.0.0
 - !ruby/object:Gem::Dependency
   name: byebug
   requirement: !ruby/object:Gem::Requirement
@@ -110,6 +90,66 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: 4.0.0
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.25.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 2.0.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 1.25.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 2.0.0
+- !ruby/object:Gem::Dependency
+  name: rubocop-rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.6.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 0.6.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.8.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 3.0.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 2.8.0
+    - - "<"
+      - !ruby/object:Gem::Version
+        version: 3.0.0
 - !ruby/object:Gem::Dependency
   name: vcr
   requirement: !ruby/object:Gem::Requirement
@@ -160,18 +200,17 @@ files:
 - README.mdown
 - VERSION
 - lib/notu.rb
+- lib/notu/api.rb
 - lib/notu/error.rb
-- lib/notu/html_document.rb
 - lib/notu/http_download.rb
+- lib/notu/json_document.rb
 - lib/notu/library.rb
-- lib/notu/listing.rb
 - lib/notu/loved_tracks.rb
 - lib/notu/most_played_tracks.rb
 - lib/notu/network_error.rb
 - lib/notu/parse_error.rb
-- lib/notu/played_tracks.rb
+- lib/notu/recent_tracks.rb
 - lib/notu/track.rb
-- lib/notu/unknown_username_error.rb
 - notu.gemspec
 homepage: https://github.com/alexistoulotte/notu
 licenses:
@@ -185,14 +224,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.0.0
+      version: 3.1.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.15
+rubygems_version: 3.3.3
 signing_key:
 specification_version: 4
 summary: API for Last.fm

data/lib/notu/html_document.rb

@@ -1,19 +0,0 @@
-module Notu
-
-  module HtmlDocument
-
-    def self.get(url, options = {})
-      parse(HttpDownload.get(url, options))
-    end
-
-    def self.parse(data)
-      data = data.gsub(/ /i, ' ').gsub(/\s+/, ' ')
-      document = Nokogiri::HTML.parse(data, nil, 'UTF-8')
-      raise ParseError.new('Invalid HTML document') if (document/'head').empty?
-      document
-    end
-    private_class_method :parse
-
-  end
-
-end

data/lib/notu/listing.rb

@@ -1,32 +0,0 @@
-module Notu
-
-  module Listing
-
-    include Enumerable
-
-    attr_reader :library
-
-    def initialize(library)
-      raise ArgumentError.new("#{self.class}#library must be a library, #{library.inspect} given") unless library.is_a?(Library)
-      @library = library
-    end
-
-    def page_urls
-      (1..pages_count).map do |index|
-        library.url(path: path, query: params.merge('page' => index))
-      end
-    end
-
-    def pages_count
-      document = HtmlDocument.get(library.url(path: path, query: params))
-      [1, (document/'ul.pagination-list li.pagination-page').text.split(/\s+/).map(&:to_i)].flatten.compact.max
-    end
-
-    def params
-      # to be overriden
-      {}
-    end
-
-  end
-
-end

data/lib/notu/played_tracks.rb

@@ -1,26 +0,0 @@
-module Notu
-
-  class PlayedTracks
-
-    include Listing
-
-    def each(&block)
-      return unless block_given?
-      page_urls.each do |url|
-        document = HtmlDocument.get(url)
-        (document/'table.chartlist tbody tr').each do |element|
-          artist = (element/'td.chartlist-artist a').first.try(:text) || next
-          title = (element/'td.chartlist-name a').first.try(:text) || next
-          yield(Track.new(artist: artist, title: title))
-        end
-      end
-      nil
-    end
-
-    def path
-      'library'
-    end
-
-  end
-
-end

data/lib/notu/unknown_username_error.rb

@@ -1,14 +0,0 @@
-module Notu
-
-  class UnknownUsernameError < Error
-
-    attr_reader :username
-
-    def initialize(username)
-      @username = username
-      super("No such Last.fm username: #{self.username.inspect}")
-    end
-
-  end
-
-end