notion_ruby_mapping 0.8.9 → 2.0.0

data/lib/notion_ruby_mapping/controllers/notion_cache.rb

@@ -2,7 +2,8 @@
 
 require "singleton"
 require "faraday"
-require "faraday_middleware"
+require "faraday/multipart"
+require "mime/types"
 
 module NotionRubyMapping
   # singleton class of caching Notion objects
@@ -14,10 +15,10 @@ module NotionRubyMapping
     # @see https://www.notion.so/hkob/NotionCache-65e1599864d6425686d495a5a4b3a623#dca210788f114cf59464090782c073bf
     def initialize
       @object_hash = {}
-      @client = Faraday::Connection.new "https://api.notion.com" do |builder|
-        builder.use FaradayMiddleware::EncodeJson
-        builder.use FaradayMiddleware::ParseJson
-        builder.adapter Faraday.default_adapter
+      @client = Faraday.new "https://api.notion.com" do |conn|
+        conn.request :json
+        conn.response :json
+        conn.headers["Notion-Version"] = NotionRubyMapping::NOTION_VERSION
       end
       @notion_token = nil
       @wait = 0.3333
@@ -28,6 +29,14 @@ module NotionRubyMapping
     attr_writer :client # for test only
     attr_accessor :notion_token, :wait, :debug, :use_cache
 
+    def multipart_client
+      @multipart_client ||= Faraday.new "https://api.notion.com" do |conn|
+        conn.request :multipart, flat_encode: true
+        conn.response :json
+        conn.headers["Notion-Version"] = NotionRubyMapping::NOTION_VERSION
+      end
+    end
+
     # @param [String] block_id
     # @return [String (frozen)] block_path
     def append_block_children_block_path(block_id)
@@ -92,6 +101,14 @@ module NotionRubyMapping
       "v1/comments"
     end
 
+    def complete_a_file_upload_path(file_id)
+      "v1/file_uploads/#{file_id}/complete"
+    end
+
+    def complete_a_file_upload_request(file_id)
+      request :post, complete_a_file_upload_path(file_id)
+    end
+
     # @param [String] notion_token
     # @return [NotionRubyMapping::NotionCache] self (NotionCache.instance)
     def create_client(notion_token, wait: 0.3333, debug: false)
@@ -107,6 +124,12 @@ module NotionRubyMapping
       request :post, databases_path, payload
     end
 
+    # @param [Hash] payload
+    # @return [Hash] response
+    def create_file_upload_request(payload = {})
+      request :post, file_uploads_path, payload
+    end
+
     # @param [Hash] payload
     # @return [Hash] response
     def create_page_request(payload)
@@ -161,6 +184,25 @@ module NotionRubyMapping
       request :delete, block_path(id)
     end
 
+    # @param [String] fname
+    # @param [String] id
+    # @param [Hash] options
+    # @return [Hash]
+    def file_upload_request(fname, id, options = {})
+      multipart_request(file_upload_path(id), fname, options)
+    end
+
+    # @param [String] id
+    # @return [String]
+    def file_upload_path(id)
+      "v1/file_uploads/#{id}/send"
+    end
+
+    # @return [String]
+    def file_uploads_path
+      "v1/file_uploads"
+    end
+
     # @param [String] id id string with "-"
     # @return [String] id without "-"
     # @see https://www.notion.so/hkob/NotionCache-65e1599864d6425686d495a5a4b3a623#a2d70a2e019c4c17898aaa1a36580f1d
@@ -172,6 +214,28 @@ module NotionRubyMapping
       "NotionCache"
     end
 
+    # @param [String] path
+    # @param [String] fname
+    # @param [Hash] options
+    # @return [Hash] response hash
+    def multipart_request(path, fname, options = {})
+      raise "Please call `NotionRubyMapping.configure' before using other methods" unless @notion_token
+
+      content_type = MIME::Types.type_for(fname).first.to_s
+
+      sleep @wait
+      body = options.map { |k, v| [k, Faraday::Multipart::ParamPart.new(v, "text/plain")] }.to_h
+      file_part = Faraday::Multipart::FilePart.new(fname, content_type, File.basename(fname))
+      response = multipart_client.send(:post) do |request|
+        request.headers["Authorization"] = "Bearer #{@notion_token}"
+        request.headers["content-Type"] = "multipart/form-data"
+        request.path = path
+        request.body = {file: file_part}.merge body
+      end
+      p response.body if @debug
+      response.body
+    end
+
     # @param [String] id id (with or without "-")
     # @return [NotionRubyMapping::Base]
     def object_for_key(id)
@@ -207,6 +271,7 @@ module NotionRubyMapping
     # @param [String] property_id
     # @return [Hash] response
     def page_property_request(page_id, property_id, query = {})
+      p "page_id = #{page_id}, property_id = #{property_id}, query = #{query}" if @debug
       request :get, page_property_path(page_id, property_id), query
     end
 
@@ -248,7 +313,6 @@ module NotionRubyMapping
       sleep @wait
       response = @client.send(method) do |request|
         request.headers["Authorization"] = "Bearer #{@notion_token}"
-        request.headers["Notion-Version"] = NotionRubyMapping::NOTION_VERSION
         case method
         when :get, :delete
           request.url path, options
@@ -266,13 +330,13 @@ module NotionRubyMapping
     end
 
     def search(query)
-      request(:post, search_path, options = query)
+      request(:post, search_path, query)
     end
 
     def search_path
       "v1/search"
     end
-    
+
     # @param [String] token
     def token=(token)
       @notion_token = token
@@ -322,7 +386,7 @@ module NotionRubyMapping
 
     # @return [Array<NotionRubyMapping::UserObject>] UserObject array
     def users
-      List.new json: users_request, type: :user_object, value: true
+      List.new json: users_request, type: "user_object", value: true
     end
 
     # @return [String (frozen)] user_path

data/lib/notion_ruby_mapping/controllers/payload.rb

@@ -21,7 +21,7 @@ module NotionRubyMapping
 
     def description=(text_objects)
       rta = RichTextArray.rich_text_array "description", text_objects
-      @json.merge!(rta.update_property_schema_json true)
+      @json.merge!(rta.update_property_schema_json(true))
     end
 
     # @param [Boolean] flag
@@ -47,14 +47,32 @@ module NotionRubyMapping
       others.compact.reduce({}) { |hash, o| hash.merge o.property_schema_json }.merge @json
     end
 
+    # @param [String, nil] url
+    # @param [String, nil] file_upload_object
+    # @return [NotionRubyMapping::Payload]
+    def set_cover(url: nil, file_upload_object: nil)
+      payload = if url
+                  {"type" => "external", "external" => {"url" => url}}
+                elsif file_upload_object
+                  {"type" => "file_upload", "file_upload" => {"id" => file_upload_object.id}}
+                else
+                  {}
+                end
+      @json["cover"] = payload
+      self
+    end
+
     # @param [String] emoji
     # @param [String] url
+    # @param [FileUploadObject] file_upload_object
     # @return [NotionRubyMapping::Payload] updated Payload
-    def set_icon(emoji: nil, url: nil)
+    def set_icon(emoji: nil, url: nil, file_upload_object: nil)
       payload = if emoji
                   {"type" => "emoji", "emoji" => emoji}
                 elsif url
                   {"type" => "external", "external" => {"url" => url}}
+                elsif file_upload_object
+                  {"type" => "file_upload", "file_upload" => {"id" => file_upload_object.id}}
                 else
                   {}
                 end

data/lib/notion_ruby_mapping/controllers/property_cache.rb

@@ -4,7 +4,7 @@ module NotionRubyMapping
   # PropertyCache class
   class PropertyCache
     include Enumerable
-    def initialize(json = {}, base_type: :page, page_id: nil)
+    def initialize(json = {}, base_type: "page", page_id: nil)
       @properties = {}
       @json = json
       @base_type = base_type

data/lib/notion_ruby_mapping/controllers/query.rb

@@ -54,10 +54,10 @@ module NotionRubyMapping
     # @return [Hash]
     def query_json
       parameters = {}
-      parameters[:filter] = @filter unless @filter.empty?
-      parameters[:sorts] = @sort unless @sort.empty?
-      parameters[:start_cursor] = @start_cursor if @start_cursor
-      parameters[:page_size] = @page_size if @page_size
+      parameters["filter"] = @filter unless @filter.empty?
+      parameters["sorts"] = @sort unless @sort.empty?
+      parameters["start_cursor"] = @start_cursor if @start_cursor
+      parameters["page_size"] = @page_size if @page_size
       parameters
     end
 

data/lib/notion_ruby_mapping/controllers/search.rb

@@ -1,6 +1,5 @@
 module NotionRubyMapping
   class Search
-
     def initialize(ascending: false, database_only: false, page_only: false, query: nil)
       @ascending = ascending
       @database_only = database_only
@@ -13,17 +12,17 @@ module NotionRubyMapping
         Base.dry_run_script :post, NotionCache.instance.search_path, payload
       else
         response = NotionCache.instance.search payload
-        List.new json: response, type: :search, value: self, query: Query.new
+        List.new json: response, type: "search", value: self, query: Query.new
       end
     end
 
     def payload
       ans = {}
       ans["sort"] = {"direction" => "ascending", "timestamp" => "last_edited_time"} if @ascending
-      ans["filter"] = {"value" => "database", "property" => "object" } if @database_only
-      ans["filter"] = {"value" => "page", "property" => "object" } if @page_only
+      ans["filter"] = {"value" => "database", "property" => "object"} if @database_only
+      ans["filter"] = {"value" => "page", "property" => "object"} if @page_only
       ans["query"] = @query if @query
       ans
     end
   end
-end
+end

data/lib/notion_ruby_mapping/objects/file_object.rb

@@ -5,10 +5,13 @@ module NotionRubyMapping
   class FileObject
     # @param [String] url
     # @return [TextObject]
-    def initialize(url: nil, json: {})
+    def initialize(url: nil, file_upload_object: nil, json: {})
       if url
         @type = "external"
         @url = url
+      elsif file_upload_object
+        @type = "file_upload"
+        @file_upload_object = file_upload_object
       elsif json
         @type = json["type"]
         @url = json[@type]["url"]
@@ -18,16 +21,18 @@ module NotionRubyMapping
       end
       @will_update = false
     end
-    attr_reader :will_update, :url, :type
+    attr_reader :will_update, :url, :type, :file_upload_object
 
-    # @param [FileObject, String] uo
+    # @param [FileObject, FileUploadObject, String] url_or_fuo_or_fo
     # @return [FileObject] self or created FileObject
     # @see https://www.notion.so/hkob/FileObject-6218c354e985423a90904f47a985be33#54b37c567e1d4dfcab06f6d8f8fd412e
-    def self.file_object(url_or_fo)
-      if url_or_fo.is_a? FileObject
-        url_or_fo
+    def self.file_object(url_or_fuo_or_fo)
+      if url_or_fuo_or_fo.is_a? FileUploadObject
+        FileObject.new file_upload_object: url_or_fuo_or_fo
+      elsif url_or_fuo_or_fo.is_a? FileObject
+        url_or_fuo_or_fo
       else
-        FileObject.new url: url_or_fo
+        FileObject.new url: url_or_fuo_or_fo
       end
     end
 
@@ -36,6 +41,15 @@ module NotionRubyMapping
       @type == "external"
     end
 
+    # @param [FileUploadObject] fuo
+    def file_upload_object=(fuo)
+      @file_upload_object = fuo
+      @type = "file_upload"
+      @url = nil
+      @expiry_time = nil
+      @will_update = true
+    end
+
     # @param [String] url
     # @see https://www.notion.so/hkob/FileObject-6218c354e985423a90904f47a985be33#6b841f75d0234a1aac93fb54348abb96
     def url=(url)
@@ -47,14 +61,23 @@ module NotionRubyMapping
 
     # @return [Hash]
     def property_values_json
-      ans = {
-        "type" => @type,
-        @type => {
-          "url" => @url,
-        },
-      }
-      ans[@type]["expiry_time"] = @expiry_time if @expiry_time
-      ans
+      if @type == "file_upload"
+        {
+          "type" => @type.to_s,
+          @type => {
+            "id" => @file_upload_object.id,
+          },
+        }
+      else
+        ans = {
+          "type" => @type.to_s,
+          @type => {
+            "url" => @url,
+          },
+        }
+        ans[@type]["expiry_time"] = @expiry_time if @expiry_time
+        ans
+      end
     end
   end
 end

data/lib/notion_ruby_mapping/objects/file_upload_object.rb

@@ -0,0 +1,78 @@
+# frozen_string_literal: true
+
+class FileUploadObject
+  MAX_SIZE = 10 * 1024 * 1024 # 10 MB
+  # @param [String] id
+  def initialize(fname:, external_url: nil)
+    @fname = fname
+    if external_url
+      payload = {mode: "external_url", external_url: external_url, filename: fname}
+      create payload
+    else
+      raise StandardError, "FileUploadObject requires a valid file name: #{fname}" unless File.exist?(fname)
+
+      @file_size = File.size fname
+      @number_of_parts = (@file_size - 1) / MAX_SIZE + 1
+      payload = if @number_of_parts == 1
+                  {}
+                else
+                  {number_of_parts: @number_of_parts, mode: "multi_part",
+                   filename: File.basename(@fname)}
+                end
+      create payload
+      if @number_of_parts == 1
+        single_file_upload
+      else
+        @temp_files = FileUploadObject.split_to_small_files(@fname, MAX_SIZE)
+        @temp_files.each_with_index do |temp_file, i|
+          single_file_upload temp_file.path, i + 1
+          temp_file.close
+          temp_file.unlink
+        end
+        NotionRubyMapping::NotionCache.instance.complete_a_file_upload_request @id
+      end
+    end
+  end
+  attr_reader :id, :fname
+
+  # @return [FileUploadObject]
+  def create(payload)
+    nc = NotionRubyMapping::NotionCache.instance
+    response = nc.create_file_upload_request(payload)
+    @id = nc.hex_id response["id"]
+  end
+
+  # @param [String] fname
+  # @param [Integer, NilClass] part_number
+  def single_file_upload(fname = @fname, part_number = 0)
+    if @number_of_parts > 1
+      options = {"part_number" => part_number}
+      status = "pending"
+    else
+      options = {}
+      status = "uploaded"
+    end
+    nc = NotionRubyMapping::NotionCache.instance
+    response = nc.file_upload_request fname, @id, options
+    return if nc.hex_id(response["id"]) == @id && response["status"] == status
+
+    raise StandardError, "File upload failed: #{response}"
+  end
+
+  def self.split_to_small_files(org_file, max_size = MAX_SIZE)
+    raise StandardError, "File does not exist: #{org_file}" unless File.exist?(org_file)
+
+    temp_files = []
+    File.open(org_file, "rb") do |file|
+      until file.eof?
+        chunk = file.read(max_size)
+        temp_file = Tempfile.new("part_")
+        temp_file.binmode
+        temp_file.write(chunk)
+        temp_file.rewind
+        temp_files << temp_file
+      end
+    end
+    temp_files
+  end
+end

data/lib/notion_ruby_mapping/properties/button_property.rb

@@ -14,11 +14,11 @@ module NotionRubyMapping
       @json
     end
 
-    # @param [String] name Property name
+    # @param [String, Symbol] name Property name
     # @param [Boolean, Hash] json
-    def initialize(name, will_update: false, base_type: :page, property_id: nil, property_cache: nil, json: nil)
+    def initialize(name, will_update: false, base_type: "page", property_id: nil, property_cache: nil, json: nil)
       super name, will_update: will_update, base_type: base_type, property_id: property_id,
-            property_cache: property_cache
+                  property_cache: property_cache
       @json = json
     end
 

data/lib/notion_ruby_mapping/properties/checkbox_property.rb

@@ -31,9 +31,9 @@ module NotionRubyMapping
 
     ## Common methods
 
-    # @param [String] name Property name
+    # @param [String, Symbol] name Property name
     # @param [Boolean, Hash] json
-    def initialize(name, will_update: false, base_type: :page, property_id: nil, property_cache: nil, json: nil)
+    def initialize(name, will_update: false, base_type: "page", property_id: nil, property_cache: nil, json: nil)
       super name, will_update: will_update, base_type: base_type, property_id: property_id,
                   property_cache: property_cache
       @json = if database?

data/lib/notion_ruby_mapping/properties/created_by_property.rb

@@ -19,10 +19,10 @@ module NotionRubyMapping
 
     ## Common methods
 
-    # @param [String] name Property name
+    # @param [String, Symbol] name Property name
     # @param [String] user_id user_id (optional)
     # @param [Hash] json json (optional)
-    def initialize(name, will_update: false, base_type: :page, json: nil, user_id: nil, property_id: nil,
+    def initialize(name, will_update: false, base_type: "page", json: nil, user_id: nil, property_id: nil,
                    property_cache: nil)
       super name, will_update: will_update, base_type: base_type, property_id: property_id,
                   property_cache: property_cache

data/lib/notion_ruby_mapping/properties/created_time_property.rb

@@ -19,9 +19,9 @@ module NotionRubyMapping
 
     ## Common methods
 
-    # @param [String] name Property name
+    # @param [String, Symbol] name Property name
     # @param [String] json created_time value (optional)
-    def initialize(name, will_update: false, base_type: :page, json: nil, property_id: nil, property_cache: nil)
+    def initialize(name, will_update: false, base_type: "page", json: nil, property_id: nil, property_cache: nil)
       super name, will_update: will_update, base_type: base_type, property_id: property_id,
                   property_cache: property_cache
       @json = json

data/lib/notion_ruby_mapping/properties/date_base_property.rb

@@ -102,7 +102,8 @@ module NotionRubyMapping
     # @return [NotionRubyMapping::Query] generated Query object
     # @see https://www.notion.so/hkob/CreatedTimeProperty-bb979ff02dc04efa9733da1003efa871#6a20ade0ee964aad81aae4c08ea29d6b
     def filter_on_or_before(date, condition: nil, another_type: nil)
-      make_filter_query "on_or_before", value_str(date, end_time: true), condition: condition, another_type: another_type
+      make_filter_query "on_or_before", value_str(date, end_time: true), condition: condition,
+                                                                         another_type: another_type
     end
 
     # @param [String] condition Rollup name
@@ -110,7 +111,8 @@ module NotionRubyMapping
     # @return [NotionRubyMapping::Query] generated Query object
     # @see https://www.notion.so/hkob/CreatedTimeProperty-bb979ff02dc04efa9733da1003efa871#1469e3fb3068426a8ea8492d191d1563
     def filter_on_or_after(date, condition: nil, another_type: nil)
-      make_filter_query "on_or_after", value_str(date, start_time: true), condition: condition, another_type: another_type
+      make_filter_query "on_or_after", value_str(date, start_time: true), condition: condition,
+                                                                          another_type: another_type
     end
 
     # @param [String] condition Rollup name

data/lib/notion_ruby_mapping/properties/date_property.rb

@@ -77,7 +77,7 @@ module NotionRubyMapping
     # @see https://www.notion.so/hkob/DateProperty-c6e815c060cb430889dbb33b697f00c6#f892cde82d9a44a0850d69878e31b216
     def time_zone
       assert_page_property __method__
-      @json["time_zone"]
+      @json[:time_zone]
     end
 
     # @param [String] tzone
@@ -85,7 +85,7 @@ module NotionRubyMapping
     def time_zone=(tzone)
       assert_page_property __method__
       @will_update = true
-      @json["time_zone"] = tzone
+      @json[:time_zone] = tzone
     end
 
     ### Not public announced methods
@@ -97,7 +97,7 @@ module NotionRubyMapping
     # @param [Date, Time, DateTime, String, nil] start_date
     # @param [Date, Time, DateTime, String, nil] end_date
     # @param [String, nil] time_zone
-    def initialize(name, will_update: false, base_type: :page, json: nil, start_date: nil, end_date: nil,
+    def initialize(name, will_update: false, base_type: "page", json: nil, start_date: nil, end_date: nil,
                    time_zone: nil, property_id: nil, property_cache: nil)
       super name, will_update: will_update, base_type: base_type, property_id: property_id,
                   property_cache: property_cache
@@ -117,7 +117,7 @@ module NotionRubyMapping
       assert_page_property __method__
       {
         @name => {
-          "type" => "date",
+          "type" => TYPE,
           "date" => {
             "start" => value_str(@json["start"]),
             "end" => value_str(@json["end"]),

data/lib/notion_ruby_mapping/properties/email_property.rb

@@ -31,8 +31,8 @@ module NotionRubyMapping
 
     ## Common methods
 
-    # @param [String] name Property name
-    def initialize(name, will_update: false, base_type: :page, json: nil, property_id: nil, property_cache: nil)
+    # @param [String, Symbol] name Property name
+    def initialize(name, will_update: false, base_type: "page", json: nil, property_id: nil, property_cache: nil)
       super name, will_update: will_update, base_type: base_type, property_id: property_id,
                   property_cache: property_cache
       @json = json || {}

data/lib/notion_ruby_mapping/properties/files_property.rb

@@ -21,7 +21,10 @@ module NotionRubyMapping
 
     def file_names=(file_names = [])
       array_file_names = Array(file_names)
-      raise StandardError, "files and file_names must be the same sizes." unless @files.length == array_file_names.length
+      unless @files.length == array_file_names.length
+        raise StandardError,
+              "files and file_names must be the same sizes."
+      end
 
       @will_update = true
       @file_names = array_file_names
@@ -31,9 +34,9 @@ module NotionRubyMapping
 
     ## Common methods
 
-    # @param [String] name Property name
+    # @param [String, Symbol] name Property name
     # @param [String] files files value (optional)
-    def initialize(name, will_update: false, base_type: :page, json: nil, files: [], property_id: nil,
+    def initialize(name, will_update: false, base_type: "page", json: nil, files: [], property_id: nil,
                    property_cache: nil)
       super name, will_update: will_update, base_type: base_type, property_id: property_id,
                   property_cache: property_cache
@@ -57,7 +60,9 @@ module NotionRubyMapping
         {}
       else
         files = @files.map(&:property_values_json)
-        @file_names&.each_with_index { |name, i| files[i]["name"] = name }
+        @file_names&.each_with_index do |name, i|
+          files[i]["name"] = name.is_a?(FileUploadObject) ? name.fname : name
+        end
         {@name => {"files" => files, "type" => "files"}}
       end
     end

data/lib/notion_ruby_mapping/properties/formula_property.rb

@@ -39,9 +39,9 @@ module NotionRubyMapping
 
     ## Common methods
 
-    # @param [String] name
+    # @param [String, Symbol] name
     # @param [Hash] json
-    def initialize(name, will_update: false, base_type: :page, json: nil, formula: nil, property_id: nil,
+    def initialize(name, will_update: false, base_type: "page", json: nil, formula: nil, property_id: nil,
                    property_cache: nil)
       super name, will_update: will_update, base_type: base_type, property_id: property_id,
                   property_cache: property_cache

data/lib/notion_ruby_mapping/properties/last_edited_by_property.rb

@@ -22,7 +22,8 @@ module NotionRubyMapping
     # @param [String] name Property name
     # @param [String] user_id user_id (optional)
     # @param [Hash] json json (optional)
-    def initialize(name, will_update: false, base_type: :page, json: nil, user_id: nil, property_id: nil,
+    def initialize(name, will_update: false, base_type:
+          "page", json: nil, user_id: nil, property_id: nil,
                    property_cache: nil)
       super name, will_update: will_update, base_type: base_type, property_id: property_id,
                   property_cache: property_cache

data/lib/notion_ruby_mapping/properties/last_edited_time_property.rb

@@ -19,9 +19,9 @@ module NotionRubyMapping
 
     ## Common methods
 
-    # @param [String] name Property name
+    # @param [String, Symbol] name Property name
     # @param [String] json last_edited_time value (optional)
-    def initialize(name, will_update: false, base_type: :page, json: nil, property_id: nil, property_cache: nil)
+    def initialize(name, will_update: false, base_type: "page", json: nil, property_id: nil, property_cache: nil)
       super name, will_update: will_update, base_type: base_type, property_id: property_id,
                   property_cache: property_cache
       @json = json

data/lib/notion_ruby_mapping/properties/multi_select_property.rb

@@ -16,7 +16,7 @@ module NotionRubyMapping
 
     # @return [Array]
     def multi_select_names
-      mshs = @base_type == :page ? @json : @json["options"]
+      mshs = @base_type == "page" ? @json : @json["options"]
       mshs.map { |h| h["name"] }
     end
 
@@ -58,10 +58,10 @@ module NotionRubyMapping
 
     ## Common methods
 
-    # @param [String] name
+    # @param [String, Symbol] name
     # @param [Hash] json
     # @param [Array<String>, String] multi_select
-    def initialize(name, will_update: false, base_type: :page, json: nil, multi_select: nil,
+    def initialize(name, will_update: false, base_type: "page", json: nil, multi_select: nil,
                    property_id: nil, property_cache: nil)
       super name, will_update: will_update, base_type: base_type, property_id: property_id,
                   property_cache: property_cache

data/lib/notion_ruby_mapping/properties/number_property.rb

@@ -51,14 +51,14 @@ module NotionRubyMapping
 
     ## Common methods
 
-    # @param [String] name Property name
+    # @param [String, Symbol] name Property name
     # @param [Float, Integer, Hash] json Number value or format Hash
-    def initialize(name, will_update: false, base_type: :page, json: nil, format: nil, property_id: nil,
+    def initialize(name, will_update: false, base_type: "page", json: nil, format: nil, property_id: nil,
                    property_cache: nil)
       super name, will_update: will_update, base_type: base_type, property_id: property_id,
                   property_cache: property_cache
       @json = json
-      @json ||= {"format" => (format || "number")} if database?
+      @json ||= {"format" => format || "number"} if database?
     end
 
     # @param [Hash] json