notifiers 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6a9805f03cbef83bc8a4adb74e42c2a355d4944e
-  data.tar.gz: c41421a3c1e48cdf0fc6d5e2d44dd4a2d2d5d44e
+  metadata.gz: e3ab9d583cfca62be7ae6a684c9ad504c313c40c
+  data.tar.gz: b9c211cbeae8b427040d14d6c387f21cc3a37046
 SHA512:
-  metadata.gz: 9b46e6f3cbff9b5ad9c0d83dc58b2625a07a5e57f04fc92c7654dce862a7847520474545c19101a16df48833a38034c459171e5677ff588a95b86d4304a5752a
-  data.tar.gz: 0bddc7d9c059a4e65a3b821a26806063ac744d9b29369b0a4b002d7c665b5031f79c1159177ae203b01d51e90dbac3059ed003a687c2da11a006374d08c131b5
+  metadata.gz: d2f7b8fdaf4b9f7d30ad573451991800f9f043c0cfbfe902c5fef39bbbb199b857f91c1e4e9eafdd52258143e7e19a80aaa8e0c96b5d4f3180c1c053ef17e2f6
+  data.tar.gz: a2d9bfd767396565d3e57a7d54d2f6604ce68fec29ac03d72b2829ad46533defa54b07fe7cb51f05f87482624cc5916fb76d801035eff8f8b5690c5a10473a2e

data/.gitignore

@@ -1,4 +1,5 @@
 pkg/*
 *.gem
 .bundle
-.ruby-version
+.ruby-version
+Gemfile.lock

data/.travis.yml

@@ -0,0 +1,10 @@
+language: ruby
+rvm:
+  - 1.9.3
+  - jruby
+  - 2.0
+before_install:
+  - export DISPLAY=:99.0
+  - sh -e /etc/init.d/xvfb start
+script:
+  - bundle exec rspec

data/History.markdown

@@ -1,3 +1,11 @@
+# 1.2.1
+
+* Implementing auto discover, just for Growl now.
+
+# 1.2.0
+
+* When the Growl notify command doesn't exist, show a better error message.
+
 # 1.1.0
 
 * Add knotify to notifications message

data/README.markdown

@@ -1,6 +1,6 @@
 # Notifiers
 
-Use notifications systems like growlm kib-notify in a simple and elegant way. :)
+Use notifications systems like growl, lib-notify in a simple and elegant way. :)
 
 ## Install
 

data/TODO.markdown

@@ -1 +1,2 @@
-* When the notifer command doesn't exists, show a better error message.
+
+* Auto Discover the OS and notify as expected.

data/lib/notifiers.rb

@@ -1,9 +1,8 @@
-[ :growl, :knotify, :notify_send].each do |notifier|
+[:base, :growl, :knotify, :notify_send, :notifier_not_found].each do |notifier|
   require "notifiers/#{notifier}"
 end
 
 module Notifiers
-
   def growl
     Growl.new
   end
@@ -16,4 +15,10 @@ module Notifiers
     NotifySend.new
   end
   alias :lib_notify :notify_send
+
+  def auto_discover
+    notifier = Notifiers::Base.subclasses.find { |notifier| notifier.installed? } or raise NotifierNotFound
+
+    notifier.new
+  end
 end

data/lib/notifiers/base.rb

@@ -0,0 +1,57 @@
+module Notifiers
+  class Base
+    def self.inherited(subclass)
+      @subclasses ||= []
+      @subclasses.push(subclass)
+      @subclasses
+    end
+
+    def self.subclasses
+      @subclasses
+    end
+
+    def self.installed?
+      false
+    end
+
+    def self.darwin?
+      platform?(/darwin/)
+    end
+
+    def self.platform?(name)
+      RbConfig::CONFIG['host_os'] =~ name or RUBY_PLATFORM =~ name
+    end
+
+    def self.command?(command)
+      `which #{command}` and $?.zero?
+    end
+
+    def notify
+      notification = system(to_s)
+
+      puts install_instructions unless notification or install_instructions.empty?
+
+      notification
+    end
+    alias :notify! :notify
+
+    def message(text)
+      @message = text
+      self
+    end
+
+    def title(text)
+      @title = text
+      self
+    end
+
+    def image(icon)
+      @icon = icon
+      self
+    end
+
+    def install_instructions
+      ''
+    end
+  end
+end

data/lib/notifiers/growl.rb

@@ -1,55 +1,47 @@
-class Growl
-  COMMAND       = 'growlnotify'
-  ERROR_MESSAGE = "The Growl is not installed. You can find more details here:
-http://growl.info/downloads"
-
-  def image(icon)
-    @image = icon
-    self
-  end
-
-  def title(text)
-    @title = text
-    self
-  end
+module Notifiers
+  class Growl < Notifiers::Base
+    def self.installed?
+      darwin? and command?('growlnotify')
+    end
 
-  def message(text)
-    @message = text
-    self
-  end
+    def image(icon)
+      @image = icon
+      self
+    end
 
-  def priority(number)
-    @priority = number
-    self
-  end
+    def priority(number)
+      @priority = number
+      self
+    end
 
-  def host(hostname)
-    @host = hostname
-    self
-  end
+    def host(hostname)
+      @host = hostname
+      self
+    end
 
-  def password(secret)
-    @password = secret
-    self
-  end
+    def password(secret)
+      @password = secret
+      self
+    end
 
-  def auth(authentication)
-    @auth = authentication
-    self
-  end
+    def auth(authentication)
+      @auth = authentication
+      self
+    end
 
-  def to_s
-    command = COMMAND.clone
-    command << " --title '#{@title}'" if @title
-    command << " --message '#{@message}'"
-    [:image, :priority, :host, :password, :auth].each do |option|
-      variable = instance_variable_get("@#{option}")
-      command << " --#{option} #{variable}" if variable
-    end
-    command
-  end
+    def to_s
+      command = 'growlnotify'
+      command << " --title '#{@title}'" if @title
+      command << " --message '#{@message}'"
+      [:image, :priority, :host, :password, :auth].each do |option|
+        variable = instance_variable_get("@#{option}")
+        command << " --#{option} #{variable}" if variable
+      end
+      command
+    end
 
-  def notify!
-    puts ERROR_MESSAGE unless system(to_s)
+    def install_instructions
+      'The Growl is not installed. You can find more details here: http://growl.info/downloads'
+    end
   end
 end

data/lib/notifiers/knotify.rb

@@ -1,26 +1,14 @@
-class Knotify
-  COMMAND = "dcop knotify default notify eventname"
-
-  def message(text)
-    @message = text
-    self
-  end
-
-  def title(text)
-    @title = text
-    self
-  end
-
-  def to_s
-    command = "#{COMMAND}"
-    command << " '#{@title}'" if @title
-    command << " '#{@message}'" if @message
-    command << " '' ''"
-    command << " 12 1"
-    command
-  end
-
-  def notify!
-    system(to_s)
+module Notifiers
+  class Knotify < Notifiers::Base
+    COMMAND = "dcop knotify default notify eventname"
+
+    def to_s
+      command = "#{COMMAND}"
+      command << " '#{@title}'" if @title
+      command << " '#{@message}'" if @message
+      command << " '' ''"
+      command << " 12 1"
+      command
+    end
   end
 end

data/lib/notifiers/notifier_not_found.rb

@@ -0,0 +1,4 @@
+module Notifiers
+  class NotifierNotFound < StandardError
+  end
+end

data/lib/notifiers/notify_send.rb

@@ -1,53 +1,34 @@
-class NotifySend
-  COMMAND = 'notify-send'
+module Notifiers
+  class NotifySend < Notifiers::Base
+    COMMAND = 'notify-send'
 
-  def message(text)
-    @message = text
-    self
-  end
-
-  def title(text)
-    @title = text
-    self
-  end
-
-  def image(icon)
-    @icon = icon
-    self
-  end
-
-  def urgency(level)
-    @urgency = level.to_s
-    self
-  end
-
-  def expire_time(time)
-    @expire_time = time
-    self
-  end
-
-  def hint(values)
-    @hint = values.collect.each { |element| element.to_s}.join(':')
-    self
-  end
+    def urgency(level)
+      @urgency = level.to_s
+      self
+    end
 
-  def to_s
-    command = COMMAND.clone
-    [:hint, :priority, :icon, :urgency].each do |option|
-      variable = instance_variable_get("@#{option}")
-      command << " --#{option}=#{variable}" if variable
+    def expire_time(time)
+      @expire_time = time
+      self
     end
-    command << " --expire-time=#{@expire_time}" if @expire_time
-    [:title, :message].each do |option|
-      variable = instance_variable_get("@#{option}")
-      command << " '#{variable}'" if variable
+
+    def hint(values)
+      @hint = values.collect.each { |element| element.to_s}.join(':')
+      self
     end
-    command
-  end
 
-  # Extract this to a module or something
-  def notify!
-    system(to_s)
+    def to_s
+      command = COMMAND.clone
+      [:hint, :priority, :icon, :urgency].each do |option|
+        variable = instance_variable_get("@#{option}")
+        command << " --#{option}=#{variable}" if variable
+      end
+      command << " --expire-time=#{@expire_time}" if @expire_time
+      [:title, :message].each do |option|
+        variable = instance_variable_get("@#{option}")
+        command << " '#{variable}'" if variable
+      end
+      command
+    end
   end
-
 end

data/notifiers.gemspec

@@ -2,7 +2,7 @@
 
 Gem::Specification.new do |s|
   s.name        = "notifiers"
-  s.version     = '1.2.0'
+  s.version     = '1.2.1'
   s.platform    = Gem::Platform::RUBY
   s.authors     = ["Tomás D'Stefano"]
   s.email       = ["tomasdestefi@gmail.com"]
@@ -13,7 +13,7 @@ Gem::Specification.new do |s|
   s.required_rubygems_version = ">= 1.3.6"
   s.rubyforge_project         = "notifiers"
 
-  s.add_development_dependency('rspec', "~> 2.11")
+  s.add_development_dependency('rspec', "~> 2.14")
   s.add_development_dependency('bundler', ">= 1.0.0")
 
   s.files        = `git ls-files`.split("\n")

data/spec/notifiers/base_spec.rb

@@ -0,0 +1,64 @@
+require 'spec_helper'
+
+module Notifiers
+  describe Base do
+    subject(:base) do
+      Base.new
+    end
+
+    describe '.subclasses' do
+      it { expect(Base.subclasses).to include(Growl, Knotify, NotifySend) }
+    end
+
+    describe '.installed?' do
+      it 'returns false as default' do
+        expect(Base).to_not be_installed
+      end
+    end
+
+    describe '.darwin?' do
+      context 'when the ruby platform is darwin' do
+        it 'returns true' do
+          expect(Base).to receive(:platform?).with(/darwin/).and_return(true)
+          expect(Base.darwin?).to be true
+        end
+      end
+
+      context 'when the ruby platform is not darwin' do
+        it 'returns false' do
+          expect(Base).to receive(:platform?).with(/darwin/).and_return(false)
+          expect(Base.darwin?).to be false
+        end
+      end
+    end
+
+    describe '#notify' do
+      before do
+        expect(base).to receive(:to_s).and_return('example')
+      end
+
+      context 'when the notify command runs without error' do
+        it 'calls system on #to_s method' do
+          expect(base).to receive(:system).with('example').and_return(true)
+          expect(base.notify).to be true
+        end
+      end
+
+      context 'when the notify command runs with error' do
+        it 'puts a install instruction if the system command returns false' do
+          expect(base).to receive(:system).with('example').and_return(false)
+          expect(base).to receive(:install_instructions).at_least(:once).and_return('Install')
+          expect(base).to receive(:puts).with('Install')
+          expect(base.notify).to be false
+        end
+
+        it 'do nothing when the instance does not have install instructions' do
+          expect(base).to receive(:system).with('example').and_return(false)
+          expect(base).to receive(:install_instructions).exactly(:once).and_return('')
+          expect(base).to_not receive(:puts)
+          expect(base.notify).to be false
+        end
+      end
+    end
+  end
+end

data/spec/notifiers/growl_spec.rb

@@ -1,108 +1,113 @@
 require 'spec_helper'
 
-describe Growl do
-  before do
-    @growl = growl
-  end
-
-  describe '#image' do
-    it "should keep the image" do
-      @growl.image('my_image.png')
-      @growl.instance_variable_get(:@image).should eql 'my_image.png'
-    end
+module Notifiers
+  describe Growl do
+    it_should_behave_like 'a notifier'
 
-    it "should set the image" do
-      @growl.image('wario.png')
-      @growl.instance_variable_get(:@image).should eql 'wario.png'
+    before do
+      @growl = growl
     end
 
-  end
-
-  describe '#message' do
+    describe '#image' do
+      it "should keep the image" do
+        @growl.image('my_image.png')
+        expect(@growl.instance_variable_get(:@image)).to eql 'my_image.png'
+      end
 
-    it "should set the message option" do
-      @growl.message('Hello World!')
-      @growl.instance_variable_get(:@message).should eql 'Hello World!'
+      it "should set the image" do
+        @growl.image('wario.png')
+        expect(@growl.instance_variable_get(:@image)).to eql 'wario.png'
+      end
     end
 
-    it "should set the message" do
-      @growl.message('May the Force be with you')
-      @growl.instance_variable_get(:@message).should eql 'May the Force be with you'
-    end
-  end
+    describe '#message' do
+      it "should set the message option" do
+        @growl.message('Hello World!')
+        expect(@growl.instance_variable_get(:@message)).to eql 'Hello World!'
+      end
 
-  describe '#title' do
-    it "should set the title" do
-      @growl.title('Nirvana')
-      @growl.instance_variable_get(:@title).should eql 'Nirvana'
+      it "should set the message" do
+        @growl.message('May the Force be with you')
+        expect(@growl.instance_variable_get(:@message)).to eql 'May the Force be with you'
+      end
     end
 
-    it "should set the title option" do
-      @growl.title('Pearl Jam')
-      @growl.instance_variable_get(:@title).should eql 'Pearl Jam'
-    end
-  end
-
-  describe '#priority' do
+    describe '#title' do
+      it "should set the title" do
+        @growl.title('Nirvana')
+        expect(@growl.instance_variable_get(:@title)).to eql 'Nirvana'
+      end
 
-    it "should set the priority" do
-      @growl.priority(0)
-      @growl.instance_variable_get(:@priority).should be 0
+      it "should set the title option" do
+        @growl.title('Pearl Jam')
+        expect(@growl.instance_variable_get(:@title)).to eql 'Pearl Jam'
+      end
     end
 
-    it "should set the priority number" do
-      @growl.priority(1)
-      @growl.instance_variable_get(:@priority).should be 1
-    end
-  end
-
-  describe '#host' do
+    describe '#priority' do
+      it "should set the priority" do
+        @growl.priority(0)
+        expect(@growl.instance_variable_get(:@priority)).to be 0
+      end
 
-    it "should set the hostname" do
-      @growl.host('localhost')
-      @growl.instance_variable_get(:@host).should eql 'localhost'
+      it "should set the priority number" do
+        @growl.priority(1)
+        expect(@growl.instance_variable_get(:@priority)).to be 1
+      end
     end
 
-    it "should set the host" do
-      @growl.host('beer_duff.com')
-      @growl.instance_variable_get(:@host).should eql 'beer_duff.com'
+    describe '#host' do
+      it "should set the hostname" do
+        @growl.host('localhost')
+        expect(@growl.instance_variable_get(:@host)).to eql 'localhost'
+      end
+
+      it "should set the host" do
+        @growl.host('beer_duff.com')
+        expect(@growl.instance_variable_get(:@host)).to eql 'beer_duff.com'
+      end
     end
-  end
 
-  describe '#password' do
+    describe '#password' do
+      it "should set the password" do
+        @growl.password('top_secret')
+        expect(@growl.instance_variable_get(:@password)).to eql 'top_secret'
+      end
 
-    it "should set the password" do
-      @growl.password('top_secret')
-      @growl.instance_variable_get(:@password).should eql 'top_secret'
+      it "should set the secret password" do
+        @growl.password('paradise_city')
+        expect(@growl.instance_variable_get(:@password)).to eql 'paradise_city'
+      end
     end
 
-    it "should set the secret password" do
-      @growl.password('paradise_city')
-      @growl.instance_variable_get(:@password).should eql 'paradise_city'
+    describe '#auth' do
+      it "should set the auth option" do
+        @growl.auth('SHA256')
+        expect(@growl.instance_variable_get(:@auth)).to eql 'SHA256'
+      end
     end
-  end
 
-  describe '#auth' do
-    it "should set the auth option" do
-      @growl.auth('SHA256')
-      @growl.instance_variable_get(:@auth).should eql 'SHA256'
-    end
-  end
+    describe '#to_s' do
+      it "should construct the command" do
+        command = @growl.message('Hello World!').priority(1).image('mario.png').to_s
+        expect(command).to eql "growlnotify --message 'Hello World!' --image mario.png --priority 1"
+      end
 
-  describe '#to_s' do
-    it "should construct the command" do
-      command = @growl.message('Hello World!').priority(1).image('mario.png').to_s
-      command.should eql "growlnotify --message 'Hello World!' --image mario.png --priority 1"
-    end
+      it "should construct the command with host password and auth" do
+        command = @growl.message('Donuts').host('duff_bear').auth('SHA256').password('welcome_to_the_jungle').to_s
+        expect(command).to eql "growlnotify --message 'Donuts' --host duff_bear --password welcome_to_the_jungle --auth SHA256"
+      end
 
-    it "should construct the command with host password and auth" do
-      command = @growl.message('Donuts').host('duff_bear').auth('SHA256').password('welcome_to_the_jungle').to_s
-      command.should eql "growlnotify --message 'Donuts' --host duff_bear --password welcome_to_the_jungle --auth SHA256"
+      it "should construct the command with title and message" do
+        command = @growl.message('Last Kiss').title('Pearl Jam').to_s
+        expect(command).to eql "growlnotify --title 'Pearl Jam' --message 'Last Kiss'"
+      end
     end
 
-    it "should construct the command with title and message" do
-      command = @growl.message('Last Kiss').title('Pearl Jam').to_s
-      command.should eql "growlnotify --title 'Pearl Jam' --message 'Last Kiss'"
+    describe '#install_instructions' do
+      it 'returns an more concise message' do
+        expect(@growl.install_instructions).to eq 'The Growl is not installed. You can find more details here: http://growl.info/downloads'
+      end
     end
   end
 end

data/spec/notifiers/knotify_spec.rb

@@ -1,44 +1,42 @@
 require 'spec_helper'
 
-describe Knotify do
+module Notifiers
+  describe Knotify do
+    it_should_behave_like 'a notifier'
 
-  before do
-    @knotify = Knotify.new
-  end
-
-  describe '#message' do
-    it "should set the message instance variable" do
-      @knotify.message('Bulls on Parade')
-      @knotify.instance_variable_get(:@message).should == 'Bulls on Parade'
-    end
-
-    it "should be possible to set the message instance variable" do
-      @knotify.message('Wake Up')
-      @knotify.instance_variable_get(:@message).should == 'Wake Up'
+    before do
+      @knotify = Knotify.new
     end
-  end
 
-  describe '#title' do
+    describe '#message' do
+      it "should set the message instance variable" do
+        @knotify.message('Bulls on Parade')
+        expect(@knotify.instance_variable_get(:@message)).to eql 'Bulls on Parade'
+      end
 
-    it "should set the title" do
-      @knotify.title('Rage Against the Machine')
-      @knotify.instance_variable_get(:@title).should == 'Rage Against the Machine'
+      it "should be possible to set the message instance variable" do
+        @knotify.message('Wake Up')
+        expect(@knotify.instance_variable_get(:@message)).to eql 'Wake Up'
+      end
     end
 
-    it "should be possible to set the title" do
-      @knotify.title('AudioSlave')
-      @knotify.instance_variable_get(:@title).should == 'AudioSlave'
-    end
+    describe '#title' do
+      it "should set the title" do
+        @knotify.title('Rage Against the Machine')
+        expect(@knotify.instance_variable_get(:@title)).to eql 'Rage Against the Machine'
+      end
 
-  end
-
-  describe '#to_s' do
-
-    it "should return the entire command" do
-      command = @knotify.title('Ruby').message('For the Win').to_s
-      command.should == "dcop knotify default notify eventname 'Ruby' 'For the Win' '' '' 12 1"
+      it "should be possible to set the title" do
+        @knotify.title('AudioSlave')
+        expect(@knotify.instance_variable_get(:@title)).to eql 'AudioSlave'
+      end
     end
 
+    describe '#to_s' do
+      it "should return the entire command" do
+        command = @knotify.title('Ruby').message('For the Win').to_s
+        expect(command).to eql "dcop knotify default notify eventname 'Ruby' 'For the Win' '' '' 12 1"
+      end
+    end
   end
-
 end

data/spec/notifiers/notify_send_spec.rb

@@ -1,117 +1,105 @@
 require 'spec_helper'
 
-describe NotifySend do
+module Notifiers
+  describe NotifySend do
+    it_should_behave_like 'a notifier'
 
-  before do
-    @notify_send = notify_send
-  end
-
-  describe '#image' do
-
-    it "should set the image" do
-      @notify_send.image('my_image.png')
-      @notify_send.instance_variable_get(:@icon).should eql 'my_image.png'
-    end
-
-    it "should set the icon option" do
-      @notify_send.image('homer_simpson.png')
-      @notify_send.instance_variable_get(:@icon).should eql 'homer_simpson.png'
-    end
-
-  end
-
-  describe '#message' do
-
-    it "should set the message" do
-      @notify_send.message('Oh Donuts!')
-      @notify_send.instance_variable_get(:@message).should eql 'Oh Donuts!'
-    end
-
-    it "should set the message option" do
-      @notify_send.message('Duff Beer')
-      @notify_send.instance_variable_get(:@message).should eql 'Duff Beer'
+    before do
+      @notify_send = notify_send
     end
 
-  end
-
-  describe '#title' do
-
-    it "should set the title" do
-      @notify_send.title('W00T!!')
-      @notify_send.instance_variable_get(:@title).should == 'W00T!!'
-    end
+    describe '#image' do
+      it "should set the image" do
+        @notify_send.image('my_image.png')
+        expect(@notify_send.instance_variable_get(:@icon)).to eql 'my_image.png'
+      end
 
-    it "should set a title as intance variable" do
-      @notify_send.title('Joker Owned Batman!')
-      @notify_send.instance_variable_get(:@title).should == 'Joker Owned Batman!'
+      it "should set the icon option" do
+        @notify_send.image('homer_simpson.png')
+        expect(@notify_send.instance_variable_get(:@icon)).to eql 'homer_simpson.png'
+      end
     end
 
-  end
-
-  describe '#urgency' do
+    describe '#message' do
+      it "should set the message" do
+        @notify_send.message('Oh Donuts!')
+        expect(@notify_send.instance_variable_get(:@message)).to eql 'Oh Donuts!'
+      end
 
-    it "should set the urgency instance variable to low" do
-      @notify_send.urgency(:low)
-      @notify_send.instance_variable_get(:@urgency).should == 'low'
+      it "should set the message option" do
+        @notify_send.message('Duff Beer')
+        expect(@notify_send.instance_variable_get(:@message)).to eql 'Duff Beer'
+      end
     end
 
-    it "should set he urgency instance variable to normal" do
-      @notify_send.urgency(:normal)
-      @notify_send.instance_variable_get(:@urgency).should == 'normal'
-    end
+    describe '#title' do
+      it "should set the title" do
+        @notify_send.title('W00T!!')
+        expect(@notify_send.instance_variable_get(:@title)).to eql 'W00T!!'
+      end
 
-    it "should set the urgency to critical" do
-      @notify_send.urgency(:critical)
-      @notify_send.instance_variable_get(:@urgency).should == 'critical'
+      it "should set a title as intance variable" do
+        @notify_send.title('Joker Owned Batman!')
+        expect(@notify_send.instance_variable_get(:@title)).to eql 'Joker Owned Batman!'
+      end
     end
 
-  end
-
-  describe '#expire_time' do
+    describe '#urgency' do
+      it "should set the urgency instance variable to low" do
+        @notify_send.urgency(:low)
+        expect(@notify_send.instance_variable_get(:@urgency)).to eql 'low'
+      end
 
-    it "should set the expire time" do
-      @notify_send.expire_time(1000)
-      @notify_send.instance_variable_get(:@expire_time).should == 1000
-    end
+      it "should set he urgency instance variable to normal" do
+        @notify_send.urgency(:normal)
+        expect(@notify_send.instance_variable_get(:@urgency)).to eql 'normal'
+      end
 
-    it "should set the expire time in miliseconds" do
-      @notify_send.expire_time(2000)
-      @notify_send.instance_variable_get(:@expire_time).should == 2000
+      it "should set the urgency to critical" do
+        @notify_send.urgency(:critical)
+        expect(@notify_send.instance_variable_get(:@urgency)).to eql 'critical'
+      end
     end
 
-  end
-
-  describe '#hint' do
+    describe '#expire_time' do
+      it "should set the expire time" do
+        @notify_send.expire_time(1000)
+        expect(@notify_send.instance_variable_get(:@expire_time)).to eql 1000
+      end
 
-    it "should set the hint" do
-      @notify_send.hint([:string, :me, :yeah])
-      @notify_send.instance_variable_get(:@hint).should == 'string:me:yeah'
+      it "should set the expire time in miliseconds" do
+        @notify_send.expire_time(2000)
+        expect(@notify_send.instance_variable_get(:@expire_time)).to eql 2000
+      end
     end
 
-    it "should set the hint in int" do
-      @notify_send.hint([:int, :me, 1])
-      @notify_send.instance_variable_get(:@hint).should == 'int:me:1'
-    end
-
-  end
-
-  describe '#to_s' do
+    describe '#hint' do
+      it "should set the hint" do
+        @notify_send.hint([:string, :me, :yeah])
+        expect(@notify_send.instance_variable_get(:@hint)).to eql 'string:me:yeah'
+      end
 
-    it "should transform in a command" do
-      command = @notify_send.title('Inception').message('3 levels').image('my_image.png').to_s
-      command.should == "notify-send --icon=my_image.png 'Inception' '3 levels'"
+      it "should set the hint in int" do
+        @notify_send.hint([:int, :me, 1])
+        expect(@notify_send.instance_variable_get(:@hint)).to eql 'int:me:1'
+      end
     end
 
-    it "should transform in a command to execute" do
-      command = @notify_send.title('Joker').message('Haha ha!').expire_time(1000).hint([:string, :me, :woot]).to_s
-      command.should == "notify-send --hint=string:me:woot --expire-time=1000 'Joker' 'Haha ha!'"
-    end
+    describe '#to_s' do
+      it "should transform in a command" do
+        command = @notify_send.title('Inception').message('3 levels').image('my_image.png').to_s
+        expect(command).to eql "notify-send --icon=my_image.png 'Inception' '3 levels'"
+      end
 
-    it "should transform in a command to execute" do
-      command = @notify_send.title('Batman').urgency(:critical).to_s
-      command.should == "notify-send --urgency=critical 'Batman'"
-    end
+      it "should transform in a command to execute" do
+        command = @notify_send.title('Joker').message('Haha ha!').expire_time(1000).hint([:string, :me, :woot]).to_s
+        expect(command).to eql "notify-send --hint=string:me:woot --expire-time=1000 'Joker' 'Haha ha!'"
+      end
 
+      it "should transform in a command to execute" do
+        command = @notify_send.title('Batman').urgency(:critical).to_s
+        expect(command).to eql "notify-send --urgency=critical 'Batman'"
+      end
+    end
   end
-
 end

data/spec/notifiers_spec.rb

@@ -1,13 +1,29 @@
 require 'spec_helper'
 
-describe 'notifiers' do
+describe Notifiers do
+  it { expect(growl).to be_instance_of(Notifiers::Growl) }
 
-  it { growl.should be_instance_of(Growl) }
+  it { expect(knotify).to be_instance_of(Notifiers::Knotify) }
 
-  it { knotify.should be_instance_of(Knotify) }
+  it { expect(notify_send).to be_instance_of(Notifiers::NotifySend) }
 
-  it { notify_send.should be_instance_of(NotifySend)}
+  it { expect(lib_notify).to be_instance_of(Notifiers::NotifySend) }
 
-  it { lib_notify.should be_instance_of(NotifySend)}
+  describe '#auto_discover' do
+    context 'when have a notifier library installed' do
+      it 'returns the notifier' do
+        expect(Notifiers::Growl).to receive(:installed?).and_return(true)
+        expect(auto_discover).to be_instance_of(Notifiers::Growl)
+      end
+    end
 
+    context 'when do not have a notifier library installed' do
+      it 'raises Notifier not Found' do
+        expect(Notifiers::Base).to receive(:subclasses).and_return([])
+        expect {
+          auto_discover
+        }.to raise_error(Notifiers::NotifierNotFound)
+      end
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -1,6 +1,22 @@
-
+require 'bundler/setup'
 require 'notifiers'
 
 RSpec.configure do |config|
   config.include Notifiers
+  config.filter_run focus: true
+  config.run_all_when_everything_filtered = true
+
+  config.expect_with :rspec do |c|
+    c.syntax = :expect
+  end
+end
+
+shared_examples_for 'a notifier' do
+  describe '#notify' do
+    it { expect(subject).to respond_to(:notify) }
+  end
+
+  describe '.installed?' do
+    it { expect(described_class).to respond_to(:installed?) }
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: notifiers
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Tomás D'Stefano
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-12 00:00:00.000000000 Z
+date: 2014-02-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '2.11'
+        version: '2.14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '2.11'
+        version: '2.14'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -48,17 +48,20 @@ files:
 - .gitignore
 - .infinity_test
 - .rspec
+- .travis.yml
 - Gemfile
-- Gemfile.lock
 - History.markdown
 - README.markdown
 - Rakefile
 - TODO.markdown
 - lib/notifiers.rb
+- lib/notifiers/base.rb
 - lib/notifiers/growl.rb
 - lib/notifiers/knotify.rb
+- lib/notifiers/notifier_not_found.rb
 - lib/notifiers/notify_send.rb
 - notifiers.gemspec
+- spec/notifiers/base_spec.rb
 - spec/notifiers/growl_spec.rb
 - spec/notifiers/knotify_spec.rb
 - spec/notifiers/notify_send_spec.rb

data/Gemfile.lock

@@ -1,25 +0,0 @@
-PATH
-  remote: .
-  specs:
-    notifiers (1.1.0)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    diff-lcs (1.1.3)
-    rspec (2.11.0)
-      rspec-core (~> 2.11.0)
-      rspec-expectations (~> 2.11.0)
-      rspec-mocks (~> 2.11.0)
-    rspec-core (2.11.1)
-    rspec-expectations (2.11.3)
-      diff-lcs (~> 1.1.3)
-    rspec-mocks (2.11.3)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  bundler (>= 1.0.0)
-  notifiers!
-  rspec (~> 2.11)