notifier 1.2.2 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8372bdfe560b7af14829350fbf06a4eec6efa573f6b87fe992dab61cc1dd74cd
-  data.tar.gz: bb4ebe4172bcea05940571909984b82d1e64eb146068ccffb00a6c028fe1313e
+  metadata.gz: 785cd994046d6e1654c06999c5909ab81b76056cd463c7b63cd72c58e096966e
+  data.tar.gz: a9db9eb14963b03a8ca59939a2a8afbf30994fa8b3fd1a8eea40689b72fcb298
 SHA512:
-  metadata.gz: f37a5e1fe74a4308edc897948c6450c272a4498a4a2abcf378133e1d8741235274b589809f77286eccfa28f1afce555ff36a4b33d33b3083ea42eedb587c0667
-  data.tar.gz: 8f67cf67140471f8621088032eda74d715150777482ad1afdfd5585949b473911e8a33c9ca87885576b4c05c910921832e2eced3bb371c25466eec1b260f846e
+  metadata.gz: f4b7c8f09062e9589abb6fa89c2266bf16c02d826ed428e3d04d139b651d370ca952ffc3ccaf53aa0f856f798ae5d7cabf14a34a29a217896a74f35973c104cb
+  data.tar.gz: 12c3ad81bd54842c608b84e3b4de1393e457e32f42e25c391ddae3952ebb7128419eb8009e26be14bc1cc656ad5a7d09d964755a2d40698cfd37a7215aee11a1

data/.rubocop.yml

@@ -3,7 +3,7 @@ inherit_gem:
   rubocop-fnando: .rubocop.yml
 
 AllCops:
-  TargetRubyVersion: 2.7
+  TargetRubyVersion: 3.4
   NewCops: enable
   Exclude:
     - vendor/**/*

data/README.md

@@ -7,6 +7,7 @@ Send system notifications on several platforms with a simple and unified API.
 Currently supports:
 
 - terminal-notifier (Notification Center wrapper for Mac OS X)
+- [HUD](https://fnando.gumroad.com/l/hud-macos)
 - Kdialog (Linux/KDE)
 - Knotify (Linux/KDE)
 - OSD Cat (Linux)
@@ -30,19 +31,23 @@ terminal-notifier also supports two additional flags:
 
 See terminal-notifier's help for additional information.
 
+#### hud
+
+- Install HUD - https://fnando.gumroad.com/l/hud-macos
+
 ### Linux
 
-If you're a linux guy, you can choose one of these methods:
+If you're a linux user, you can choose one of these methods:
 
 - Install libnotify-bin and its dependencies:
   `sudo aptitude install libnotify-bin`
 - Install xosd-bin: `sudo aptitude install xosd-bin`
-- KDE users don't need to install anything: Test Notifier will use +knotify+ or
-  +kdialog+.
+- KDE users don't need to install anything: Test Notifier will use `knotify` or
+  `kdialog`.
 
 ### Windows
 
-- Install Snarl: download from http://www.fullphat.net
+- Install Snarl: download from https://github.com/fullphat/snarl
 - Install ruby-snarl: `gem install ruby-snarl`
 
 ## Usage

data/lib/notifier/hud.rb

@@ -11,19 +11,18 @@ module Notifier
     def hud_bin
       @hud_bin ||= [
         "/Applications/hud.app/Contents/MacOS/cli",
-        "~/Applications/hud.app/Contents/MacOS/cli"
-      ].first {|path| File.expand_path(path) }
+        File.expand_path("~/Applications/hud.app/Contents/MacOS/cli")
+      ].find {|path| File.file?(path) }
     end
 
     def notify(options)
+      options[:image] ||= "apple.terminal"
+
       command = [
         hud_bin,
-        "--title",
-        options[:title].to_s,
-        "--message",
-        options[:message].to_s,
-        "--symbol-name",
-        options[:image].to_s
+        "--title", options[:title].to_s,
+        "--message", options[:message].to_s,
+        "--symbol-name", options[:image].to_s
       ]
 
       Thread.new { system(*command) }.join

data/lib/notifier/{placebo.rb → noop.rb}

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 module Notifier
-  module Placebo
+  module Noop
     extend self
 
     def supported?

data/lib/notifier/terminal_notifier.rb

@@ -11,9 +11,9 @@ module Notifier
     def notify(options)
       command = [
         "terminal-notifier",
+        "-ignoreDnD",
         "-group", "notifier-rubygems",
         "-title", options[:title].to_s,
-        "-appIcon", options.fetch(:image, "").to_s,
         "-message", options[:message].to_s,
         "-subtitle", options.fetch(:subtitle, "").to_s
       ]
@@ -21,16 +21,17 @@ module Notifier
       # -sound with an empty string (e.g., "") will trigger the
       # default sound so we need to check for it.
       if options[:sound]
-        command.concat([
-          "-sound",
-          options.fetch(:sound, "default").to_s
-        ])
+        command.push("-sound", options.fetch(:sound, "default").to_s)
       end
 
       Thread.new do
         Open3.popen3(*command) do |_stdin, _stdout, _stderr|
           # noop
         end
+
+        sleep 5
+
+        Open3.popen3("terminal-notifier", "-remove", "notifier-rubygems")
       end.join
     end
   end

data/lib/notifier/version.rb

@@ -3,8 +3,8 @@
 module Notifier
   module Version
     MAJOR = 1
-    MINOR = 2
-    PATCH = 2
-    STRING = "#{MAJOR}.#{MINOR}.#{PATCH}"
+    MINOR = 3
+    PATCH = 0
+    STRING = "#{MAJOR}.#{MINOR}.#{PATCH}".freeze
   end
 end

data/lib/notifier.rb

@@ -15,7 +15,7 @@ module Notifier
   require "notifier/knotify"
   require "notifier/kdialog"
   require "notifier/notify_send"
-  require "notifier/placebo"
+  require "notifier/noop"
   require "notifier/terminal_notifier"
   require "notifier/version"
 
@@ -26,7 +26,7 @@ module Notifier
   end
 
   def skip_constants
-    @skip_constants ||= %w[Placebo Adapters Version]
+    @skip_constants ||= %w[Noop Adapters Version]
   end
 
   def notifier
@@ -43,7 +43,7 @@ module Notifier
       const_get(name) unless skip_constants.include?(name.to_s)
     end
 
-    notifiers.sort_by(&:name) + [Placebo]
+    notifiers.sort_by(&:name) + [Noop]
   end
 
   def supported_notifiers

data/notifier.gemspec

@@ -11,20 +11,19 @@ Gem::Specification.new do |s|
   s.homepage    = "http://rubygems.org/gems/notifier"
   s.summary     = "Send system notifications on several platforms with a " \
                   "simple and unified API. Currently supports Libnotify, " \
-                  "OSD, KDE (Knotify and Kdialog) and Snarl"
+                  "OSD, HUD, KDE (Knotify and Kdialog) and Snarl"
   s.description = s.summary
-  s.required_ruby_version = ">= 2.7"
+  s.required_ruby_version = ">= 3.4"
   s.metadata["rubygems_mfa_required"] = "true"
 
   s.files         = `git ls-files`.split("\n")
-  s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.executables   = `git ls-files -- bin/*`.split("\n").map do |f|
     File.basename(f)
   end
   s.require_paths = ["lib"]
 
-  s.requirements << "terminal-notifier, Libnotify, OSD, KDE (Knotify and " \
-                    "Kdialog) or Snarl"
+  s.requirements << "terminal-notifier, HUD, Libnotify, OSD, " \
+                    "KDE (Knotify and Kdialog) or Snarl"
 
   s.add_development_dependency "minitest-utils"
   s.add_development_dependency "mocha"

data/test/notifier_test.rb

@@ -5,7 +5,7 @@ require "test_helper"
 class NotifierTest < Minitest::Test
   setup do
     Notifier.notifiers.each do |notifier|
-      unless notifier == Notifier::Placebo
+      unless notifier == Notifier::Noop
         notifier.stubs(:supported?).returns(false)
       end
     end
@@ -14,10 +14,6 @@ class NotifierTest < Minitest::Test
     ENV.delete("NOTIFIER")
   end
 
-  teardown do
-    Notifier.default_notifier = :hud
-  end
-
   test "retrieves list of supported notifiers" do
     Notifier::Snarl.stubs(:supported?).returns(true)
     Notifier::Knotify.stubs(:supported?).returns(true)
@@ -70,8 +66,8 @@ class NotifierTest < Minitest::Test
     assert_equal 8, Notifier.notifiers.size
   end
 
-  test "considers Placebo as fallback notifier" do
-    assert_equal Notifier::Placebo, Notifier.supported_notifiers.last
+  test "considers Noop as fallback notifier" do
+    assert_equal Notifier::Noop, Notifier.supported_notifiers.last
   end
 
   test "returns notifier by its name" do
@@ -82,6 +78,7 @@ class NotifierTest < Minitest::Test
 
   test "returns notifier by its name when supported" do
     Notifier::Snarl.expects(:supported?).returns(true)
+
     assert_equal Notifier::Snarl, Notifier.supported_notifier_from_name(:snarl)
   end
 

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: notifier
 version: !ruby/object:Gem::Version
-  version: 1.2.2
+  version: 1.3.0
 platform: ruby
 authors:
 - Nando Vieira
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-02-25 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest-utils
@@ -109,7 +108,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 description: Send system notifications on several platforms with a simple and unified
-  API. Currently supports Libnotify, OSD, KDE (Knotify and Kdialog) and Snarl
+  API. Currently supports Libnotify, OSD, HUD, KDE (Knotify and Kdialog) and Snarl
 email:
 - me@fnando.com
 executables: []
@@ -126,9 +125,9 @@ files:
 - lib/notifier/hud.rb
 - lib/notifier/kdialog.rb
 - lib/notifier/knotify.rb
+- lib/notifier/noop.rb
 - lib/notifier/notify_send.rb
 - lib/notifier/osd_cat.rb
-- lib/notifier/placebo.rb
 - lib/notifier/snarl.rb
 - lib/notifier/terminal_notifier.rb
 - lib/notifier/version.rb
@@ -140,7 +139,6 @@ homepage: http://rubygems.org/gems/notifier
 licenses: []
 metadata:
   rubygems_mfa_required: 'true'
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -148,20 +146,16 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.7'
+      version: '3.4'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements:
-- terminal-notifier, Libnotify, OSD, KDE (Knotify and Kdialog) or Snarl
-rubygems_version: 3.3.7
-signing_key:
+- terminal-notifier, HUD, Libnotify, OSD, KDE (Knotify and Kdialog) or Snarl
+rubygems_version: 4.0.3
 specification_version: 4
 summary: Send system notifications on several platforms with a simple and unified
-  API. Currently supports Libnotify, OSD, KDE (Knotify and Kdialog) and Snarl
-test_files:
-- test/notifier/snarl_test.rb
-- test/notifier_test.rb
-- test/test_helper.rb
+  API. Currently supports Libnotify, OSD, HUD, KDE (Knotify and Kdialog) and Snarl
+test_files: []