notifier 1.0.0 → 1.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4e8f22ae020099416927c4342232f8e37631292454b51036ee75a80227da2152
-  data.tar.gz: bed78ad310c8577665578bc763e1e3f20f100e368d66c9f13fd460b38486bb2a
+  metadata.gz: 8372bdfe560b7af14829350fbf06a4eec6efa573f6b87fe992dab61cc1dd74cd
+  data.tar.gz: bb4ebe4172bcea05940571909984b82d1e64eb146068ccffb00a6c028fe1313e
 SHA512:
-  metadata.gz: 2bca083c02fb0ee73772a8f3604ca2749b6e9cee6e6f75bff623afc948b0032aee87af722b3e071391731043749a0f1d9470b472c23f405e719b78df62183b9c
-  data.tar.gz: a082e4f102062da75d76e21253848bf1cf56a08780a3fac4c7f2e032310e5c9c45cf7005700e84ce7d336632aa7b7ace9dd8c5493196074350c4bc6fa9dfb79e
+  metadata.gz: f37a5e1fe74a4308edc897948c6450c272a4498a4a2abcf378133e1d8741235274b589809f77286eccfa28f1afce555ff36a4b33d33b3083ea42eedb587c0667
+  data.tar.gz: 8f67cf67140471f8621088032eda74d715150777482ad1afdfd5585949b473911e8a33c9ca87885576b4c05c910921832e2eced3bb371c25466eec1b260f846e

data/README.md

@@ -7,7 +7,6 @@ Send system notifications on several platforms with a simple and unified API.
 Currently supports:
 
 - terminal-notifier (Notification Center wrapper for Mac OS X)
-- GNTP Protocol (Growl, with Vagrant support)
 - Kdialog (Linux/KDE)
 - Knotify (Linux/KDE)
 - OSD Cat (Linux)
@@ -68,6 +67,14 @@ prefer:
 Notifier.default_notifier = :notify_send
 ```
 
+Alternatively, you can set the default notifier by using the `NOTIFIER` env var.
+The following example assumes `test_notifier` is configured on this Rails
+project. The env var has precedence of `Notifier.default_notifier`.
+
+```console
+$ NOTIFIER=hud rails test
+```
+
 The available names are `terminal_notifier`, `kdialog`, `knotify`,
 `notify_send`, `osd_cat`, and `snarl`.
 

data/lib/notifier/hud.rb

@@ -0,0 +1,32 @@
+# frozen_string_literal: true
+
+module Notifier
+  module Hud
+    extend self
+
+    def supported?
+      Notifier.os?(/darwin/) && hud_bin
+    end
+
+    def hud_bin
+      @hud_bin ||= [
+        "/Applications/hud.app/Contents/MacOS/cli",
+        "~/Applications/hud.app/Contents/MacOS/cli"
+      ].first {|path| File.expand_path(path) }
+    end
+
+    def notify(options)
+      command = [
+        hud_bin,
+        "--title",
+        options[:title].to_s,
+        "--message",
+        options[:message].to_s,
+        "--symbol-name",
+        options[:image].to_s
+      ]
+
+      Thread.new { system(*command) }.join
+    end
+  end
+end

data/lib/notifier/knotify.rb

@@ -12,9 +12,17 @@ module Notifier
 
     def notify(options)
       command = [
-        "dcop", "knotify", "default", "notify", "eventname",
-        options[:title].to_s, options[:message].to_s,
-        "", "", "16", "2"
+        "dcop",
+        "knotify",
+        "default",
+        "notify",
+        "eventname",
+        options[:title].to_s,
+        options[:message].to_s,
+        "",
+        "",
+        "16",
+        "2"
       ]
 
       Thread.new { system(*command) }.join

data/lib/notifier/version.rb

@@ -3,8 +3,8 @@
 module Notifier
   module Version
     MAJOR = 1
-    MINOR = 0
-    PATCH = 0
+    MINOR = 2
+    PATCH = 2
     STRING = "#{MAJOR}.#{MINOR}.#{PATCH}"
   end
 end

data/lib/notifier.rb

@@ -6,9 +6,11 @@ require "digest/md5"
 require "timeout"
 require "rbconfig"
 require "English"
+require "net/http"
 
 module Notifier
   require "notifier/snarl"
+  require "notifier/hud"
   require "notifier/osd_cat"
   require "notifier/knotify"
   require "notifier/kdialog"
@@ -28,7 +30,8 @@ module Notifier
   end
 
   def notifier
-    supported_notifier_from_name(default_notifier) || supported_notifiers.first
+    supported_notifier_from_name(ENV.fetch("NOTIFIER", default_notifier)) ||
+      supported_notifiers.first
   end
 
   def notify(options)
@@ -36,9 +39,11 @@ module Notifier
   end
 
   def notifiers
-    constants.filter_map do |name|
+    notifiers = constants.filter_map do |name|
       const_get(name) unless skip_constants.include?(name.to_s)
-    end + [Placebo]
+    end
+
+    notifiers.sort_by(&:name) + [Placebo]
   end
 
   def supported_notifiers

data/notifier.gemspec

@@ -32,4 +32,5 @@ Gem::Specification.new do |s|
   s.add_development_dependency "rubocop"
   s.add_development_dependency "rubocop-fnando"
   s.add_development_dependency "simplecov"
+  s.add_development_dependency "test_notifier"
 end

data/test/{notifier/notifier_test.rb → notifier_test.rb}

@@ -11,6 +11,11 @@ class NotifierTest < Minitest::Test
     end
 
     Notifier.default_notifier = nil
+    ENV.delete("NOTIFIER")
+  end
+
+  teardown do
+    Notifier.default_notifier = :hud
   end
 
   test "retrieves list of supported notifiers" do
@@ -23,8 +28,9 @@ class NotifierTest < Minitest::Test
   test "returns first available notifier" do
     Notifier::Snarl.stubs(:supported?).returns(true)
     Notifier::Knotify.stubs(:supported?).returns(true)
+    Notifier::Hud.stubs(:supported?).returns(true)
 
-    assert_equal Notifier::Snarl, Notifier.notifier
+    assert_equal Notifier::Hud, Notifier.notifier
   end
 
   test "prefers default notifier" do
@@ -36,6 +42,17 @@ class NotifierTest < Minitest::Test
     assert_equal Notifier::Knotify, Notifier.notifier
   end
 
+  test "prefers default notifier using env var" do
+    ENV["NOTIFIER"] = "knotify"
+
+    Notifier::Snarl.stubs(:supported?).returns(true)
+    Notifier::Knotify.stubs(:supported?).returns(true)
+
+    Notifier.default_notifier = :snarl
+
+    assert_equal Notifier::Knotify, Notifier.notifier
+  end
+
   test "sends notification" do
     params = {
       title: "Some title",
@@ -50,7 +67,7 @@ class NotifierTest < Minitest::Test
   end
 
   test "retrieves list of all notifiers" do
-    assert_equal 7, Notifier.notifiers.size
+    assert_equal 8, Notifier.notifiers.size
   end
 
   test "considers Placebo as fallback notifier" do
@@ -60,6 +77,7 @@ class NotifierTest < Minitest::Test
   test "returns notifier by its name" do
     assert_equal Notifier::OsdCat, Notifier.from_name(:osd_cat)
     assert_equal Notifier::NotifySend, Notifier.from_name(:notify_send)
+    assert_equal Notifier::Hud, Notifier.from_name(:hud)
   end
 
   test "returns notifier by its name when supported" do

data/test/test_helper.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+ENV.delete("NOTIFIER")
+
 require "simplecov"
 SimpleCov.start
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: notifier
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.2.2
 platform: ruby
 authors:
 - Nando Vieira
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-02-20 00:00:00.000000000 Z
+date: 2022-02-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest-utils
@@ -94,6 +94,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: test_notifier
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Send system notifications on several platforms with a simple and unified
   API. Currently supports Libnotify, OSD, KDE (Knotify and Kdialog) and Snarl
 email:
@@ -109,6 +123,7 @@ files:
 - README.md
 - Rakefile
 - lib/notifier.rb
+- lib/notifier/hud.rb
 - lib/notifier/kdialog.rb
 - lib/notifier/knotify.rb
 - lib/notifier/notify_send.rb
@@ -118,8 +133,8 @@ files:
 - lib/notifier/terminal_notifier.rb
 - lib/notifier/version.rb
 - notifier.gemspec
-- test/notifier/notifier_test.rb
 - test/notifier/snarl_test.rb
+- test/notifier_test.rb
 - test/test_helper.rb
 homepage: http://rubygems.org/gems/notifier
 licenses: []
@@ -147,6 +162,6 @@ specification_version: 4
 summary: Send system notifications on several platforms with a simple and unified
   API. Currently supports Libnotify, OSD, KDE (Knotify and Kdialog) and Snarl
 test_files:
-- test/notifier/notifier_test.rb
 - test/notifier/snarl_test.rb
+- test/notifier_test.rb
 - test/test_helper.rb