notifier 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: dd923128a3458ecd262b6bb21a948fa6a626ea43
-  data.tar.gz: 2954f0a783b91705f4b389c670a09611808e1242
+  metadata.gz: ded78a65a591a7d25fc841c511ed827622fc1463
+  data.tar.gz: db832909bd190d77d8dcdd2248a60a4098e616db
 SHA512:
-  metadata.gz: 71c15cf0499fb9e8896108ee4bba840313c142c79fc19ac0be6faee5fa0b4f38e47cd41f673eaa6e37e2600d75bd37539557eb974607696e7d991f149e4277e2
-  data.tar.gz: 066b7ee6f3fa640f7909d03640a65a9f0f29119b60d137edf97b3641c145fe88ec5738fe1b5c2cc8e2f82e0cfb2f43d6aeeae61a6dd0bc0a556b78bdae1195c6
+  metadata.gz: 2e26970c850341800b43a6d61865f82b95db278ed0666e8a550848d51b479cf837dbceaeb950224f0c1cceda8830f5f4ba0e69b027f2bf624a444adf08436d54
+  data.tar.gz: 96e7619e015a14c3383ccedca1423ce638cbbc771ac5789d9f455901b1bbf34d63c5356c70d9a7ef43107fa46eaf80c19263812f3ac02d55af1289cd9dee1f80

data/.gitignore

@@ -1,4 +1,5 @@
 pkg/*
 *.gem
 .bundle
-.DS_Store
+.DS_Store
+*.lock

data/README.rdoc

@@ -56,7 +56,7 @@ If your system support more than one notifier, you can specify which one you pre
 
   Notifier.default_notifier = :notify_send
 
-The available names are <tt>growl</tt>, <tt>kdialog</tt>, <tt>knotify</tt>, <tt>notify_send</tt>, <tt>osd_cat</tt>, and <tt>snarl</tt>.
+The available names are <tt>growl</tt>, <tt>terminal_notifier</tt>, <tt>kdialog</tt>, <tt>knotify</tt>, <tt>notify_send</tt>, <tt>osd_cat</tt>, and <tt>snarl</tt>.
 
 There are several helper methods that you can use in order to retrieve notifiers.
 

data/lib/notifier/growl.rb

@@ -14,13 +14,13 @@ module Notifier
       command = [
         "growlnotify",
         "--name", "test_notifier",
-        "--image", options.fetch(:image, ''),
+        "--image", options.fetch(:image, '').to_s,
         "--priority", "2",
-        "--message", options[:message],
-        options[:title]
+        "--message", options[:message].to_s,
+        options[:title].to_s
       ]
 
-      Thread.new { system(*command) }
+      Thread.new { system(*command) }.join
     end
 
     def register

data/lib/notifier/kdialog.rb

@@ -9,11 +9,12 @@ module Notifier
     def notify(options)
       command = [
         "kdialog",
-        "--title", options[:title],
-        "--passivepopup", options[:message], "5"
+        "--title", options[:title].to_s,
+        "--passivepopup", options[:message].to_s,
+        "5"
       ]
 
-      Thread.new { system(*command) }
+      Thread.new { system(*command) }.join
     end
   end
 end

data/lib/notifier/knotify.rb

@@ -9,11 +9,11 @@ module Notifier
     def notify(options)
       command = [
         "dcop", "knotify", "default", "notify", "eventname",
-        options[:title], options[:message],
+        options[:title].to_s, options[:message].to_s,
         "", "", "16", "2"
       ]
 
-      Thread.new { system(*command) }
+      Thread.new { system(*command) }.join
     end
   end
 end

data/lib/notifier/notify_send.rb

@@ -9,12 +9,12 @@ module Notifier
     def notify(options)
       command = [
         "notify-send", "-i",
-        options[:image],
-        options[:title],
-        options[:message]
+        options[:image].to_s,
+        options[:title].to_s,
+        options[:message].to_s
       ]
 
-      Thread.new { system(*command) }
+      Thread.new { system(*command) }.join
     end
   end
 end

data/lib/notifier/osd_cat.rb

@@ -7,7 +7,7 @@ module Notifier
     end
 
     def notify(options)
-      color = options.fetch(:color, "white")
+      color = options.fetch(:color, "white").to_s
 
       command = [
         "osd_cat",
@@ -26,7 +26,7 @@ module Notifier
           stdin.puts options[:message]
           stdin.close
         end
-      end
+      end.join
     end
   end
 end

data/lib/notifier/terminal_notifier.rb

@@ -10,12 +10,12 @@ module Notifier
       command = [
         "terminal-notifier",
         "-group", "notifier-rubygems",
-        "-title", options[:title],
-        "-appIcon", options.fetch(:image, ""),
-        "-message", options[:message]
+        "-title", options[:title].to_s,
+        "-appIcon", options.fetch(:image, "").to_s,
+        "-message", options[:message].to_s
       ]
 
-      Thread.new { system(*command) }
+      Thread.new { system(*command) }.join
     end
   end
 end

data/lib/notifier/version.rb

@@ -2,7 +2,7 @@ module Notifier
   module Version
     MAJOR = 0
     MINOR = 5
-    PATCH = 0
+    PATCH = 1
     STRING = "#{MAJOR}.#{MINOR}.#{PATCH}"
   end
 end

data/spec/notifier_spec.rb

@@ -7,22 +7,22 @@ describe Notifier do
   end
 
   it "retrieves list of supported notifiers" do
-    Notifier::Snarl.stub :supported? => true
-    Notifier::Knotify.stub :supported? => true
+    allow(Notifier::Snarl).to receive_messages :supported? => true
+    allow(Notifier::Knotify).to receive_messages :supported? => true
 
     expect(Notifier.supported_notifiers.size).to eql(3)
   end
 
   it "returns first available notifier" do
-    Notifier::Snarl.stub :supported? => true
-    Notifier::Knotify.stub :supported? => true
+    allow(Notifier::Snarl).to receive_messages :supported? => true
+    allow(Notifier::Knotify).to receive_messages :supported? => true
 
     expect(Notifier.notifier).to eql(Notifier::Snarl)
   end
 
   it "prefers default notifier" do
-    Notifier::Snarl.stub :supported? => true
-    Notifier::Knotify.stub :supported? => true
+    allow(Notifier::Snarl).to receive_messages :supported? => true
+    allow(Notifier::Knotify).to receive_messages :supported? => true
 
     Notifier.default_notifier = :knotify
 
@@ -36,8 +36,8 @@ describe Notifier do
       :image => "image.png"
     }
 
-    Notifier::Snarl.stub :supported? => true
-    Notifier::Snarl.should_receive(:notify).with(params)
+    allow(Notifier::Snarl).to receive_messages :supported? => true
+    expect(Notifier::Snarl).to receive(:notify).with(params)
 
     Notifier.notify(params)
   end
@@ -57,7 +57,7 @@ describe Notifier do
   end
 
   it "returns notifier by its name when supported" do
-    Notifier::Snarl.stub :supported? => true
+    allow(Notifier::Snarl).to receive_messages :supported? => true
     expect(Notifier.supported_notifier_from_name(:snarl)).to eql(Notifier::Snarl)
   end
 

data/spec/spec_helper.rb

@@ -3,7 +3,7 @@ require "notifier"
 module SpecHelpers
   def unsupport_all_notifiers
     Notifier.notifiers.each do |notifier|
-      notifier.stub :supported? => false unless notifier == Notifier::Placebo
+      allow(notifier).to receive_messages(:supported? => false) unless notifier == Notifier::Placebo
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: notifier
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Nando Vieira
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-30 00:00:00.000000000 Z
+date: 2015-03-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -49,7 +49,6 @@ files:
 - ".gitignore"
 - ".rspec"
 - Gemfile
-- Gemfile.lock
 - README.rdoc
 - Rakefile
 - lib/notifier.rb
@@ -89,7 +88,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements:
 - Growl, terminal-notifier, Libnotify, OSD, KDE (Knotify and Kdialog) or Snarl
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: Send system notifications on several platforms with a simple and unified

data/Gemfile.lock

@@ -1,26 +0,0 @@
-PATH
-  remote: .
-  specs:
-    notifier (0.5.0)
-
-GEM
-  remote: http://rubygems.org/
-  specs:
-    diff-lcs (1.2.5)
-    rake (10.3.1)
-    rspec (2.14.1)
-      rspec-core (~> 2.14.0)
-      rspec-expectations (~> 2.14.0)
-      rspec-mocks (~> 2.14.0)
-    rspec-core (2.14.8)
-    rspec-expectations (2.14.5)
-      diff-lcs (>= 1.1.3, < 2.0)
-    rspec-mocks (2.14.6)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  notifier!
-  rake
-  rspec