notifications 0.4.3 → 0.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 55c8e18fe2e682eaf7a45ef6fb104d0a8d7446d6
-  data.tar.gz: 74a390763224f92a43807c2dbd31f86c2e04c75f
+SHA256:
+  metadata.gz: 79db559c211b2011d5615a2ac349e6d36abf5ec76c61bb2fcb08db013d5ced50
+  data.tar.gz: cffba71597d27b35f00357c9a743645a9c276b673acc618214084110f0f46c75
 SHA512:
-  metadata.gz: 314ca88887751450405a13e24f6ed4c8a093e670e24efd688c4bb040fb08a0c2394f339487497cdc28d77ccfe4fcc88138dc409dcb1949e4a96b9777499c9f62
-  data.tar.gz: cc94c073af15fdb5bc721d99e9a057d331ec9654980422ec6de19d0ad2f64eccfc0585b07d10ab4705717f53256d7522b70b3b3a0caff00362aa7dd1da2584f5
+  metadata.gz: '0998a62dd596d90afcdc6289d4a54195f00ad39c782ef31e503f4263cd94309c5ce1660651f48a6686bf50749449f71cda01b6902bd1a8d0a2c2224f211385eb'
+  data.tar.gz: 754e36beeb1b439e4acaa89f7c651e36f21f884cac0a628ba3b081691abe92e9c23bac0955b787e2d60be463efa586f454162c44a14bb346af5b854988b617da

data/README.md

@@ -1,6 +1,6 @@
 # Notifications
 
-Rails mountable Notification for any applications.
+Mountable notifications for any Rails applications.
 
 [![Gem Version](https://badge.fury.io/rb/notifications.svg)](https://badge.fury.io/rb/notifications) [![Build Status](https://travis-ci.org/rails-engine/notifications.svg)](https://travis-ci.org/rails-engine/notifications) [![Code Climate](https://codeclimate.com/github/rails-engine/notifications/badges/gpa.svg)](https://codeclimate.com/github/rails-engine/notifications) [![codecov.io](https://codecov.io/github/rails-engine/notifications/coverage.svg?branch=master)](https://codecov.io/github/rails-engine/notifications?branch=master) [![](http://inch-ci.org/github/rails-engine/notifications.svg?branch=master)](http://inch-ci.org/github/rails-engine/notifications?branch=master)
 
@@ -17,13 +17,13 @@ gem 'notifications'
 
 And then run `bundle install`.
 
-Now you have notifications generator in Rails application:
+You now have a notifications generator in your Rails application:
 
 ```bash
 $ rails g notifications:install
 ```
 
-And, you can generate views, controller if you need custom them:
+You can generate views, controllers if you need to customize them:
 
 ```bash
 $ rails g notifications:views
@@ -56,7 +56,7 @@ class Comment
 end
 ```
 
-Get user unread count:
+Get unread notifications count for a user:
 
 ```rb
 count = Notification.unread_count(current_user)
@@ -64,7 +64,7 @@ count = Notification.unread_count(current_user)
 
 ### Write your custom Notification partial view for notify_types:
 
-If you create a notify_type, you need add a partial view in `app/views/notifications/` path, for example:
+If you create a notify_type, you need to add a partial view in `app/views/notifications/` path, for example:
 
 ```rb
 # There have two notify_type
@@ -72,7 +72,7 @@ Notification.create(notify_type: 'follow' ....)
 Notification.create(notify_type: 'mention', target: @reply, second_target: @topic, ....)
 ```
 
-You app must be have:
+You app must have:
 
 - app/views/notifications/_follow.html.erb
 - app/views/notifications/_mention.html.erb
@@ -87,7 +87,7 @@ You app must be have:
 ```erb
 # app/views/notifications/_mention.html.erb
 <div class="media-heading">
-  <%= link_to notification.actor.title, notification.actor %> has mention you in
+  <%= link_to notification.actor.title, notification.actor %> has mentioned you in
   <%= link_to notification.second_target.title, topic_path(notification.second_target) %>
 </div>
 <div class="media-content">
@@ -97,7 +97,7 @@ You app must be have:
 
 ### About Notification template N+1 performance
 
-Suggest you to use [second_level_cache](https://github.com/hooopo/second_level_cache) for solve N+1 performance issue.
+It is recommended that you use [second_level_cache](https://github.com/hooopo/second_level_cache) for solving N+1 performance issues.
 
 ## Contributing
 

data/db/migrate/20160328045436_create_notifications.rb

@@ -1,4 +1,4 @@
-class CreateNotifications < ActiveRecord::Migration[4.2]
+class CreateNotifications < ActiveRecord::Migration[5.0]
   def change
     create_table :notifications do |t|
       t.integer :user_id, null: false

data/lib/notifications/model.rb

@@ -5,7 +5,7 @@ module Notifications
     DEFAULT_AVATAR = 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAPAAAADwCAMAAAAJixmgAAAAFVBMVEWkpKSnp6eqqqq3t7fS0tLV1dXZ2dmshcKEAAAAtklEQVR4Ae3XsRGAAAjAQFRk/5HtqaTz5H+DlInvAQAAAAAAAAAAAAAAAAAAAACymiveO6o7BQsWLFiwYMGCBS8PFixYsGDBggULFixYsGDBggULFixYsGDBggULFixYsGDBc4IFCxYsWLBgwYIFC14ZfOeAPRQ8IliwYMGCBQsWLFiwYMGCBQsWLFiwYMGCBQsWLFiwYMGCBQsWLFiwYMGCBQv+JQAAAAAAAAAAAAAAAAAAAOAB4KJfdHmj+kwAAAAASUVORK5CYII='
 
     included do
-      belongs_to :actor, class_name: Notifications.config.user_class
+      belongs_to :actor, class_name: Notifications.config.user_class, optional: true
       belongs_to :user, class_name: Notifications.config.user_class
 
       belongs_to :target, polymorphic: true, optional: true

data/lib/notifications/version.rb

@@ -1,3 +1,3 @@
 module Notifications
-  VERSION = '0.4.3'
+  VERSION = '0.4.4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: notifications
 version: !ruby/object:Gem::Version
-  version: 0.4.3
+  version: 0.4.4
 platform: ruby
 authors:
 - Jason Lee
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-16 00:00:00.000000000 Z
+date: 2018-02-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -89,7 +89,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Rails mountable Notification for any applications.