noticed 2.2.1 → 2.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 205cad1bba9c4d875d180be2f65ba4aaab52a32441ce145c81325c49978058be
-  data.tar.gz: 873716a4c09250b3b5fef685f690fb43a9c99e6b754e66355bac46bdaeac120b
+  metadata.gz: 70482becaedf2461851b7c9f8f0afd9c37a2c4caa9c2d5622cf007b212988730
+  data.tar.gz: '023579ed0635603e27fe99473bb77b17bda4bce7a0ac9ad0533179a6570693c3'
 SHA512:
-  metadata.gz: 6d911291bb8bcf378371e5e3c33eb5e4456a977ce2e9bc19af3301e3fea9d34d85fc9ce0bca71ad1498d041578b858eb1d39bb3b668fcad21da8378a1d7b38e4
-  data.tar.gz: 64de0e142c6be7482068830d06f96413391ac38f7dbfd7089c80ee70b957ab1e30edbdf9c70670b52e245a182c69c8a417515aedf5f89e7ad8fcae98c4e072ea
+  metadata.gz: 923f424527ae03b0a9cb24d3fc83f59b9b7d914d7b0f53db928cc9d12b6757ee20fa1a7b810735d2a1657f7ee8a5b7efdee03d69de5b73c8fa31dae6c5400dd0
+  data.tar.gz: 2fd06825b9afabd447c867b54c8e31207b7c180d32a5f1ff341b543cf90d1cf9f4a1b65d398e230789e51d9b40cce42e3ebd04611f5970e520e9086e3eeae85f

data/README.md

@@ -331,6 +331,7 @@ class IosNotifier < Noticed::Event
     config.before_enqueue = ->{ throw(:abort) unless recipient.registered_ios? }
   end
 end
+```
 
 #### Tip: Extracting Delivery Method Configurations
 
@@ -644,7 +645,7 @@ class DeliveryMethods::WhatsApp < Noticed::DeliveryMethod
   def deliver
     # ...
     config.day #=> #<Proc:0x000f7c8 (lambda)>
-    evaluate_option(config.day) #=> "Tuesday"
+    evaluate_option(:day) #=> "Tuesday"
   end
 end
 ```
@@ -693,12 +694,6 @@ user.notifications.mark_as_unread
 
 #### Instance methods
 
-Convert back into a Noticed notifier object:
-
-```ruby
-@notification.to_notifier
-```
-
 Mark notification as read / unread:
 
 ```ruby

data/app/models/concerns/noticed/deliverable.rb

@@ -70,8 +70,12 @@ module Noticed
       end
 
       def with(params)
-        record = params.delete(:record)
-        new(params: params, record: record)
+        if self < Ephemeral
+          new(params: params)
+        else
+          record = params.delete(:record)
+          new(params: params, record: record)
+        end
       end
 
       def deliver(recipients = nil, **options)

data/lib/noticed/delivery_method.rb

@@ -38,8 +38,8 @@ module Noticed
     end
 
     def fetch_constant(name)
-      option = config[name]
-      option.is_a?(String) ? option.constantize : evaluate_option(option)
+      option = evaluate_option(name)
+      option.is_a?(String) ? option.constantize : option
     end
 
     def evaluate_option(name)

data/lib/noticed/delivery_methods/action_cable.rb

@@ -4,11 +4,15 @@ module Noticed
       required_options :message
 
       def deliver
-        channel = fetch_constant(:channel) || Noticed::NotificationChannel
-        stream = evaluate_option(:stream) || recipient
-        message = evaluate_option(:message)
+        channel.broadcast_to stream, evaluate_option(:message)
+      end
+
+      def channel
+        fetch_constant(:channel) || Noticed::NotificationChannel
+      end
 
-        channel.broadcast_to stream, message
+      def stream
+        evaluate_option(:stream) || recipient
       end
     end
   end

data/lib/noticed/delivery_methods/twilio_messaging.rb

@@ -3,6 +3,12 @@ module Noticed
     class TwilioMessaging < DeliveryMethod
       def deliver
         post_request url, basic_auth: {user: account_sid, pass: auth_token}, form: json.stringify_keys
+      rescue Noticed::ResponseUnsuccessful => exception
+        if exception.response.code.start_with?("4") && config[:error_handler]
+          notification.instance_exec(exception.response, &config[:error_handler])
+        else
+          raise
+        end
       end
 
       def json

data/lib/noticed/version.rb

@@ -1,3 +1,3 @@
 module Noticed
-  VERSION = "2.2.1"
+  VERSION = "2.3.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: noticed
 version: !ruby/object:Gem::Version
-  version: 2.2.1
+  version: 2.3.0
 platform: ruby
 authors:
 - Chris Oliver
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-03-20 00:00:00.000000000 Z
+date: 2024-05-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -100,7 +100,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.4
+rubygems_version: 3.5.10
 signing_key:
 specification_version: 4
 summary: Notifications for Ruby on Rails applications