noticed 1.2.4 → 1.2.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2936d217d3d881874888d8dd68280ecc9888f41fc1edf3f195e713bf863d2233
-  data.tar.gz: a73fba77cb4eebead7c3d343c501cbe7ca5b19db5a24b11b6d33e6674c41a1f9
+  metadata.gz: aab5129001fd96625a6a4141dfcf8aa93263b691fb663faa25e66153c5df9244
+  data.tar.gz: 22d30af822563d150c933bc5aeb2116386db73bcb114d82cf46059ae53c9407e
 SHA512:
-  metadata.gz: 67f055f8a05d3418caf3c21c2a3938341705752e6154284bbe596ac31563fd715c7d29d5651f690ce310433d762b7dca05e99ec8326b93d477a85db91cddfd10
-  data.tar.gz: 3fbaf13b4dd6f7f3fa9f50a52849ef0ff112268c730cdca202f2e421fd7f66cdc797147c549911addb2161ed2c40d7738d6d85e5d420427f46658eaef5b13b81
+  metadata.gz: 1ecf9ce4e2be01cbb171a86f1fe10feb2931e2035c8f857f2b98951c5f8e299b9eadef7b0b1086f53b971f5fa5a31f266491c57f5715cf615b7acc7cf828f518
+  data.tar.gz: 8f896e1e98893d611697c10ebb30e6359a5cafefc9b54d6eff7a434b05eef90d055ed82e9e1d3ed61fcb76dbc2c0be4b5845ebdff799527e745507c919070585

data/Rakefile

@@ -18,6 +18,10 @@ require "bundler/gem_tasks"
 
 require "rake/testtask"
 
+APP_RAKEFILE = File.expand_path("test/dummy/Rakefile", __dir__)
+load "rails/tasks/engine.rake"
+load "rails/tasks/statistics.rake"
+
 Rake::TestTask.new(:test) do |t|
   t.libs << "test"
   t.pattern = "test/**/*_test.rb"

data/lib/noticed/base.rb

@@ -29,9 +29,10 @@ module Noticed
         new(params)
       end
 
-      def param(name)
-        param_names.push(name)
+      def params(*names)
+        param_names.concat Array.wrap(names)
       end
+      alias param params
     end
 
     def initialize(params = {})
@@ -68,6 +69,9 @@ module Noticed
     def run_delivery(recipient, enqueue: true)
       delivery_methods = self.class.delivery_methods.dup
 
+      # Set recipient to instance var so it is available to Notification class
+      @recipient = recipient
+
       # Run database delivery inline first if it exists so other methods have access to the record
       if (index = delivery_methods.find_index { |m| m[:name] == :database })
         delivery_method = delivery_methods.delete_at(index)

data/lib/noticed/coder.rb

@@ -1,11 +1,19 @@
 module Noticed
   class Coder
     def self.load(data)
+      return if data.nil?
+
+      # Text columns need JSON parsing
+      if data.is_a?(String)
+        data = JSON.parse(data)
+      end
+
       ActiveJob::Arguments.send(:deserialize_argument, data)
     end
 
     def self.dump(data)
-      ActiveJob::Arguments.send(:serialize_argument, data)
+      return if data.nil?
+      ActiveJob::Arguments.send(:serialize_argument, data).to_json
     end
   end
 end

data/lib/noticed/delivery_methods/action_cable.rb

@@ -16,11 +16,19 @@ module Noticed
       end
 
       def channel
-        if (method = options[:channel])
-          notification.send(method)
-        else
-          Noticed::NotificationChannel
-        end
+        @channel ||= begin
+           value = options[:channel]
+           case value
+           when String
+             value.constantize
+           when Symbol
+             notification.send(value)
+           when Class
+             value
+           else
+             Noticed::NotificationChannel
+           end
+         end
       end
     end
   end

data/lib/noticed/delivery_methods/slack.rb

@@ -11,7 +11,7 @@ module Noticed
         if (method = options[:format])
           notification.send(method)
         else
-          params
+          notification.params
         end
       end
 

data/lib/noticed/delivery_methods/twilio.rb

@@ -2,7 +2,7 @@ module Noticed
   module DeliveryMethods
     class Twilio < Base
       def deliver
-        HTTP.basic_auth(user: account_sid, pass: auth_token).post(url, json: format)
+        HTTP.basic_auth(user: account_sid, pass: auth_token).post(url, form: format)
       end
 
       private

data/lib/noticed/translation.rb

@@ -13,7 +13,7 @@ module Translation
 
   def scope_translation_key(key)
     if key.to_s.start_with?(".")
-      "notifications.#{self.class.name.underscore}#{key}"
+      "#{i18n_scope}.#{self.class.name.underscore}#{key}"
     else
       key
     end

data/lib/noticed/version.rb

@@ -1,3 +1,3 @@
 module Noticed
-  VERSION = "1.2.4"
+  VERSION = "1.2.9"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: noticed
 version: !ruby/object:Gem::Version
-  version: 1.2.4
+  version: 1.2.9
 platform: ruby
 authors:
 - Chris Oliver
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-08-04 00:00:00.000000000 Z
+date: 2020-08-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails