notable 0.6.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 91975df22291af40ac05c843a010f31596265d0d079b425bdd3c67e6a39cfc33
-  data.tar.gz: 6545cf681ab0754e5ca2c53dca09f604dc4a8ea83fa54a2fe0e0ae7386814d08
+  metadata.gz: ee82589dc34dfe74acd8795e2c089121c53eb41a00287f716ac52ea2ced317cc
+  data.tar.gz: c17132eb0b6332e7a48aa6a9618a40f838ccb21cd241da502f52621a2324ee73
 SHA512:
-  metadata.gz: be3f75a95fba1891c522b206f6810565930b963393fec88326ff4b9dde63ec338be9fd45a8ff2b697781f2b1d4270a9619476b5266fe2f60bc6232d8c19bd8ee
-  data.tar.gz: eb6f5b4dc56aa25df22a5fa628fb689f2fe78244826ad542deb85694ff4927438abfd475d6fd3ba4187ce3fc00d5e7aa4b8d81d7d4446d5e6e35c15abc150224
+  metadata.gz: 9844579f84fa695a6f5333e279d3b51b2872dc915e2dd116250b6c9950a0b4dfe5cf0849120d0fbd4d2bb58990f07a168eedbe2959391bb925b7bf3b68d228e9
+  data.tar.gz: 44597e910a31f9c6c9d4905c428663d3b64c9c03b7bdb18cc300487d067b2171acda11eb70d1f7548e0b2aea413902342450fe95df7983a0ecd2d7156b5857cf

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+## 0.7.0 (2026-04-15)
+
+- Enabled `scrub_invalid_utf8` by default
+- Dropped support for Ruby < 3.3 and Rails < 7.2
+
+## 0.6.1 (2026-02-07)
+
+- Added `scrub_invalid_utf8` option
+- Improved handling of invalid parameters
+
 ## 0.6.0 (2025-04-03)
 
 - Dropped support for Ruby < 3.2 and Rails < 7.1

data/LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright (c) 2014-2025 Andrew Kane
+Copyright (c) 2014-2026 Andrew Kane
 
 MIT License
 

data/README.md

@@ -1,7 +1,5 @@
 # Notable
 
-:star2: :star2: :star2:
-
 Notable tracks notable requests and background jobs and stores them in your database.  What makes a request or job notable? There are a number of default situations, but ultimately you decide what interests you.
 
 By default, Notable tracks:

data/lib/notable/engine.rb

@@ -6,8 +6,9 @@ module Notable
       if Notable.requests_enabled?
         # insert in same place as request_store
         app.config.middleware.insert_after ActionDispatch::RequestId, Notable::Middleware
-        # TODO switch to register_interceptor in 0.6.0
-        ActionDispatch::DebugExceptions.prepend Notable::DebugExceptions
+        ActionDispatch::DebugExceptions.register_interceptor do |request, exception|
+          request.env["action_dispatch.exception"] = exception
+        end
       end
     end
   end

data/lib/notable/job_extensions.rb

@@ -4,8 +4,7 @@ module Notable
 
     included do
       around_perform do |job, block|
-        # enqueued_at is only available in Active Job 6+
-        Notable.track_job(job.class.name, job.job_id, job.queue_name, job.try(:enqueued_at), try(:notable_slow_job_threshold)) do
+        Notable.track_job(job.class.name, job.job_id, job.queue_name, job.enqueued_at, try(:notable_slow_job_threshold)) do
           block.call
         end
       end

data/lib/notable/middleware.rb

@@ -10,8 +10,7 @@ module Notable
       request_time = Notable.monotonic_time - start_time
 
       Safely.safely do
-        if env["action_dispatch.exception"]
-          e = env["action_dispatch.exception"]
+        if (e = env["action_dispatch.exception"]) && (!defined?(ActionController::TooManyRequests) || !e.is_a?(ActionController::TooManyRequests))
           message =
             case status.to_i
             when 404
@@ -37,11 +36,19 @@ module Notable
           url = request.original_url
 
           controller = env["action_controller.instance"]
-          action = controller && "#{controller.params["controller"]}##{controller.params["action"]}"
-          params = controller && controller.request.filtered_parameters.except("controller", "action")
+          action = controller && "#{controller.controller_path}##{controller.action_name}"
+          params = controller && (controller.request.filtered_parameters.except("controller", "action") rescue nil)
 
           user = Notable.user_method.call(env)
 
+          user_agent = request.user_agent
+          referrer = request.referer
+
+          if Notable.scrub_invalid_utf8
+            user_agent = user_agent&.scrub
+            referrer = referrer&.scrub
+          end
+
           notes.each do |note|
             ip = request.remote_ip
             if ip && Notable.mask_ips
@@ -57,9 +64,9 @@ module Notable
               params: params,
               request_id: request.uuid,
               ip: ip,
-              user_agent: request.user_agent,
+              user_agent: user_agent,
               url: url,
-              referrer: request.referer,
+              referrer: referrer,
               request_time: request_time
             }
             Notable.track_request_method.call(data, env)

data/lib/notable/throttle.rb

@@ -1,7 +1,11 @@
-ActiveSupport::Notifications.subscribe "rack.attack" do |_name, _start, _finish, _request_id, req|
+ActiveSupport::Notifications.subscribe "rack.attack" do |_, _, _, _, req|
   request = req.is_a?(Hash) ? req[:request] : req
 
   if [:blacklist, :blocklist, :throttle].include?(request.env["rack.attack.match_type"])
     Notable.track "Throttle", request.env["rack.attack.matched"]
   end
 end
+
+ActiveSupport::Notifications.subscribe "rate_limit.action_controller" do |_, _, _, _, _|
+  Notable.track "Throttle", "throttle note"
+end

data/lib/notable/unpermitted_parameters.rb

@@ -1,3 +1,3 @@
-ActiveSupport::Notifications.subscribe "unpermitted_parameters.action_controller" do |_name, _start, _finish, _id, payload|
+ActiveSupport::Notifications.subscribe "unpermitted_parameters.action_controller" do |_, _, _, _, payload|
   Notable.track "Unpermitted Parameters", payload[:keys].join(", ")
 end

data/lib/notable/version.rb

@@ -1,3 +1,3 @@
 module Notable
-  VERSION = "0.6.0"
+  VERSION = "0.7.0"
 end

data/lib/notable.rb

@@ -3,7 +3,6 @@ require "active_support"
 require "safely/core"
 
 # modules
-require_relative "notable/debug_exceptions"
 require_relative "notable/middleware"
 require_relative "notable/throttle"
 require_relative "notable/unpermitted_parameters"
@@ -22,6 +21,7 @@ module Notable
     attr_accessor :user_method
     attr_accessor :slow_request_threshold
     attr_accessor :mask_ips
+    attr_accessor :scrub_invalid_utf8
 
     # jobs
     attr_accessor :track_job_method
@@ -31,6 +31,7 @@ module Notable
   self.requests_enabled = true
   self.jobs_enabled = true
   self.mask_ips = false
+  self.scrub_invalid_utf8 = true
 
   def self.requests_enabled?
     enabled && requests_enabled

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: notable
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.7.0
 platform: ruby
 authors:
 - Andrew Kane
 bindir: bin
 cert_chain: []
-date: 2025-04-03 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -15,28 +15,28 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '7.1'
+        version: '7.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '7.1'
+        version: '7.2'
 - !ruby/object:Gem::Dependency
   name: safely_block
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.4'
+        version: '1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0.4'
+        version: '1'
 email: andrew@ankane.org
 executables: []
 extensions: []
@@ -52,7 +52,6 @@ files:
 - lib/generators/notable/templates/create_jobs.rb.tt
 - lib/generators/notable/templates/create_requests.rb.tt
 - lib/notable.rb
-- lib/notable/debug_exceptions.rb
 - lib/notable/engine.rb
 - lib/notable/job_extensions.rb
 - lib/notable/middleware.rb
@@ -72,14 +71,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '3.2'
+      version: '3.3'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.2
+rubygems_version: 4.0.6
 specification_version: 4
 summary: Track notable requests and background jobs
 test_files: []

data/lib/notable/debug_exceptions.rb

@@ -1,8 +0,0 @@
-module Notable
-  module DebugExceptions
-    def render_exception(request, exception, *)
-      request.env["action_dispatch.exception"] = exception
-      super
-    end
-  end
-end