notable 0.3.4 → 0.4.1
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/CHANGELOG.md +8 -0
- data/LICENSE.txt +1 -1
- data/README.md +6 -2
- data/lib/notable/middleware.rb +4 -4
- data/lib/notable/version.rb +1 -1
- data/lib/notable.rb +12 -4
- metadata +11 -123
checksums.yaml
CHANGED
@@ -1,7 +1,7 @@
|
|
1
1
|
---
|
2
2
|
SHA256:
|
3
|
-
metadata.gz:
|
4
|
-
data.tar.gz:
|
3
|
+
metadata.gz: 714094d0059bb07c9e66ab382626795bc81b1e8cdd695f7354198531bab9caa9
|
4
|
+
data.tar.gz: bc36e2654ebd17188b2fb913d3f745ebf40487a57f1e0e82b3ca6a041d4d9975
|
5
5
|
SHA512:
|
6
|
-
metadata.gz:
|
7
|
-
data.tar.gz:
|
6
|
+
metadata.gz: 1590cf5d58fcb9d9bf8021081392b089390218ae3fc525a44f4404dad41302c12c54117aeee658386855321458e17360f12b5ef98bb263e401ee106a95820341
|
7
|
+
data.tar.gz: d128c411ed50df17b835d6dcddad2d9dcf3bc0c7094756586709316f604ba0a63cbb5ca00d79f192285895d854f9f8a3c2d4ec3adcf14699cc016b097fa44923
|
data/CHANGELOG.md
CHANGED
data/LICENSE.txt
CHANGED
data/README.md
CHANGED
@@ -19,14 +19,14 @@ You can track custom notes as well.
|
|
19
19
|
|
20
20
|
:tangerine: Battle-tested at [Instacart](https://www.instacart.com/opensource)
|
21
21
|
|
22
|
-
[![Build Status](https://
|
22
|
+
[![Build Status](https://github.com/ankane/notable/workflows/build/badge.svg?branch=master)](https://github.com/ankane/notable/actions)
|
23
23
|
|
24
24
|
## Installation
|
25
25
|
|
26
26
|
Add this line to your application’s Gemfile:
|
27
27
|
|
28
28
|
```ruby
|
29
|
-
gem
|
29
|
+
gem "notable"
|
30
30
|
```
|
31
31
|
|
32
32
|
And run:
|
@@ -134,6 +134,10 @@ Notable.track_job_method = lambda do |data|
|
|
134
134
|
end
|
135
135
|
```
|
136
136
|
|
137
|
+
## History
|
138
|
+
|
139
|
+
View the [changelog](https://github.com/ankane/notable/blob/master/CHANGELOG.md)
|
140
|
+
|
137
141
|
## Contributing
|
138
142
|
|
139
143
|
Everyone is encouraged to help improve this project. Here are a few ways you can help:
|
data/lib/notable/middleware.rb
CHANGED
@@ -5,9 +5,9 @@ module Notable
|
|
5
5
|
end
|
6
6
|
|
7
7
|
def call(env)
|
8
|
-
start_time =
|
8
|
+
start_time = Notable.monotonic_time
|
9
9
|
status, headers, body = @app.call(env)
|
10
|
-
request_time =
|
10
|
+
request_time = Notable.monotonic_time - start_time
|
11
11
|
|
12
12
|
Safely.safely do
|
13
13
|
if env["action_dispatch.exception"]
|
@@ -22,11 +22,11 @@ module Notable
|
|
22
22
|
"Error"
|
23
23
|
end
|
24
24
|
Notable.track message, "#{e.class.name}: #{e.message}"
|
25
|
-
elsif (!status
|
25
|
+
elsif (!status || status.to_i >= 400) && !Notable.notes.any?
|
26
26
|
Notable.track Rack::Utils::HTTP_STATUS_CODES[status.to_i]
|
27
27
|
end
|
28
28
|
|
29
|
-
if request_time > Notable.slow_request_threshold
|
29
|
+
if request_time > Notable.slow_request_threshold && status.to_i != 503
|
30
30
|
Notable.track "Slow Request"
|
31
31
|
end
|
32
32
|
|
data/lib/notable/version.rb
CHANGED
data/lib/notable.rb
CHANGED
@@ -69,9 +69,8 @@ module Notable
|
|
69
69
|
slow_job_threshold ||= Notable.slow_job_threshold
|
70
70
|
exception = nil
|
71
71
|
notes = nil
|
72
|
-
|
73
|
-
|
74
|
-
queued_time = created_at ? start_time - created_at : nil
|
72
|
+
started_at = Time.now # wall time
|
73
|
+
start_time = monotonic_time
|
75
74
|
begin
|
76
75
|
yield
|
77
76
|
rescue Exception => e
|
@@ -81,11 +80,16 @@ module Notable
|
|
81
80
|
notes = Notable.notes
|
82
81
|
Notable.clear_notes
|
83
82
|
end
|
84
|
-
runtime =
|
83
|
+
runtime = monotonic_time - start_time
|
85
84
|
|
86
85
|
Safely.safely do
|
87
86
|
notes << {note_type: "Slow Job"} if runtime > slow_job_threshold
|
88
87
|
|
88
|
+
if notes.any?
|
89
|
+
created_at = Time.parse(created_at) if created_at.is_a?(String)
|
90
|
+
queued_time = created_at ? [started_at - created_at, 0].max : nil
|
91
|
+
end
|
92
|
+
|
89
93
|
notes.each do |note|
|
90
94
|
data = {
|
91
95
|
note_type: note[:note_type],
|
@@ -114,6 +118,10 @@ module Notable
|
|
114
118
|
addr.mask(48).to_s
|
115
119
|
end
|
116
120
|
end
|
121
|
+
|
122
|
+
def self.monotonic_time
|
123
|
+
Process.clock_gettime(Process::CLOCK_MONOTONIC)
|
124
|
+
end
|
117
125
|
end
|
118
126
|
|
119
127
|
ActiveSupport.on_load(:action_controller) do
|
metadata
CHANGED
@@ -1,14 +1,14 @@
|
|
1
1
|
--- !ruby/object:Gem::Specification
|
2
2
|
name: notable
|
3
3
|
version: !ruby/object:Gem::Version
|
4
|
-
version: 0.
|
4
|
+
version: 0.4.1
|
5
5
|
platform: ruby
|
6
6
|
authors:
|
7
7
|
- Andrew Kane
|
8
|
-
autorequire:
|
8
|
+
autorequire:
|
9
9
|
bindir: bin
|
10
10
|
cert_chain: []
|
11
|
-
date:
|
11
|
+
date: 2022-09-27 00:00:00.000000000 Z
|
12
12
|
dependencies:
|
13
13
|
- !ruby/object:Gem::Dependency
|
14
14
|
name: activesupport
|
@@ -16,14 +16,14 @@ dependencies:
|
|
16
16
|
requirements:
|
17
17
|
- - ">="
|
18
18
|
- !ruby/object:Gem::Version
|
19
|
-
version: '5'
|
19
|
+
version: '5.2'
|
20
20
|
type: :runtime
|
21
21
|
prerelease: false
|
22
22
|
version_requirements: !ruby/object:Gem::Requirement
|
23
23
|
requirements:
|
24
24
|
- - ">="
|
25
25
|
- !ruby/object:Gem::Version
|
26
|
-
version: '5'
|
26
|
+
version: '5.2'
|
27
27
|
- !ruby/object:Gem::Dependency
|
28
28
|
name: safely_block
|
29
29
|
requirement: !ruby/object:Gem::Requirement
|
@@ -38,120 +38,8 @@ dependencies:
|
|
38
38
|
- - ">="
|
39
39
|
- !ruby/object:Gem::Version
|
40
40
|
version: 0.1.1
|
41
|
-
|
42
|
-
|
43
|
-
requirement: !ruby/object:Gem::Requirement
|
44
|
-
requirements:
|
45
|
-
- - ">="
|
46
|
-
- !ruby/object:Gem::Version
|
47
|
-
version: '0'
|
48
|
-
type: :development
|
49
|
-
prerelease: false
|
50
|
-
version_requirements: !ruby/object:Gem::Requirement
|
51
|
-
requirements:
|
52
|
-
- - ">="
|
53
|
-
- !ruby/object:Gem::Version
|
54
|
-
version: '0'
|
55
|
-
- !ruby/object:Gem::Dependency
|
56
|
-
name: rake
|
57
|
-
requirement: !ruby/object:Gem::Requirement
|
58
|
-
requirements:
|
59
|
-
- - ">="
|
60
|
-
- !ruby/object:Gem::Version
|
61
|
-
version: '0'
|
62
|
-
type: :development
|
63
|
-
prerelease: false
|
64
|
-
version_requirements: !ruby/object:Gem::Requirement
|
65
|
-
requirements:
|
66
|
-
- - ">="
|
67
|
-
- !ruby/object:Gem::Version
|
68
|
-
version: '0'
|
69
|
-
- !ruby/object:Gem::Dependency
|
70
|
-
name: minitest
|
71
|
-
requirement: !ruby/object:Gem::Requirement
|
72
|
-
requirements:
|
73
|
-
- - ">="
|
74
|
-
- !ruby/object:Gem::Version
|
75
|
-
version: '5'
|
76
|
-
type: :development
|
77
|
-
prerelease: false
|
78
|
-
version_requirements: !ruby/object:Gem::Requirement
|
79
|
-
requirements:
|
80
|
-
- - ">="
|
81
|
-
- !ruby/object:Gem::Version
|
82
|
-
version: '5'
|
83
|
-
- !ruby/object:Gem::Dependency
|
84
|
-
name: combustion
|
85
|
-
requirement: !ruby/object:Gem::Requirement
|
86
|
-
requirements:
|
87
|
-
- - ">="
|
88
|
-
- !ruby/object:Gem::Version
|
89
|
-
version: '0'
|
90
|
-
type: :development
|
91
|
-
prerelease: false
|
92
|
-
version_requirements: !ruby/object:Gem::Requirement
|
93
|
-
requirements:
|
94
|
-
- - ">="
|
95
|
-
- !ruby/object:Gem::Version
|
96
|
-
version: '0'
|
97
|
-
- !ruby/object:Gem::Dependency
|
98
|
-
name: rails
|
99
|
-
requirement: !ruby/object:Gem::Requirement
|
100
|
-
requirements:
|
101
|
-
- - ">="
|
102
|
-
- !ruby/object:Gem::Version
|
103
|
-
version: '0'
|
104
|
-
type: :development
|
105
|
-
prerelease: false
|
106
|
-
version_requirements: !ruby/object:Gem::Requirement
|
107
|
-
requirements:
|
108
|
-
- - ">="
|
109
|
-
- !ruby/object:Gem::Version
|
110
|
-
version: '0'
|
111
|
-
- !ruby/object:Gem::Dependency
|
112
|
-
name: sqlite3
|
113
|
-
requirement: !ruby/object:Gem::Requirement
|
114
|
-
requirements:
|
115
|
-
- - ">="
|
116
|
-
- !ruby/object:Gem::Version
|
117
|
-
version: '0'
|
118
|
-
type: :development
|
119
|
-
prerelease: false
|
120
|
-
version_requirements: !ruby/object:Gem::Requirement
|
121
|
-
requirements:
|
122
|
-
- - ">="
|
123
|
-
- !ruby/object:Gem::Version
|
124
|
-
version: '0'
|
125
|
-
- !ruby/object:Gem::Dependency
|
126
|
-
name: rack-attack
|
127
|
-
requirement: !ruby/object:Gem::Requirement
|
128
|
-
requirements:
|
129
|
-
- - ">="
|
130
|
-
- !ruby/object:Gem::Version
|
131
|
-
version: '0'
|
132
|
-
type: :development
|
133
|
-
prerelease: false
|
134
|
-
version_requirements: !ruby/object:Gem::Requirement
|
135
|
-
requirements:
|
136
|
-
- - ">="
|
137
|
-
- !ruby/object:Gem::Version
|
138
|
-
version: '0'
|
139
|
-
- !ruby/object:Gem::Dependency
|
140
|
-
name: slowpoke
|
141
|
-
requirement: !ruby/object:Gem::Requirement
|
142
|
-
requirements:
|
143
|
-
- - ">="
|
144
|
-
- !ruby/object:Gem::Version
|
145
|
-
version: '0'
|
146
|
-
type: :development
|
147
|
-
prerelease: false
|
148
|
-
version_requirements: !ruby/object:Gem::Requirement
|
149
|
-
requirements:
|
150
|
-
- - ">="
|
151
|
-
- !ruby/object:Gem::Version
|
152
|
-
version: '0'
|
153
|
-
description:
|
154
|
-
email: andrew@chartkick.com
|
41
|
+
description:
|
42
|
+
email: andrew@ankane.org
|
155
43
|
executables: []
|
156
44
|
extensions: []
|
157
45
|
extra_rdoc_files: []
|
@@ -179,7 +67,7 @@ homepage: https://github.com/ankane/notable
|
|
179
67
|
licenses:
|
180
68
|
- MIT
|
181
69
|
metadata: {}
|
182
|
-
post_install_message:
|
70
|
+
post_install_message:
|
183
71
|
rdoc_options: []
|
184
72
|
require_paths:
|
185
73
|
- lib
|
@@ -187,15 +75,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
|
|
187
75
|
requirements:
|
188
76
|
- - ">="
|
189
77
|
- !ruby/object:Gem::Version
|
190
|
-
version: '2.
|
78
|
+
version: '2.6'
|
191
79
|
required_rubygems_version: !ruby/object:Gem::Requirement
|
192
80
|
requirements:
|
193
81
|
- - ">="
|
194
82
|
- !ruby/object:Gem::Version
|
195
83
|
version: '0'
|
196
84
|
requirements: []
|
197
|
-
rubygems_version: 3.
|
198
|
-
signing_key:
|
85
|
+
rubygems_version: 3.3.7
|
86
|
+
signing_key:
|
199
87
|
specification_version: 4
|
200
88
|
summary: Track notable requests and background jobs
|
201
89
|
test_files: []
|