notable 0.2.0 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: c4d9ade6391e626b6456ce4fbbea37d0978327c1
-  data.tar.gz: 3c5baf92e0867ae2e94790613a28ab843217ecb0
+SHA256:
+  metadata.gz: 97e610b1e6274a603bf4404cad75d7fb024b265b2ccad352916940e3f1b81dd1
+  data.tar.gz: 0b7b71c06fcf86d5b9cf5b3aa10439d7902d3c9a185ce52ae50ce43a63aa8030
 SHA512:
-  metadata.gz: 2b46b38463983747feb4521469f6896c20a682b5c41a465743548ab6a6fcb811c991270039dc9b631086984273eee8b1f43560c5de23d1667bafc32df979ad4e
-  data.tar.gz: 07573eecf3ea2442f48ef5cd22e00130b815e866e36e1bcbc3062ac1bdae56b1c719590f46f9deba10f9cce6525759edb38381eb309efcdab015587a79ccd97f
+  metadata.gz: 24736ec76486d7f1dc515bbf7d45da6c0d4328f56b27232ace17df78f5899b9dd1230b4f11a4c62baa5ac729df2d113b595f038467d9099a0f62d5d111dabcb8
+  data.tar.gz: a2af6018e63f62f886be2212b6349909ee3d36f15aaa16063508d0420366921afd12b8b27e914ebcc889f0af4287dad87e8fa7dd956729341a976bb1b3c2c3af

data/CHANGELOG.md

@@ -1,8 +1,31 @@
-## 0.2.0
+## 0.3.2 (2020-07-24)
+
+- Added support for Rails API
+- Fixed blocked requests with Rack::Attack
+
+## 0.3.1 (2020-05-20)
+
+- Fixed deprecation warning in Ruby 2.7
+
+## 0.3.0 (2019-05-28)
+
+- Added support for Rack::Attack 6
+- Added job-specific slow job threshold
+- Dropped support for Rails 4.2
+
+## 0.2.2 (2018-05-18)
+
+- Added `mask_ips` option
+
+## 0.2.1 (2017-05-01)
+
+- Added support for Rails 5.1
+
+## 0.2.0 (2017-01-16)
 
 - Switched to ActiveJob for jobs
 - Fixed deprecation warnings
 
-## 0.1.0
+## 0.1.0 (2016-02-20)
 
 - Launched

data/LICENSE.txt

@@ -1,4 +1,4 @@
-Copyright (c) 2014 Andrew Kane
+Copyright (c) 2014-2020 Andrew Kane
 
 MIT License
 

data/README.md

@@ -23,6 +23,8 @@ You can track custom notes as well.
 
 :tangerine: Battle-tested at [Instacart](https://www.instacart.com/opensource)
 
+[![Build Status](https://travis-ci.org/ankane/notable.svg?branch=master)](https://travis-ci.org/ankane/notable)
+
 ## Installation
 
 Add this line to your application’s Gemfile:
@@ -36,10 +38,10 @@ And run:
 ```sh
 rails generate notable:requests
 rails generate notable:jobs
-rake db:migrate
+rails db:migrate
 ```
 
-For a web interface, check out [Notable Web](https://github.com/ankane/notable_web).
+To explore the data, check out [Blazer](https://github.com/ankane/blazer).
 
 ## Requests
 
@@ -50,7 +52,7 @@ A `Notable::Request` is created for:
 - slow requests
 - timeouts
 - validation failures
-- [CSRF failures](http://guides.rubyonrails.org/security.html#cross-site-request-forgery-csrf)
+- [CSRF failures](https://guides.rubyonrails.org/security.html#cross-site-request-forgery-csrf)
 - unpermitted parameters
 - blocked and throttled requests
 
@@ -93,23 +95,23 @@ Notable.enabled = Rails.env.production?
 Set slow threshold
 
 ```ruby
-Notable.slow_request_threshold = 5 # seconds (default)
+Notable.slow_request_threshold = 5.seconds
 ```
 
 Custom user method
 
 ```ruby
-Notable.user_method = -> (env) {
+Notable.user_method = lambda do |env|
   env["warden"].try(:user) || env["action_controller.instance"].try(:current_visit)
-}
+end
 ```
 
 Custom track method
 
 ```ruby
-Notable.track_request_method = -> (data, env) {
+Notable.track_request_method = lambda do |data, env|
   Notable::Request.create!(data)
-}
+end
 ```
 
 Skip tracking CSRF failures
@@ -118,26 +120,37 @@ Skip tracking CSRF failures
 skip_before_action :track_unverified_request
 ```
 
+Anonymize IP addresses
+
+```ruby
+Notable.mask_ips = true
+```
+
 ### Jobs
 
 Set slow threshold
 
 ```ruby
-Notable.slow_job_threshold = 60 # seconds (default)
+Notable.slow_job_threshold = 60.seconds
 ```
 
-Custom track method
+To set a threshold for a specific job, use:
 
 ```ruby
-Notable.track_job_method = -> (data) {
-  Notable::Job.create!(data)
-}
+class CustomJob < ApplicationJob
+  def notable_slow_job_threshold
+    5.minutes
+  end
+end
 ```
 
-## TODO
+Custom track method
 
-- ability to disable features
-- add indexes
+```ruby
+Notable.track_job_method = lambda do |data|
+  Notable::Job.create!(data)
+end
+```
 
 ## Contributing
 
@@ -147,3 +160,12 @@ Everyone is encouraged to help improve this project. Here are a few ways you can
 - Fix bugs and [submit pull requests](https://github.com/ankane/notable/pulls)
 - Write, clarify, or fix documentation
 - Suggest or add new features
+
+To get started with development:
+
+```sh
+git clone https://github.com/ankane/notable.git
+cd notable
+bundle install
+bundle exec rake test
+```

data/app/models/notable/request.rb

@@ -2,7 +2,7 @@ module Notable
   class Request < ActiveRecord::Base
     self.table_name = "notable_requests"
 
-    belongs_to :user, polymorphic: true
+    belongs_to :user, polymorphic: true, optional: true
     serialize :params, JSON
   end
 end

data/lib/generators/notable/jobs_generator.rb

@@ -1,28 +1,17 @@
-# taken from https://github.com/collectiveidea/audited/blob/master/lib/generators/audited/install_generator.rb
-require "rails/generators"
-require "rails/generators/migration"
-require "active_record"
 require "rails/generators/active_record"
 
 module Notable
   module Generators
     class JobsGenerator < Rails::Generators::Base
-      include Rails::Generators::Migration
+      include ActiveRecord::Generators::Migration
+      source_root File.join(__dir__, "templates")
 
-      source_root File.expand_path("../templates", __FILE__)
-
-      # Implement the required interface for Rails::Generators::Migration.
-      def self.next_migration_number(dirname) #:nodoc:
-        next_migration_number = current_migration_number(dirname) + 1
-        if ActiveRecord::Base.timestamped_migrations
-          [Time.now.utc.strftime("%Y%m%d%H%M%S"), "%.14d" % next_migration_number].max
-        else
-          "%.3d" % next_migration_number
-        end
+      def copy_migration
+        migration_template "create_jobs.rb", "db/migrate/create_notable_jobs.rb", migration_version: migration_version
       end
 
-      def copy_migration
-        migration_template "create_jobs.rb", "db/migrate/create_notable_jobs.rb"
+      def migration_version
+        "[#{ActiveRecord::VERSION::MAJOR}.#{ActiveRecord::VERSION::MINOR}]"
       end
     end
   end

data/lib/generators/notable/requests_generator.rb

@@ -1,28 +1,17 @@
-# taken from https://github.com/collectiveidea/audited/blob/master/lib/generators/audited/install_generator.rb
-require "rails/generators"
-require "rails/generators/migration"
-require "active_record"
 require "rails/generators/active_record"
 
 module Notable
   module Generators
     class RequestsGenerator < Rails::Generators::Base
-      include Rails::Generators::Migration
+      include ActiveRecord::Generators::Migration
+      source_root File.join(__dir__, "templates")
 
-      source_root File.expand_path("../templates", __FILE__)
-
-      # Implement the required interface for Rails::Generators::Migration.
-      def self.next_migration_number(dirname) #:nodoc:
-        next_migration_number = current_migration_number(dirname) + 1
-        if ActiveRecord::Base.timestamped_migrations
-          [Time.now.utc.strftime("%Y%m%d%H%M%S"), "%.14d" % next_migration_number].max
-        else
-          "%.3d" % next_migration_number
-        end
+      def copy_migration
+        migration_template "create_requests.rb", "db/migrate/create_notable_requests.rb", migration_version: migration_version
       end
 
-      def copy_migration
-        migration_template "create_requests.rb", "db/migrate/create_notable_requests.rb"
+      def migration_version
+        "[#{ActiveRecord::VERSION::MAJOR}.#{ActiveRecord::VERSION::MINOR}]"
       end
     end
   end

data/lib/generators/notable/templates/{create_jobs.rb → create_jobs.rb.tt}

@@ -1,4 +1,4 @@
-class <%= migration_class_name %> < ActiveRecord::Migration
+class <%= migration_class_name %> < ActiveRecord::Migration<%= migration_version %>
   def change
     create_table :notable_jobs do |t|
       t.string :note_type
@@ -6,8 +6,8 @@ class <%= migration_class_name %> < ActiveRecord::Migration
       t.text :job
       t.string :job_id
       t.string :queue
-      t.decimal :runtime
-      t.decimal :queued_time
+      t.float :runtime
+      t.float :queued_time
       t.timestamp :created_at
     end
   end

data/lib/generators/notable/templates/{create_requests.rb → create_requests.rb.tt}

@@ -1,10 +1,9 @@
-class <%= migration_class_name %> < ActiveRecord::Migration
+class <%= migration_class_name %> < ActiveRecord::Migration<%= migration_version %>
   def change
     create_table :notable_requests do |t|
       t.string :note_type
       t.text :note
-      t.integer :user_id
-      t.string :user_type
+      t.references :user, polymorphic: true
       t.text :action
       t.integer :status
       t.text :url
@@ -13,10 +12,8 @@ class <%= migration_class_name %> < ActiveRecord::Migration
       t.text :user_agent
       t.text :referrer
       t.text :params
-      t.decimal :request_time
+      t.float :request_time
       t.timestamp :created_at
     end
-
-    add_index :notable_requests, [:user_id, :user_type]
   end
 end

data/lib/notable.rb

@@ -1,19 +1,15 @@
-require "notable/version"
-
-require "request_store"
+# dependencies
+require "active_support"
 require "safely/core"
-require "action_dispatch/middleware/debug_exceptions"
-
-# middleware
-require "notable/middleware"
-require "notable/engine" if defined?(Rails)
 
-# requests
-require "notable/unpermitted_parameters"
-require "notable/unverified_request"
-require "notable/validation_errors"
+# modules
 require "notable/debug_exceptions"
+require "notable/middleware"
 require "notable/throttle"
+require "notable/unpermitted_parameters"
+require "notable/version"
+
+require "notable/engine" if defined?(Rails)
 
 module Notable
   class << self
@@ -25,6 +21,7 @@ module Notable
     attr_accessor :track_request_method
     attr_accessor :user_method
     attr_accessor :slow_request_threshold
+    attr_accessor :mask_ips
 
     # jobs
     attr_accessor :track_job_method
@@ -33,6 +30,7 @@ module Notable
   self.enabled = true
   self.requests_enabled = true
   self.jobs_enabled = true
+  self.mask_ips = false
 
   def self.requests_enabled?
     enabled && requests_enabled
@@ -43,7 +41,7 @@ module Notable
   end
 
   # requests
-  self.track_request_method = -> (data, env) { Notable::Request.create!(data) }
+  self.track_request_method = -> (data, _) { Notable::Request.create!(data) }
   self.user_method = -> (env) { env["warden"].user if env["warden"] }
   self.slow_request_threshold = 5
 
@@ -52,7 +50,7 @@ module Notable
   self.slow_job_threshold = 60
 
   def self.track(note_type, note = nil)
-    (RequestStore.store[:notable_notes] ||= []) << {note_type: note_type, note: note}
+    notes << {note_type: note_type, note: note}
   end
 
   def self.track_error(e)
@@ -60,14 +58,15 @@ module Notable
   end
 
   def self.notes
-    RequestStore.store[:notable_notes].to_a
+    Thread.current[:notable_notes] ||= []
   end
 
   def self.clear_notes
-    RequestStore.store.delete(:notable_notes)
+    Thread.current[:notable_notes] = nil
   end
 
-  def self.track_job(job, job_id, queue, created_at)
+  def self.track_job(job, job_id, queue, created_at, slow_job_threshold = nil)
+    slow_job_threshold ||= Notable.slow_job_threshold
     exception = nil
     notes = nil
     start_time = Time.now
@@ -84,7 +83,7 @@ module Notable
     runtime = Time.now - start_time
 
     Safely.safely do
-      notes << {note_type: "Slow Job"} if runtime > Notable.slow_job_threshold
+      notes << {note_type: "Slow Job"} if runtime > slow_job_threshold
 
       notes.each do |note|
         data = {
@@ -103,6 +102,27 @@ module Notable
 
     raise exception if exception
   end
+
+  def self.mask_ip(ip)
+    addr = IPAddr.new(ip)
+    if addr.ipv4?
+      # set last octet to 0
+      addr.mask(24).to_s
+    else
+      # set last 80 bits to zeros
+      addr.mask(48).to_s
+    end
+  end
+end
+
+ActiveSupport.on_load(:action_controller) do
+  require "notable/unverified_request"
+  include Notable::UnverifiedRequest
+end
+
+ActiveSupport.on_load(:active_record) do
+  require "notable/validation_errors"
+  include Notable::ValidationErrors
 end
 
 ActiveSupport.on_load(:active_job) do

data/lib/notable/engine.rb

@@ -4,8 +4,9 @@ module Notable
 
     initializer "notable" do |app|
       if Notable.requests_enabled?
-        app.config.middleware.insert_after RequestStore::Middleware, Notable::Middleware
-        ActionDispatch::DebugExceptions.send(:prepend, Notable::DebugExceptions)
+        # insert in same place as request_store
+        app.config.middleware.insert_after ActionDispatch::RequestId, Notable::Middleware
+        ActionDispatch::DebugExceptions.prepend Notable::DebugExceptions
       end
     end
   end

data/lib/notable/job_extensions.rb

@@ -5,7 +5,7 @@ module Notable
     included do
       around_perform do |job, block|
         # no way to get queued_at time :(
-        Notable.track_job(job.class.name, job.job_id, job.queue_name, nil) do
+        Notable.track_job(job.class.name, job.job_id, job.queue_name, nil, try(:notable_slow_job_threshold)) do
           block.call
         end
       end

data/lib/notable/middleware.rb

@@ -1,6 +1,5 @@
 module Notable
   class Middleware
-
     def initialize(app)
       @app = app
     end
@@ -44,6 +43,11 @@ module Notable
           user = Notable.user_method.call(env)
 
           notes.each do |note|
+            ip = request.remote_ip
+            if ip && Notable.mask_ips
+              ip = Notable.mask_ip(ip)
+            end
+
             data = {
               note_type: note[:note_type],
               note: note[:note],
@@ -52,7 +56,7 @@ module Notable
               status: status,
               params: params,
               request_id: request.uuid,
-              ip: request.remote_ip,
+              ip: ip,
               user_agent: request.user_agent,
               url: url,
               referrer: request.referer,
@@ -64,7 +68,8 @@ module Notable
       end
 
       [status, headers, body]
+    ensure
+      Notable.clear_notes
     end
-
   end
 end

data/lib/notable/throttle.rb

@@ -1,5 +1,7 @@
-ActiveSupport::Notifications.subscribe "rack.attack" do |name, start, finish, request_id, req|
-  if [:blacklist, :throttle].include?(req.env["rack.attack.match_type"])
-    Notable.track "Throttle", req.env["rack.attack.matched"]
+ActiveSupport::Notifications.subscribe "rack.attack" do |_name, _start, _finish, _request_id, req|
+  request = req.is_a?(Hash) ? req[:request] : req
+
+  if [:blacklist, :blocklist, :throttle].include?(request.env["rack.attack.match_type"])
+    Notable.track "Throttle", request.env["rack.attack.matched"]
   end
 end

data/lib/notable/unpermitted_parameters.rb

@@ -1,3 +1,3 @@
-ActiveSupport::Notifications.subscribe "unpermitted_parameters.action_controller" do |name, start, finish, id, payload|
+ActiveSupport::Notifications.subscribe "unpermitted_parameters.action_controller" do |_name, _start, _finish, _id, payload|
   Notable.track "Unpermitted Parameters", payload[:keys].join(", ")
 end

data/lib/notable/unverified_request.rb

@@ -7,7 +7,7 @@ module Notable
     end
 
     def track_unverified_request
-      if !verified_request?
+      if respond_to?(:verified_request?, true) && !verified_request?
         expected = form_authenticity_token
         actual = form_authenticity_param || request.headers["X-CSRF-Token"]
         Notable.track "Unverified Request", "#{actual || "nil"} != #{expected}"
@@ -15,5 +15,3 @@ module Notable
     end
   end
 end
-
-ActionController::Base.send(:include, Notable::UnverifiedRequest)

data/lib/notable/validation_errors.rb

@@ -13,5 +13,3 @@ module Notable
     end
   end
 end
-
-ActiveRecord::Base.send(:include, Notable::ValidationErrors)

data/lib/notable/version.rb

@@ -1,3 +1,3 @@
 module Notable
-  VERSION = "0.2.0"
+  VERSION = "0.3.2"
 end

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: notable
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.2
 platform: ruby
 authors:
 - Andrew Kane
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-17 00:00:00.000000000 Z
+date: 2020-07-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: request_store
+  name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '5'
 - !ruby/object:Gem::Dependency
   name: safely_block
   requirement: !ruby/object:Gem::Requirement
@@ -42,49 +42,129 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: minitest
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '5'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '5'
+- !ruby/object:Gem::Dependency
+  name: combustion
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
-description: Track notable requests and background jobs
-email:
-- andrew@chartkick.com
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: sqlite3
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rack-attack
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: slowpoke
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+description: 
+email: andrew@chartkick.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
 - CHANGELOG.md
-- Gemfile
 - LICENSE.txt
 - README.md
-- Rakefile
 - app/models/notable/job.rb
 - app/models/notable/request.rb
 - lib/generators/notable/jobs_generator.rb
 - lib/generators/notable/requests_generator.rb
-- lib/generators/notable/templates/create_jobs.rb
-- lib/generators/notable/templates/create_requests.rb
+- lib/generators/notable/templates/create_jobs.rb.tt
+- lib/generators/notable/templates/create_requests.rb.tt
 - lib/notable.rb
 - lib/notable/debug_exceptions.rb
 - lib/notable/engine.rb
@@ -95,7 +175,6 @@ files:
 - lib/notable/unverified_request.rb
 - lib/notable/validation_errors.rb
 - lib/notable/version.rb
-- notable.gemspec
 homepage: https://github.com/ankane/notable
 licenses:
 - MIT
@@ -108,15 +187,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.4'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.8
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Track notable requests and background jobs

data/.gitignore

@@ -1,14 +0,0 @@
-/.bundle/
-/.yardoc
-/Gemfile.lock
-/_yardoc/
-/coverage/
-/doc/
-/pkg/
-/spec/reports/
-/tmp/
-*.bundle
-*.so
-*.o
-*.a
-mkmf.log

data/Gemfile

@@ -1,4 +0,0 @@
-source "https://rubygems.org"
-
-# Specify your gem's dependencies in notable.gemspec
-gemspec

data/Rakefile

@@ -1 +0,0 @@
-require "bundler/gem_tasks"

data/notable.gemspec

@@ -1,26 +0,0 @@
-# coding: utf-8
-lib = File.expand_path("../lib", __FILE__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require "notable/version"
-
-Gem::Specification.new do |spec|
-  spec.name          = "notable"
-  spec.version       = Notable::VERSION
-  spec.authors       = ["Andrew Kane"]
-  spec.email         = ["andrew@chartkick.com"]
-  spec.summary       = "Track notable requests and background jobs"
-  spec.description   = "Track notable requests and background jobs"
-  spec.homepage      = "https://github.com/ankane/notable"
-  spec.license       = "MIT"
-
-  spec.files         = `git ls-files -z`.split("\x0")
-  spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
-  spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
-
-  spec.add_dependency "request_store"
-  spec.add_dependency "safely_block", ">= 0.1.1"
-
-  spec.add_development_dependency "bundler", "~> 1.7"
-  spec.add_development_dependency "rake", "~> 10.0"
-end