not_naughty 0.3

data/spec/sequel_spec_helper.rb

@@ -0,0 +1,17 @@
+require File.dirname(__FILE__) + '/spec_helper.rb'
+require 'sequel_not_naughty'
+
+DB = Sequel::Model.db = Sequel.sqlite
+
+Sequel::Model.instance_eval do
+  %w[validate valid?].
+  each {|m| undef_method m.to_sym}
+end
+
+(class << Sequel::Model; self; end).module_eval do
+  %w[validate validates validates_acceptance_of validates_confirmation_of
+     validates_each validates_format_of validates_length_of 
+     validates_numericality_of validates_presence_of validations
+     has_validations?].
+  each {|m| undef_method m.to_sym}
+end

data/spec/sequel_validated_spec.rb

@@ -0,0 +1,97 @@
+require "#{ File.dirname(__FILE__) }/sequel_spec_helper.rb"
+
+describe Sequel::Plugins::NotNaughty do
+  
+  before(:each) do
+    @obj = Class.new(Sequel::Model) { is :not_naughty }
+  end
+  
+  it "should delegate validation methods in receiver" do
+    @instance = @obj.new
+
+    @obj.validator.should be_an_instance_of(Sequel::Plugins::NotNaughty)
+    @obj.validator.should_receive(:states).and_return({})
+    @obj.validator.should_receive(:has_validations?)
+    @obj.validator.should_receive(:invoke).with(@instance)
+    
+    @instance.errors.should be_an_instance_of(subject::Errors)
+    @instance.should respond_to(:validate)
+    @instance.should respond_to(:valid?)
+    @instance.should respond_to(:save_without_validations)
+
+    @obj.validations
+    @obj.has_validations?
+    @obj.validate @instance
+  end
+  it "should return validations" do
+    @obj.validations.should be_an_instance_of(Hash)
+  end
+  it "should not have validations" do
+    @obj.has_validations?.should == false
+  end
+  it "should add_validation instance of validation" do
+    validation = Class.new(subject::Validation)
+    
+    @obj.validator.add_validation validation, :attribute
+    
+    validations = @obj.validator.states[:create][:attribute]
+    validations.length.should == 1
+    validations.first.should be_an_instance_of(validation)
+    
+    validations = @obj.validator.states[:update][:attribute]
+    validations.length.should == 1
+    validations.first.should be_an_instance_of(validation)
+    
+    @obj.validator.add_validation validation, :attribute, :on => :create
+    
+    validations = @obj.validator.states[:create][:attribute]
+    validations.length.should == 2
+    validations[0].should be_an_instance_of(validation)
+    validations[1].should be_an_instance_of(validation)
+    
+    validations = @obj.validator.states[:update][:attribute]
+    validations.length.should == 1
+    validations.first.should be_an_instance_of(validation)
+  end
+  it "should have validations" do
+    validation = Class.new(subject::Validation)
+    @obj.validator.add_validation validation, :attribute
+    
+    @obj.has_validations?.should == true
+  end
+  it "should add_validation blocks as Validation" do
+    @obj.validator.add_validation(:attribute) { |o, a, v| }
+    
+    @obj.validator.states[:create][:attribute].first.
+    should be_kind_of(subject::Validation)
+    @obj.validator.states[:update][:attribute].first.
+    should be_kind_of(subject::Validation)
+  end
+  it "should run validations on object when it's invoked" do
+    probe = mock 'Probe', :new? => true
+    probe.should_receive(:attribute).and_return(1)
+    probe.should_receive(:test).with(:attribute, 1)
+    
+    @obj.validator.add_validation(:attribute) { |o, a, v| o.test a, v }
+    @obj.validate probe
+  end
+  it "should validate if saved" do
+    instance = @obj.new
+    instance.stub!(:save_without_validations).and_return(false)
+    @obj.validator.should_receive(:invoke).with(instance)
+    instance.save.should be_false
+  end
+  it "should run hooks if validated" do
+    instance = @obj.new
+    instance.should_receive(:before_validate)
+    instance.should_receive(:after_validate)
+    instance.validate
+  end
+  it "should not run hooks if validated" do
+    i = Class.new(Sequel::Model) { is :not_naughty, :without => :hooks }.new
+    i.should_not_receive(:before_validate)
+    i.should_not_receive(:after_validate)
+    i.validate
+  end
+  
+end

data/spec/spec.opts

@@ -0,0 +1,5 @@
+--colour
+--backtrace
+--format
+specdoc
+--diff

data/spec/spec_helper.rb

@@ -0,0 +1,7 @@
+require File.dirname(__FILE__) + '/../lib/not_naughty.rb'
+
+def subject() ::NotNaughty end
+def h(something)
+  puts '<pre>%s</pre>' %
+  something.inspect.gsub(/[<>]/) {|m| (m == '<')? '&lt;': '&gt;'}
+end

data/spec/validation_spec.rb

@@ -0,0 +1,118 @@
+require "#{ File.dirname(__FILE__) }/spec_helper.rb"
+
+describe subject::Validation do
+  
+  it "should register validations if inherited" do
+    subject::Builder.
+      should_receive(:update).any_number_of_times.
+      with Class.new(subject::Validation)
+    pending 'This one kinda sucks...'
+  end
+  it "should build validations with block" do
+    block = proc {|o, a, v|}
+    validation = subject::Validation.new({}, &block)
+    
+    validation.instance_variable_get(:@block).should == block
+  end
+  it "should alias call to call_without_conditions" do
+    validation = subject::Validation.new({}) {|o, a, v|}
+    
+    validation.method(:call).
+    should == validation.method(:call_without_conditions)
+  end
+  it "should not build conditions" do
+    validation = subject::Validation.
+    new({:if => nil, :unless => nil}) {|o, a, v|}
+
+    validation.instance_variable_get(:@conditions).should be_empty
+  end
+  it "should build conditions" do
+    validation = subject::Validation.new({:if => :nil?}) {|o, a, v|}
+    validation.instance_variable_get(:@conditions).should_not be_empty
+
+    validation.instance_variable_get(:@conditions).
+    first.instance_variable_get(:@condition).
+    should == :nil?
+  end
+  it "should alias call to call_with_conditions" do
+    validation = subject::Validation.new({:if => :nil?}) {|o, a, v|}
+    
+    validation.method(:call).
+    should == validation.method(:call_with_conditions)
+  end
+  it "should call" do
+    probe = mock 'Probe'
+    probe.should_receive(:test).exactly(3).times
+    
+    validation = subject::Validation.
+      new({}) { |o, a, v| [o, a, v].each { |p| p.test } }
+    
+    validation.call probe, probe, probe
+  end
+  it "should call unless a condition passes" do
+    probe = mock 'Probe'
+    probe.stub!(:nil?).and_return(true)
+    
+    validation = subject::Validation.
+      new({:unless => :nil?}) { |o, a, v| [o, a, v].each { |p| p.test } }
+    
+    validation.call probe, probe, probe
+    
+    probe.should_receive(:test).exactly(3).times
+    probe.stub!(:nil?).and_return(false)
+    
+    validation.call probe, probe, probe
+  end
+  it "should not call" do
+    probe = mock 'Probe'
+    probe.should_not_receive(:test)
+    
+    validation = subject::Validation.
+      new({:if => :nil?}) { |o, a, v| [o, a, v].each { |p| p.test } }
+    
+    validation.call probe, probe, probe
+
+  end
+  it "should have validated attributes accessable" do
+    validation = subject::Validation.new(:probe)
+    validation.attributes.should include(:probe)
+  end
+  it "should clone observer peers to descendant" do
+    peers = subject::Validation.instance_variable_get :@observer_peers
+    peers.should_receive(:clone).and_return(true)
+    descendant = Class.new(subject::Validation)
+    descendant.instance_variable_get(:@observer_peers).should be_true
+  end
+  
+end
+
+describe subject::Validation::Condition do
+
+  it "should evaluate positive callable" do
+    condition = subject::Validation::Condition.new proc {|o| o.nil?}
+    condition.evaluate(nil).should be_true
+  end
+  it "should evaluate negative callable" do
+    condition = subject::Validation::Condition.new proc {|o| o.nil?}, false
+    condition.evaluate(nil).should be_false
+  end
+  it "should evaluate positive Symbol" do
+    condition = subject::Validation::Condition.new :nil?
+    condition.evaluate(nil).should be_true
+  end
+  it "should evaluate negative Symbol" do
+    condition = subject::Validation::Condition.new :nil?, false
+    condition.evaluate(nil).should be_false
+  end
+  it "should evaluate positive UnboundMethod" do
+    um = NilClass.instance_method :nil?
+    condition = subject::Validation::Condition.new um
+    condition.evaluate(nil).should be_true
+  end
+  it "should evaluate negative UnboundMethod" do
+    um = NilClass.instance_method :nil?
+    condition = subject::Validation::Condition.new um, false
+    condition.evaluate(nil).should be_false
+  end
+
+end

data/spec/validations_spec.rb

@@ -0,0 +1,267 @@
+require "#{ File.dirname(__FILE__) }/spec_helper.rb"
+
+::NotNaughty::Validation.load(
+  :acceptance, :confirmation, :format,
+  :length, :numericality, :presence
+)
+
+describe subject::LengthValidation do
+  
+  before(:each) { @receiver, @errors = mock('Receiver'), mock('Errors') }
+  
+  it "should return the 'precise' block" do
+    validation = subject::LengthValidation.new :is => 8, :within => 10..12
+    
+    probe = mock 'Probe', :length => 8, :nil? => false
+    validation.call @receiver, :probe, probe
+    
+    @receiver.should_receive(:errors).and_return(@errors)
+    @errors.should_receive(:add).with(:probe, an_instance_of(String))
+    
+    probe = mock 'Probe', :length => 11, :nil? => false
+    validation.call @receiver, :probe, probe
+  end
+  it "should return the 'range' block" do
+    validation = subject::LengthValidation.
+      new :within => 10..12, :maximum => 9
+    
+    probe = mock 'Probe', :length => 10, :nil? => false
+    validation.call @receiver, :probe, probe
+    
+    @receiver.should_receive(:errors).and_return(@errors)
+    @errors.should_receive(:add).with(:probe, an_instance_of(String))
+    
+    probe = mock 'Probe', :length => 9, :nil? => false
+    validation.call @receiver, :probe, probe
+  end
+  it "should return the 'maximum' block" do
+    validation = subject::LengthValidation.
+      new :maximum => 9
+    
+    probe = mock 'Probe', :length => 9, :nil? => false
+    validation.call @receiver, :probe, probe
+    
+    @receiver.should_receive(:errors).and_return(@errors)
+    @errors.should_receive(:add).with(:probe, an_instance_of(String))
+    
+    probe = mock 'Probe', :length => 10, :nil? => false
+    validation.call @receiver, :probe, probe
+  end
+  it "should return the 'minimum' block" do
+    validation = subject::LengthValidation.
+      new :minimum => 9
+    
+    probe = mock 'Probe', :length => 9, :nil? => false
+    validation.call @receiver, :probe, probe
+    
+    @receiver.should_receive(:errors).and_return(@errors)
+    @errors.should_receive(:add).with(:probe, an_instance_of(String))
+    
+    probe = mock 'Probe', :length => 8, :nil? => false
+    validation.call @receiver, :probe, probe
+  end
+  it "should raise an ArgumentError" do
+    lambda { subject::LengthValidation.new }.
+    should raise_error(ArgumentError)
+  end
+  
+end
+
+LengthExample = Struct.new(:name).extend(subject)
+describe LengthExample do
+  
+  before(:each) { @example = LengthExample.clone }
+  
+  it "should always allow nil " do
+    @example.validates_length_of :name, :is => 1, :allow_nil => false
+    @example.new(nil).should be_valid
+    @example.new('').should_not be_valid
+    @example.new('a').should be_valid
+    @example.new('ab').should_not be_valid
+  end
+  it "should allow blank" do
+    @example.validates_length_of :name, :is => 1, :allow_blank => true
+    @example.new(nil).should be_valid
+    @example.new('').should be_valid
+    @example.new('a').should be_valid
+    @example.new('ab').should_not be_valid
+  end
+  
+end
+
+FormatExample = Struct.new(:email).extend(subject)
+describe FormatExample do
+  
+  before(:each) { @example = FormatExample.clone }
+  
+  it "claims to match 99% of all e-mail addresses out there..." do
+    # Regexp was taken from: http://www.regular-expressions.info/email.html
+    @example.validates_format_of :email,
+      :with => /\b[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,4}\b/i
+    @example.new('"Foo Bar" <foo@bar.com>').should be_valid
+    @example.new('foo@bar.com').should be_valid
+    @example.new('foobarcom').should_not be_valid
+    @example.new(nil).should_not be_valid
+    @example.new('').should_not be_valid
+  end
+  it "should allow nil e-mail addresses" do
+    @example.validates_format_of :email, :allow_nil => true,
+      :with => /\b[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,4}\b/i
+    @example.new('"Foo Bar" <foo@bar.com>').should be_valid
+    @example.new('foo@bar.com').should be_valid
+    @example.new('foobarcom').should_not be_valid
+    @example.new(nil).should be_valid
+    @example.new('').should_not be_valid
+  end
+  it "should allow blank e-mail addresses" do
+    @example.validates_format_of :email, :allow_blank => true,
+      :with => /\b[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,4}\b/i
+    @example.new('"Foo Bar" <foo@bar.com>').should be_valid
+    @example.new('foo@bar.com').should be_valid
+    @example.new('foobarcom').should_not be_valid
+    @example.new(nil).should be_valid
+    @example.new('').should be_valid
+  end
+  it "should raise an ArgumentError if format does not respond to :match" do
+    lambda { @example.validates_format_of :email }.
+    should raise_error(ArgumentError)
+    lambda { @example.validates_format_of :email, :with => 1 }.
+    should raise_error(ArgumentError)
+    lambda { @example.validates_format_of :email, :with => '' }.
+    should_not raise_error(ArgumentError)
+    lambda { @example.validates_format_of :email, :with => // }.
+    should_not raise_error(ArgumentError)
+  end
+  
+end
+
+PresenceExample = Struct.new(:name).extend(subject)
+describe PresenceExample do
+  
+  before(:each) { @example = PresenceExample.clone }
+  
+  it "should be present" do
+    @example.validates_presence_of :name
+    @example.new(0).should be_valid
+    @example.new([0]).should be_valid
+    @example.new('0').should be_valid
+  end
+  it "should not be present" do
+    @example.validates_presence_of :name
+    @example.new(nil).should_not be_valid
+    @example.new([]).should_not be_valid
+    @example.new('').should_not be_valid
+  end
+  
+end
+
+AcceptanceExample = Struct.new(:conditions).extend(subject)
+describe AcceptanceExample do
+  
+  before(:each) { @example = AcceptanceExample.clone }
+  
+  it "should accept '1' and allows nil by default" do
+    @example.validates_acceptance_of :conditions
+    @example.new(nil).should be_valid
+    @example.new('').should_not be_valid
+    @example.new(true).should_not be_valid
+    @example.new(false).should_not be_valid
+    @example.new('0').should_not be_valid
+    @example.new('1').should be_valid
+  end
+  it "should accept true and allows nil by default" do
+    @example.validates_acceptance_of :conditions, :accept => true
+    @example.new(nil).should be_valid
+    @example.new('').should_not be_valid
+    @example.new(true).should be_valid
+    @example.new(false).should_not be_valid
+    @example.new('0').should_not be_valid
+    @example.new('1').should_not be_valid
+  end
+  it "should accept '1' and disallows nil" do
+    @example.validates_acceptance_of :conditions, :accept => true,
+      :allow_nil => false
+    
+    @example.new(nil).should_not be_valid
+    @example.new('').should_not be_valid
+    @example.new(true).should be_valid
+    @example.new(false).should_not be_valid
+    @example.new('0').should_not be_valid
+    @example.new('1').should_not be_valid
+  end
+  it "should accept '1' and allow blank" do
+    @example.validates_acceptance_of :conditions, :accept => true,
+      :allow_blank => true
+    
+    @example.new(nil).should be_valid
+    @example.new('').should be_valid
+    @example.new(true).should be_valid
+    @example.new(false).should be_valid
+    @example.new('0').should_not be_valid
+    @example.new('1').should_not be_valid
+  end
+  
+end
+
+ConfirmationExample = Struct.new(:name, :name_confirmation).extend(subject)
+describe ConfirmationExample do
+  
+  before(:each) { @example = ConfirmationExample.clone }
+  
+  it "should be confirmed without allowing neither :nil nor :blank" do
+    @example.validates_confirmation_of :name
+    
+    @example.new(nil, 'foo').should_not be_valid
+    @example.new('', 'foo').should_not be_valid
+
+    @example.new('foo', 'foo').should be_valid
+    @example.new('foo', 'bar').should_not be_valid
+  end
+  it "should be confirmed with allowing :nil" do
+    @example.validates_confirmation_of :name, :allow_nil => true
+    
+    @example.new(nil, 'foo').should be_valid
+    @example.new('', 'foo').should_not be_valid
+    
+    @example.new('foo', 'foo').should be_valid
+    @example.new('foo', 'bar').should_not be_valid
+  end
+  it "should be confirmed with allowing :blank" do
+    @example.validates_confirmation_of :name, :allow_blank => true
+    
+    @example.new(nil, 'foo').should be_valid
+    @example.new('', 'foo').should be_valid
+    
+    @example.new('foo', 'foo').should be_valid
+    @example.new('foo', 'bar').should_not be_valid
+  end
+  
+end
+
+NumericalityExample = Struct.new(:weight).extend(subject)
+describe NumericalityExample do
+  
+  before(:each) { @example = NumericalityExample.clone }
+  
+  it "should be matched with number pattern" do
+    @example.validates_numericality_of :weight
+    
+    @example.new('-123.56').should be_valid
+    
+    @example.new('+123').should be_valid
+    @example.new('-123').should be_valid
+    @example.new('123').should be_valid
+    @example.new('abc').should_not be_valid
+  end
+  it "should be matched with integer pattern" do
+    @example.validates_numericality_of :weight, :only_integer => true
+    
+    @example.new('-123.45').should_not be_valid
+    
+    @example.new('+123').should be_valid
+    @example.new('-123').should be_valid
+    @example.new('123').should be_valid
+    @example.new('abc').should_not be_valid
+  end
+  
+end

data/spec/validator_spec.rb

@@ -0,0 +1,123 @@
+require "#{ File.dirname(__FILE__) }/spec_helper.rb"
+
+describe subject::Validator, 'with default state' do
+  
+  before(:each) { @validator = subject::Validator.new }
+  
+  it "should have atleast the default state" do
+    @validator.instance_variable_get(:@states).keys.should include(:default)
+  end
+  it "should shoult return default state" do
+    @validator.get_state(nil).name.should == :default
+  end
+
+end
+
+describe NotNaughty::Validator, 'with custom states' do
+  
+  before(:each) do
+    @states = [:create, :update]
+    @validator = subject::Validator.new(*@states)
+  end
+  
+  it "should assign states dynamically" do
+    @validator.states.keys.should include(*@states)
+  end
+  it "should have an initial state" do
+    @validator.instance_variable_get(:@initial_state).name.
+    should == @states[0]
+  end
+  it "should add validations to all states" do
+    @validator.add_validation :firstname, :lastname
+    
+    @validator.states.each do |name, state|
+      state.validations.should include(:firstname, :lastname)
+    end
+  end
+  it "should add validations to :create state" do
+    @validator.add_validation :firstname, :lastname, :on => :create
+    
+    @validator.states[:create].validations.keys.
+    should include(:firstname, :lastname)
+    @validator.states[:update].validations.keys.
+    should_not include(:firstname, :lastname)
+  end
+  it "should add validations to :create and :update states" do
+    @validator.add_validation :firstname, :lastname, :on => [:create, :update]
+    
+    @validator.states.each do |name, state|
+      state.validations.should include(:firstname, :lastname)
+    end
+  end
+  it "should return initial state" do
+    @validator.get_state(nil).name.should == :create
+  end
+  it "should not have validations" do
+    @validator.should_not have_validations
+  end
+  it "should have validations" do
+    @validator.add_validation :firstname, :lastname
+    @validator.should have_validations
+  end
+  it "should have validations on initial state" do
+    @validator.add_validation :firstname, :lastname, :on => :create
+    @validator.should have_validations('')
+  end
+  it "should not have validations on initial state" do
+    @validator.add_validation :firstname, :lastname, :on => :update
+    @validator.should_not have_validations('')
+  end
+  it "should send! attributes to probe if invoked" do
+    block = proc {|o, a, v|}
+
+    probe = mock 'Probe'
+    probe.should_receive(:send!).with(:firstname)
+    probe.should_receive(:send!).with(:lastname)
+
+    @validator.add_validation :firstname, :lastname, &block
+    @validator.invoke probe
+  end
+  it "should call validations with object, attribute and value if invoked" do
+    block = proc {|o, a, v|}
+
+    probe = mock 'Probe'
+    value = mock 'Value'
+    probe.stub!(:send!).and_return(value)
+
+    @validator.add_validation :firstname, :lastname, &block
+    @validator.get_state.validations
+    @validator.invoke probe
+  end
+  it "should clone states as well" do
+    validator_clone = @validator.clone
+    validator_clone.states.length == @validator.states.length
+    validator_clone.states.should_not != @validator.states
+  end
+  
+end
+
+describe NotNaughty::Validator::State do
+  
+  before(:each) { @state = NotNaughty::Validator::State.new }
+  
+  it "should initialize with name and validations" do
+    @state.name.should == :default
+    @state.validations.should be_an_instance_of(Hash)
+    
+    @state = NotNaughty::Validator::State.new :foo
+    @state.name.should == :foo
+  end
+  it "should add validation" do
+    @state.add_validation(:firstname, :lastname, :on => :default) {|o, a, v|}
+    @state.validations.keys.should include(:firstname, :lastname)
+  end
+  it "should return validation for an attribute" do
+    @state.validations[:foo] = :bar
+    @state[:foo].should == :bar
+  end
+  it "should have validations" do
+    @state.validations[:foo] = [:bar]
+    @state.should have_validations
+  end
+  
+end