nosj 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 354e310be9d2d56119d2db1f9ad13052c9a6bc8fba5c8d7b7993b78abf345e1e
-  data.tar.gz: b21acc76a56a10a56c62c370ff1dfcaa8dc263a96958fcac6c4f3c213c4bb542
+  metadata.gz: f6c2ec4836b21fafff5a18244b4089e632b39ed4dd48cdbb57d9ab4529beea73
+  data.tar.gz: 544ce5c54ab3d6c4300b720d6462af4f02f3427868a6fa94b5cc960b9d2704f4
 SHA512:
-  metadata.gz: c672e8653239dc1600ce19b4b38c31ae298dbf40a79449fe12ccf05335144eed7d210a115e87a3a60e8b534b868d3c0080079072ed21a8e67b398e2e8d7e8fc4
-  data.tar.gz: 22aadd62a736d86fe310ed099d995fe6006e149103eb95d41d128adc6164e6c2f64c2de49e6652437bccefbef70379b27cc3700d45fcad7ae1e2003ac6f05f41
+  metadata.gz: 777e339c9ab64479dad1811b33da20bd30e545afdc390a32b70ac1c92c1574cfd7f7c04a5c70f87dd3d1469520970387c50db68af3b3b18c849d3705c92274ee
+  data.tar.gz: 8a099e1880b3b6efd6f28311636fbd4e29fb4aca4c3a8c19e5e4603c5fed3cd1936e53547fde34821e701eaf09b77dcc83f44317bd9af4d29d0fe307bc85ea52

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+## [0.5.1] - 2026-10-06
+
+- Fixed: `NOSJ.patch` read a `path` without the leading slash (`"a"`
+  instead of `"/a"`) as the root pointer, so `add`, `copy`, and `move`
+  silently replaced the whole document with the value instead of
+  raising, and `remove` reported `cannot remove the root`. Such paths
+  now raise the same `ArgumentError` as `NOSJ.at_pointer`
+  (`JSON Pointer must be empty or start with '/'`) in every op. The
+  bug dates back to 0.3.0. Found by fuzzing.
+
 ## [0.5.0] - 2026-09-25
 
 **json 3.0 compatibility.** nosj now matches the behavior of the json

data/Cargo.lock

@@ -200,7 +200,7 @@ dependencies = [
 
 [[package]]
 name = "nosj_native"
-version = "0.5.0"
+version = "0.5.1"
 dependencies = [
  "ahash",
  "magnus",

data/ext/nosj/Cargo.toml

@@ -5,7 +5,7 @@
 # required by lib/nosj.rb as "nosj/nosj" (Init_nosj set explicitly in
 # lib.rs). Gem name, module, and API are plain nosj.
 name = "nosj_native"
-version = "0.5.0"
+version = "0.5.1"
 edition = "2021"
 authors = ["Yaroslav Markin <yaroslav@markin.net>"]
 license = "MIT"

data/ext/nosj/fuzz/src/prelude.rb

@@ -140,11 +140,19 @@ module NOSJFuzz
     raise "yielded values diverge from per-line parses" unless yielded.eql?(reference)
 
     if status == :ok && !yielded.empty?
-      # Parsed values are always generable: parse refuses lone
-      # surrogates, the only source of unencodable strings.
-      ndjson = stage("generate_lines") { NOSJ.generate_lines_native(yielded, nil) }
+      # Parse refuses lone surrogates, the only unencodable strings, but
+      # an overflow float (1e999, 124.4e044754) parses to Infinity, which
+      # generates only under allow_nan; it lifts exactly that refusal,
+      # and the round-trip then reads Infinity back under it too.
+      opts = nil
+      ndjson = begin
+        NOSJ.generate_lines_native(yielded, nil)
+      rescue NOSJ::GeneratorError
+        opts = {allow_nan: true}
+        stage("generate_lines with allow_nan") { NOSJ.generate_lines_native(yielded, opts) }
+      end
       back = []
-      NOSJ.each_line_native(ndjson, nil) { |v| back << v }
+      NOSJ.each_line_native(ndjson, opts) { |v| back << v }
       raise "generate_lines does not round-trip" unless back.eql?(yielded)
     end
     nil
@@ -227,6 +235,7 @@ module NOSJFuzz
   # --- the pure-Ruby reference implementations ------------------------
 
   def ref_splice(tree, edits)
+    edits.each_value { |value| generable(value) }
     token_lists = edits.keys.map { |ptr| ptr_tokens(ptr) }
     token_lists.combination(2) do |a, b|
       short, long = (a.length <= b.length) ? [a, b] : [b, a]
@@ -262,8 +271,8 @@ module NOSJFuzz
       path = op["path"]
       raise RefFail unless path.is_a?(String)
       case name
-      when "add" then ref_add(box, ptr_tokens(path), fetch_value(op))
-      when "replace" then ref_replace(box, ptr_tokens(path), fetch_value(op))
+      when "add" then ref_add(box, ptr_tokens(path), generable(fetch_value(op)))
+      when "replace" then ref_replace(box, ptr_tokens(path), generable(fetch_value(op)))
       when "remove" then ref_remove(box, ptr_tokens(path))
       when "move"
         from = op["from"]
@@ -366,6 +375,24 @@ module NOSJFuzz
     op["value"]
   end
 
+  # splice, add, and replace generate their values with default options,
+  # which refuse non-finite floats, and an overflow literal in the spec
+  # (1e999) parses to Infinity. test compares, and move/copy splice raw
+  # document bytes, so a 1e999 already in the document passes there.
+  def generable(value)
+    raise RefFail unless finite_floats?(value)
+    value
+  end
+
+  def finite_floats?(v)
+    case v
+    when Float then v.finite?
+    when Array then v.all? { |e| finite_floats?(e) }
+    when Hash then v.each_value.all? { |e| finite_floats?(e) }
+    else true
+    end
+  end
+
   def deep_dup(v)
     case v
     when Hash then v.transform_values { |e| deep_dup(e) }

data/ext/nosj/src/patch.rs

@@ -119,11 +119,25 @@ fn container_children(
 }
 
 /// Split an RFC 6901 pointer into (parent, unescaped last token).
-/// Returns None for the root pointer "".
-fn split_pointer(pointer: &str) -> Option<(&str, String)> {
-    let cut = pointer.rfind('/')?;
+/// Returns None for the root pointer "" only: any other pointer must
+/// start with '/', else the crate's own InvalidPointer error raises as
+/// ArgumentError, exactly like `span_at`. (A slash-free path once read
+/// as the root, and `add` replaced the whole document.)
+fn split_pointer<'p>(ruby: &Ruby, pointer: &'p str) -> Result<Option<(&'p str, String)>, Error> {
+    if pointer.is_empty() {
+        return Ok(None);
+    }
+    if !pointer.starts_with('/') {
+        // Byte 0 is where the crate reports a missing leading slash.
+        let invalid = nosj::ParseError {
+            offset: 0,
+            kind: nosj::ErrorKind::InvalidPointer,
+        };
+        return Err(arg_error(ruby, invalid.to_string()));
+    }
+    let cut = pointer.rfind('/').unwrap_or(0);
     let token = pointer[cut + 1..].replace("~1", "/").replace("~0", "~");
-    Some((&pointer[..cut], token))
+    Ok(Some((&pointer[..cut], token)))
 }
 
 /// RFC 6902 array index token: digits only, no leading zeros.
@@ -211,7 +225,7 @@ fn op_add(
     value: &Insert,
     cfg: &GenConfig,
 ) -> Result<Vec<u8>, Error> {
-    let Some((parent, token)) = split_pointer(path) else {
+    let Some((parent, token)) = split_pointer(ruby, path)? else {
         // Root: the value becomes the entire document.
         return apply_edit(ruby, doc, 0, doc.len(), value, cfg);
     };
@@ -295,7 +309,7 @@ fn extend_insert(
 /// RFC 6902 `remove`: the entry disappears along with its key and one
 /// separating comma; surrounding formatting stays.
 fn op_remove(ruby: &Ruby, doc: &[u8], path: &str) -> Result<Vec<u8>, Error> {
-    let Some((parent, token)) = split_pointer(path) else {
+    let Some((parent, token)) = split_pointer(ruby, path)? else {
         return Err(patch_error(ruby, "cannot remove the root".into()));
     };
     let Some((pstart, pend)) = span_at(ruby, doc, parent)? else {

data/lib/nosj/version.rb

@@ -2,5 +2,5 @@
 
 module NOSJ
   # The gem version.
-  VERSION = "0.5.0"
+  VERSION = "0.5.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nosj
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Yaroslav Markin