norman-has_image 0.1.5 → 0.1.6

data/CHANGELOG

@@ -1,5 +1,13 @@
+2008-08-1 Norman Clarke <norman@randomba.org>
+  
+  * Fixed a bug where overwriting a previous image triggered callbacks more
+    than once, causing errors.
+
 2008-07-29 Norman Clarke <norman@randomba.org>
 
+  * Downcased generated file names to avoid potential issues on
+    case-insensitive filesystems.
+  * Added "absolute path" method to model instances.
   * Made image deletion nullify the "has_image_file" field.
   * Added "has_image?" method to model instances.
   * Fixed ENONENT error with record update when there are no images yet.

data/README

@@ -65,7 +65,25 @@ Image with some thumbnails:
   
 It also provides a view helper to make displaying the images extremely simple:
 
-  <%= image_tag_for(@photo, :thumb => :square) %>
+  <%= image_tag_for(@photo) # show the full-sized image %>
+  <%= image_tag_for(@photo, :thumb => :square) # show the square thumbnail %>
+
+The image_tag_for helper calls Rails' image_tag, so you can pass in all the 
+regular options to set the alt property, CSS class, etc:
+  
+  <%= image_tag_for(@photo, :alt => "my cool picture", :class => "photo") %>
+  
+Setting up forms for has_image is simple, too:
+
+  <% form_for(@photo, :html => {:multipart => true}) do |f| %>
+    <p>
+      <%= f.label :image_data %>
+      <%= f.file_field :image_data %>
+    </p>
+    <p>
+      <%= f.submit %>
+    </p>
+  <% end %>
 
 == Getting it
 

data/lib/has_image/storage.rb

@@ -27,7 +27,7 @@ module HasImage
       # helps prevent a possibly undesirable sitation where the uploaded images
       # have offensive names.
       def random_file_name
-        Zlib.crc32(Time.now.to_s + rand(10e10).to_s).to_s(36)
+        Zlib.crc32(Time.now.to_s + rand(10e10).to_s).to_s(36).downcase
       end
           
     end

data/lib/has_image.rb

@@ -200,14 +200,27 @@ module HasImage
     def public_path(thumbnail = nil)
       storage.public_path_for(self, thumbnail)
     end
+
+    # Gets the absolute filesystem path for the image, or optionally, its
+    # thumbnail.
+    def absolute_path(thumbnail = nil)
+      storage.filesystem_path_for(self, thumbnail)
+    end
     
     # Deletes the image from the storage.
     def remove_images
       return if has_image_file.blank?
-      storage.remove_images(self.id)
-      update_attribute(:has_image_file, nil)
-    rescue Errno::ENOENT
-      logger.warn("Could not delete files for #{self.class.to_s} #{to_param}") 
+      self.class.transaction do
+        begin
+          # Resorting to SQL here to avoid triggering callbacks. There must be
+          # a better way to do this.
+          self.connection.execute("UPDATE #{self.class.table_name} SET has_image_file = NULL WHERE id = #{id}")
+          self.has_image_file = nil
+          storage.remove_images(self.id)
+        rescue Errno::ENOENT
+          logger.warn("Could not delete files for #{self.class.to_s} #{to_param}")
+        end
+      end
     end
     
     # Creates new images and removes the old ones when image_data has been

data/test_rails/pic_test.rb

@@ -36,6 +36,8 @@ class PicTest < Test::Unit::TestCase
   def test_create
     @pic = Pic.new(:image_data => fixture_file_upload("/image.jpg", "image/jpeg"))
     assert @pic.save!
+    assert_not_nil @pic.public_path
+    assert_not_nil @pic.absolute_path
   end
 
   def test_update

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: norman-has_image
 version: !ruby/object:Gem::Version 
-  version: 0.1.5
+  version: 0.1.6
 platform: ruby
 authors: 
 - Norman Clarke
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2008-07-29 00:00:00 -07:00
+date: 2008-08-01 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency