normalizr 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: c92e29d4c962eab7b59f45d08e1491ab5198071b
-  data.tar.gz: b36c1555e4e4680972c64696d85a00a4117ce73b
+SHA256:
+  metadata.gz: '068b8f6b2685d273ee884c7a8c0f751da02fd254fe56f0ee6366f304910f81f6'
+  data.tar.gz: 9edd590a85219a2ea44651412e32fced140dad016b3035acadcd1ebc43df2408
 SHA512:
-  metadata.gz: 409bda7a9f3416b22acc330674aafdacba08b0fd1747f2c3f4896081fee9b7e203606d26dc33a556d61e90b8668b04d2224c639c2ff4c485398d772d5760a2b9
-  data.tar.gz: 6dc1d908fe0fb69c046120438bbe344d33d7238771a837fa8fec8fe6fbd7f738cec01ea5e29b783ade832447c27b0d18f36f82efea337810b260803b728682af
+  metadata.gz: eb22312649da1951b0fe9d0d1214851ebeb62d408217156a0427a55b442814505e68786a513898e8ca8b095701cd47d4880e5c82ba943993b1516cbfd8b04774
+  data.tar.gz: 06c555da8af5e30f7527927518e28186577ac1baf2c36b0a0ae9ce3a4596c6cc15eb13c08f9a361e833e84665eb4ed769c9f3ff9d3d4f725db2d8cfa5eb82e37

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+### 0.3.0 / 2018-03-21
+
+* Add a possibility to use if/unless cases for normalizer options (@TheTharin)
+
 ### 0.2.0 / 2016-03-17
 
 * Introduce arrays normalization

data/README.md

@@ -74,7 +74,7 @@ Normalizr.configure do
   add :indent do |value, amount = 2|
     if String === value
       value.indent(amount)
-    end
+    else
       value
     end
   end
@@ -130,6 +130,21 @@ sms.message
 #=> "It works"
 ```
 
+You can also use if/unless options (they accept a symbol (method name) or proc):
+
+```ruby
+class Book
+  include Normalizr::Concerns
+
+  attr_accessor :author, :description, :date
+
+  normalize :author, if: :author_should_be_normalized?
+  normalize :description, unless: :description_should_not_be_normalized?
+  
+  normalize :author, if: proc { date.today? }
+end
+```
+
 Normalize values outside of class:
 
 ```ruby

data/lib/normalizr/concern.rb

@@ -11,8 +11,14 @@ module Normalizr
         prepend Module.new {
           options.attributes.each do |method|
             define_method :"#{method}=" do |value|
-              value = Normalizr.normalize(value, *options.before)
-              value = Normalizr.normalize(value, *options.after) if options.after.any?
+              positive = options.positive_condition.all?  { |condition| instance_eval(&condition) }
+              negative = options.negative_condition.none? { |condition| instance_eval(&condition) }
+
+              if positive && negative
+                value = Normalizr.normalize(value, *options.before)
+                value = Normalizr.normalize(value, *options.after) if options.after.any?
+              end
+
               super(value)
             end
           end

data/lib/normalizr/options_parser.rb

@@ -16,6 +16,14 @@ module Normalizr
       options_at(:after)
     end
 
+    def positive_condition
+      options_at(:if)
+    end
+
+    def negative_condition
+      options_at(:unless)
+    end
+
     private
 
     def options_at(*keys)

data/lib/normalizr/version.rb

@@ -1,3 +1,3 @@
 module Normalizr
-  VERSION = '0.2.0'
+  VERSION = '0.3.0'
 end

data/spec/models/user_spec.rb

@@ -4,4 +4,42 @@ describe User do
   context 'on default attribute with the default normalizer changed' do
     it { should normalize_attribute(:firstname).from(' here ').to('here') }
   end
+
+  context 'last name has to be normalized' do
+    before do
+      allow(subject).to receive(:should_normalize_lastname?).and_return(true)
+    end
+
+    it { is_expected.to normalize_attribute(:lastname).from(' here ').to('here') }
+  end
+
+  context 'last name cannot be normalized' do
+    before do
+      allow(subject).to receive(:should_normalize_lastname?).and_return(false)
+    end
+
+    it { is_expected.not_to normalize_attribute(:lastname).from(' here ').to('here') }
+  end
+
+  context 'maidenname has to be normalized' do
+    before do
+      allow(subject).to receive(:should_normalize_maidenname_positive?).and_return(true)
+      allow(subject).to receive(:should_normalize_maidenname_negative?).and_return(false)
+    end
+
+    it { is_expected.to normalize_attribute(:maidenname).from(' boba ').to('boba') }
+  end
+
+  context 'maidenname cannot to be normalized' do
+    before do
+      allow(subject).to receive(:should_normalize_maidenname_positive?).and_return(true)
+      allow(subject).to receive(:should_normalize_maidenname_negative?).and_return(true)
+    end
+
+    it { is_expected.not_to normalize_attribute(:maidenname).from(' boba ').to('boba') }
+  end
+
+  context 'favouritebook has to be normalized with proc' do
+    it { is_expected.to normalize_attribute(:favouritebook).from(' Евангелие от Матфея ').to('Евангелие от Матфея') }
+  end
 end

data/spec/spec_helper.rb

@@ -1,4 +1,4 @@
-require 'support/codeclimate'
+require 'simplecov'
 require 'pry'
 require 'rspec'
 require 'rspec/its'

data/spec/support/models/user.rb

@@ -1,3 +1,19 @@
 class User < Person
   normalize_attribute :firstname
+
+  normalize :lastname, if: :should_normalize_lastname?
+  normalize :maidenname, if: :should_normalize_maidenname_positive?, unless: :should_normalize_maidenname_negative?
+  normalize :favouritebook, if: proc { true }
+
+  def should_normalize_lastname?
+    true
+  end
+
+  def should_normalize_maidenname_positive?
+    true
+  end
+
+  def should_normalize_maidenname_negative?
+    false
+  end
 end

data/spec/support/schema.rb

@@ -38,5 +38,7 @@ ActiveRecord::Schema.define do
   create_table :users, force: true do |t|
     t.string :firstname
     t.string :lastname
+    t.string :maidenname
+    t.string :favouritebook
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: normalizr
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Dimko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-18 00:00:00.000000000 Z
+date: 2018-03-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry
@@ -213,7 +213,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Writer methods parameters normalization