normalizr 0.1.1 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9f01b405bb0c605fb3d1ee13165c30708a209ac2
-  data.tar.gz: 585231449522b519400d785946f8d226fee9a1c2
+  metadata.gz: c92e29d4c962eab7b59f45d08e1491ab5198071b
+  data.tar.gz: b36c1555e4e4680972c64696d85a00a4117ce73b
 SHA512:
-  metadata.gz: cfe8b07219b1869ce39d2e9795b98c0bf34af89547274e4e6e22c112ef47df6286be7c2098032584d9c40811280ecfc4ea139bbce4bc53a2a64415f0b8a6cebd
-  data.tar.gz: f7ca6b8dc3cc39ae349a753190eb809f734c00334bf22c5a676addd5f0485cc2c822f5801be8180f22d5e08272da66368c7a2bf446eef2da67ea09bfb4767205
+  metadata.gz: 409bda7a9f3416b22acc330674aafdacba08b0fd1747f2c3f4896081fee9b7e203606d26dc33a556d61e90b8668b04d2224c639c2ff4c485398d772d5760a2b9
+  data.tar.gz: 6dc1d908fe0fb69c046120438bbe344d33d7238771a837fa8fec8fe6fbd7f738cec01ea5e29b783ade832447c27b0d18f36f82efea337810b260803b728682af

data/.travis.yml

@@ -1,9 +1,10 @@
 language: ruby
 cache: bundler
 rvm:
-  - 2.0
-  - 2.1
-  - 2.2
+  - 2.0.0
+  - 2.1.8
+  - 2.2.4
+  - 2.3.0
 gemfile:
   - gemfiles/activerecord-3.2.x.gemfile
   - gemfiles/activerecord-4.0.x.gemfile
@@ -14,3 +15,6 @@ addons:
     repo_token: 1cac54041089115a5bf218169b62c76c8b87a5896f5aa973f89637a8553c0376
 matrix:
   fast_finish: true
+before_install:
+  - gem install bundler
+sudo: false

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+### 0.2.0 / 2016-03-17
+
+* Introduce arrays normalization
+
+### 0.1.1 / 2015-11-12
+
+* New `parameterize` normalizer
+
 ### 0.1.0 / 2014-08-30
 
 * Add Mongoid integration

data/README.md

@@ -1,6 +1,9 @@
 ## Normalizr
 
-[![Travic CI](http://img.shields.io/travis/dimko/normalizr.svg)](https://travis-ci.org/dimko/normalizr) [![Code Climate](http://img.shields.io/codeclimate/github/dimko/normalizr.svg)](https://codeclimate.com/github/dimko/normalizr) [![Coverage](http://img.shields.io/codeclimate/coverage/github/dimko/normalizr.svg)](https://codeclimate.com/github/dimko/normalizr)
+[![Gem Version](https://badge.fury.io/rb/normalizr.svg)](https://badge.fury.io/rb/normalizr)
+[![Build Status](https://travis-ci.org/dimko/normalizr.svg?branch=master)](https://travis-ci.org/dimko/normalizr)
+[![Code Climate](https://codeclimate.com/github/dimko/normalizr/badges/gpa.svg)](https://codeclimate.com/github/dimko/normalizr)
+[![Test Coverage](https://codeclimate.com/github/dimko/normalizr/badges/coverage.svg)](https://codeclimate.com/github/dimko/normalizr/coverage)
 
 The [attribute_normalizer](https://github.com/mdeering/attribute_normalizer) replacement.
 
@@ -87,9 +90,12 @@ class User < ActiveRecord::Base
 
   # supports `normalize_attribute` and `normalize_attributes` as well
   normalize_attribute :skype
+
+  # array normalization is supported too
+  normalize :skills
 end
 
-user = User.new(first_name: '', last_name: '')
+user = User.new(first_name: '', last_name: '', skills: [nil, '', ' ruby'])
 user.email = "ADDRESS@example.com"
 
 user.first_name
@@ -98,6 +104,8 @@ user.last_name
 #=> nil
 user.email
 #=> "address@example.com"
+user.skills
+#=> ["ruby"]
 ```
 
 ```ruby

data/lib/normalizr.rb

@@ -27,13 +27,23 @@ module Normalizr
     end
   end
 
-  def normalize(value, *normalizers)
+  def process(obj, name, options)
+    if Array === obj
+      obj.map { |item| process(item, name, options) }.tap do |ary|
+        ary.compact! if name == :blank
+      end
+    else
+      find(name).call(obj, options)
+    end
+  end
+
+  def normalize(obj, *normalizers)
     normalizers = configuration.default_normalizers if normalizers.empty?
     normalizers.each do |name|
       name, options = name.first if Hash === name
-      value = find(name).call(value, options)
+      obj = process(obj, name, options)
     end
-    value
+    obj
   end
 end
 

data/lib/normalizr/concern.rb

@@ -11,8 +11,8 @@ module Normalizr
         prepend Module.new {
           options.attributes.each do |method|
             define_method :"#{method}=" do |value|
-              value = Normalizr.normalize(value, *options.pre)
-              value = Normalizr.normalize(value, *options.post) if options.post.any?
+              value = Normalizr.normalize(value, *options.before)
+              value = Normalizr.normalize(value, *options.after) if options.after.any?
               super(value)
             end
           end

data/lib/normalizr/options_parser.rb

@@ -8,11 +8,11 @@ module Normalizr
       @block = block
     end
 
-    def pre
+    def before
       options_at(:with, :before) { block }
     end
 
-    def post
+    def after
       options_at(:after)
     end
 

data/lib/normalizr/version.rb

@@ -1,3 +1,3 @@
 module Normalizr
-  VERSION = '0.1.1'
+  VERSION = '0.2.0'
 end

data/spec/lib/normalizr_spec.rb

@@ -17,7 +17,7 @@ describe Normalizr do
     context 'not existed normalizer' do
       let(:normalizer) { :not_existed }
 
-      it 'raise exception with normalizer in message' do
+      it 'raises the exception with normalizer in message' do
         expect { subject }.to raise_error(Normalizr::MissingNormalizer, /not_existed/)
       end
     end
@@ -31,25 +31,92 @@ describe Normalizr do
     end
   end
 
+  describe '#process' do
+    subject { described_class.process(obj, name, {}) }
+
+    context 'string' do
+      let(:obj) { ' test ' }
+
+      context 'blank normalizer' do
+        let(:name) { :strip }
+
+        it 'strips the value' do
+          should == 'test'
+        end
+      end
+    end
+
+    context 'array ' do
+      let(:obj) { [nil, ' '] }
+
+      context 'strip normalizer' do
+        let(:name) { :strip }
+
+        it 'strips all elements' do
+          expect(subject).to eq([nil, ''])
+        end
+      end
+
+      context 'custom normalizer' do
+        let(:name) { proc { |value| value.prepend('N:') if String === value }}
+
+        it 'processes all elements with the custom normalizer' do
+          expect(subject).to eq([nil, 'N: '])
+        end
+      end
+
+      context 'blank normalizer' do
+        let(:name) { :blank }
+
+        it 'returns empty array' do
+          expect(subject).to eq([])
+        end
+      end
+    end
+  end
+
   describe '#normalize' do
     before  { configuration.default_normalizers = [:strip, :blank] }
     subject { described_class.normalize(value, *normalizers) }
 
-    context 'normalizers is empty' do
+
+    context 'normalizers are empty' do
       let(:normalizers) { [] }
-      let(:value) { ' text ' }
 
-      it 'use default normalizers' do
-        expect(subject).to eq('text')
+      context 'string' do
+        let(:value) { ' text ' }
+
+        it 'uses the default normalizers' do
+          expect(subject).to eq('text')
+        end
+      end
+
+      context 'array' do
+        let(:value) { [nil, ' test '] }
+
+        it 'uses the default normalizers' do
+          expect(subject).to eq(['test'])
+        end
       end
     end
 
-    context 'normalizers is not empty' do
+    context 'normalizers are not empty' do
       let(:normalizers) { [:strip, { truncate: { length: 8, omission: '...' }}, proc { |v| v.first(6) }] }
-      let(:value) { ' Lorem ipsum dolor sit amet' }
 
-      it 'normalize value' do
-        expect(subject).to eq('Lorem.')
+      context 'string' do
+        let(:value) { ' Lorem ipsum dolor sit amet' }
+
+        it 'strips, truncates and then slices the value' do
+          expect(subject).to eq('Lorem.')
+        end
+      end
+
+      context 'array' do
+        let(:value) { [' Lorem ipsum dolor sit amet', '    One more sentence'] }
+
+        it 'strips, truncates and then slices the value' do
+          expect(subject).to eq(['Lorem.', 'One m.'])
+        end
       end
     end
   end

data/spec/models/book_spec.rb

@@ -1,12 +1,15 @@
 require 'spec_helper'
 
 describe Book do
-  it { should normalize_attribute(:author).from(' Michael Deering ').to('Michael Deering') }
-  it { should normalize_attribute(:us_price).from('$3.50').to(3.50) }
-  it { should normalize_attribute(:cnd_price).from('$3,450.98').to(3450.98) }
-  it { should normalize_attribute(:summary).from('    Here is my summary that is a little to long  ').to('Here is m...') }
-
-  it { should normalize_attribute(:title).from('pick up chicks with magic tricks').to('Pick Up Chicks With Magic Tricks') }
+  it { should normalize(:author).from(' Michael Deering ').to('Michael Deering') }
+  it { should normalize(:us_price).from('$3.50').to(3.50) }
+  it { should normalize(:cnd_price).from('$3,450.98').to(3450.98) }
+  it { should normalize(:summary).from('    Here is my summary that is a little to long  ').to('Here is m...') }
+  it { should normalize(:title).from('pick up chicks with magic tricks').to('Pick Up Chicks With Magic Tricks') }
+
+  it { should normalize(:tags).from(['', nil, ' ', ' test']).to(['test']) }
+  it { should normalize(:tags).from([[''], [nil, ' test ']]).to([[], ['test']]) } # nested arrays
+  it { should normalize(:tags).from([]).to([]) }
 
   context 'normalization should not interfere with other hooks and aliases on the attribute assignment' do
     before do

data/spec/support/models/book.rb

@@ -5,4 +5,7 @@ class Book < ActiveRecord::Base
   normalize_attributes :title do |value|
     String === value ? value.titleize.strip : value
   end
+
+  serialize :tags, Array
+  normalize :tags
 end

data/spec/support/schema.rb

@@ -22,6 +22,7 @@ ActiveRecord::Schema.define do
     t.decimal :us_price
     t.string  :summary
     t.string  :title
+    t.text    :tags
   end
 
   create_table :journals, force: true do |t|

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: normalizr
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.2.0
 platform: ruby
 authors:
 - Dimko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-13 00:00:00.000000000 Z
+date: 2016-03-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry