normalizr 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 001866efe62b5690380583e71cd63a7db0f8b50e
-  data.tar.gz: 5569ab0e1c9379bfae5bb5c5a3f085839dffd4dc
+  metadata.gz: 40309262aecfd58ad3c5e78f110c0e364e05aca1
+  data.tar.gz: 41c13121f6be1657aec6f7c42261028464701a6d
 SHA512:
-  metadata.gz: dd87e9aa36aa9da01e264b5097e00fdc6af7f576c116c5d640078eaa40de6e57127e838b0f8bc1e1773fb3dcd5c928c4dc238aa5c4d9627fb117a1a417311168
-  data.tar.gz: 54a92ab8ec8a31523f8eb8bbf8b3322aefaf58b2d5b999659258dcaf35dbe36bff3bbe7cfe9f5783393f2dda079366a1ead640c6649670bec5edd4f27abd282b
+  metadata.gz: 9176eed415951ae139c7292fcecd1d9984c7fa5480c465172e192a72914add830d1de488201b0c7dedabae82098e2093e39a14f0bf7f91971513ca48c5ebd283
+  data.tar.gz: f866ecbde412f110fb642e0ba90616885825fb1b7c2915af282ba02b53afb3167674a48377b20588156a6752837903cc6e7e0b121e27f5b779ce02b51cdc1fb0

data/.travis.yml

@@ -2,6 +2,9 @@ language: ruby
 rvm:
   - 2.0.0
   - 2.1.0
+gemfile:
+  - gemfiles/activerecord-3.2.x.gemfile
+  - gemfiles/activerecord-4.1.x.gemfile
 addons:
   code_climate:
     repo_token: 1cac54041089115a5bf218169b62c76c8b87a5896f5aa973f89637a8553c0376

data/CHANGELOG.md

@@ -1,6 +1,10 @@
+### 0.0.4 / 2014-08-30
+
+* Automatically include RSpec matcher
+
 ### 0.0.3 / 2014-08-22
 
-* Fixed issue when some built-in normalizers modify passed-in parameters
+* Fix issue when some built-in normalizers modify passed-in parameters
 
 ### 0.0.2 / 2014-08-22
 

data/Gemfile

@@ -1,7 +1,5 @@
 source 'https://rubygems.org'
 
-gemspec
+gem 'codeclimate-test-reporter', require: false
 
-group :test do
-  gem 'codeclimate-test-reporter', require: false
-end
+gemspec

data/README.md

@@ -6,23 +6,22 @@ The [attribute_normalizer](https://github.com/mdeering/attribute_normalizer) rep
 
 ### Synopsis
 
-Attribute normalizer doesn't normalize overloaded writer methods correctly. Example:
+Attribute normalizer doesn't normalize overloaded methods correctly. Example:
 
 ```ruby
-class Currency
-  include Normalizr::Concern
+class Phone
+  include AttributeNormalizer
 
-  attr_accessor :value
-  normalize_attribute :value
+  attr_accessor :number
+  normalize_attribute :number
 
-  def value=(*)
-    # ...
-    super
+  def number=(value)
+    @number = value
   end
 end
 ```
 
-`value` will never be normalized as expected. Normalizr resolves this problem and doesn't generate any extra instance methods.
+`number` will never be normalized as expected. Normalizr resolves this problem and doesn't pollute target object namespace.
 
 Magic based on ruby's `prepend` feature, so it requires 2.0 or higher version.
 
@@ -70,8 +69,11 @@ Normalizr.configure do
   end
 
   add :indent do |value, amount = 2|
-    value.indent!(amount) if String === value
-    value
+    if String === value
+      value.indent(amount)
+    end
+      value
+    end
   end
 end
 ```
@@ -87,10 +89,37 @@ class User < ActiveRecord::Base
   normalize_attribute :skype
 end
 
-class Currency
+user = User.new(first_name: '', last_name: '')
+user.email = "ADDRESS@example.com"
+
+user.first_name
+#=> nil
+user.last_name
+#=> nil
+user.email
+#=> "address@example.com"
+```
+
+```ruby
+class SMS
   include Normalizr::Concern
-  normalize :value
+
+  attr_accessor :phone, :message
+
+  normalize :phone, with: :phone
+  normalize :message
+
+  def initialize(phone, message)
+    self.phone   = phone
+    self.message = message
+  end
 end
+
+sms = SMS.new("+1 (810) 555-0000", "It works \n")
+sms.phone
+#=> "18105550000"
+sms.message
+#=> "It works"
 ```
 
 Normalize values outside of class:
@@ -101,6 +130,16 @@ Normalizr.normalize(value, :strip, :blank)
 Normalizr.normalize(value, :strip, truncate: { length: 20 })
 ```
 
+### RSpec matcher
+
+```ruby
+describe User do
+  it { should normalize(:name) }
+  it { should normalize(:phone).from('+1 (810) 555-0000').to('18105550000') }
+  it { should normalize(:email).from('ADDRESS@example.com').to('address@example.com') }
+end
+```
+
 ### Built-in normalizers
 
 - blank

data/gemfiles/activerecord-3.2.x.gemfile

@@ -0,0 +1,6 @@
+source 'https://rubygems.org'
+
+gem 'activerecord', '~> 3.2.0'
+gem 'codeclimate-test-reporter', require: false
+
+gemspec path: '../'

data/gemfiles/activerecord-4.1.x.gemfile

@@ -0,0 +1,6 @@
+source 'https://rubygems.org'
+
+gem 'activerecord', '~> 4.1.0'
+gem 'codeclimate-test-reporter', require: false
+
+gemspec path: '../'

data/lib/normalizr.rb

@@ -38,6 +38,5 @@ module Normalizr
 end
 
 require 'normalizr/normalizers'
-ActiveSupport.on_load(:active_record) do
-  ActiveRecord::Base.send(:include, Normalizr::Concern)
-end
+require 'normalizr/integrations/active_record' if defined?(ActiveRecord)
+require 'normalizr/integrations/rspec' if defined?(RSpec)

data/lib/normalizr/integrations/active_record.rb

@@ -0,0 +1 @@
+ActiveRecord::Base.send(:include, Normalizr::Concern)

data/lib/normalizr/integrations/rspec.rb

@@ -0,0 +1,5 @@
+if RSpec.respond_to?(:configure)
+  RSpec.configure do |config|
+    config.include Normalizr::RSpec::Matcher
+  end
+end

data/lib/normalizr/rspec/matcher.rb

@@ -5,7 +5,7 @@ module Normalizr
         Normalization.new(attribute)
       end
 
-      alias_method :normalize_attribute, :normalize
+      alias normalize_attribute normalize
 
       class Normalization
         def initialize(attribute)
@@ -14,15 +14,15 @@ module Normalizr
         end
 
         def description
-          "normalize #{@attribute} from #{@from.nil? ? 'nil' : "\"#{@from}\""} to #{@to.nil? ? 'nil' : "\"#{@to}\""}"
+          "normalize #{@attribute} from #{display(@from)} to #{display(@to)}"
         end
 
         def failure_message
-          "#{@attribute} did not normalize as expected! \"#{@subject.send(@attribute)}\" != #{@to.nil? ? 'nil' : "\"#{@to}\""}"
+          "#{@attribute} did not normalize as expected! #{display(@subject.send(@attribute))} != #{display(@to)}"
         end
 
         def failure_message_when_negated
-          "expected #{@attribute} to not be normalized from #{@from.nil? ? 'nil' : "\"#{@from}\""} to #{@to.nil? ? 'nil' : "\"#{@to}\""}"
+          "expected #{@attribute} to not be normalized from #{display(@from)} to #{display(@to)}"
         end
 
         alias negative_failure_message failure_message_when_negated
@@ -42,6 +42,12 @@ module Normalizr
           @subject.send("#{@attribute}=", @from)
           @subject.send(@attribute) == @to
         end
+
+        protected
+
+        def display(value)
+          value.nil? ? 'nil' : "\"#{value}\""
+        end
       end
     end
   end

data/lib/normalizr/version.rb

@@ -1,3 +1,3 @@
 module Normalizr
-  VERSION = '0.0.3'
+  VERSION = '0.0.4'
 end

data/spec/models/phone_spec.rb

@@ -0,0 +1,5 @@
+require 'spec_helper'
+
+describe Phone do
+  it { should normalize(:number) }
+end

data/spec/spec_helper.rb

@@ -17,12 +17,9 @@ require 'support/models/journal'
 require 'support/models/magazine'
 require 'support/models/person'
 require 'support/models/publisher'
+require 'support/models/phone'
 require 'support/models/user'
 
-RSpec.configure do |config|
-  config.include Normalizr::RSpec::Matcher
-end
-
 Normalizr.configure do |config|
   default :strip, :special_normalizer, :blank
 

data/spec/support/models/phone.rb

@@ -0,0 +1,10 @@
+class Phone
+  include Normalizr::Concern
+
+  attr_accessor :number
+  normalize_attribute :number
+
+  def number=(value)
+    @number = value
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: normalizr
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Dimko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-22 00:00:00.000000000 Z
+date: 2014-08-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry
@@ -137,10 +137,14 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
+- gemfiles/activerecord-3.2.x.gemfile
+- gemfiles/activerecord-4.1.x.gemfile
 - lib/normalizr.rb
 - lib/normalizr/concern.rb
 - lib/normalizr/configuration.rb
 - lib/normalizr/exceptions.rb
+- lib/normalizr/integrations/active_record.rb
+- lib/normalizr/integrations/rspec.rb
 - lib/normalizr/normalizers.rb
 - lib/normalizr/options_parser.rb
 - lib/normalizr/rspec/matcher.rb
@@ -154,6 +158,7 @@ files:
 - spec/models/book_spec.rb
 - spec/models/journal_spec.rb
 - spec/models/magazine_spec.rb
+- spec/models/phone_spec.rb
 - spec/models/publisher_spec.rb
 - spec/models/user_spec.rb
 - spec/spec_helper.rb
@@ -165,6 +170,7 @@ files:
 - spec/support/models/journal.rb
 - spec/support/models/magazine.rb
 - spec/support/models/person.rb
+- spec/support/models/phone.rb
 - spec/support/models/publisher.rb
 - spec/support/models/user.rb
 - spec/support/schema.rb
@@ -201,6 +207,7 @@ test_files:
 - spec/models/book_spec.rb
 - spec/models/journal_spec.rb
 - spec/models/magazine_spec.rb
+- spec/models/phone_spec.rb
 - spec/models/publisher_spec.rb
 - spec/models/user_spec.rb
 - spec/spec_helper.rb
@@ -212,6 +219,7 @@ test_files:
 - spec/support/models/journal.rb
 - spec/support/models/magazine.rb
 - spec/support/models/person.rb
+- spec/support/models/phone.rb
 - spec/support/models/publisher.rb
 - spec/support/models/user.rb
 - spec/support/schema.rb