norma43_parser 4.0.0 → 4.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '0449ec18860a4308816374b89703797ec359a8032b15a3f3fb3e4a8749dbdc44'
-  data.tar.gz: 0d0438fb23ba70c0b5c3ce107e7ac6e71dd5007ceb2fe64887aaf0d61c46cf60
+  metadata.gz: 6a576ebd4936bf3b9f7c190dd6f9024f6581efabca4141d8383ebdd16c4cdb9d
+  data.tar.gz: '079b2f02c83c570abe052d635d82d7ad78919b18341de0d81fe2f22e62a64108'
 SHA512:
-  metadata.gz: dd5abd1c1b2893eb6fcb8c2025d659c1c5876198d68d624e19e18ac1975aecb48c557f7a27070c690f0090028d630a6d2ece30daf7daad70eda3993a736e56fe
-  data.tar.gz: 5431b59a68a1f3ce474e31aa44735ad9a6c1863deb20e157375e8b81938192d99e6184f587b6eadefffd992bf6fd5398acea5e261d2100f70be4bd59d4b019f3
+  metadata.gz: 5b54505e514e0f3e226b6d910963570a753686db02f8bc6229fcb2f6586b79153fb914f8a2ed0c0ad73a4381a72c7f1ff5e9f2333c6d21ee3dd6e9bdecc03151
+  data.tar.gz: cffc3991bef02c3fe166d711db5e9c7d5d3d804eeb9b02d1188679fcfd84d46b511de0ce064c2eded074bdffd9d925817385f545553383459e8c428dd0f2006b

data/.github/dependabot.yml

@@ -0,0 +1,6 @@
+version: 2
+updates:
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "weekly"

data/.github/workflows/ci.yml

@@ -12,7 +12,7 @@ jobs:
         ruby-version: ["3.3", "3.2", "3.1", "3.0", "jruby-head"]
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Set up Ruby ${{ matrix.ruby-version }}
         uses: ruby/setup-ruby@v1
         with:

data/.github/workflows/release.yml

@@ -7,14 +7,14 @@ jobs:
   release:
     runs-on: ubuntu-latest
     steps:
-      - uses: GoogleCloudPlatform/release-please-action@v3
+      - uses: GoogleCloudPlatform/release-please-action@v4
         id: release
         with:
           release-type: ruby
           package-name: norma43_parser
           bump-minor-pre-major: true
           version-file: 'lib/norma43/version.rb'
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
         if: ${{ steps.release.outputs.release_created }}
       - uses: ruby/setup-ruby@v1
         with:

data/.rspec

@@ -0,0 +1 @@
+--require spec_helper

data/CHANGELOG.md

@@ -1,6 +1,21 @@
-## [4.0.0](https://github.com/sequra/norma43_parser/compare/3.0.0...v4.0.0) (2024-06-18)
+## [4.1.0](https://github.com/sequra/norma43_parser/compare/v4.0.0...v4.1.0) (2024-06-20)
+
+### Features
+
+* Remove virtus dependency ([#35](https://github.com/sequra/norma43_parser/issues/35))
+
+* Soft-deprecate `Norma43::Models::Document#transaction_date`, use transaction_date in transactions instead
+
+
+## [4.2.0](https://github.com/sequra/norma43_parser/compare/v4.1.0...v4.2.0) (2025-03-25)
 
 
+### Features
+
+* [PAY-1007] Parse `reference_1` as string to be able to filter lines ([#42](https://github.com/sequra/norma43_parser/issues/42)) ([f60f4e4](https://github.com/sequra/norma43_parser/commit/f60f4e4f396e0e4ccfba22e59018a8e97a39dd47))
+
+## [4.0.0](https://github.com/sequra/norma43_parser/compare/3.0.0...v4.0.0) (2024-06-18)
+
 ### ⚠ BREAKING CHANGES
 
 * Drop Ruby support below 3
@@ -22,13 +37,13 @@
 
 - Update rake requirement from ~> 10.0 to ~> 13.0 (#6)
 
+
 ## v2.0.0 (2019-10-17)
 
 ### Breaking Changes
 
 - Drop Ruby support below 2.4.
 
-
 ### Enhancements
 
 - Clean up dependencies

data/Gemfile.lock

@@ -1,25 +1,14 @@
 PATH
   remote: .
   specs:
-    norma43_parser (4.0.0)
-      virtus (~> 1.0)
+    norma43_parser (4.2.0)
       zeitwerk (~> 2.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
     ast (2.4.2)
-    axiom-types (0.1.1)
-      descendants_tracker (~> 0.0.4)
-      ice_nine (~> 0.11.0)
-      thread_safe (~> 0.3, >= 0.3.1)
-    coercible (1.0.0)
-      descendants_tracker (~> 0.0.1)
-    descendants_tracker (0.0.4)
-      thread_safe (~> 0.3, >= 0.3.1)
     diff-lcs (1.5.1)
-    equalizer (0.0.11)
-    ice_nine (0.11.2)
     json (2.7.2)
     json (2.7.2-java)
     language_server-protocol (3.17.0.3)
@@ -32,8 +21,7 @@ GEM
     rainbow (3.1.1)
     rake (13.2.1)
     regexp_parser (2.9.2)
-    rexml (3.3.0)
-      strscan
+    rexml (3.3.9)
     rspec (3.13.0)
       rspec-core (~> 3.13.0)
       rspec-expectations (~> 3.13.0)
@@ -64,16 +52,7 @@ GEM
       rubocop (>= 1.48.1, < 2.0)
       rubocop-ast (>= 1.31.1, < 2.0)
     ruby-progressbar (1.13.0)
-    strscan (3.1.0)
-    strscan (3.1.0-java)
-    thread_safe (0.3.6)
-    thread_safe (0.3.6-java)
     unicode-display_width (2.5.0)
-    virtus (1.0.5)
-      axiom-types (~> 0.1)
-      coercible (~> 1.0)
-      descendants_tracker (~> 0.0, >= 0.0.3)
-      equalizer (~> 0.0, >= 0.0.9)
     zeitwerk (2.6.15)
 
 PLATFORMS

data/README.md

@@ -62,7 +62,7 @@ amount_code=2,
 document_number=0,
 origin_branch_code=123,
 own_item=16,
-reference_1=0,
+reference_1=nil,
 reference_2=nil,
 shared_item=4,
 transaction_date=Tue, 04 Feb 2016,

data/lib/norma43/line_parsers/transaction.rb

@@ -11,7 +11,7 @@ module Norma43
       field :amount_code, 27, :integer
       field :amount, 28..41, :integer
       field :document_number, 42..51, :integer
-      field :reference_1, 52..63, :integer
+      field :reference_1, 52..63
       field :reference_2, 64..79
     end
   end

data/lib/norma43/models/account.rb

@@ -1,30 +1,62 @@
 # frozen_string_literal: true
 
-require "virtus"
-
 module Norma43
   module Models
     class Account
-      include Virtus.model
+      include Mixins::AttributesAssignment
+
+      attr_accessor :bank_code,
+        :branch_code,
+        :account_number,
+        :start_date,
+        :end_date,
+        :balance_code,
+        :balance_amount,
+        :currency_code,
+        :information_mode_code,
+        :abbreviated_name,
+        :debit_entries,
+        :debit_amount,
+        :credit_entries,
+        :credit_amount,
+        :transactions
 
-      attribute :bank_code
-      attribute :branch_code
-      attribute :account_number
-      attribute :start_date
-      attribute :end_date
-      attribute :balance_code
-      attribute :balance_amount
-      attribute :currency_code
-      attribute :information_mode_code
-      attribute :abbreviated_name
-      attribute :debit_entries
-      attribute :debit_amount
-      attribute :credit_entries
-      attribute :credit_amount
-      attribute :transactions, Array[Transaction]
+      def initialize(attributes = EMPTY_ATTRIBUTES)
+        @bank_code,
+        @branch_code,
+        @account_number,
+        @start_date,
+        @end_date,
+        @balance_code,
+        @balance_amount,
+        @currency_code,
+        @information_mode_code,
+        @abbreviated_name,
+        @debit_entries,
+        @debit_amount,
+        @credit_entries,
+        @credit_amount,
+        transactions = Hash(attributes).values_at(
+          :bank_code,
+          :branch_code,
+          :account_number,
+          :start_date,
+          :end_date,
+          :balance_code,
+          :balance_amount,
+          :currency_code,
+          :information_mode_code,
+          :abbreviated_name,
+          :debit_entries,
+          :debit_amount,
+          :credit_entries,
+          :credit_amount,
+          :transactions)
+        @transactions = Array(transactions).map { |attrs| Transaction.new(attrs) }
+      end
 
       def iban
-        @iban ||= SpanishIban.from_account(self)
+        SpanishIban.from_account(self)
       end
     end
   end

data/lib/norma43/models/additional_currency.rb

@@ -1,16 +1,22 @@
 # frozen_string_literal: true
 
-require "virtus"
-
 module Norma43
   module Models
     class AdditionalCurrency
-      include Virtus.model
+      include Mixins::AttributesAssignment
+
+      attr_accessor :data_code, :currency_code, :amount, :free
 
-      attribute :data_code
-      attribute :currency_code
-      attribute :amount
-      attribute :free
+      def initialize(attributes = EMPTY_ATTRIBUTES)
+        @data_code,
+        @currency_code,
+        @amount,
+        @free = Hash(attributes).values_at(
+          :data_code,
+          :currency_code,
+          :amount,
+          :free)
+      end
     end
   end
 end

data/lib/norma43/models/additional_item.rb

@@ -1,15 +1,20 @@
 # frozen_string_literal: true
 
-require "virtus"
-
 module Norma43
   module Models
     class AdditionalItem
-      include Virtus.model
+      include Mixins::AttributesAssignment
+
+      attr_accessor :data_code, :item_1, :item_2
 
-      attribute :data_code
-      attribute :item_1
-      attribute :item_2
+      def initialize(attributes = EMPTY_ATTRIBUTES)
+        @data_code,
+        @item_1,
+        @item_2 = Hash(attributes).values_at(
+          :data_code,
+          :item_1,
+          :item_2)
+      end
     end
   end
 end

data/lib/norma43/models/document.rb

@@ -1,22 +1,41 @@
 # frozen_string_literal: true
 
-require "virtus"
-
 module Norma43
   module Models
     class Document
-      include Virtus.model
+      include Mixins::AttributesAssignment
+
+      attr_accessor :id, :created_at, :delivery_number, :file_type, :name, :number_of_lines, :accounts
 
-      attribute :id
-      attribute :created_at
-      attribute :delivery_number
-      attribute :file_type
-      attribute :name
-      attribute :number_of_lines
-      attribute :accounts, Array[Account]
+      def initialize(attributes = EMPTY_ATTRIBUTES)
+        @id,
+        @created_at,
+        @delivery_number,
+        @file_type,
+        @name,
+        @number_of_lines,
+        accounts = Hash(attributes).values_at(
+          :id,
+          :created_at,
+          :delivery_number,
+          :file_type,
+          :name,
+          :number_of_lines,
+          :accounts)
+        @accounts = Array(accounts).map { |account| Account.new(account) }
+      end
 
+      # @deprecated Please ask each transaction inside accounts for their transaction_date instead
       def transaction_date
-        accounts.map(&:date).compact.first
+        warn "[DEPRECATION] `transaction_date` is deprecated, use `#transaction_date` from transactions in `#accounts` instead"
+        date = nil
+
+        accounts.flat_map(&:transactions).each { |transaction|
+          date = transaction&.transaction_date
+          break unless date.nil?
+        }
+
+        date
       end
     end
   end

data/lib/norma43/models/mixins/attributes_assignment.rb

@@ -0,0 +1,33 @@
+# frozen_string_literal: true
+
+module Norma43
+  module Models
+    module Mixins
+      module AttributesAssignment
+        EMPTY_ATTRIBUTES = {}.freeze
+
+        def attributes=(new_attributes)
+          Hash(new_attributes).each do |attr_name, attr_value|
+            attr_writer_method_name = "#{attr_name}=".to_sym
+            next unless public_methods(false).include?(attr_writer_method_name)
+
+            public_send(attr_writer_method_name, attr_value)
+          end
+        end
+
+        def attributes
+          instance_variables.map { |ivar_name|
+            attr_reader_method_name = ivar_name.to_s.delete_prefix("@").to_sym
+            next unless public_methods(false).include?(attr_reader_method_name)
+
+            attr_value = public_send(attr_reader_method_name)
+
+            [attr_reader_method_name, attr_value]
+          }.compact.to_h
+        end
+        alias_method :to_hash, :attributes # Implicit coercion for `Hash(model)`
+        alias_method :to_h,    :attributes # Explicit coercion
+      end
+    end
+  end
+end

data/lib/norma43/models/transaction.rb

@@ -1,24 +1,50 @@
 # frozen_string_literal: true
 
-require "virtus"
-
 module Norma43
   module Models
     class Transaction
-      include Virtus.model
+      include Mixins::AttributesAssignment
+
+      attr_accessor :origin_branch_code,
+        :transaction_date,
+        :value_date,
+        :shared_item,
+        :own_item,
+        :amount_code,
+        :amount,
+        :document_number,
+        :reference_1,
+        :reference_2,
+        :additional_items,
+        :additional_currency
+
+      def initialize(attributes = EMPTY_ATTRIBUTES)
+        @origin_branch_code,
+        @transaction_date,
+        @value_date,
+        @shared_item,
+        @own_item,
+        @amount_code,
+        @amount,
+        @document_number,
+        @reference_1,
+        @reference_2,
+        additional_items,
+        additional_currency = Hash(attributes).values_at(
+          :origin_branch_code,
+          :transaction_date,
+          :value_date,
+          :shared_item,
+          :own_item,
+          :amount_code,
+          :amount,
+          :document_number,
+          :reference_1,
+          :reference_2)
+        @additional_items = Array(additional_items).map { |attrs| AdditionalItem.new(attrs) }
+        @additional_currency = AdditionalCurrency.new(additional_currency) if additional_currency
+      end
 
-      attribute :origin_branch_code
-      attribute :transaction_date
-      attribute :value_date
-      attribute :shared_item
-      attribute :own_item
-      attribute :amount_code
-      attribute :amount
-      attribute :document_number
-      attribute :reference_1
-      attribute :reference_2
-      attribute :additional_items, Array[AdditionalItem]
-      attribute :additional_currency, AdditionalCurrency
       def debit?; self.amount_code == DEBIT_CODE end
     end
   end

data/lib/norma43/models.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require "virtus"
-
 module Norma43
   module Models
     DEBIT_CODE = 1

data/lib/norma43/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Norma43
-  VERSION = "4.0.0"
+  VERSION = "4.2.0"
 end

data/norma43_parser.gemspec

@@ -19,7 +19,6 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_runtime_dependency "virtus",   "~> 1.0"
   spec.add_runtime_dependency "zeitwerk", "~> 2.0"
 
   spec.add_development_dependency "rake",  "~> 13.0"

data/spec/example1_parse_spec.rb

@@ -58,7 +58,7 @@ RSpec.describe Norma43 do
               "amount_code"        => 2,
               "amount"             => 1234,
               "document_number"    => 0,
-              "reference_1"        => 0,
+              "reference_1"        => nil,
               "reference_2"        => nil,
             )
           end

data/spec/example2_parse_spec.rb

@@ -0,0 +1,86 @@
+# frozen_string_literal: true
+
+require "norma43"
+
+RSpec.describe Norma43 do
+  describe "parse" do
+    let(:document) do
+      file = File.open(File.join(__dir__, "fixtures/example2.n43"),
+                        encoding: "iso-8859-1")
+      Norma43.parse file
+    end
+
+    it "finds one account" do
+      expect(document.accounts.size).to eq 1
+    end
+
+    describe "first account" do
+      let(:account) { document.accounts.first }
+
+      it "stores expected attributes from AccountStart parser" do
+        expect(account).to have_attributes(
+          "bank_code"             => 81,
+          "branch_code"           => 4797,
+          "account_number"        => 6995216857,
+          "start_date"            => Date.parse("2025-03-17"),
+          "end_date"              => Date.parse("2025-03-17"),
+          "currency_code"         => 978,
+          "information_mode_code" => 3,
+          "abbreviated_name"      => "SEQURA WORLDWIDE S.A.",
+        )
+      end
+
+      it "stores expected attributes from AccountEnd parser" do
+        expect(account).to have_attributes(
+          "balance_code"   => 2,
+          "balance_amount" => 8614571,
+          "debit_entries"  => nil,
+          "debit_amount"   => nil,
+          "credit_entries" => nil,
+          "credit_amount"  => nil,
+        )
+      end
+
+      describe "transactions" do
+        it "finds all transactions" do
+          expect(account.transactions.size).to eq 4
+        end
+
+        describe "first transaction" do
+          let(:transaction) { account.transactions[0] }
+          it "stores expected attributes" do
+            expect(transaction).to have_attributes(
+              "origin_branch_code" => 7013,
+              "transaction_date"   => Date.parse("2025-03-17"),
+              "value_date"         => Date.parse("2025-03-14"),
+              "shared_item"        => 4,
+              "own_item"           => 7,
+              "amount_code"        => 2,
+              "amount"             => 9726,
+              "document_number"    => 6871166755,
+              "reference_1"        => "TRANSFERENCI",
+              "reference_2"        => "A48555633617",
+            )
+          end
+        end
+
+        it "each transaction has 5 additional_items as a maximum" do
+          account.transactions.each do |transaction|
+            expect(transaction.additional_items.size).to be <= 5
+          end
+        end
+
+        describe "first additional item" do
+          let(:additional_item) { account.transactions[0].additional_items[0] }
+          it "stores expected attributes" do
+            expect(additional_item).to have_attributes(
+              "data_code" => 1,
+              "item_1"    => "MARIA NARANJO ENFLOR",
+              "item_2"    => "A48555633617"
+            )
+          end
+        end
+      end
+    end
+  end
+end

data/spec/fixtures/example2.n43

@@ -0,0 +1,13 @@
+110081479769952168572503172503172000000086145719783SEQURA WORLDWIDE S.A.        
+2201827013250317250314040072000000000097266871166755TRANSFERENCIA48555633617    
+2301MARIA NARANJO ENFLOR                  A48555633617                          
+2302                                      01826874                              
+2201827013250317250317040072000000000074332011157110TRANSFERENCISEQURA          
+2301LAURA MARTINEZ PEREZ                                                       
+2302                                      01822011                              
+2201828510250317250317990512000000000082250000000000BIZUM                       
+2301NAYARA;MARTINEZ RODRIGUEZ             PEDIDO 322200000000                   
+2302                                      15830001                              
+2201828510250317250317990512000000000088940000000000BIZUM                       
+2301DANIEL GARCIA GARCIA                  PEDIDO 322254909000                   
+2302                                      21000900                              

data/spec/norma43/line_parsers/transaction_spec.rb

@@ -42,7 +42,7 @@ module Norma43
       end
 
       it "parses the reference 1" do
-        expect(transaction.reference_1).to eq 0
+        expect(transaction.reference_1).to be_nil
       end
 
       it "parses the reference 2" do

data/spec/norma43/line_processors/account_end_spec.rb

@@ -3,10 +3,7 @@
 module Norma43
   module LineProcessors
     RSpec.describe AccountEnd do
-      let :line do
-        double "Line", attributes: {}
-      end
-
+      let(:line) { instance_double(LineParsers::AccountEnd, attributes: {}) } 
       let(:account) { Norma43::Models::Account.new }
       let(:contexts) { Norma43::Utils::Contexts.new(
         [

data/spec/norma43/line_processors/account_start_spec.rb

@@ -2,8 +2,8 @@
 
 module Norma43
   module LineProcessors
-    RSpec.describe "AccountStart" do
-      let(:line) { double "Line", attributes: {} }
+    RSpec.describe AccountStart do
+      let(:line) { instance_double(LineParsers::AccountStart, attributes: {}) }
       let(:document) { Norma43::Models::Document.new }
       let(:contexts) { Norma43::Utils::Contexts.new }
 
@@ -20,7 +20,7 @@ module Norma43
       end
 
       context "when AccountStart is called" do
-        let(:fake_account) { double "Norma43::Models::Account" }
+        let(:fake_account) { instance_double(Norma43::Models::Account) }
         before do
           allow(Norma43::Models::Account).to receive(:new) { fake_account }
         end

data/spec/norma43/line_processors/additional_currency_spec.rb

@@ -2,8 +2,8 @@
 
 module Norma43
   module LineProcessors
-    RSpec.describe "AdditionalCurrency" do
-      let(:line) { double "Line", attributes: {} }
+    RSpec.describe AdditionalCurrency do
+      let(:line) { instance_double(LineParsers::AdditionalCurrency, attributes: {}) }
       let(:transaction) { Norma43::Models::Transaction.new }
       let(:contexts) { Norma43::Utils::Contexts.new(
         [
@@ -22,7 +22,7 @@ module Norma43
       end
 
       context "when AdditionalCurrency is called" do
-        let(:fake_additional_currency) { double "Models::AdditionalCurrency" }
+        let(:fake_additional_currency) { instance_double(Models::AdditionalCurrency) }
         before do
           allow(Models::AdditionalCurrency).to receive(:new) { fake_additional_currency }
         end

data/spec/norma43/line_processors/{additional_items_spec.rb → additional_item_spec.rb}

@@ -2,8 +2,8 @@
 
 module Norma43
   module LineProcessors
-    RSpec.describe "AdditionalItems" do
-      let(:line) { double "Line", attributes: {} }
+    RSpec.describe AdditionalItem do
+      let(:line) { instance_double(LineParsers::AdditionalItem, attributes: {}) }
       let(:transaction) { Norma43::Models::Transaction.new }
       let(:contexts) { Norma43::Utils::Contexts.new(
         [
@@ -22,7 +22,7 @@ module Norma43
       end
 
       context "when AdditionalItem is called" do
-        let(:fake_additional_item) { double "Models::AdditionalItem" }
+        let(:fake_additional_item) { instance_double(Models::AdditionalItem) }
         before do
           allow(Models::AdditionalItem).to receive(:new) { fake_additional_item }
         end

data/spec/norma43/line_processors/document_end_spec.rb

@@ -2,15 +2,12 @@
 
 module Norma43
   module LineProcessors
-    RSpec.describe "DocumentEnd" do
-      class Thing
-      end
-
-      let(:line) { double "Line", record_number: 35 }
+    RSpec.describe DocumentEnd do
+      let(:line) { instance_double(LineParsers::DocumentEnd, record_number: 35) }
 
       it "moves to the nearest document context" do
         document = Norma43::Models::Document.new
-        contexts = Norma43::Utils::Contexts.new [Thing.new, document, Thing.new, Thing.new]
+        contexts = Norma43::Utils::Contexts.new [anything, document, anything, anything]
 
         DocumentEnd.call line, contexts
 

data/spec/norma43/line_processors/document_start_spec.rb

@@ -2,8 +2,8 @@
 
 module Norma43
   module LineProcessors
-    RSpec.describe "DocumentStart" do
-      let (:line) { double "Line", attributes: {} }
+    RSpec.describe DocumentStart do
+      let(:line) { instance_double(LineParsers::DocumentStart, attributes: {}) }
 
       it "instantiates a new document with the line attributes" do
         allow(Models::Document).to receive :new
@@ -14,7 +14,7 @@ module Norma43
       end
 
       it "sets the document as the current context" do
-        fake_document = double "Models::Document"
+        fake_document = instance_double(Models::Document)
         allow(Models::Document).to receive(:new) { fake_document }
 
         contexts = DocumentStart.call line, Norma43::Utils::Contexts.new

data/spec/norma43/line_processors/transaction_spec.rb

@@ -2,8 +2,8 @@
 
 module Norma43
   module LineProcessors
-    RSpec.describe "Transaction" do
-      let(:line) { double "Line", attributes: {} }
+    RSpec.describe Transaction do
+      let(:line) { instance_double(LineParsers::Transaction, attributes: {}) }
       let(:account) { Norma43::Models::Account.new }
       let(:contexts) { Norma43::Utils::Contexts.new(
         [
@@ -22,7 +22,7 @@ module Norma43
       end
 
       context "when Transaction is called" do
-        let(:fake_transaction) { double "Models::Transaction" }
+        let(:fake_transaction) { instance_double(Models::Transaction) }
         before do
           allow(Models::Transaction).to receive(:new) { fake_transaction }
         end

data/spec/norma43/models/account_spec.rb

@@ -3,17 +3,51 @@
 module Norma43
   module Models
     RSpec.describe Account do
+      it_behaves_like "a model"
+
       describe "#iban" do
-        it { is_expected.to respond_to :iban }
+        it { is_expected.to respond_to(:iban) }
 
         context "with the example in the documentation" do
-          it "delegates to SpanishIban to return a IBAN string" do
+          it "returns the correct IBAN string" do
             account = subject
-            allow(Account::SpanishIban).to receive(:from_account).with(account).and_return("ES0000000000000000000123")
-            expect(account.iban).to eq("ES0000000000000000000123")
-            expect(Account::SpanishIban).to have_received(:from_account).with(account)
+            account.account_number = 1234567
+            account.bank_code = 81
+            account.branch_code = 54
+
+            expect(account.iban).to eq("ES5400810054180001234567")
           end
         end
+
+        context "with missing bank data" do
+          subject { described_class.new.iban }
+          it { is_expected.to be_nil }
+        end
+
+        context "with missing bank code" do
+          subject { described_class.new(bank_code: nil, branch_code: 1234, account_number: 1234).iban }
+          it { is_expected.to be_nil }
+        end
+
+        context "with missing branch code" do
+          subject { described_class.new(bank_code: 1234, branch_code: nil, account_number: 1234).iban }
+          it { is_expected.to be_nil }
+        end
+
+        context "with missing account number" do
+          subject { described_class.new(bank_code: 1234, branch_code: 1234, account_number: nil).iban }
+          it { is_expected.to be_nil }
+        end
+
+        context "with negative account number" do
+          subject { described_class.new(bank_code: 1234, branch_code: 1234, account_number: -1234).iban }
+          it { is_expected.to be_nil }
+        end
+
+        context "with an account number which is too large" do
+          subject { described_class.new(bank_code: 1234, branch_code: 1234, account_number: 1*10**10).iban }
+          it { is_expected.to be_nil }
+        end
       end
     end
   end

data/spec/norma43/models/document_spec.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+module Norma43
+  module Models
+    RSpec.describe Document do
+      it_behaves_like "a model"
+
+      describe "#transaction_date" do
+        it { is_expected.to respond_to(:transaction_date) }
+
+        context "when there are no accounts" do
+          subject(:document) { described_class.new({ accounts: [] }) }
+
+          it { expect(document.transaction_date).to be_nil }
+        end
+
+        context "when there are accounts" do
+          subject(:document) { described_class.new({ accounts: [account] }) }
+
+          let(:account) {
+            Account.new(transactions: [
+              nil,
+              Transaction.new(transaction_date: nil),
+              Transaction.new(transaction_date: Date.parse("2024-01-23")),
+            ])
+          }
+
+          it "returns the date of the first account with a transaction date" do
+            expect(document.transaction_date).to eq(Date.parse("2024-01-23"))
+          end
+        end
+      end
+    end
+  end
+end

data/spec/norma43/models/transaction_spec.rb

@@ -0,0 +1,25 @@
+# frozen_string_literal: true
+
+module Norma43
+  module Models
+    RSpec.describe Transaction do
+      it_behaves_like "a model"
+
+      describe "#debit?" do
+        it { is_expected.to respond_to(:debit?) }
+
+        context "when amount code is code for debits" do
+          subject(:transaction) { described_class.new(amount_code: 1) }
+
+          it { expect(transaction.debit?).to be_truthy }
+        end
+
+        context "when amount code is code for credits" do
+          subject(:transaction) { described_class.new(amount_code: 2) }
+
+          it { expect(transaction.debit?).to be_falsey }
+        end
+      end
+    end
+  end
+end

data/spec/norma43_spec.rb

@@ -6,7 +6,7 @@ RSpec.describe Norma43 do
   describe "#parse" do
     it "returns the parser results" do
       text = "some total-in text"
-      parser = double "Parser", result: "result"
+      parser = instance_double(Norma43::Parser, result: "result")
       expect(Norma43::Parser).to receive(:new).with(text) { parser }
 
       expect(Norma43.parse(text)).to eq "result"

data/spec/spec_helper.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require "norma43"
+
 RSpec.configure do |config|
   config.order = :random
   Kernel.srand config.seed
@@ -11,6 +13,7 @@ RSpec.configure do |config|
   config.mock_with :rspec do |mocks|
     mocks.syntax = :expect
     mocks.verify_partial_doubles = true
+    mocks.verify_doubled_constant_names = true
   end
 end
 

data/spec/support/shared_examples_for_models.rb

@@ -0,0 +1,61 @@
+# frozen_string_literal: true
+
+RSpec.shared_examples "a model" do
+  it { is_expected.to respond_to(:attributes) }
+  it { is_expected.to respond_to(:attributes=) }
+  it { is_expected.to respond_to(:to_h) }
+  it { is_expected.to respond_to(:to_hash) }
+
+  describe "#new" do
+    subject(:model) { described_class.new(attributes) }
+
+    context "when instantiated with an empty hash" do
+      let(:attributes) { {} }
+
+      it "accepts it without failing" do
+        expect { model }.not_to raise_error
+      end
+    end
+  end
+
+  describe "#attributes" do
+    subject { described_class.new.attributes }
+
+    it { is_expected.not_to be_empty }
+    it { is_expected.to respond_to(:each_pair) }
+    it { is_expected.to respond_to(:to_h) }
+    it { is_expected.to respond_to(:to_hash) }
+    it { is_expected.to respond_to(:keys) }
+
+    describe "#attributes.keys" do
+      subject { super().keys }
+
+      it { is_expected.not_to be_empty }
+      it { is_expected.to all(be_a(Symbol)) }
+    end
+  end
+
+  describe "#attributes=" do
+    subject { described_class.new.attributes=(attributes) }
+
+    context "when passed an empty hash" do
+      let(:attributes) { {} }
+
+      it "accepts it without failing" do
+        expect { subject }.not_to raise_error
+      end
+    end
+
+    context "when passed a hash with unknown attribute names" do
+      let(:attributes) { { potato: nil } }
+
+      it "accepts it without failing" do
+        expect { subject }.not_to raise_error
+      end
+
+      it "does not set any new method" do
+        expect { subject.potato }.to raise_error(NoMethodError, /undefined method.+potato/i)
+      end
+    end
+  end
+end

metadata

@@ -1,29 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: norma43_parser
 version: !ruby/object:Gem::Version
-  version: 4.0.0
+  version: 4.2.0
 platform: ruby
 authors:
 - Sequra engineering
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-06-19 00:00:00.000000000 Z
+date: 2025-03-25 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: virtus
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: zeitwerk
   requirement: !ruby/object:Gem::Requirement
@@ -66,7 +52,7 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.9'
-description: 
+description:
 email:
 - dev@sequra.es
 executables: []
@@ -75,8 +61,10 @@ extra_rdoc_files: []
 files:
 - ".github/ISSUE_TEMPLATE.md"
 - ".github/PULL_REQUEST_TEMPLATE.md"
+- ".github/dependabot.yml"
 - ".github/workflows/ci.yml"
 - ".github/workflows/release.yml"
+- ".rspec"
 - ".rubocop.yml"
 - CHANGELOG.md
 - Gemfile
@@ -104,6 +92,7 @@ files:
 - lib/norma43/models/additional_currency.rb
 - lib/norma43/models/additional_item.rb
 - lib/norma43/models/document.rb
+- lib/norma43/models/mixins/attributes_assignment.rb
 - lib/norma43/models/transaction.rb
 - lib/norma43/parser.rb
 - lib/norma43/utils/contexts.rb
@@ -112,7 +101,9 @@ files:
 - lib/norma43/version.rb
 - norma43_parser.gemspec
 - spec/example1_parse_spec.rb
+- spec/example2_parse_spec.rb
 - spec/fixtures/example1.n43
+- spec/fixtures/example2.n43
 - spec/norma43/line_parsers/account_end_spec.rb
 - spec/norma43/line_parsers/account_start_spec.rb
 - spec/norma43/line_parsers/additional_currency_spec.rb
@@ -123,21 +114,24 @@ files:
 - spec/norma43/line_processors/account_end_spec.rb
 - spec/norma43/line_processors/account_start_spec.rb
 - spec/norma43/line_processors/additional_currency_spec.rb
-- spec/norma43/line_processors/additional_items_spec.rb
+- spec/norma43/line_processors/additional_item_spec.rb
 - spec/norma43/line_processors/document_end_spec.rb
 - spec/norma43/line_processors/document_start_spec.rb
 - spec/norma43/line_processors/transaction_spec.rb
 - spec/norma43/models/account/spanish_iban_spec.rb
 - spec/norma43/models/account_spec.rb
+- spec/norma43/models/document_spec.rb
+- spec/norma43/models/transaction_spec.rb
 - spec/norma43/parser_spec.rb
 - spec/norma43_spec.rb
 - spec/spec_helper.rb
+- spec/support/shared_examples_for_models.rb
 - spec/support/shared_examples_for_values_line_parsers.rb
 homepage: https://github.com/sequra/norma43_parser
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -153,12 +147,14 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.4.19
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Parses banks transactions files specified in rule 43
 test_files:
 - spec/example1_parse_spec.rb
+- spec/example2_parse_spec.rb
 - spec/fixtures/example1.n43
+- spec/fixtures/example2.n43
 - spec/norma43/line_parsers/account_end_spec.rb
 - spec/norma43/line_parsers/account_start_spec.rb
 - spec/norma43/line_parsers/additional_currency_spec.rb
@@ -169,13 +165,16 @@ test_files:
 - spec/norma43/line_processors/account_end_spec.rb
 - spec/norma43/line_processors/account_start_spec.rb
 - spec/norma43/line_processors/additional_currency_spec.rb
-- spec/norma43/line_processors/additional_items_spec.rb
+- spec/norma43/line_processors/additional_item_spec.rb
 - spec/norma43/line_processors/document_end_spec.rb
 - spec/norma43/line_processors/document_start_spec.rb
 - spec/norma43/line_processors/transaction_spec.rb
 - spec/norma43/models/account/spanish_iban_spec.rb
 - spec/norma43/models/account_spec.rb
+- spec/norma43/models/document_spec.rb
+- spec/norma43/models/transaction_spec.rb
 - spec/norma43/parser_spec.rb
 - spec/norma43_spec.rb
 - spec/spec_helper.rb
+- spec/support/shared_examples_for_models.rb
 - spec/support/shared_examples_for_values_line_parsers.rb